GoogleCoordinatesService::getCoordinates() - Code Metrics - Inspection of "[TASK] Added scheduler task for getCoordinates" - tomasnorre/golf_courses - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6db110...3d72e1 )

by Tomas Norre

created 2017-04-16 18:34 UTC

GoogleCoordinatesService::getCoordinates() A

↳ Parent: GoogleCoordinatesService

Complexity

Conditions	2
Paths	2

Size

Total Lines	21
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	21
rs	9.3142
cc	2
eloc	10
nc	2
nop	1

<?php
namespace TNM\GolfCourses\Service;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2017 Tomas Norre Mikkelsen <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/

/**
 * Class GoogleCoordinatesService
 *
 * @package TNM\GolfCourses\Service
 */
class GoogleCoordinatesService
{
    /**
     * @param $address
     *
     * @return array
     * @codeCoverageIgnore
     */
    public static function getCoordinates($address){

        if(empty($address)) {
            return [];
        }

        // replace all the white space with "+" sign to match with google search pattern
        $address = str_replace(" ", "+", $address);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $url = "http://maps.google.com/maps/api/geocode/json?sensor=false&address=$address";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        $response = file_get_contents($url);

        //generate array object from the response from the web
        $json = json_decode($response,TRUE);

        return [
            'longitude' => $json['results'][0]['geometry']['location']['lng'],
            'latitude' => $json['results'][0]['geometry']['location']['lat']
        ];
    }
}

1			<?php
2			namespace TNM\GolfCourses\Service;
3
4			/***************************************************************
5			* Copyright notice
6			*
7			* (c) 2017 Tomas Norre Mikkelsen <[email protected]>
8			*
9			* All rights reserved
10			*
11			* This script is part of the TYPO3 project. The TYPO3 project is
12			* free software; you can redistribute it and/or modify
13			* it under the terms of the GNU General Public License as published by
14			* the Free Software Foundation; either version 3 of the License, or
15			* (at your option) any later version.
16			*
17			* The GNU General Public License can be found at
18			* http://www.gnu.org/copyleft/gpl.html.
19			*
20			* This script is distributed in the hope that it will be useful,
21			* but WITHOUT ANY WARRANTY; without even the implied warranty of
22			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23			* GNU General Public License for more details.
24			*
25			* This copyright notice MUST APPEAR in all copies of the script!
26			***************************************************************/
27
28			/**
29			* Class GoogleCoordinatesService
30			*
31			* @package TNM\GolfCourses\Service
32			*/
33			class GoogleCoordinatesService
34			{
35			/**
36			* @param $address
37			*
38			* @return array
39			* @codeCoverageIgnore
40			*/
41			public static function getCoordinates($address){
42
43			if(empty($address)) {
44			return [];
45			}
46
47			// replace all the white space with "+" sign to match with google search pattern
48			$address = str_replace(" ", "+", $address);
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-04-16 18:50 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2017-04-16 18:50 UTC by Report Bug Copy Issue Report The string literal `+` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
49
50			$url = "http://maps.google.com/maps/api/geocode/json?sensor=false&address=$address";
			0 ignored issues – show Coding Style Best Practice introduced 2017-04-16 18:50 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$address` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
51
52			$response = file_get_contents($url);
53
54			//generate array object from the response from the web
55			$json = json_decode($response,TRUE);
56
57			return [
58			'longitude' => $json['results'][0]['geometry']['location']['lng'],
59			'latitude' => $json['results'][0]['geometry']['location']['lat']
60			];
61			}
62			}

tomasnorre / golf_courses

Push — master ( 6db110...3d72e1 )

GoogleCoordinatesService::getCoordinates() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like