Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 21 | class ApiPresenter extends Presenter |
||
| 22 | { |
||
| 23 | /** |
||
| 24 | * @var ApiDecider @inject |
||
| 25 | */ |
||
| 26 | public $apiDecider; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * CORS header settings |
||
| 30 | * |
||
| 31 | * Available values: |
||
| 32 | * 'auto' - send back header Access-Control-Allow-Origin with domain that made request |
||
| 33 | * '*' - send header with '*' - this will workf fine if you dont need to send cookies via ajax calls to api |
||
| 34 | * with jquery $.ajax with xhrFields: { withCredentials: true } settings |
||
| 35 | * 'off' - will not send any CORS header |
||
| 36 | * other - any other value will be send in Access-Control-Allow-Origin header |
||
| 37 | * |
||
| 38 | * @var string |
||
| 39 | */ |
||
| 40 | protected $corsHeader = '*'; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Presenter startup method |
||
| 44 | * |
||
| 45 | * @return void |
||
| 46 | */ |
||
| 47 | 9 | public function startup() |
|
| 52 | |||
| 53 | /** |
||
| 54 | * Set cors header |
||
| 55 | * |
||
| 56 | * See description to property $corsHeader for valid inputs |
||
| 57 | * |
||
| 58 | * @param string $corsHeader |
||
| 59 | */ |
||
| 60 | public function setCorsHeader($corsHeader) |
||
| 64 | |||
| 65 | /** |
||
| 66 | * Nette render default method |
||
| 67 | * |
||
| 68 | * @return void |
||
| 69 | */ |
||
| 70 | 9 | public function renderDefault() |
|
| 71 | { |
||
| 72 | 9 | $start = microtime(true); |
|
| 73 | |||
| 74 | 9 | $this->sendCorsHeaders(); |
|
| 75 | |||
| 76 | 9 | $hand = $this->getHandler(); |
|
| 77 | 9 | $handler = $hand['handler']; |
|
| 78 | 9 | $authorization = $hand['authorization']; |
|
| 79 | |||
| 80 | 9 | if ($this->checkAuth($authorization) === false) { |
|
| 81 | return; |
||
| 82 | } |
||
| 83 | |||
| 84 | 6 | $params = $this->processParams($handler); |
|
| 85 | 3 | if ($params === false) { |
|
| 86 | return; |
||
| 87 | } |
||
| 88 | |||
| 89 | try { |
||
| 90 | 3 | $response = $handler->handle($params); |
|
| 91 | 3 | $code = $response->getCode(); |
|
| 92 | } catch (Exception $exception) { |
||
| 93 | if (Debugger::isEnabled()) { |
||
| 94 | $response = new JsonApiResponse(500, ['status' => 'error', 'message' => 'Internal server error', 'detail' => $exception->getMessage()]); |
||
| 95 | } else { |
||
| 96 | $response = new JsonApiResponse(500, ['status' => 'error', 'message' => 'Internal server error']); |
||
| 97 | } |
||
| 98 | $code = $response->getCode(); |
||
| 99 | Debugger::log($exception, Debugger::EXCEPTION); |
||
| 100 | } |
||
| 101 | |||
| 102 | 3 | $end = microtime(true); |
|
| 103 | |||
| 104 | 3 | if ($this->context->findByType('Tomaj\NetteApi\Logger\ApiLoggerInterface')) { |
|
| 105 | $this->logRequest($this->context->getByType('Tomaj\NetteApi\Logger\ApiLoggerInterface'), $code, $end - $start); |
||
|
|
|||
| 106 | } |
||
| 107 | |||
| 108 | // output to nette |
||
| 109 | 3 | $this->getHttpResponse()->setCode($code); |
|
| 110 | 3 | $this->sendResponse($response); |
|
| 111 | } |
||
| 112 | |||
| 113 | /** |
||
| 114 | * Get handler information triplet (endpoint, handler, authorization) |
||
| 115 | * |
||
| 116 | * @return array |
||
| 117 | */ |
||
| 118 | 9 | private function getHandler() |
|
| 119 | { |
||
| 120 | 9 | return $this->apiDecider->getApiHandler( |
|
| 121 | 9 | $this->getRequest()->getMethod(), |
|
| 122 | 9 | $this->params['version'], |
|
| 123 | 9 | $this->params['package'], |
|
| 124 | 9 | $this->params['apiAction'] |
|
| 125 | ); |
||
| 126 | } |
||
| 127 | |||
| 128 | /** |
||
| 129 | * Check authorization |
||
| 130 | * |
||
| 131 | * @param ApiAuthorizationInterface $authorization |
||
| 132 | * |
||
| 133 | * @return bool |
||
| 134 | */ |
||
| 135 | 9 | private function checkAuth(ApiAuthorizationInterface $authorization) |
|
| 144 | |||
| 145 | /** |
||
| 146 | * Process input parameters |
||
| 147 | * |
||
| 148 | * @param ApiHandlerInterface $handler |
||
| 149 | * |
||
| 150 | * @return array|bool |
||
| 151 | */ |
||
| 152 | 6 | private function processParams(ApiHandlerInterface $handler) |
|
| 162 | |||
| 163 | /** |
||
| 164 | * Log request |
||
| 165 | * |
||
| 166 | * @param ApiLoggerInterface $logger |
||
| 167 | * @param integer $code |
||
| 168 | * @param double $elapsed |
||
| 169 | * |
||
| 170 | * @return void |
||
| 171 | */ |
||
| 172 | private function logRequest(ApiLoggerInterface $logger, $code, $elapsed) |
||
| 202 | |||
| 203 | 9 | protected function sendCorsHeaders() |
|
| 225 | |||
| 226 | private function getRequestDomain() |
||
| 241 | } |
||
| 242 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: