Completed
Pull Request — master (#77)
by Michal
01:40
created
src/Authorization/BearerTokenAuthorization.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,12 +45,12 @@  discard block
 block discarded – undo
45 45
         }
46 46
 
47 47
         $result = $this->tokenRepository->validToken($token);
48
-        if (!$result) {
48
+        if ( ! $result) {
49 49
             $this->errorMessage = 'Token doesn\'t exists or isn\'t active';
50 50
             return false;
51 51
         }
52 52
 
53
-        if (!$this->isValidIp($this->tokenRepository->ipRestrictions($token))) {
53
+        if ( ! $this->isValidIp($this->tokenRepository->ipRestrictions($token))) {
54 54
             $this->errorMessage = 'Invalid IP';
55 55
             return false;
56 56
         }
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
         list($range, $netmask) = explode('/', $range, 2);
114 114
         $range_decimal = ip2long($range);
115 115
         $ipDecimal = ip2long($ip);
116
-        $wildcard_decimal = pow(2, (32 - (int)$netmask)) - 1;
116
+        $wildcard_decimal = pow(2, (32 - (int) $netmask)) - 1;
117 117
         $netmask_decimal = ~ $wildcard_decimal;
118 118
         return (($ipDecimal & $netmask_decimal) === ($range_decimal & $netmask_decimal));
119 119
     }
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
      */
127 127
     private function readAuthorizationToken(): ?string
128 128
     {
129
-        if (!isset($_SERVER['HTTP_AUTHORIZATION'])) {
129
+        if ( ! isset($_SERVER['HTTP_AUTHORIZATION'])) {
130 130
             $this->errorMessage = 'Authorization header HTTP_Authorization is not set';
131 131
             return null;
132 132
         }
Please login to merge, or discard this patch.
src/ValidationResult/ValidationResult.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
 
17 17
     public function __construct(string $status, array $errors = [])
18 18
     {
19
-        if (!in_array($status, [self::STATUS_OK, self::STATUS_ERROR], true)) {
19
+        if ( ! in_array($status, [self::STATUS_OK, self::STATUS_ERROR], true)) {
20 20
             throw new InvalidArgumentException($status . ' is not valid validation result status');
21 21
         }
22 22
 
Please login to merge, or discard this patch.
src/Params/ParamsProcessor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,11 +21,11 @@
 block discarded – undo
21 21
     {
22 22
         foreach ($this->params as $param) {
23 23
             $validationResult = $param->validate();
24
-            if (!$validationResult->isOk()) {
24
+            if ( ! $validationResult->isOk()) {
25 25
                 $this->errors[$param->getKey()] = $validationResult->getErrors();
26 26
             }
27 27
         }
28
-        return !empty($this->errors);
28
+        return ! empty($this->errors);
29 29
     }
30 30
 
31 31
     public function getErrors(): array
Please login to merge, or discard this patch.
src/Params/JsonInputParam.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
             return new ValidationResult(ValidationResult::STATUS_ERROR, [json_last_error_msg()]);
41 41
         }
42 42
 
43
-        if (!$value && $this->isRequired() === self::OPTIONAL) {
43
+        if ( ! $value && $this->isRequired() === self::OPTIONAL) {
44 44
             return new ValidationResult(ValidationResult::STATUS_OK);
45 45
         }
46 46
 
Please login to merge, or discard this patch.
src/Output/JsonOutput.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
 
26 26
     public function validate(ResponseInterface $response): ValidationResultInterface
27 27
     {
28
-        if (!$response instanceof JsonApiResponse) {
28
+        if ( ! $response instanceof JsonApiResponse) {
29 29
             return new ValidationResult(ValidationResult::STATUS_ERROR);
30 30
         }
31 31
         if ($this->code !== $response->getCode()) {
Please login to merge, or discard this patch.
src/Presenters/ApiPresenter.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
                 }
97 97
                 $outputValidatorErrors[] = $validationResult->getErrors();
98 98
             }
99
-            if (!$outputValid) {
99
+            if ( ! $outputValid) {
100 100
                 $response = new JsonApiResponse(500, ['status' => 'error', 'message' => 'Internal server error', 'details' => $outputValidatorErrors]);
101 101
             }
102 102
             $code = $response->getCode();
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 
136 136
     private function checkAuth(ApiAuthorizationInterface $authorization): bool
137 137
     {
138
-        if (!$authorization->authorized()) {
138
+        if ( ! $authorization->authorized()) {
139 139
             $this->getHttpResponse()->setCode(Response::S403_FORBIDDEN);
140 140
             $this->sendResponse(new JsonResponse(['status' => 'error', 'message' => $authorization->getErrorMessage()]));
141 141
             return false;
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
     private function checkRateLimit(RateLimitInterface $rateLimit): bool
147 147
     {
148 148
         $rateLimitResponse = $rateLimit->check();
149
-        if (!$rateLimitResponse) {
149
+        if ( ! $rateLimitResponse) {
150 150
             return true;
151 151
         }
152 152
 
@@ -154,12 +154,12 @@  discard block
 block discarded – undo
154 154
         $remaining = $rateLimitResponse->getRemaining();
155 155
         $retryAfter = $rateLimitResponse->getRetryAfter();
156 156
 
157
-        $this->getHttpResponse()->addHeader('X-RateLimit-Limit', (string)$limit);
158
-        $this->getHttpResponse()->addHeader('X-RateLimit-Remaining', (string)$remaining);
157
+        $this->getHttpResponse()->addHeader('X-RateLimit-Limit', (string) $limit);
158
+        $this->getHttpResponse()->addHeader('X-RateLimit-Remaining', (string) $remaining);
159 159
 
160 160
         if ($remaining === 0) {
161 161
             $this->getHttpResponse()->setCode(Response::S429_TOO_MANY_REQUESTS);
162
-            $this->getHttpResponse()->addHeader('Retry-After', (string)$retryAfter);
162
+            $this->getHttpResponse()->addHeader('Retry-After', (string) $retryAfter);
163 163
             $response = $rateLimitResponse->getErrorResponse() ?: new JsonResponse(['status' => 'error', 'message' => 'Too many requests. Retry after ' . $retryAfter . ' seconds.']);
164 164
             $this->sendResponse($response);
165 165
             return false;
@@ -239,11 +239,11 @@  discard block
 block discarded – undo
239 239
 
240 240
     private function getRequestDomain(): ?string
241 241
     {
242
-        if (!filter_input(INPUT_SERVER, 'HTTP_REFERER')) {
242
+        if ( ! filter_input(INPUT_SERVER, 'HTTP_REFERER')) {
243 243
             return null;
244 244
         }
245 245
         $refererParsedUrl = parse_url(filter_input(INPUT_SERVER, 'HTTP_REFERER'));
246
-        if (!(isset($refererParsedUrl['scheme']) && isset($refererParsedUrl['host']))) {
246
+        if ( ! (isset($refererParsedUrl['scheme']) && isset($refererParsedUrl['host']))) {
247 247
             return null;
248 248
         }
249 249
         $url = $refererParsedUrl['scheme'] . '://' . $refererParsedUrl['host'];
Please login to merge, or discard this patch.