ConsoleRequest::makeRequest() - Code Metrics - Inspection of "ConsoleRequest: sends current PHPSESSID as cookie" - tomaj/nette-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#26)

unknown

created 2016-04-02 21:51 UTC

ConsoleRequest::makeRequest() C

↳ Parent: ConsoleRequest

Complexity

Conditions	10
Paths	64

Size

Total Lines	80
Code Lines	58

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	54
CRAP Score	10.4843

Importance

Changes	9
Bugs	2	Features	3

Metric	Value
c	9
b	2
f	3
dl	0
loc	80
ccs	54
cts	65
cp	0.8308
rs	5.5471
cc	10
eloc	58
nc	64
nop	4
crap	10.4843

How to fix Long Method Complexity

<?php

namespace Tomaj\NetteApi\Misc;

use Tomaj\NetteApi\Handlers\ApiHandlerInterface;
use Tomaj\NetteApi\Params\InputParam;

class ConsoleRequest
{
    /**
     * @var ApiHandlerInterface
     */
    private $handler;

    /**
     * Create ConsoleRequest
     *
     * @param ApiHandlerInterface $handler
     */
    public function __construct(ApiHandlerInterface $handler)
    {
        $this->handler = $handler;
    }

    /**
     * Make request to API url
     *
     * @param string $url
     * @param string $method
     * @param array $values
     * @param string|null $token
     *
     * @return ConsoleResponse
     */
    public function makeRequest($url, $method, array $values, $token = null)
    {
        list($postFields, $getFields, $cookieFields, $rawPost) = $this->processValues($values);

        $postFields = $this->normalizeValues($postFields);
        $getFields = $this->normalizeValues($getFields);

        if (count($getFields)) {
            $parts = [];
            foreach ($getFields as $key => $value) {
                $parts[] = "$key=$value";
            }
            $url = $url . '?' . implode('&', $parts);
        }

        $startTime = microtime(true);

        $curl = curl_init();
        curl_setopt($curl, CURLOPT_URL, $url);
        curl_setopt($curl, CURLOPT_CUSTOMREQUEST, $method);
        curl_setopt($curl, CURLOPT_NOBODY, false);
        curl_setopt($curl, CURLOPT_FOLLOWLOCATION, true);
        curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
        curl_setopt($curl, CURLOPT_VERBOSE, false);
        curl_setopt($curl, CURLOPT_TIMEOUT, 10);
        curl_setopt($curl, CURLOPT_HEADER, true);
        if (count($postFields)) {
            curl_setopt($curl, CURLOPT_POST, true);
            curl_setopt($curl, CURLOPT_POSTFIELDS, $postFields);
        }
        if ($rawPost) {
            curl_setopt($curl, CURLOPT_POST, true);
            curl_setopt($curl, CURLOPT_POSTFIELDS, $rawPost);
        }
        $cookieFields['PHPSESSID'] = session_id();
        if (count($cookieFields)) {
            $parts = [];
            foreach ($cookieFields as $key => $value) {
                $parts[] = "$key=$value";
            }
            curl_setopt($curl, CURLOPT_HTTPHEADER, ["Cookie: " . implode('&', $parts)]);
        }

        curl_setopt($curl, CURLOPT_TIMEOUT, 30);
        $headers = [];
        if ($token !== null && $token !== false) {
            $headers = ['Authorization: Bearer ' . $token];
            curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
        }

        $consoleResponse = new ConsoleResponse(
            $url,
            $method,
            $postFields,
            $getFields,
            $cookieFields,
            $headers,
            $rawPost
        );
        /** @see http://stackoverflow.com/questions/15627217/curl-not-passing-phpsessid */
        session_write_close();

        $response = curl_exec($curl);
        $elapsed = intval((microtime(true) - $startTime) * 1000);

        $headerSize = curl_getinfo($curl, CURLINFO_HEADER_SIZE);
        $responseHeaders = substr($response, 0, $headerSize);
        $responseBody = substr($response, $headerSize);

        $curlErrorNumber = curl_errno($curl);
        $curlError = curl_error($curl);
        if ($curlErrorNumber > 0) {
            $consoleResponse->logError($curlErrorNumber, $curlError, $elapsed);
        } else {
            $httpCode = curl_getinfo($curl, CURLINFO_HTTP_CODE);
            $consoleResponse->logRequest($httpCode, $responseBody, $responseHeaders, $elapsed);
        }

        return $consoleResponse;
    }

    /**
     * Process given values to POST and GET fields
     *
     * @param array $values
     *
     * @return array
     */
    private function processValues(array $values)
    {
        $params = $this->handler->params();

        $postFields = [];
        $rawPost = isset($values['post_raw']) ? $values['post_raw'] : false;
        $getFields = [];
        $cookieFields = [];

        foreach ($values as $key => $value) {
            if (strstr($key, '___') !== false) {
                $parts = explode('___', $key);
                $key = $parts[0];
            }

            foreach ($params as $param) {
                $valueData = $this->processParam($param, $key, $value);
                if ($valueData === null) {
                    continue;
                }

                if ($param->isMulti()) {
                    if (in_array($param->getType(), [InputParam::TYPE_POST, InputParam::TYPE_FILE])) {

                        $postFields[$key][] = $valueData;
                    } elseif ($param->getType() == InputParam::TYPE_COOKIE) {
                        $cookieFields[$key][] = $valueData;
                    } else {
                        $getFields[$key][] = $valueData;
                    }
                } else {
                    if (in_array($param->getType(), [InputParam::TYPE_POST, InputParam::TYPE_FILE])) {

                        $postFields[$key] = $valueData;
                    } elseif ($param->getType() == InputParam::TYPE_COOKIE) {
                        $cookieFields[$key] = $valueData;
                    } else {
                        $getFields[$key] = $valueData;
                    }
                }
            }
        }

        return [$postFields, $getFields, $cookieFields, $rawPost];
    }

    /**
     * Process one param and returns value
     *
     * @param InputParam  $param   input param
     * @param string      $key     param key
     * @param string      $value   actual value from request
     *
     * @return string
     */
    private function processParam(InputParam $param, $key, $value)
    {
        if ($param->getKey() == $key) {
            if (!$value) {
                return null;
            }

            $valueData = $value;

            if ($param->getType() == InputParam::TYPE_FILE) {
                if ($value->isOk()) {

                    $valueData = curl_file_create($value->getTemporaryFile(), $value->getContentType(), $value->getName());

                } else {
                    $valueData = false;
                }
            }

            if ($param->getType() == InputParam::TYPE_POST_RAW) {
                if (isset($HTTP_RAW_POST_DATA)) {

                    $valueData = $HTTP_RAW_POST_DATA;
                } else {
                    $valueData = file_get_contents('php://input');
                }
            }

            return $valueData;
        }
        return null;
    }

    /**
     * Normalize values array.
     *
     * @param $values
     * @return array
     */
    private function normalizeValues($values)
    {
        $result = [];
        foreach ($values as $key => $value) {
            if (is_array($value)) {
                $counter = 0;
                foreach ($value as $innerValue) {
                    if ($innerValue != null) {
                        $result[$key . "[".$counter++."]"] = $innerValue;
                    }
                }
            } else {
                $result[$key] = $value;
            }
        }
        return $result;
    }
}


1			<?php
2
3			namespace Tomaj\NetteApi\Misc;
4
5			use Tomaj\NetteApi\Handlers\ApiHandlerInterface;
6			use Tomaj\NetteApi\Params\InputParam;
7
8			class ConsoleRequest
9			{
10			/**
11			* @var ApiHandlerInterface
12			*/
13			private $handler;
14
15			/**
16			* Create ConsoleRequest
17			*
18			* @param ApiHandlerInterface $handler
19			*/
20	3		public function __construct(ApiHandlerInterface $handler)
21			{
22	3		$this->handler = $handler;
23	3		}
24
25			/**
26			* Make request to API url
27			*
28			* @param string $url
29			* @param string $method
30			* @param array $values
31			* @param string\|null $token
32			*
33			* @return ConsoleResponse
34			*/
35	3		public function makeRequest($url, $method, array $values, $token = null)
36			{
37	3		list($postFields, $getFields, $cookieFields, $rawPost) = $this->processValues($values);
38
39	3		$postFields = $this->normalizeValues($postFields);
40	3		$getFields = $this->normalizeValues($getFields);
41
42	3		if (count($getFields)) {
43	3		$parts = [];
44	3		foreach ($getFields as $key => $value) {
45	3		$parts[] = "$key=$value";
46	3		}
47	3		$url = $url . '?' . implode('&', $parts);
48	3		}
49
50	3		$startTime = microtime(true);
51
52	3		$curl = curl_init();
53	3		curl_setopt($curl, CURLOPT_URL, $url);
54	3		curl_setopt($curl, CURLOPT_CUSTOMREQUEST, $method);
55	3		curl_setopt($curl, CURLOPT_NOBODY, false);
56	3		curl_setopt($curl, CURLOPT_FOLLOWLOCATION, true);
57	3		curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
58	3		curl_setopt($curl, CURLOPT_VERBOSE, false);
59	3		curl_setopt($curl, CURLOPT_TIMEOUT, 10);
60	3		curl_setopt($curl, CURLOPT_HEADER, true);
61	3		if (count($postFields)) {
62			curl_setopt($curl, CURLOPT_POST, true);
63			curl_setopt($curl, CURLOPT_POSTFIELDS, $postFields);
64			}
65	3		if ($rawPost) {
66			curl_setopt($curl, CURLOPT_POST, true);
67			curl_setopt($curl, CURLOPT_POSTFIELDS, $rawPost);
68			}
69	3		$cookieFields['PHPSESSID'] = session_id();
70	3		if (count($cookieFields)) {
71	3		$parts = [];
72	3		foreach ($cookieFields as $key => $value) {
73	3		$parts[] = "$key=$value";
74	3		}
75	3		curl_setopt($curl, CURLOPT_HTTPHEADER, ["Cookie: " . implode('&', $parts)]);
76	3		}
77
78	3		curl_setopt($curl, CURLOPT_TIMEOUT, 30);
79	3		$headers = [];
80	3		if ($token !== null && $token !== false) {
81			$headers = ['Authorization: Bearer ' . $token];
82			curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
83			}
84
85	3		$consoleResponse = new ConsoleResponse(
86	3		$url,
87	3		$method,
88	3		$postFields,
89	3		$getFields,
90	3		$cookieFields,
91	3		$headers,
92			$rawPost
93	3		);
94			/** @see http://stackoverflow.com/questions/15627217/curl-not-passing-phpsessid */
95	3		session_write_close();
96
97	3		$response = curl_exec($curl);
98	3		$elapsed = intval((microtime(true) - $startTime) * 1000);
99
100	3		$headerSize = curl_getinfo($curl, CURLINFO_HEADER_SIZE);
101	3		$responseHeaders = substr($response, 0, $headerSize);
102	3		$responseBody = substr($response, $headerSize);
103
104	3		$curlErrorNumber = curl_errno($curl);
105	3		$curlError = curl_error($curl);
106	3		if ($curlErrorNumber > 0) {
107	3		$consoleResponse->logError($curlErrorNumber, $curlError, $elapsed);
108	3		} else {
109			$httpCode = curl_getinfo($curl, CURLINFO_HTTP_CODE);
110			$consoleResponse->logRequest($httpCode, $responseBody, $responseHeaders, $elapsed);
111			}
112
113	3		return $consoleResponse;
114			}
115
116			/**
117			* Process given values to POST and GET fields
118			*
119			* @param array $values
120			*
121			* @return array
122			*/
123	3		private function processValues(array $values)
124			{
125	3		$params = $this->handler->params();
126
127	3		$postFields = [];
128	3		$rawPost = isset($values['post_raw']) ? $values['post_raw'] : false;
129	3		$getFields = [];
130	3		$cookieFields = [];
131
132	3		foreach ($values as $key => $value) {
133	3		if (strstr($key, '___') !== false) {
134			$parts = explode('___', $key);
135			$key = $parts[0];
136			}
137
138	3		foreach ($params as $param) {
139	3		$valueData = $this->processParam($param, $key, $value);
140	3		if ($valueData === null) {
141	3		continue;
142			}
143
144	3		if ($param->isMulti()) {
145		View Code Duplication	if (in_array($param->getType(), [InputParam::TYPE_POST, InputParam::TYPE_FILE])) {
			0 ignored issues – show Duplication introduced 2016-02-02 11:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
146			$postFields[$key][] = $valueData;
147			} elseif ($param->getType() == InputParam::TYPE_COOKIE) {
148			$cookieFields[$key][] = $valueData;
149			} else {
150			$getFields[$key][] = $valueData;
151			}
152			} else {
153	3	View Code Duplication	if (in_array($param->getType(), [InputParam::TYPE_POST, InputParam::TYPE_FILE])) {
			0 ignored issues – show Duplication introduced 2016-02-11 14:05 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
154			$postFields[$key] = $valueData;
155	3		} elseif ($param->getType() == InputParam::TYPE_COOKIE) {
156			$cookieFields[$key] = $valueData;
157			} else {
158	3		$getFields[$key] = $valueData;
159			}
160			}
161	3		}
162	3		}
163
164	3		return [$postFields, $getFields, $cookieFields, $rawPost];
165			}
166
167			/**
168			* Process one param and returns value
169			*
170			* @param InputParam $param input param
171			* @param string $key param key
172			* @param string $value actual value from request
173			*
174			* @return string
175			*/
176	3		private function processParam(InputParam $param, $key, $value)
177			{
178	3		if ($param->getKey() == $key) {
179	3		if (!$value) {
180			return null;
181			}
182
183	3		$valueData = $value;
184
185	3		if ($param->getType() == InputParam::TYPE_FILE) {
186			if ($value->isOk()) {
			0 ignored issues – show Bug introduced 2016-02-02 11:08 UTC by Report Bug Copy Issue Report The method `isOk` cannot be called on `$value` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
187			$valueData = curl_file_create($value->getTemporaryFile(), $value->getContentType(), $value->getName());
			0 ignored issues – show Bug introduced 2016-02-02 11:08 UTC by Report Bug Copy Issue Report The method `getTemporaryFile` cannot be called on `$value` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history... Bug introduced 2016-02-02 11:08 UTC by Report Bug Copy Issue Report The method `getContentType` cannot be called on `$value` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history... Bug introduced 2016-02-02 11:08 UTC by Report Bug Copy Issue Report The method `getName` cannot be called on `$value` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
188			} else {
189			$valueData = false;
190			}
191			}
192
193	3		if ($param->getType() == InputParam::TYPE_POST_RAW) {
194			if (isset($HTTP_RAW_POST_DATA)) {
			0 ignored issues – show Bug introduced 2016-02-11 13:52 UTC by Report Bug Copy Issue Report The variable `$HTTP_RAW_POST_DATA` seems to never exist, and therefore `isset` should always return `false`. Did you maybe rename this variable? This check looks for calls to `isset(...)` or `empty()` on variables that are yet undefined. These calls will always produce the same result and can be removed. This is most likely caused by the renaming of a variable or the removal of a function/method parameter. Loading history...
195			$valueData = $HTTP_RAW_POST_DATA;
196			} else {
197			$valueData = file_get_contents('php://input');
198			}
199			}
200
201	3		return $valueData;
202			}
203	3		return null;
204			}
205
206			/**
207			* Normalize values array.
208			*
209			* @param $values
210			* @return array
211			*/
212	3		private function normalizeValues($values)
213			{
214	3		$result = [];
215	3		foreach ($values as $key => $value) {
216	3		if (is_array($value)) {
217			$counter = 0;
218			foreach ($value as $innerValue) {
219			if ($innerValue != null) {
220			$result[$key . "[".$counter++."]"] = $innerValue;
221			}
222			}
223			} else {
224	3		$result[$key] = $value;
225			}
226	3		}
227	3		return $result;
228			}
229			}
230

tomaj / nette-api

Pull Request — master (#26)

ConsoleRequest::makeRequest() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like