TextApiResponse::__construct() - Code Metrics - Inspection of "WIP 2.0.0" - tomaj/nette-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#61)

by Tomas

created 2019-04-11 13:40 UTC

TextApiResponse::__construct() A

↳ Parent: TextApiResponse

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	1

<?php

namespace Tomaj\NetteApi\Response;

use Nette\Application\UI\ITemplate;
use Nette\Http\IRequest;
use Nette\Http\IResponse;
use Nette\SmartObject;

class TextApiResponse implements ResponseInterface
{
    use SmartObject;

    /** @var int */
    private $code;

    /** @var mixed */
    private $data;

    /**
     * @param int $code
     * @param mixed $data
     */
    public function __construct(int $code, $data)
    {
        $this->code = $code;
        $this->data = $data;
    }

    /**
     * {@inheritdoc}
     */
    public function getCode(): int
    {
        return $this->code;
    }

    /**
     * {@inheritdoc}
     */
    public function send(IRequest $httpRequest, IResponse $httpResponse): void
    {
        if ($this->data instanceof ITemplate) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $this->data->render();
        } else {
            echo $this->data;
        }
    }
}


Pull Request — master (#61)

TextApiResponse::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

1		<?php
2
3		namespace Tomaj\NetteApi\Response;
4
5		use Nette\Application\UI\ITemplate;
6		use Nette\Http\IRequest;
7		use Nette\Http\IResponse;
8		use Nette\SmartObject;
9
10		class TextApiResponse implements ResponseInterface
11		{
12		use SmartObject;
13
14		/** @var int */
15		private $code;
16
17		/** @var mixed */
18		private $data;
19
20		/**
21		* @param int $code
22		* @param mixed $data
23		*/
24	3	public function __construct(int $code, $data)
25		{
26	3	$this->code = $code;
27	3	$this->data = $data;
28	3	}
29
30		/**
31		* {@inheritdoc}
32		*/
33	3	public function getCode(): int
34		{
35	3	return $this->code;
36		}
37
38		/**
39		* {@inheritdoc}
40		*/
41	3	public function send(IRequest $httpRequest, IResponse $httpResponse): void
42		{
43	3	if ($this->data instanceof ITemplate) {
		0 ignored issues – show Bug introduced 2019-04-11 13:30 UTC by Report Bug Copy Issue Report The class `Nette\Application\UI\ITemplate` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
44		$this->data->render();
45		} else {
46	3	echo $this->data;
47		}
48	3	}
49		}
50

tomaj / nette-api

Pull Request — master (#61)

TextApiResponse::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like