ConsoleRequest::processParam() - Code Metrics - Inspection of "File console upload" - tomaj/nette-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

by Tomas

created 2016-02-02 11:04 UTC

ConsoleRequest::processParam() B

↳ Parent: ConsoleRequest

Complexity

Conditions	6
Paths	6

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	9.6594

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
c	3
b	0
f	1
dl	0
loc	23
ccs	8
cts	15
cp	0.5333
rs	8.5906
cc	6
eloc	15
nc	6
nop	3
crap	9.6594

<?php

namespace Tomaj\NetteApi\Misc;

use Tomaj\NetteApi\Handlers\ApiHandlerInterface;
use Tomaj\NetteApi\Params\InputParam;

class ConsoleRequest
{
    /**
     * @var ApiHandlerInterface
     */
    private $handler;

    /**
     * Create ConsoleRequest
     *
     * @param ApiHandlerInterface $handler
     */
    public function __construct(ApiHandlerInterface $handler)
    {
        $this->handler = $handler;
    }

    /**
     * Make request to API url
     *
     * @param string $url
     * @param string $method
     * @param array $values
     * @param string|null $token
     *
     * @return ConsoleResponse
     */
    public function makeRequest($url, $method, array $values, $token = null)
    {
        list($postFields, $getFields) = $this->processValues($values);

        if (count($getFields)) {
            $url = $url . '?' . implode('&', $getFields);
        }

        $startTime = microtime();

        $curl = curl_init();
        curl_setopt($curl, CURLOPT_URL, $url);
        curl_setopt($curl, CURLOPT_CUSTOMREQUEST, $method);
        curl_setopt($curl, CURLOPT_NOBODY, false);
        curl_setopt($curl, CURLOPT_FOLLOWLOCATION, true);
        curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
        curl_setopt($curl, CURLOPT_VERBOSE, false);
        curl_setopt($curl, CURLOPT_TIMEOUT, 10);
        curl_setopt($curl, CURLOPT_HEADER, 1);
        if (count($postFields)) {
            curl_setopt($curl, CURLOPT_POST, 1);
            curl_setopt($curl, CURLOPT_POSTFIELDS, $postFields);
        }

        curl_setopt($curl, CURLOPT_TIMEOUT, 30);
        $headers = [];
        if ($token !== null && $token !== false) {
            $headers = ['Authorization: Bearer ' . $token];
            curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
        }

        $consoleResponse = new ConsoleResponse(
            $url,
            $method,
            $postFields,
            $getFields,
            $headers
        );

        $response = curl_exec($curl);
        $elapsed = intval((microtime() - $startTime) * 1000);

        $headerSize = curl_getinfo($curl, CURLINFO_HEADER_SIZE);
        $responseHeaders = substr($response, 0, $headerSize);
        $responseBody = substr($response, $headerSize);

        $curlErrorNumber = curl_errno($curl);
        $curlError = curl_error($curl);
        if ($curlErrorNumber > 0) {
            $consoleResponse->logError($curlErrorNumber, $curlError, $elapsed);
        } else {
            $httpCode = curl_getinfo($curl, CURLINFO_HTTP_CODE);
            $consoleResponse->logRequest($httpCode, $responseBody, $responseHeaders, $elapsed);
        }

        return $consoleResponse;
    }

    /**
     * Process given values to POST and GET fields
     *
     * @param array $values
     *
     * @return array
     */
    private function processValues(array $values)
    {
        $params = $this->handler->params();

        $postFields = [];
        $getFields = [];
        $fileFields = [];

        foreach ($values as $key => $value) {
            if (strstr($key, '___') !== false) {
                $parts = explode('___', $key);
                $key = $parts[0];
            }

            foreach ($params as $param) {
                $valueData = $this->processParam($param, $key, $value);
                if ($valueData === null) {
                    continue;
                }

                if ($param->getType() == InputParam::TYPE_FILE) {
                    $postFields[$key] = $valueData;
                } elseif ($param->getType() == InputParam::TYPE_POST) {
                    $postFields[$key] = $valueData;
                } else {
                    $getFields[$key] = $valueData;
                }
            }
        }

        return [$postFields, $getFields, $fileFields];
    }

    /**
     * Process one param and returns value
     *
     * @param InputParam  $param   input param
     * @param string      $key     param key
     * @param string      $value   actual value from request
     *
     * @return string
     */
    private function processParam(InputParam $param, $key, $value)
    {
        if ($param->getKey() == $key) {
            if (!$value) {
                return null;
            }

            if ($param->isMulti()) {
                $valueData = $this->processMultiParam($key, $value);
            } elseif ($param->getType() == InputParam::TYPE_FILE) {
                if ($value->isOk()) {

                    $valueData = curl_file_create($value->getTemporaryFile(), $value->getContentType(), $value->getName());

                } else {
                    $valueData = false;
                }
            } else {
                $valueData = "$value";
            }

            return $valueData;
        }
        return null;
    }

    /**
     * Process multi param
     *
     * @param string  $key
     * @param string  $value
     * @return string
     */
    private function processMultiParam($key, $value)
    {
        $valueKey = '';
        if (strstr($value, '=') !== false) {
            $parts = explode('=', $value);
            $valueKey = $parts[0];
            $value = $parts[1];
        }
        return $key . "[$valueKey]=$value";
    }
}


1		<?php
2
3		namespace Tomaj\NetteApi\Misc;
4
5		use Tomaj\NetteApi\Handlers\ApiHandlerInterface;
6		use Tomaj\NetteApi\Params\InputParam;
7
8		class ConsoleRequest
9		{
10		/**
11		* @var ApiHandlerInterface
12		*/
13		private $handler;
14
15		/**
16		* Create ConsoleRequest
17		*
18		* @param ApiHandlerInterface $handler
19		*/
20	3	public function __construct(ApiHandlerInterface $handler)
21		{
22	3	$this->handler = $handler;
23	3	}
24
25		/**
26		* Make request to API url
27		*
28		* @param string $url
29		* @param string $method
30		* @param array $values
31		* @param string\|null $token
32		*
33		* @return ConsoleResponse
34		*/
35	3	public function makeRequest($url, $method, array $values, $token = null)
36		{
37	3	list($postFields, $getFields) = $this->processValues($values);
38
39	3	if (count($getFields)) {
40	3	$url = $url . '?' . implode('&', $getFields);
41	3	}
42
43	3	$startTime = microtime();
44
45	3	$curl = curl_init();
46	3	curl_setopt($curl, CURLOPT_URL, $url);
47	3	curl_setopt($curl, CURLOPT_CUSTOMREQUEST, $method);
48	3	curl_setopt($curl, CURLOPT_NOBODY, false);
49	3	curl_setopt($curl, CURLOPT_FOLLOWLOCATION, true);
50	3	curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
51	3	curl_setopt($curl, CURLOPT_VERBOSE, false);
52	3	curl_setopt($curl, CURLOPT_TIMEOUT, 10);
53	3	curl_setopt($curl, CURLOPT_HEADER, 1);
54	3	if (count($postFields)) {
55		curl_setopt($curl, CURLOPT_POST, 1);
56		curl_setopt($curl, CURLOPT_POSTFIELDS, $postFields);
57		}
58
59	3	curl_setopt($curl, CURLOPT_TIMEOUT, 30);
60	3	$headers = [];
61	3	if ($token !== null && $token !== false) {
62		$headers = ['Authorization: Bearer ' . $token];
63		curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
64		}
65
66	3	$consoleResponse = new ConsoleResponse(
67	3	$url,
68	3	$method,
69	3	$postFields,
70	3	$getFields,
71		$headers
72	3	);
73
74	3	$response = curl_exec($curl);
75	3	$elapsed = intval((microtime() - $startTime) * 1000);
76
77	3	$headerSize = curl_getinfo($curl, CURLINFO_HEADER_SIZE);
78	3	$responseHeaders = substr($response, 0, $headerSize);
79	3	$responseBody = substr($response, $headerSize);
80
81	3	$curlErrorNumber = curl_errno($curl);
82	3	$curlError = curl_error($curl);
83	3	if ($curlErrorNumber > 0) {
84	3	$consoleResponse->logError($curlErrorNumber, $curlError, $elapsed);
85	3	} else {
86		$httpCode = curl_getinfo($curl, CURLINFO_HTTP_CODE);
87		$consoleResponse->logRequest($httpCode, $responseBody, $responseHeaders, $elapsed);
88		}
89
90	3	return $consoleResponse;
91		}
92
93		/**
94		* Process given values to POST and GET fields
95		*
96		* @param array $values
97		*
98		* @return array
99		*/
100	3	private function processValues(array $values)
101		{
102	3	$params = $this->handler->params();
103
104	3	$postFields = [];
105	3	$getFields = [];
106	3	$fileFields = [];
107
108	3	foreach ($values as $key => $value) {
109	3	if (strstr($key, '___') !== false) {
110		$parts = explode('___', $key);
111		$key = $parts[0];
112		}
113
114	3	foreach ($params as $param) {
115	3	$valueData = $this->processParam($param, $key, $value);
116	3	if ($valueData === null) {
117	3	continue;
118		}
119
120	3	if ($param->getType() == InputParam::TYPE_FILE) {
121		$postFields[$key] = $valueData;
122	3	} elseif ($param->getType() == InputParam::TYPE_POST) {
123		$postFields[$key] = $valueData;
124		} else {
125	3	$getFields[$key] = $valueData;
126		}
127	3	}
128	3	}
129
130	3	return [$postFields, $getFields, $fileFields];
131		}
132
133		/**
134		* Process one param and returns value
135		*
136		* @param InputParam $param input param
137		* @param string $key param key
138		* @param string $value actual value from request
139		*
140		* @return string
141		*/
142	3	private function processParam(InputParam $param, $key, $value)
143		{
144	3	if ($param->getKey() == $key) {
145	3	if (!$value) {
146		return null;
147		}
148
149	3	if ($param->isMulti()) {
150		$valueData = $this->processMultiParam($key, $value);
151	3	} elseif ($param->getType() == InputParam::TYPE_FILE) {
152		if ($value->isOk()) {
		0 ignored issues – show Bug introduced 2016-02-02 11:08 UTC by Report Bug Copy Issue Report The method `isOk` cannot be called on `$value` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
153		$valueData = curl_file_create($value->getTemporaryFile(), $value->getContentType(), $value->getName());
		0 ignored issues – show Bug introduced 2016-02-02 11:08 UTC by Report Bug Copy Issue Report The method `getTemporaryFile` cannot be called on `$value` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history... Bug introduced 2016-02-02 11:08 UTC by Report Bug Copy Issue Report The method `getContentType` cannot be called on `$value` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history... Bug introduced 2016-02-02 11:08 UTC by Report Bug Copy Issue Report The method `getName` cannot be called on `$value` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
154		} else {
155		$valueData = false;
156		}
157		} else {
158	3	$valueData = "$value";
159		}
160
161	3	return $valueData;
162		}
163	3	return null;
164		}
165
166		/**
167		* Process multi param
168		*
169		* @param string $key
170		* @param string $value
171		* @return string
172		*/
173		private function processMultiParam($key, $value)
174		{
175		$valueKey = '';
176		if (strstr($value, '=') !== false) {
177		$parts = explode('=', $value);
178		$valueKey = $parts[0];
179		$value = $parts[1];
180		}
181		return $key . "[$valueKey]=$value";
182		}
183		}
184

tomaj / nette-api

Pull Request — master (#20)

ConsoleRequest::processParam() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like