SharedFileRestart::__construct() - Code Metrics - Inspection of "Merge pull request #31 from markoph/redis-implemen..." - tomaj/hermes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1b6642...22d6fd )

by Tomas

created 2020-10-12 19:09 UTC

SharedFileRestart::__construct() A

↳ Parent: SharedFileRestart

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php
declare(strict_types=1);

namespace Tomaj\Hermes\Restart;

use DateTime;

class SharedFileRestart implements RestartInterface
{
    private $filePath;

    public function __construct(string $filePath)
    {
        $this->filePath = $filePath;
    }

    /**
     * {@inheritdoc}
     */
    public function shouldRestart(DateTime $startTime): bool
    {
        if (!file_exists($this->filePath)) {
            return false;
        }

        $time = filemtime($this->filePath);
        if ($time >= $startTime->getTimestamp()) {
            return true;
        }

        return false;
    }

    /**
     * {@inheritdoc}
     *
     * Creates file defined in contructor with modification time `$restartTime` (or current DateTime).
     */
    public function restart(DateTime $restartTime = null): bool

    {
        if ($restartTime === null) {
            $restartTime = new DateTime();
        }

        return touch($this->filePath, (int) $restartTime->format('U'));
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Tomaj\Hermes\Restart;
5
6			use DateTime;
7
8			class SharedFileRestart implements RestartInterface
9			{
10			private $filePath;
11	9
12			public function __construct(string $filePath)
13	9		{
14	9		$this->filePath = $filePath;
15			}
16
17			/**
18			* {@inheritdoc}
19	9		*/
20			public function shouldRestart(DateTime $startTime): bool
21	9		{
22	3		if (!file_exists($this->filePath)) {
23			return false;
24			}
25	6
26	6		$time = filemtime($this->filePath);
27	3		if ($time >= $startTime->getTimestamp()) {
28			return true;
29			}
30	3
31			return false;
32			}
33
34			/**
35			* {@inheritdoc}
36			*
37			* Creates file defined in contructor with modification time `$restartTime` (or current DateTime).
38			*/
39		View Code Duplication	public function restart(DateTime $restartTime = null): bool
			0 ignored issues – show Duplication introduced 2020-10-12 15:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40			{
41			if ($restartTime === null) {
42			$restartTime = new DateTime();
43			}
44
45			return touch($this->filePath, (int) $restartTime->format('U'));
46			}
47			}
48

tomaj / hermes

Push — master ( 1b6642...22d6fd )

SharedFileRestart::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like