| Conditions | 1 |
| Paths | 1 |
| Total Lines | 92 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 205 | public function testVhost() |
||
| 206 | { |
||
| 207 | // Create an account |
||
| 208 | $this->assertTrue($this->getAdminCmd()->addArg('account:create')->addArg('test')->execute()); |
||
| 209 | |||
| 210 | // Create two domains |
||
| 211 | $this->assertTrue($this->getAdminCmd()->addArg('domain:create')->addArg('test')->addArg('example.com') |
||
| 212 | ->execute()); |
||
| 213 | $this->assertTrue($this->getAdminCmd()->addArg('domain:create')->addArg('test')->addArg('test.com')->execute()); |
||
| 214 | $this->assertEquals(2, $this->getConnection()->getRowCount('domain')); |
||
| 215 | $queryTable = $this->getConnection()->createQueryTable('domain', 'SELECT * FROM domain'); |
||
| 216 | $expectedTable = $this->getFixtureDataSet('vhost_create_domain.xml')->getTable('domain'); |
||
| 217 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 218 | |||
| 219 | // Create a virtual host |
||
| 220 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:create')->addArg('test')->addArg('example.com') |
||
| 221 | ->execute()); |
||
| 222 | $this->assertEquals(1, $this->getConnection()->getRowCount('vhost')); |
||
| 223 | $queryTable = $this->getConnection()->createQueryTable('vhost', 'SELECT * FROM vhost'); |
||
| 224 | $expectedTable = $this->getFixtureDataSet('vhost_create.xml')->getTable('vhost'); |
||
| 225 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 226 | $queryTable = $this->getConnection()->createQueryTable('domain', 'SELECT * FROM domain'); |
||
| 227 | $expectedTable = $this->getFixtureDataSet('vhost_create.xml')->getTable('domain'); |
||
| 228 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 229 | |||
| 230 | // Enable the vhost |
||
| 231 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:enable')->addArg('test')->execute()); |
||
| 232 | $queryTable = $this->getConnection()->createQueryTable('vhost', 'SELECT * FROM vhost'); |
||
| 233 | $expectedTable = $this->getFixtureDataSet('vhost_enable.xml')->getTable('vhost'); |
||
| 234 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 235 | |||
| 236 | // Disable the vhost |
||
| 237 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:disable')->addArg('test')->execute()); |
||
| 238 | $queryTable = $this->getConnection()->createQueryTable('vhost', 'SELECT * FROM vhost'); |
||
| 239 | $expectedTable = $this->getFixtureDataSet('vhost_create.xml')->getTable('vhost'); |
||
| 240 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 241 | |||
| 242 | // Configure PHP, the HTTP and the HTTPS ports, the redirect URL and status |
||
| 243 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:php')->addArg('test')->addArg('/')->addArg('7.0') |
||
| 244 | ->execute()); |
||
| 245 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:port:add')->addArg('test')->addArg('/')->addArg('http') |
||
| 246 | ->addArg('81')->execute()); |
||
| 247 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:port:add')->addArg('test')->addArg('/')->addArg('https') |
||
| 248 | ->addArg('444')->execute()); |
||
| 249 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:redirect')->addArg('test')->addArg('/') |
||
| 250 | ->addArg('http://test.com')->addArg('302')->execute()); |
||
| 251 | $queryTable = $this->getConnection()->createQueryTable('vhost', 'SELECT * FROM vhost'); |
||
| 252 | $expectedTable = $this->getFixtureDataSet('vhost_php_ports_redirect.xml')->getTable('vhost'); |
||
| 253 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 254 | $queryTable = $this->getConnection()->createQueryTable('port', 'SELECT * FROM port'); |
||
| 255 | $expectedTable = $this->getFixtureDataSet('vhost_php_ports_redirect.xml')->getTable('port'); |
||
| 256 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 257 | |||
| 258 | // Reset PHP, the HTTP and the HTTPS ports, the redirect URL and status |
||
| 259 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:php')->addArg('test')->execute()); |
||
| 260 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:port:remove')->addArg('test')->addArg('/') |
||
| 261 | ->addArg('http')->addArg('81')->execute()); |
||
| 262 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:port:remove')->addArg('test')->addArg('/') |
||
| 263 | ->addArg('https')->addArg('444')->execute()); |
||
| 264 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:redirect')->addArg('test')->execute()); |
||
| 265 | $queryTable = $this->getConnection()->createQueryTable('vhost', 'SELECT * FROM vhost'); |
||
| 266 | $expectedTable = $this->getFixtureDataSet('vhost_reset.xml')->getTable('vhost'); |
||
| 267 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 268 | $this->assertEquals(0, $this->getConnection()->getRowCount('port')); |
||
| 269 | |||
| 270 | // Add a secondary domain |
||
| 271 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:domain:add')->addArg('test')->addArg('/') |
||
| 272 | ->addArg('test.com')->execute()); |
||
| 273 | $queryTable = $this->getConnection()->createQueryTable('domain', 'SELECT * FROM domain'); |
||
| 274 | $expectedTable = $this->getFixtureDataSet('vhost_domain_add.xml')->getTable('domain'); |
||
| 275 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 276 | |||
| 277 | // Remove a secondary domain |
||
| 278 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:domain:remove')->addArg('test')->addArg('/') |
||
| 279 | ->addArg('test.com')->execute()); |
||
| 280 | $queryTable = $this->getConnection()->createQueryTable('domain', 'SELECT * FROM domain'); |
||
| 281 | $expectedTable = $this->getFixtureDataSet('vhost_create.xml')->getTable('domain'); |
||
| 282 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 283 | |||
| 284 | // Delete the virtual host |
||
| 285 | $this->assertTrue($this->getAdminCmd()->addArg('vhost:delete')->addArg('test')->execute()); |
||
| 286 | $this->assertEquals(0, $this->getConnection()->getRowCount('vhost')); |
||
| 287 | $queryTable = $this->getConnection()->createQueryTable('domain', 'SELECT * FROM domain'); |
||
| 288 | $expectedTable = $this->getFixtureDataSet('vhost_create_domain.xml')->getTable('domain'); |
||
| 289 | $this->assertTablesEqual($expectedTable, $queryTable); |
||
| 290 | |||
| 291 | // Delete the account and the home directory |
||
| 292 | $this->assertTrue($this->getAdminCmd()->addArg('account:delete')->addArg('test')->execute()); |
||
| 293 | $this->assertEquals(0, $this->getConnection()->getRowCount('account')); |
||
| 294 | $this->assertUserNotExists('test'); |
||
| 295 | // self::$tmpDirectories[] = self::$homebase.'test'; |
||
| 296 | } |
||
| 297 | |||
| 349 |