RenameAccountCommand::execute() - Code Metrics - tollwerk/admin - Measure and Improve Code Quality continuously with Scrutinizer

RenameAccountCommand::execute() A
last analyzed 2020-07-08 14:33 UTC

↳ Parent: RenameAccountCommand

Complexity

Conditions	2
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	29
ccs	0
cts	29
cp	0
rs	9.456
c	0
b	0
f	0
cc	2
nc	4
nop	2
crap	6

<?php

/**
 * admin
 *
 * @category    Tollwerk
 * @package     Tollwerk\Admin
 * @subpackage  Tollwerk\Admin\Infrastructure
 * @author      Joschi Kuphal <[email protected]> / @jkphl
 * @copyright   Copyright © 2018 Joschi Kuphal <[email protected]> / @jkphl
 * @license     http://opensource.org/licenses/MIT The MIT License (MIT)
 */

/***********************************************************************************
 *  The MIT License (MIT)
 *
 *  Copyright © 2018 Joschi Kuphal <[email protected]> / @jkphl
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy of
 *  this software and associated documentation files (the "Software"), to deal in
 *  the Software without restriction, including without limitation the rights to
 *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 *  the Software, and to permit persons to whom the Software is furnished to do so,
 *  subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in all
 *  copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ***********************************************************************************/

namespace Tollwerk\Admin\Infrastructure\Commands\Account;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Tollwerk\Admin\Infrastructure\Commands\AbstractCommand;
use Tollwerk\Admin\Ports\Facade\Account;

/**
 * account:rename command
 *
 * @package Tollwerk\Admin
 * @subpackage Tollwerk\Admin\Infrastructure
 */
class RenameAccountCommand extends AbstractCommand
{
    /**
     * Configure the command
     */
    protected function configure()
    {
        $this
            // the name of the command (the part after "bin/console")
            ->setName('account:rename')
            // the short description shown while running "php bin/console list"
            ->setDescription('Rename an existing account')
            // the full command description shown when running the command with
            // the "--help" option
            ->setHelp("This command allows you to rename an existing account")
            // configure the account oldname argument
            ->addArgument('oldname', InputArgument::REQUIRED, 'The old name of the account')
            // configure the account newname argument
            ->addArgument('newname', InputArgument::REQUIRED, 'The new name of the account');
    }

    /**
     * Execute the command
     *
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $oldaccount = $input->getArgument('oldname');
        $newaccount = $input->getArgument('newname');
        try {
            Account::rename($oldaccount, $newaccount);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $output->writeln(
                sprintf(
                    '<info>Account "%s" successfully renamed to "%s"</info>',
                    $oldaccount,
                    $newaccount
                )
            );
            $this->printMessages($output);
            return 0;
        } catch (\Exception $e) {
            $output->writeln(
                sprintf(
                    '<error>Error renaming account "%s" to "%s": %s (%s)</error>',
                    $oldaccount,
                    $newaccount,
                    $e->getMessage(),
                    $e->getCode()
                )
            );
            $this->printMessages($output);
            return $e->getCode();
        }
    }
}


1			<?php
2
3			/**
4			* admin
5			*
6			* @category Tollwerk
7			* @package Tollwerk\Admin
8			* @subpackage Tollwerk\Admin\Infrastructure
9			* @author Joschi Kuphal <[email protected]> / @jkphl
10			* @copyright Copyright © 2018 Joschi Kuphal <[email protected]> / @jkphl
11			* @license http://opensource.org/licenses/MIT The MIT License (MIT)
12			*/
13
14			/***********************************************************************************
15			* The MIT License (MIT)
16			*
17			* Copyright © 2018 Joschi Kuphal <[email protected]> / @jkphl
18			*
19			* Permission is hereby granted, free of charge, to any person obtaining a copy of
20			* this software and associated documentation files (the "Software"), to deal in
21			* the Software without restriction, including without limitation the rights to
22			* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
23			* the Software, and to permit persons to whom the Software is furnished to do so,
24			* subject to the following conditions:
25			*
26			* The above copyright notice and this permission notice shall be included in all
27			* copies or substantial portions of the Software.
28			*
29			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
31			* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
32			* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
33			* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
34			* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
35			***********************************************************************************/
36
37			namespace Tollwerk\Admin\Infrastructure\Commands\Account;
38
39			use Symfony\Component\Console\Input\InputArgument;
40			use Symfony\Component\Console\Input\InputInterface;
41			use Symfony\Component\Console\Output\OutputInterface;
42			use Tollwerk\Admin\Infrastructure\Commands\AbstractCommand;
43			use Tollwerk\Admin\Ports\Facade\Account;
44
45			/**
46			* account:rename command
47			*
48			* @package Tollwerk\Admin
49			* @subpackage Tollwerk\Admin\Infrastructure
50			*/
51			class RenameAccountCommand extends AbstractCommand
52			{
53			/**
54			* Configure the command
55			*/
56			protected function configure()
57			{
58			$this
59			// the name of the command (the part after "bin/console")
60			->setName('account:rename')
61			// the short description shown while running "php bin/console list"
62			->setDescription('Rename an existing account')
63			// the full command description shown when running the command with
64			// the "--help" option
65			->setHelp("This command allows you to rename an existing account")
66			// configure the account oldname argument
67			->addArgument('oldname', InputArgument::REQUIRED, 'The old name of the account')
68			// configure the account newname argument
69			->addArgument('newname', InputArgument::REQUIRED, 'The new name of the account');
70			}
71
72			/**
73			* Execute the command
74			*
75			* @param InputInterface $input
76			* @param OutputInterface $output
77			*/
78			protected function execute(InputInterface $input, OutputInterface $output)
79			{
80			$oldaccount = $input->getArgument('oldname');
81			$newaccount = $input->getArgument('newname');
82			try {
83			Account::rename($oldaccount, $newaccount);
			0 ignored issues – show Bug introduced 2020-07-08 14:26 UTC by Report Bug Copy Issue Report It seems like `$oldaccount` defined by `$input->getArgument('oldname')` on line `80` can also be of type `array<integer,string>` or `null`; however, `Tollwerk\Admin\Ports\Facade\Account::rename()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2020-07-08 14:26 UTC by Report Bug Copy Issue Report It seems like `$newaccount` defined by `$input->getArgument('newname')` on line `81` can also be of type `array<integer,string>` or `null`; however, `Tollwerk\Admin\Ports\Facade\Account::rename()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
84			$output->writeln(
85			sprintf(
86			'<info>Account "%s" successfully renamed to "%s"</info>',
87			$oldaccount,
88			$newaccount
89			)
90			);
91			$this->printMessages($output);
92			return 0;
93			} catch (\Exception $e) {
94			$output->writeln(
95			sprintf(
96			'<error>Error renaming account "%s" to "%s": %s (%s)</error>',
97			$oldaccount,
98			$newaccount,
99			$e->getMessage(),
100			$e->getCode()
101			)
102			);
103			$this->printMessages($output);
104			return $e->getCode();
105			}
106			}
107			}
108

tollwerk / admin

RenameAccountCommand::execute() A last analyzed 2020-07-08 14:33 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RenameAccountCommand::execute() A
last analyzed 2020-07-08 14:33 UTC