ForwardingRule - Code Metrics - Inspection of "Merge branch 'jwh315-feature-lb'" - toin0u/DigitalOceanV2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c894bb...4464ce )

by Yassir

created 2017-05-27 22:10 UTC

ForwardingRule A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	1
dl	0
loc	59
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setStandardHttpRules()	0	9	1
A	setStandardHttpsRules()	0	10	1

<?php

/*
 * This file is part of the DigitalOceanV2 library.
 *
 * (c) Antoine Corcy <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace DigitalOceanV2\Entity;

/**
 * @author Jacob Holmes <[email protected]>
 */
class ForwardingRule extends AbstractEntity
{
    /**
     * @var string
     */
    public $entryProtocol;

    /**
     * @var int
     */
    public $entryPort;

    /**
     * @var string
     */
    public $targetProtocol;

    /**
     * @var int
     */
    public $targetPort;

    /**
     * @var string
     */
    public $certificateId;

    /**
     * @var string
     */
    public $tlsPassthrough;

    /**
     * @return $this
     */
    public function setStandardHttpRules()
    {
        $this->entryProtocol = 'http';
        $this->targetProtocol = 'http';
        $this->entryPort = 80;
        $this->targetPort = 80;

        return $this;
    }

    /**
     * @return $this
     */
    public function setStandardHttpsRules()
    {
        $this->entryProtocol = 'https';
        $this->targetProtocol = 'https';
        $this->entryPort = 443;
        $this->targetPort = 443;
        $this->tlsPassthrough = true;
$answer = 42;

$correct = false;

$correct = (bool) $answer;

        return $this;
    }
}


1			<?php
2
3			/*
4			* This file is part of the DigitalOceanV2 library.
5			*
6			* (c) Antoine Corcy <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace DigitalOceanV2\Entity;
13
14			/**
15			* @author Jacob Holmes <[email protected]>
16			*/
17			class ForwardingRule extends AbstractEntity
18			{
19			/**
20			* @var string
21			*/
22			public $entryProtocol;
23
24			/**
25			* @var int
26			*/
27			public $entryPort;
28
29			/**
30			* @var string
31			*/
32			public $targetProtocol;
33
34			/**
35			* @var int
36			*/
37			public $targetPort;
38
39			/**
40			* @var string
41			*/
42			public $certificateId;
43
44			/**
45			* @var string
46			*/
47			public $tlsPassthrough;
48
49			/**
50			* @return $this
51			*/
52			public function setStandardHttpRules()
53			{
54			$this->entryProtocol = 'http';
55			$this->targetProtocol = 'http';
56			$this->entryPort = 80;
57			$this->targetPort = 80;
58
59			return $this;
60			}
61
62			/**
63			* @return $this
64			*/
65			public function setStandardHttpsRules()
66			{
67			$this->entryProtocol = 'https';
68			$this->targetProtocol = 'https';
69			$this->entryPort = 443;
70			$this->targetPort = 443;
71			$this->tlsPassthrough = true;
			0 ignored issues – show Documentation Bug introduced 2017-05-05 22:33 UTC by Report Bug Copy Issue Report The property `$tlsPassthrough` was declared of type `string`, but `true` is of type `boolean`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
72
73			return $this;
74			}
75			}
76

toin0u / DigitalOceanV2

Push — master ( c894bb...4464ce )

ForwardingRule A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like