Tobscure\JsonApi\Relationship::toArray()

Complexity

Conditions	4
Paths	8

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4.5923

Importance

Changes	1
Bugs	1	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	Relationship::jsonSerialize()	0	15	3

<?php

/*
 * This file is part of JSON-API.
 *
 * (c) Toby Zerner <toby.zerner@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tobscure\JsonApi;

use JsonSerializable;

class Relationship implements JsonSerializable
{
    use LinksTrait, SelfLinkTrait, RelatedLinkTrait, PaginationLinksTrait, MetaTrait;

    private $data;

    private function __construct()
    {
    }

    public static function fromMeta($meta)
    {
        $r = new self;
        $r->replaceMeta($meta);

The method replaceMeta() does not seem to exist on object<Tobscure\JsonApi\Relationship>.

        return $r;
    }

    public static function fromSelfLink($link)
    {
        $r = new self;
        $r->setSelfLink($link);

        return $r;
    }

    public static function fromRelatedLink($link)
    {
        $r = new self;
        $r->setRelatedLink($link);

        return $r;
    }

    public static function fromData($data)
    {
        $r = new self;
        $r->data = $data;

        return $r;
    }

    public function getData()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->data;
    }

    public function setData($data)
    {
        $this->data = $data;
    }

    public function jsonSerialize()
    {
        $relationship = [];

        if ($this->data) {
            $relationship['data'] = is_array($this->data)
                ? array_map([$this, 'buildIdentifier'], $this->data)
                : $this->buildIdentifier($this->data);
        }

        return array_filter($relationship + [
            'meta' => $this->meta,
            'links' => $this->links
        ]);
    }

    private function buildIdentifier(ResourceInterface $resource)
    {
        $id = new ResourceIdentifier($resource->getType(), $resource->getId());
        $id->setMeta($resource->getMeta());

It seems like $resource->getMeta() targeting Tobscure\JsonApi\ResourceInterface::getMeta() can also be of type null; however, Tobscure\JsonApi\MetaTrait::setMeta() does only seem to accept array, maybe add an additional type check?

        return $id;
    }
}