Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | class ResourceObject extends ResourceIdentifier |
||
18 | { |
||
19 | use LinksTrait, SelfLinkTrait; |
||
20 | |||
21 | private $attributes = []; |
||
22 | private $relationships = []; |
||
23 | |||
24 | 6 | View Code Duplication | public function setAttribute($name, $value) |
36 | |||
37 | 3 | View Code Duplication | public function setRelationship($name, Relationship $value) |
38 | { |
||
39 | 3 | if (! $this->validateField($name)) { |
|
40 | throw new InvalidArgumentException('Invalid relationship name'); |
||
41 | } |
||
42 | |||
43 | 3 | if (isset($this->attributes[$name])) { |
|
44 | throw new LogicException("Field $name already exists in attributes"); |
||
45 | } |
||
46 | |||
47 | 3 | $this->relationships[$name] = $value; |
|
48 | 3 | } |
|
49 | |||
50 | 15 | public function jsonSerialize() |
|
60 | |||
61 | 9 | private function validateField($name) |
|
65 | } |
||
66 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.