Issues in AudioValidator.php (master) - Issues in master - toaotc/Validator - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Constraints/AudioValidator.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Toa\Component\Validator\Constraints;

use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\Constraints\FileValidator;
use Symfony\Component\Validator\Exception\ConstraintDefinitionException;
use Toa\Component\Validator\Exception\ProviderException;
use Toa\Component\Validator\Provider\AudioProviderInterface;

/**
 * Class AudioValidator
 *
 * @author Enrico Thies <[email protected]>
 */
class AudioValidator extends FileValidator
{
    /** @var ProviderInterface */
    protected $provider;

    /**
     * @param AudioProviderInterface $provider
     */
    public function __construct(AudioProviderInterface $provider)
    {
        $this->provider = $provider;

    }

    /**
     * {@inheritDoc}
     */
    public function validate($value, Constraint $constraint)
    {
        $violations = count($this->context->getViolations());

        parent::validate($value, $constraint);

        $failed = count($this->context->getViolations()) !== $violations;

        if ($failed || null === $value || '' === $value) {
            return;
        }

        $path = $value instanceof \SplFileInfo ? $value->getPathname() : (string) $value;

        try {
            $duration = $this->provider->getDuration($path);
        } catch (ProviderException $e) {
            $this->context->addViolation($constraint->formatNotDetectedMessage);

            return;
        }

        if ($this->validateMaxDuration($duration, $constraint)) {
            return;
        }

        if ($this->validateMinDuration($duration, $constraint)) {
            return;
        }
    }

    /**
     * @param float      $duration
     * @param Constraint $constraint
     *
     * @throws ConstraintDefinitionException
     * @return boolean
     */
    protected function validateMaxDuration($duration, Constraint $constraint)
    {
        if ($constraint->maxDuration) {
            if (!ctype_digit((string) $constraint->maxDuration)) {
                throw new ConstraintDefinitionException(
                    sprintf(
                        '"%s" is not a valid maximum duration',
                        $constraint->maxDuration
                    )
                );
            }

            if ($duration > $constraint->maxDuration) {
                $this->context->addViolation(
                    $constraint->maxDurationMessage,
                    array(
                        '{{ duration }}' => $duration,
                        '{{ max_duration }}' => $constraint->maxDuration
                    )
                );

                return true;
            }
        }
    }

    /**
     * @param float      $duration
     * @param Constraint $constraint
     *
     * @throws ConstraintDefinitionException
     * @return boolean
     */
    protected function validateMinDuration($duration, Constraint $constraint)
    {
        if ($constraint->minDuration) {
            if (!ctype_digit((string) $constraint->minDuration)) {
                throw new ConstraintDefinitionException(
                    sprintf(
                        '"%s" is not a valid minimum duration',
                        $constraint->minDuration
                    )
                );
            }

            if ($duration < $constraint->minDuration) {
                $this->context->addViolation(
                    $constraint->minDurationMessage,
                    array(
                        '{{ duration }}' => $duration,
                        '{{ min_duration }}' => $constraint->minDuration
                    )
                );

                return true;
            }
        }
    }
}


1			<?php
2
3			namespace Toa\Component\Validator\Constraints;
4
5			use Symfony\Component\Validator\Constraint;
6			use Symfony\Component\Validator\Constraints\FileValidator;
7			use Symfony\Component\Validator\Exception\ConstraintDefinitionException;
8			use Toa\Component\Validator\Exception\ProviderException;
9			use Toa\Component\Validator\Provider\AudioProviderInterface;
10
11			/**
12			* Class AudioValidator
13			*
14			* @author Enrico Thies <[email protected]>
15			*/
16			class AudioValidator extends FileValidator
17			{
18			/** @var ProviderInterface */
19			protected $provider;
20
21			/**
22			* @param AudioProviderInterface $provider
23			*/
24			public function __construct(AudioProviderInterface $provider)
25			{
26			$this->provider = $provider;
			0 ignored issues – show Documentation Bug introduced 2020-02-11 07:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$provider` of type `object<Toa\Component\Val...AudioProviderInterface>` is incompatible with the declared type `object<Toa\Component\Val...ints\ProviderInterface>` of property `$provider`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
27			}
28
29			/**
30			* {@inheritDoc}
31			*/
32			public function validate($value, Constraint $constraint)
33			{
34			$violations = count($this->context->getViolations());
35
36			parent::validate($value, $constraint);
37
38			$failed = count($this->context->getViolations()) !== $violations;
39
40			if ($failed \|\| null === $value \|\| '' === $value) {
41			return;
42			}
43
44			$path = $value instanceof \SplFileInfo ? $value->getPathname() : (string) $value;
45
46			try {
47			$duration = $this->provider->getDuration($path);
48			} catch (ProviderException $e) {
49			$this->context->addViolation($constraint->formatNotDetectedMessage);
50
51			return;
52			}
53
54			if ($this->validateMaxDuration($duration, $constraint)) {
55			return;
56			}
57
58			if ($this->validateMinDuration($duration, $constraint)) {
59			return;
60			}
61			}
62
63			/**
64			* @param float $duration
65			* @param Constraint $constraint
66			*
67			* @throws ConstraintDefinitionException
68			* @return boolean
69			*/
70			protected function validateMaxDuration($duration, Constraint $constraint)
71			{
72			if ($constraint->maxDuration) {
73			if (!ctype_digit((string) $constraint->maxDuration)) {
74			throw new ConstraintDefinitionException(
75			sprintf(
76			'"%s" is not a valid maximum duration',
77			$constraint->maxDuration
78			)
79			);
80			}
81
82			if ($duration > $constraint->maxDuration) {
83			$this->context->addViolation(
84			$constraint->maxDurationMessage,
85			array(
86			'{{ duration }}' => $duration,
87			'{{ max_duration }}' => $constraint->maxDuration
88			)
89			);
90
91			return true;
92			}
93			}
94			}
95
96			/**
97			* @param float $duration
98			* @param Constraint $constraint
99			*
100			* @throws ConstraintDefinitionException
101			* @return boolean
102			*/
103			protected function validateMinDuration($duration, Constraint $constraint)
104			{
105			if ($constraint->minDuration) {
106			if (!ctype_digit((string) $constraint->minDuration)) {
107			throw new ConstraintDefinitionException(
108			sprintf(
109			'"%s" is not a valid minimum duration',
110			$constraint->minDuration
111			)
112			);
113			}
114
115			if ($duration < $constraint->minDuration) {
116			$this->context->addViolation(
117			$constraint->minDurationMessage,
118			array(
119			'{{ duration }}' => $duration,
120			'{{ min_duration }}' => $constraint->minDuration
121			)
122			);
123
124			return true;
125			}
126			}
127			}
128			}
129

toaotc / Validator

Issues (4)

Security Analysis no request data

Constraints/AudioValidator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like