tnhfw / tnh-fw

core/classes/Module.php

Indentation +255 added lines, -255 removed lines

@@ -1,6 +1,6 @@ 
 <?php
-	defined('ROOT_PATH') || exit('Access denied');
-	/**
+    defined('ROOT_PATH') || exit('Access denied');
+    /**
      * TNH Framework
      *
      * A simple PHP framework using HMVC architecture
@@ -22,283 +22,283 @@ 
      * You should have received a copy of the GNU General Public License
      * along with this program; if not, write to the Free Software
      * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
-    */
+     */
    
-	class Module{
+    class Module{
 		
-		/**
-		 * list of loaded module
-		 * @var array
-		 */
-		private static $list = array();
+        /**
+         * list of loaded module
+         * @var array
+         */
+        private static $list = array();
 
-		/**
-		 * logger instance
-		 * @var object
-		 */
-		private static $logger;
+        /**
+         * logger instance
+         * @var object
+         */
+        private static $logger;
 
-		/**
-		 * Initialise the module list by scanning the directory MODULE_PATH
-		 */
-		public function init(){
-			$logger = self::getLogger();
-			$logger->debug('Check if the application contains the modules ...');
-			$moduleDir = opendir(MODULE_PATH);
-			if (is_resource($moduleDir)){
-				while(($module = readdir($moduleDir)) !== false){
-					if (preg_match('/^([a-z0-9-_]+)$/i', $module) && is_dir(MODULE_PATH . $module)){
-						self::$list[] = $module;
-					}
-					else{
-						$logger->info('Skipping [' .$module. '], may be this is not a directory or does not exists or is invalid name');
-					}
-				}
-				closedir($moduleDir);
-			}
-			ksort(self::$list);
+        /**
+         * Initialise the module list by scanning the directory MODULE_PATH
+         */
+        public function init(){
+            $logger = self::getLogger();
+            $logger->debug('Check if the application contains the modules ...');
+            $moduleDir = opendir(MODULE_PATH);
+            if (is_resource($moduleDir)){
+                while(($module = readdir($moduleDir)) !== false){
+                    if (preg_match('/^([a-z0-9-_]+)$/i', $module) && is_dir(MODULE_PATH . $module)){
+                        self::$list[] = $module;
+                    }
+                    else{
+                        $logger->info('Skipping [' .$module. '], may be this is not a directory or does not exists or is invalid name');
+                    }
+                }
+                closedir($moduleDir);
+            }
+            ksort(self::$list);
 			
-			if (! empty(self::$list)){
-				$logger->info('The application contains the module below [' . implode(', ', self::getModuleList()) . ']');
-			}
-		}
+            if (! empty(self::$list)){
+                $logger->info('The application contains the module below [' . implode(', ', self::getModuleList()) . ']');
+            }
+        }
 
-		/**
-		 * The signleton of the logger
-		 * @return Object the Log instance
-		 */
-		public static function getLogger(){
-			if (self::$logger == null){
-				$logger = array();
-				$logger[0] =& class_loader('Log', 'classes');
-				$logger[0]->setLogger('Library::Module');
-				self::$logger = $logger[0];
-			}
-			return self::$logger;			
-		}
+        /**
+         * The signleton of the logger
+         * @return Object the Log instance
+         */
+        public static function getLogger(){
+            if (self::$logger == null){
+                $logger = array();
+                $logger[0] =& class_loader('Log', 'classes');
+                $logger[0]->setLogger('Library::Module');
+                self::$logger = $logger[0];
+            }
+            return self::$logger;			
+        }
 
-		/**
-		 * Set the log instance for future use
-		 * @param object $logger the log object
-		 * @return object the log instance
-		 */
-		public static function setLogger($logger){
-			self::$logger = $logger;
-			return self::$logger;
-		}
+        /**
+         * Set the log instance for future use
+         * @param object $logger the log object
+         * @return object the log instance
+         */
+        public static function setLogger($logger){
+            self::$logger = $logger;
+            return self::$logger;
+        }
 
 		
 
-		/**
-		 * Add new module in the list
-		 * @param string $name the name of the module
-		 *
-		 * @return object the current instance
-		 */
-		public function add($name){
-			self::$list[] = $name;
-			return $this;
-		}
+        /**
+         * Add new module in the list
+         * @param string $name the name of the module
+         *
+         * @return object the current instance
+         */
+        public function add($name){
+            self::$list[] = $name;
+            return $this;
+        }
 		
-		/**
-		 * Get the list of the custom autoload configuration from module if exists
-		 * @return array|boolean the autoload configurations list or false if no module contains the autoload configuration values
-		 */
-		public static function getModulesAutoloadConfig(){
-			$logger = self::getLogger();
-			if (empty(self::$list)){
-				$logger->info('No module was loaded skipping.');
-				return false;
-			}
-			$autoloads = array();
-			$autoloads['libraries'] = array();
-			$autoloads['config']    = array();
-			$autoloads['models']    = array();
-			$autoloads['functions'] = array();
-			$autoloads['languages'] = array();
+        /**
+         * Get the list of the custom autoload configuration from module if exists
+         * @return array|boolean the autoload configurations list or false if no module contains the autoload configuration values
+         */
+        public static function getModulesAutoloadConfig(){
+            $logger = self::getLogger();
+            if (empty(self::$list)){
+                $logger->info('No module was loaded skipping.');
+                return false;
+            }
+            $autoloads = array();
+            $autoloads['libraries'] = array();
+            $autoloads['config']    = array();
+            $autoloads['models']    = array();
+            $autoloads['functions'] = array();
+            $autoloads['languages'] = array();
 			
-			foreach (self::$list as $module) {
-				$file = MODULE_PATH . $module . DS . 'config' . DS . 'autoload.php';
-				if (file_exists($file)){
-					$autoload = array();
-					require_once $file;
-					if (! empty($autoload) && is_array($autoload)){
-						$autoloads = array_merge_recursive($autoloads, $autoload);
-						unset($autoload);
-					}
-				}
-			}
-			return $autoloads;
-		}
+            foreach (self::$list as $module) {
+                $file = MODULE_PATH . $module . DS . 'config' . DS . 'autoload.php';
+                if (file_exists($file)){
+                    $autoload = array();
+                    require_once $file;
+                    if (! empty($autoload) && is_array($autoload)){
+                        $autoloads = array_merge_recursive($autoloads, $autoload);
+                        unset($autoload);
+                    }
+                }
+            }
+            return $autoloads;
+        }
 
-		/**
-		 * Get the list of the custom routes configuration from module if exists
-		 * @return array|boolean the routes list or false if no module contains the routes configuration
-		 */
-		public static function getModulesRoutesConfig(){
-			$logger = self::getLogger();
-			if (empty(self::$list)){
-				$logger->info('No module was loaded skipping.');
-				return false;
-			}
-			$routes = array();
-			foreach (self::$list as $module) {
-				$file = MODULE_PATH . $module . DS . 'config' . DS . 'routes.php';
-				if (file_exists($file)){
-					$route = array();
-					require_once $file;
-					if (! empty($route) && is_array($route)){
-						$routes = array_merge($routes, $route);
-						unset($route);
-					}
-				}
-			}
-			return $routes;
-		}
+        /**
+         * Get the list of the custom routes configuration from module if exists
+         * @return array|boolean the routes list or false if no module contains the routes configuration
+         */
+        public static function getModulesRoutesConfig(){
+            $logger = self::getLogger();
+            if (empty(self::$list)){
+                $logger->info('No module was loaded skipping.');
+                return false;
+            }
+            $routes = array();
+            foreach (self::$list as $module) {
+                $file = MODULE_PATH . $module . DS . 'config' . DS . 'routes.php';
+                if (file_exists($file)){
+                    $route = array();
+                    require_once $file;
+                    if (! empty($route) && is_array($route)){
+                        $routes = array_merge($routes, $route);
+                        unset($route);
+                    }
+                }
+            }
+            return $routes;
+        }
 
 
-		/**
-		 * Check if in module list can have this controller
-		 * @see Module::findClassInModuleFullFilePath
-		 * @return boolean|string  false or null if no module have this controller, path the full path of the controller
-		 */
-		public static function findControllerFullPath($class, $module = null){
-			return self::findClassInModuleFullFilePath($class, $module, 'controllers');
-		}
+        /**
+         * Check if in module list can have this controller
+         * @see Module::findClassInModuleFullFilePath
+         * @return boolean|string  false or null if no module have this controller, path the full path of the controller
+         */
+        public static function findControllerFullPath($class, $module = null){
+            return self::findClassInModuleFullFilePath($class, $module, 'controllers');
+        }
 
-		/**
-		 * Check if in module list can have this model
-		 * @see Module::findClassInModuleFullFilePath
-		 * @return boolean|string  false or null if no module have this model, return the full path of this model
-		 */
-		public static function findModelFullPath($class, $module = null){
-			return self::findClassInModuleFullFilePath($class, $module, 'models');
-		}
+        /**
+         * Check if in module list can have this model
+         * @see Module::findClassInModuleFullFilePath
+         * @return boolean|string  false or null if no module have this model, return the full path of this model
+         */
+        public static function findModelFullPath($class, $module = null){
+            return self::findClassInModuleFullFilePath($class, $module, 'models');
+        }
 
-		/**
-		 * Check if in module list can have this library
-		 * @see Module::findClassInModuleFullFilePath
-		 * @return boolean|string  false or null if no module have this library,  return the full path of this library
-		 */
-		public static function findLibraryFullPath($class, $module = null){
-			return self::findClassInModuleFullFilePath($class, $module, 'libraries');
-		}
+        /**
+         * Check if in module list can have this library
+         * @see Module::findClassInModuleFullFilePath
+         * @return boolean|string  false or null if no module have this library,  return the full path of this library
+         */
+        public static function findLibraryFullPath($class, $module = null){
+            return self::findClassInModuleFullFilePath($class, $module, 'libraries');
+        }
 
 		
-		/**
-		 * Check if in module list can have this config
-		 * @see  Module::findNonClassInModuleFullFilePath
-		 * @return boolean|string  false or null if no module have this configuration,  return the full path of this configuration
-		 */
-		public static function findConfigFullPath($configuration, $module = null){
-			return self::findNonClassInModuleFullFilePath($configuration, $module, 'config');
-		}
+        /**
+         * Check if in module list can have this config
+         * @see  Module::findNonClassInModuleFullFilePath
+         * @return boolean|string  false or null if no module have this configuration,  return the full path of this configuration
+         */
+        public static function findConfigFullPath($configuration, $module = null){
+            return self::findNonClassInModuleFullFilePath($configuration, $module, 'config');
+        }
 
-		/**
-		 * Check if in module list can have this helper
-		 * @see  Module::findNonClassInModuleFullFilePath
-		 * @return boolean|string  false or null if no module have this helper,  return the full path of this helper
-		 */
-		public static function findFunctionFullPath($helper, $module = null){
-			return self::findNonClassInModuleFullFilePath($helper, $module, 'functions');
-		}
+        /**
+         * Check if in module list can have this helper
+         * @see  Module::findNonClassInModuleFullFilePath
+         * @return boolean|string  false or null if no module have this helper,  return the full path of this helper
+         */
+        public static function findFunctionFullPath($helper, $module = null){
+            return self::findNonClassInModuleFullFilePath($helper, $module, 'functions');
+        }
 
-		/**
-		 * Check if in module list can have this view
-		 * @see  Module::findNonClassInModuleFullFilePath
-		 * @return boolean|string  false or null if no module have this view, path the full path of the view
-		 */
-		public static function findViewFullPath($view, $module = null){
-			return self::findNonClassInModuleFullFilePath($view, $module, 'views');
-		}
+        /**
+         * Check if in module list can have this view
+         * @see  Module::findNonClassInModuleFullFilePath
+         * @return boolean|string  false or null if no module have this view, path the full path of the view
+         */
+        public static function findViewFullPath($view, $module = null){
+            return self::findNonClassInModuleFullFilePath($view, $module, 'views');
+        }
 
-		/**
-		 * Check if in module list can have this language
-		 * @see  Module::findNonClassInModuleFullFilePath
-		 * @return boolean|string  false or null if no module have this language,  return the full path of this language
-		 */
-		public static function findLanguageFullPath($language, $appLang, $module = null){
-			return self::findNonClassInModuleFullFilePath($language, $module, 'lang', $appLang);
-		}
+        /**
+         * Check if in module list can have this language
+         * @see  Module::findNonClassInModuleFullFilePath
+         * @return boolean|string  false or null if no module have this language,  return the full path of this language
+         */
+        public static function findLanguageFullPath($language, $appLang, $module = null){
+            return self::findNonClassInModuleFullFilePath($language, $module, 'lang', $appLang);
+        }
 
-		/**
-		 * Get the list of module loaded
-		 * @return array the module list
-		 */
-		public static function getModuleList(){
-			return self::$list;
-		}
+        /**
+         * Get the list of module loaded
+         * @return array the module list
+         */
+        public static function getModuleList(){
+            return self::$list;
+        }
 
-		/**
-		 * Check if the application has an module
-		 * @return boolean
-		 */
-		public static function hasModule(){
-			return !empty(self::$list);
-		}
+        /**
+         * Check if the application has an module
+         * @return boolean
+         */
+        public static function hasModule(){
+            return !empty(self::$list);
+        }
 
-		/**
-		 * Check if in module list can have the model, controller, library
-		 * @param  string $class the class name of library, model, controller
-		 * @param string $module the module name
-		 * @param string $type the name of the type "controllers", "libraries", "models"
-		 * @return boolean|string  false or null if no module 
-		 * have this class, return the full path of the class
-		 */
-		protected static function findClassInModuleFullFilePath($class, $module, $type){
-			$logger = self::getLogger();
-		    $class = str_ireplace('.php', '', $class);
-		    $class = ucfirst($class);
-		    $classFile = $class.'.php';
-		    $logger->debug('Checking the class [' . $class . '] in module [' . $module . '] for [' . $type . '] ...');
-		    $filePath = MODULE_PATH . $module . DS . $type . DS . $classFile;
-		    if (file_exists($filePath)){
-		        $logger->info('Found class [' . $class . '] in module [' . $module . '] for [' . $type . '] the file path is [' .$filePath. ']');
-		        return $filePath;
-		    }
-		    $logger->info('Class [' . $class . '] does not exist in the module [' .$module. '] for [' . $type . ']');
-		    return false;
-		}
+        /**
+         * Check if in module list can have the model, controller, library
+         * @param  string $class the class name of library, model, controller
+         * @param string $module the module name
+         * @param string $type the name of the type "controllers", "libraries", "models"
+         * @return boolean|string  false or null if no module 
+         * have this class, return the full path of the class
+         */
+        protected static function findClassInModuleFullFilePath($class, $module, $type){
+            $logger = self::getLogger();
+            $class = str_ireplace('.php', '', $class);
+            $class = ucfirst($class);
+            $classFile = $class.'.php';
+            $logger->debug('Checking the class [' . $class . '] in module [' . $module . '] for [' . $type . '] ...');
+            $filePath = MODULE_PATH . $module . DS . $type . DS . $classFile;
+            if (file_exists($filePath)){
+                $logger->info('Found class [' . $class . '] in module [' . $module . '] for [' . $type . '] the file path is [' .$filePath. ']');
+                return $filePath;
+            }
+            $logger->info('Class [' . $class . '] does not exist in the module [' .$module. '] for [' . $type . ']');
+            return false;
+        }
 
-		/**
-		 * Check if in module list can have the config, view, helper, language
-		 * @param string $name the name of config, view, helper, language
-		 * @param string $module the module name
-		 * @param string $type the name of the type "config", "functions", "views", "lang"
-		 * @param string|null $appLang the application language. This is use only when $type = "lang"
-		 * @return boolean|string  false or null if no module 
-		 * have this resource, return the full path of the resource
-		 */
-		protected static function findNonClassInModuleFullFilePath($name, $module, $type, $appLang = null){
-		    $logger = self::getLogger();
-		    $name = str_ireplace('.php', '', $name);
-		    $file = $name.'.php';
-		    $filePath = MODULE_PATH . $module . DS . $type . DS . $file;
-		    switch($type){
-		        case 'functions':
-		            $name = str_ireplace('function_', '', $name);
-		            $file = 'function_'.$name.'.php';
-		            $filePath = MODULE_PATH . $module . DS . $type . DS . $file;
-		        break;
-		        case 'views':
-		            $name = trim($name, '/\\');
-		            $name = str_ireplace('/', DS, $name);
-		            $file = $name . '.php';
-		            $filePath = MODULE_PATH . $module . DS . $type . DS . $file;
-		        break;
-		        case 'lang':
-		            $name = str_ireplace('lang_', '', $name);
-		            $file = 'lang_'.$name.'.php';
-		            $filePath = MODULE_PATH . $module . DS . $type . DS . $appLang . DS . $file;
-		        break;
-		    }
-		    $logger->debug('Checking resource [' . $name . '] in module [' .$module. '] for [' . $type . '] ...');
-		    if (file_exists($filePath)){
-		        $logger->info('Found resource [' . $name . '] in module [' .$module. '] for [' . $type . '] the file path is [' .$filePath. ']');
-		        return $filePath;
-		    }
-		    $logger->info('Resource [' . $name . '] does not exist in the module [' .$module. '] for [' . $type . ']');
-		    return false;
-		}
+        /**
+         * Check if in module list can have the config, view, helper, language
+         * @param string $name the name of config, view, helper, language
+         * @param string $module the module name
+         * @param string $type the name of the type "config", "functions", "views", "lang"
+         * @param string|null $appLang the application language. This is use only when $type = "lang"
+         * @return boolean|string  false or null if no module 
+         * have this resource, return the full path of the resource
+         */
+        protected static function findNonClassInModuleFullFilePath($name, $module, $type, $appLang = null){
+            $logger = self::getLogger();
+            $name = str_ireplace('.php', '', $name);
+            $file = $name.'.php';
+            $filePath = MODULE_PATH . $module . DS . $type . DS . $file;
+            switch($type){
+                case 'functions':
+                    $name = str_ireplace('function_', '', $name);
+                    $file = 'function_'.$name.'.php';
+                    $filePath = MODULE_PATH . $module . DS . $type . DS . $file;
+                break;
+                case 'views':
+                    $name = trim($name, '/\\');
+                    $name = str_ireplace('/', DS, $name);
+                    $file = $name . '.php';
+                    $filePath = MODULE_PATH . $module . DS . $type . DS . $file;
+                break;
+                case 'lang':
+                    $name = str_ireplace('lang_', '', $name);
+                    $file = 'lang_'.$name.'.php';
+                    $filePath = MODULE_PATH . $module . DS . $type . DS . $appLang . DS . $file;
+                break;
+            }
+            $logger->debug('Checking resource [' . $name . '] in module [' .$module. '] for [' . $type . '] ...');
+            if (file_exists($filePath)){
+                $logger->info('Found resource [' . $name . '] in module [' .$module. '] for [' . $type . '] the file path is [' .$filePath. ']');
+                return $filePath;
+            }
+            $logger->info('Resource [' . $name . '] does not exist in the module [' .$module. '] for [' . $type . ']');
+            return false;
+        }
 
-	}
+    }

Spacing +44 added lines, -44 removed lines

@@ -24,7 +24,7 @@ 
      * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
     */
    
-	class Module{
+	class Module {
 		
 		/**
 		 * list of loaded module
@@ -41,24 +41,24 @@ 
 		/**
 		 * Initialise the module list by scanning the directory MODULE_PATH
 		 */
-		public function init(){
+		public function init() {
 			$logger = self::getLogger();
 			$logger->debug('Check if the application contains the modules ...');
 			$moduleDir = opendir(MODULE_PATH);
-			if (is_resource($moduleDir)){
-				while(($module = readdir($moduleDir)) !== false){
-					if (preg_match('/^([a-z0-9-_]+)$/i', $module) && is_dir(MODULE_PATH . $module)){
+			if (is_resource($moduleDir)) {
+				while (($module = readdir($moduleDir)) !== false) {
+					if (preg_match('/^([a-z0-9-_]+)$/i', $module) && is_dir(MODULE_PATH . $module)) {
 						self::$list[] = $module;
 					}
-					else{
-						$logger->info('Skipping [' .$module. '], may be this is not a directory or does not exists or is invalid name');
+					else {
+						$logger->info('Skipping [' . $module . '], may be this is not a directory or does not exists or is invalid name');
 					}
 				}
 				closedir($moduleDir);
 			}
 			ksort(self::$list);
 			
-			if (! empty(self::$list)){
+			if (!empty(self::$list)) {
 				$logger->info('The application contains the module below [' . implode(', ', self::getModuleList()) . ']');
 			}
 		}
@@ -67,10 +67,10 @@ 
 		 * The signleton of the logger
 		 * @return Object the Log instance
 		 */
-		public static function getLogger(){
-			if (self::$logger == null){
+		public static function getLogger() {
+			if (self::$logger == null) {
 				$logger = array();
-				$logger[0] =& class_loader('Log', 'classes');
+				$logger[0] = & class_loader('Log', 'classes');
 				$logger[0]->setLogger('Library::Module');
 				self::$logger = $logger[0];
 			}
@@ -82,7 +82,7 @@ 
 		 * @param object $logger the log object
 		 * @return object the log instance
 		 */
-		public static function setLogger($logger){
+		public static function setLogger($logger) {
 			self::$logger = $logger;
 			return self::$logger;
 		}
@@ -95,7 +95,7 @@ 
 		 *
 		 * @return object the current instance
 		 */
-		public function add($name){
+		public function add($name) {
 			self::$list[] = $name;
 			return $this;
 		}
@@ -104,9 +104,9 @@ 
 		 * Get the list of the custom autoload configuration from module if exists
 		 * @return array|boolean the autoload configurations list or false if no module contains the autoload configuration values
 		 */
-		public static function getModulesAutoloadConfig(){
+		public static function getModulesAutoloadConfig() {
 			$logger = self::getLogger();
-			if (empty(self::$list)){
+			if (empty(self::$list)) {
 				$logger->info('No module was loaded skipping.');
 				return false;
 			}
@@ -119,10 +119,10 @@ 
 			
 			foreach (self::$list as $module) {
 				$file = MODULE_PATH . $module . DS . 'config' . DS . 'autoload.php';
-				if (file_exists($file)){
+				if (file_exists($file)) {
 					$autoload = array();
 					require_once $file;
-					if (! empty($autoload) && is_array($autoload)){
+					if (!empty($autoload) && is_array($autoload)) {
 						$autoloads = array_merge_recursive($autoloads, $autoload);
 						unset($autoload);
 					}
@@ -135,19 +135,19 @@ 
 		 * Get the list of the custom routes configuration from module if exists
 		 * @return array|boolean the routes list or false if no module contains the routes configuration
 		 */
-		public static function getModulesRoutesConfig(){
+		public static function getModulesRoutesConfig() {
 			$logger = self::getLogger();
-			if (empty(self::$list)){
+			if (empty(self::$list)) {
 				$logger->info('No module was loaded skipping.');
 				return false;
 			}
 			$routes = array();
 			foreach (self::$list as $module) {
 				$file = MODULE_PATH . $module . DS . 'config' . DS . 'routes.php';
-				if (file_exists($file)){
+				if (file_exists($file)) {
 					$route = array();
 					require_once $file;
-					if (! empty($route) && is_array($route)){
+					if (!empty($route) && is_array($route)) {
 						$routes = array_merge($routes, $route);
 						unset($route);
 					}
@@ -162,7 +162,7 @@ 
 		 * @see Module::findClassInModuleFullFilePath
 		 * @return boolean|string  false or null if no module have this controller, path the full path of the controller
 		 */
-		public static function findControllerFullPath($class, $module = null){
+		public static function findControllerFullPath($class, $module = null) {
 			return self::findClassInModuleFullFilePath($class, $module, 'controllers');
 		}
 
@@ -171,7 +171,7 @@ 
 		 * @see Module::findClassInModuleFullFilePath
 		 * @return boolean|string  false or null if no module have this model, return the full path of this model
 		 */
-		public static function findModelFullPath($class, $module = null){
+		public static function findModelFullPath($class, $module = null) {
 			return self::findClassInModuleFullFilePath($class, $module, 'models');
 		}
 
@@ -180,7 +180,7 @@ 
 		 * @see Module::findClassInModuleFullFilePath
 		 * @return boolean|string  false or null if no module have this library,  return the full path of this library
 		 */
-		public static function findLibraryFullPath($class, $module = null){
+		public static function findLibraryFullPath($class, $module = null) {
 			return self::findClassInModuleFullFilePath($class, $module, 'libraries');
 		}
 
@@ -190,7 +190,7 @@ 
 		 * @see  Module::findNonClassInModuleFullFilePath
 		 * @return boolean|string  false or null if no module have this configuration,  return the full path of this configuration
 		 */
-		public static function findConfigFullPath($configuration, $module = null){
+		public static function findConfigFullPath($configuration, $module = null) {
 			return self::findNonClassInModuleFullFilePath($configuration, $module, 'config');
 		}
 
@@ -199,7 +199,7 @@ 
 		 * @see  Module::findNonClassInModuleFullFilePath
 		 * @return boolean|string  false or null if no module have this helper,  return the full path of this helper
 		 */
-		public static function findFunctionFullPath($helper, $module = null){
+		public static function findFunctionFullPath($helper, $module = null) {
 			return self::findNonClassInModuleFullFilePath($helper, $module, 'functions');
 		}
 
@@ -208,7 +208,7 @@ 
 		 * @see  Module::findNonClassInModuleFullFilePath
 		 * @return boolean|string  false or null if no module have this view, path the full path of the view
 		 */
-		public static function findViewFullPath($view, $module = null){
+		public static function findViewFullPath($view, $module = null) {
 			return self::findNonClassInModuleFullFilePath($view, $module, 'views');
 		}
 
@@ -217,7 +217,7 @@ 
 		 * @see  Module::findNonClassInModuleFullFilePath
 		 * @return boolean|string  false or null if no module have this language,  return the full path of this language
 		 */
-		public static function findLanguageFullPath($language, $appLang, $module = null){
+		public static function findLanguageFullPath($language, $appLang, $module = null) {
 			return self::findNonClassInModuleFullFilePath($language, $module, 'lang', $appLang);
 		}
 
@@ -225,7 +225,7 @@ 
 		 * Get the list of module loaded
 		 * @return array the module list
 		 */
-		public static function getModuleList(){
+		public static function getModuleList() {
 			return self::$list;
 		}
 
@@ -233,7 +233,7 @@ 
 		 * Check if the application has an module
 		 * @return boolean
 		 */
-		public static function hasModule(){
+		public static function hasModule() {
 			return !empty(self::$list);
 		}
 
@@ -245,18 +245,18 @@ 
 		 * @return boolean|string  false or null if no module 
 		 * have this class, return the full path of the class
 		 */
-		protected static function findClassInModuleFullFilePath($class, $module, $type){
+		protected static function findClassInModuleFullFilePath($class, $module, $type) {
 			$logger = self::getLogger();
 		    $class = str_ireplace('.php', '', $class);
 		    $class = ucfirst($class);
-		    $classFile = $class.'.php';
+		    $classFile = $class . '.php';
 		    $logger->debug('Checking the class [' . $class . '] in module [' . $module . '] for [' . $type . '] ...');
 		    $filePath = MODULE_PATH . $module . DS . $type . DS . $classFile;
-		    if (file_exists($filePath)){
-		        $logger->info('Found class [' . $class . '] in module [' . $module . '] for [' . $type . '] the file path is [' .$filePath. ']');
+		    if (file_exists($filePath)) {
+		        $logger->info('Found class [' . $class . '] in module [' . $module . '] for [' . $type . '] the file path is [' . $filePath . ']');
 		        return $filePath;
 		    }
-		    $logger->info('Class [' . $class . '] does not exist in the module [' .$module. '] for [' . $type . ']');
+		    $logger->info('Class [' . $class . '] does not exist in the module [' . $module . '] for [' . $type . ']');
 		    return false;
 		}
 
@@ -269,15 +269,15 @@ 
 		 * @return boolean|string  false or null if no module 
 		 * have this resource, return the full path of the resource
 		 */
-		protected static function findNonClassInModuleFullFilePath($name, $module, $type, $appLang = null){
+		protected static function findNonClassInModuleFullFilePath($name, $module, $type, $appLang = null) {
 		    $logger = self::getLogger();
 		    $name = str_ireplace('.php', '', $name);
-		    $file = $name.'.php';
+		    $file = $name . '.php';
 		    $filePath = MODULE_PATH . $module . DS . $type . DS . $file;
-		    switch($type){
+		    switch ($type) {
 		        case 'functions':
 		            $name = str_ireplace('function_', '', $name);
-		            $file = 'function_'.$name.'.php';
+		            $file = 'function_' . $name . '.php';
 		            $filePath = MODULE_PATH . $module . DS . $type . DS . $file;
 		        break;
 		        case 'views':
@@ -288,16 +288,16 @@ 
 		        break;
 		        case 'lang':
 		            $name = str_ireplace('lang_', '', $name);
-		            $file = 'lang_'.$name.'.php';
+		            $file = 'lang_' . $name . '.php';
 		            $filePath = MODULE_PATH . $module . DS . $type . DS . $appLang . DS . $file;
 		        break;
 		    }
-		    $logger->debug('Checking resource [' . $name . '] in module [' .$module. '] for [' . $type . '] ...');
-		    if (file_exists($filePath)){
-		        $logger->info('Found resource [' . $name . '] in module [' .$module. '] for [' . $type . '] the file path is [' .$filePath. ']');
+		    $logger->debug('Checking resource [' . $name . '] in module [' . $module . '] for [' . $type . '] ...');
+		    if (file_exists($filePath)) {
+		        $logger->info('Found resource [' . $name . '] in module [' . $module . '] for [' . $type . '] the file path is [' . $filePath . ']');
 		        return $filePath;
 		    }
-		    $logger->info('Resource [' . $name . '] does not exist in the module [' .$module. '] for [' . $type . ']');
+		    $logger->info('Resource [' . $name . '] does not exist in the module [' . $module . '] for [' . $type . ']');
 		    return false;
 		}
 

Braces +1 added lines, -2 removed lines

@@ -49,8 +49,7 @@
 				while(($module = readdir($moduleDir)) !== false){
 					if (preg_match('/^([a-z0-9-_]+)$/i', $module) && is_dir(MODULE_PATH . $module)){
 						self::$list[] = $module;
-					}
-					else{
+					} else{
 						$logger->info('Skipping [' .$module. '], may be this is not a directory or does not exists or is invalid name');
 					}
 				}

core/classes/DBSessionHandler.php

Indentation +352 added lines, -352 removed lines

@@ -1,81 +1,81 @@ 
 <?php 
-	defined('ROOT_PATH') || exit('Access denied');
-	/**
-	 * TNH Framework
-	 *
-	 * A simple PHP framework using HMVC architecture
-	 *
-	 * This content is released under the GNU GPL License (GPL)
-	 *
-	 * Copyright (C) 2017 Tony NGUEREZA
-	 *
-	 * This program is free software; you can redistribute it and/or
-	 * modify it under the terms of the GNU General Public License
-	 * as published by the Free Software Foundation; either version 3
-	 * of the License, or (at your option) any later version.
-	 *
-	 * This program is distributed in the hope that it will be useful,
-	 * but WITHOUT ANY WARRANTY; without even the implied warranty of
-	 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-	 * GNU General Public License for more details.
-	 *
-	 * You should have received a copy of the GNU General Public License
-	 * along with this program; if not, write to the Free Software
-	 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
-	*/
+    defined('ROOT_PATH') || exit('Access denied');
+    /**
+     * TNH Framework
+     *
+     * A simple PHP framework using HMVC architecture
+     *
+     * This content is released under the GNU GPL License (GPL)
+     *
+     * Copyright (C) 2017 Tony NGUEREZA
+     *
+     * This program is free software; you can redistribute it and/or
+     * modify it under the terms of the GNU General Public License
+     * as published by the Free Software Foundation; either version 3
+     * of the License, or (at your option) any later version.
+     *
+     * This program is distributed in the hope that it will be useful,
+     * but WITHOUT ANY WARRANTY; without even the implied warranty of
+     * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+     * GNU General Public License for more details.
+     *
+     * You should have received a copy of the GNU General Public License
+     * along with this program; if not, write to the Free Software
+     * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+     */
 	
-	/**
-	 * check if the interface "SessionHandlerInterface" exists (normally in PHP 5.4 this already exists)
-	 */
-	if ( !interface_exists('SessionHandlerInterface')){
-		show_error('"SessionHandlerInterface" interface does not exists or is disabled can not use it to handler database session.');
-	}
-
-	class DBSessionHandler implements SessionHandlerInterface{
+    /**
+     * check if the interface "SessionHandlerInterface" exists (normally in PHP 5.4 this already exists)
+     */
+    if ( !interface_exists('SessionHandlerInterface')){
+        show_error('"SessionHandlerInterface" interface does not exists or is disabled can not use it to handler database session.');
+    }
+
+    class DBSessionHandler implements SessionHandlerInterface{
 		
-		/**
-		 * The encryption method to use to encrypt session data in database
-		 * @const string
-		 */
-		const DB_SESSION_HASH_METHOD = 'AES-256-CBC';
+        /**
+         * The encryption method to use to encrypt session data in database
+         * @const string
+         */
+        const DB_SESSION_HASH_METHOD = 'AES-256-CBC';
 		
-		/**
-		 * Super global instance
-		 * @var object
-		 */
-		protected $OBJ = null;
-
-		/**
-		 * Session secret to use 
-		 * @var string
-		 */
-		private $sessionSecret = null;
-
-		/**
-		 * The initialisation vector to use for openssl
-		 * @var string
-		 */
-		private $iv = null;
-
-		/**
-		 * The model instance to use
-		 * @var object
-		 */
-		private $modelInstance = null;
-
-		/**
-		 * The columns of the table to use to store session data
-		 * @var array
-		 */
-		private $sessionTableColumns = array();
-
-		/**
-		 * The instance of the Log 
-		 * @var Log
-		 */
-		private $logger;
-
-		/**
+        /**
+         * Super global instance
+         * @var object
+         */
+        protected $OBJ = null;
+
+        /**
+         * Session secret to use 
+         * @var string
+         */
+        private $sessionSecret = null;
+
+        /**
+         * The initialisation vector to use for openssl
+         * @var string
+         */
+        private $iv = null;
+
+        /**
+         * The model instance to use
+         * @var object
+         */
+        private $modelInstance = null;
+
+        /**
+         * The columns of the table to use to store session data
+         * @var array
+         */
+        private $sessionTableColumns = array();
+
+        /**
+         * The instance of the Log 
+         * @var Log
+         */
+        private $logger;
+
+        /**
          * Instance of the Loader class
          * @var Loader
          */
@@ -85,227 +85,227 @@ 
          * Create new instance of Database session handler
          * @param object $modelInstance the model instance
          */
-		public function __construct(DBSessionHandlerModel $modelInstance = null){
-			//Set Log instance to use
-	        $this->setLoggerFromParamOrCreate(null);
+        public function __construct(DBSessionHandlerModel $modelInstance = null){
+            //Set Log instance to use
+            $this->setLoggerFromParamOrCreate(null);
 			
-	    	//Set Loader instance to use
-	        $this->setDependencyInstanceFromParamOrCreate('loader', null, 'Loader', 'classes');
+            //Set Loader instance to use
+            $this->setDependencyInstanceFromParamOrCreate('loader', null, 'Loader', 'classes');
 	       
-		    $this->OBJ = & get_instance();
+            $this->OBJ = & get_instance();
 		    
-			if (is_object($modelInstance)){
-				$this->setModelInstance($modelInstance);
-			}
-		}
-
-		/**
-		 * Set the session secret used to encrypt the data in database 
-		 * @param string $secret the base64 string secret
-		 */
-		public function setSessionSecret($secret){
-			$this->sessionSecret = $secret;
-			return $this;
-		}
-
-		/**
-		 * Return the session secret
-		 * @return string 
-		 */
-		public function getSessionSecret(){
-			return $this->sessionSecret;
-		}
-
-
-		/**
-		 * Set the initializer vector for openssl 
-		 * @param string $key the session secret used in base64 format
-		 */
-		public function setInitializerVector($key){
-			$ivLength = openssl_cipher_iv_length(self::DB_SESSION_HASH_METHOD);
-			$key = base64_decode($key);
-			$this->iv = substr(hash('sha256', $key), 0, $ivLength);
-			return $this;
-		}
-
-		/**
-		 * Return the initializer vector
-		 * @return string 
-		 */
-		public function getInitializerVector(){
-			return $this->iv;
-		}
-
-		/**
-		 * Open the database session handler, here nothing to do just return true
-		 * @param  string $savePath    the session save path
-		 * @param  string $sessionName the session name
-		 * @return boolean 
-		 */
-		public function open($savePath, $sessionName){
-			$this->logger->debug('Opening database session handler for [' . $sessionName . ']');
-			//try to check if session secret is set before
-			$secret = $this->getSessionSecret();
-			if (empty($secret)){
-				$secret = get_config('session_secret', null);
-				$this->setSessionSecret($secret);
-			}
-			$this->logger->info('Session secret: ' . $secret);
-
-			if (! is_object($this->modelInstance)){
-				$this->setModelInstanceFromConfig();
-			}
-			$this->setInitializerVector($secret);
-
-			//set session tables columns
-			$this->sessionTableColumns = $this->modelInstance->getSessionTableColumns();
-
-			if (empty($this->sessionTableColumns)){
-				show_error('The session handler is "database" but the table columns not set');
-			}
-			$this->logger->info('Database session, the model columns are listed below: ' . stringfy_vars($this->sessionTableColumns));
+            if (is_object($modelInstance)){
+                $this->setModelInstance($modelInstance);
+            }
+        }
+
+        /**
+         * Set the session secret used to encrypt the data in database 
+         * @param string $secret the base64 string secret
+         */
+        public function setSessionSecret($secret){
+            $this->sessionSecret = $secret;
+            return $this;
+        }
+
+        /**
+         * Return the session secret
+         * @return string 
+         */
+        public function getSessionSecret(){
+            return $this->sessionSecret;
+        }
+
+
+        /**
+         * Set the initializer vector for openssl 
+         * @param string $key the session secret used in base64 format
+         */
+        public function setInitializerVector($key){
+            $ivLength = openssl_cipher_iv_length(self::DB_SESSION_HASH_METHOD);
+            $key = base64_decode($key);
+            $this->iv = substr(hash('sha256', $key), 0, $ivLength);
+            return $this;
+        }
+
+        /**
+         * Return the initializer vector
+         * @return string 
+         */
+        public function getInitializerVector(){
+            return $this->iv;
+        }
+
+        /**
+         * Open the database session handler, here nothing to do just return true
+         * @param  string $savePath    the session save path
+         * @param  string $sessionName the session name
+         * @return boolean 
+         */
+        public function open($savePath, $sessionName){
+            $this->logger->debug('Opening database session handler for [' . $sessionName . ']');
+            //try to check if session secret is set before
+            $secret = $this->getSessionSecret();
+            if (empty($secret)){
+                $secret = get_config('session_secret', null);
+                $this->setSessionSecret($secret);
+            }
+            $this->logger->info('Session secret: ' . $secret);
+
+            if (! is_object($this->modelInstance)){
+                $this->setModelInstanceFromConfig();
+            }
+            $this->setInitializerVector($secret);
+
+            //set session tables columns
+            $this->sessionTableColumns = $this->modelInstance->getSessionTableColumns();
+
+            if (empty($this->sessionTableColumns)){
+                show_error('The session handler is "database" but the table columns not set');
+            }
+            $this->logger->info('Database session, the model columns are listed below: ' . stringfy_vars($this->sessionTableColumns));
 			
-			//delete the expired session
-			$timeActivity = get_config('session_inactivity_time', 100);
-			$this->gc($timeActivity);
+            //delete the expired session
+            $timeActivity = get_config('session_inactivity_time', 100);
+            $this->gc($timeActivity);
 			
-			return true;
-		}
-
-		/**
-		 * Close the session
-		 * @return boolean
-		 */
-		public function close(){
-			$this->logger->debug('Closing database session handler');
-			return true;
-		}
-
-		/**
-		 * Get the session value for the given session id
-		 * @param  string $sid the session id to use
-		 * @return string      the session data in serialiaze format
-		 */
-		public function read($sid){
-			$this->logger->debug('Reading database session data for SID: ' . $sid);
-			$instance = $this->getModelInstance();
-			$columns = $this->sessionTableColumns;
-			$this->loader->functions('user_agent'); 
-			$this->loader->library('Browser'); 
+            return true;
+        }
+
+        /**
+         * Close the session
+         * @return boolean
+         */
+        public function close(){
+            $this->logger->debug('Closing database session handler');
+            return true;
+        }
+
+        /**
+         * Get the session value for the given session id
+         * @param  string $sid the session id to use
+         * @return string      the session data in serialiaze format
+         */
+        public function read($sid){
+            $this->logger->debug('Reading database session data for SID: ' . $sid);
+            $instance = $this->getModelInstance();
+            $columns = $this->sessionTableColumns;
+            $this->loader->functions('user_agent'); 
+            $this->loader->library('Browser'); 
 			
-			$ip = get_ip();
-			$host = @gethostbyaddr($ip) or null;
-			$browser = $this->OBJ->browser->getPlatform().', '.$this->OBJ->browser->getBrowser().' '.$this->OBJ->browser->getVersion();
+            $ip = get_ip();
+            $host = @gethostbyaddr($ip) or null;
+            $browser = $this->OBJ->browser->getPlatform().', '.$this->OBJ->browser->getBrowser().' '.$this->OBJ->browser->getVersion();
 			
-			$data = $instance->get_by(array($columns['sid'] => $sid, $columns['shost'] => $host, $columns['sbrowser'] => $browser));
-			if ($data && isset($data->{$columns['sdata']})){
-				//checking inactivity 
-				$timeInactivity = time() - get_config('session_inactivity_time', 100);
-				if ($data->{$columns['stime']} < $timeInactivity){
-					$this->logger->info('Database session data for SID: ' . $sid . ' already expired, destroy it');
-					$this->destroy($sid);
-					return null;
-				}
-				return $this->decode($data->{$columns['sdata']});
-			}
-			$this->logger->info('Database session data for SID: ' . $sid . ' is not valid return false, may be the session ID is wrong');
-			return null;
-		}
-
-		/**
-		 * Save the session data
-		 * @param  string $sid  the session ID
-		 * @param  mixed $data the session data to save in serialize format
-		 * @return boolean 
-		 */
-		public function write($sid, $data){
-			$this->logger->debug('Saving database session data for SID: ' . $sid . ', data: ' . stringfy_vars($data));
-			$instance = $this->getModelInstance();
-			$columns = $this->sessionTableColumns;
-
-			$this->loader->functions('user_agent'); 
-			$this->loader->library('Browser'); 
-
-			$ip = get_ip();
-			$keyValue = $instance->getKeyValue();
-			$host = @gethostbyaddr($ip) or null;
-			$browser = $this->OBJ->browser->getPlatform().', '.$this->OBJ->browser->getBrowser().' '.$this->OBJ->browser->getVersion();
-			$data = $this->encode($data);
-			$params = array(
-							$columns['sid'] => $sid,
-							$columns['sdata'] => $data,
-							$columns['stime'] => time(),
-							$columns['shost'] => $host,
-							$columns['sbrowser'] => $browser,
-							$columns['sip'] => $ip,
-							$columns['skey'] => $keyValue
-						);
-			$this->logger->info('Database session data to save are listed below :' . stringfy_vars($params));
-			$exists = $instance->get($sid);
-			if ($exists){
-				$this->logger->info('Session data for SID: ' . $sid . ' already exists, just update it');
-				//update
-				unset($params[$columns['sid']]);
-				return $instance->update($sid, $params);
-			}
-			$this->logger->info('Session data for SID: ' . $sid . ' not yet exists, insert it now');
-			return $instance->insert($params);
-			return true;
-		}
-
-
-		/**
-		 * Destroy the session data for the given session id
-		 * @param  string $sid the session id value
-		 * @return boolean
-		 */
-		public function destroy($sid){
-			$this->logger->debug('Destroy of session data for SID: ' . $sid);
-			$instance = $this->modelInstance;
-			$instance->delete($sid);
-			return true;
-		}
-
-		/**
-		 * Clean the expire session data to save espace
-		 * @param  integer $maxLifetime the max lifetime
-		 * @return boolean
-		 */
-		public function gc($maxLifetime){
-			$instance = $this->modelInstance;
-			$time = time() - $maxLifetime;
-			$this->logger->debug('Garbage collector of expired session. maxLifetime [' . $maxLifetime . '] sec, expired time [' . $time . ']');
-			$instance->deleteByTime($time);
-			return true;
-		}
-
-		/**
-		 * Encode the session data using the openssl
-		 * @param  mixed $data the session data to encode
-		 * @return mixed the encoded session data
-		 */
-		public function encode($data){
-			$key = base64_decode($this->sessionSecret);
-			$dataEncrypted = openssl_encrypt($data , self::DB_SESSION_HASH_METHOD, $key, OPENSSL_RAW_DATA, $this->getInitializerVector());
-			$output = base64_encode($dataEncrypted);
-			return $output;
-		}
-
-
-		/**
-		 * Decode the session data using the openssl
-		 * @param  mixed $data the data to decode
-		 * @return mixed       the decoded data
-		 */
-		public function decode($data){
-			$key = base64_decode($this->sessionSecret);
-			$data = base64_decode($data);
-			$data = openssl_decrypt($data, self::DB_SESSION_HASH_METHOD, $key, OPENSSL_RAW_DATA, $this->getInitializerVector());
-			return $data;
-		}
+            $data = $instance->get_by(array($columns['sid'] => $sid, $columns['shost'] => $host, $columns['sbrowser'] => $browser));
+            if ($data && isset($data->{$columns['sdata']})){
+                //checking inactivity 
+                $timeInactivity = time() - get_config('session_inactivity_time', 100);
+                if ($data->{$columns['stime']} < $timeInactivity){
+                    $this->logger->info('Database session data for SID: ' . $sid . ' already expired, destroy it');
+                    $this->destroy($sid);
+                    return null;
+                }
+                return $this->decode($data->{$columns['sdata']});
+            }
+            $this->logger->info('Database session data for SID: ' . $sid . ' is not valid return false, may be the session ID is wrong');
+            return null;
+        }
+
+        /**
+         * Save the session data
+         * @param  string $sid  the session ID
+         * @param  mixed $data the session data to save in serialize format
+         * @return boolean 
+         */
+        public function write($sid, $data){
+            $this->logger->debug('Saving database session data for SID: ' . $sid . ', data: ' . stringfy_vars($data));
+            $instance = $this->getModelInstance();
+            $columns = $this->sessionTableColumns;
+
+            $this->loader->functions('user_agent'); 
+            $this->loader->library('Browser'); 
+
+            $ip = get_ip();
+            $keyValue = $instance->getKeyValue();
+            $host = @gethostbyaddr($ip) or null;
+            $browser = $this->OBJ->browser->getPlatform().', '.$this->OBJ->browser->getBrowser().' '.$this->OBJ->browser->getVersion();
+            $data = $this->encode($data);
+            $params = array(
+                            $columns['sid'] => $sid,
+                            $columns['sdata'] => $data,
+                            $columns['stime'] => time(),
+                            $columns['shost'] => $host,
+                            $columns['sbrowser'] => $browser,
+                            $columns['sip'] => $ip,
+                            $columns['skey'] => $keyValue
+                        );
+            $this->logger->info('Database session data to save are listed below :' . stringfy_vars($params));
+            $exists = $instance->get($sid);
+            if ($exists){
+                $this->logger->info('Session data for SID: ' . $sid . ' already exists, just update it');
+                //update
+                unset($params[$columns['sid']]);
+                return $instance->update($sid, $params);
+            }
+            $this->logger->info('Session data for SID: ' . $sid . ' not yet exists, insert it now');
+            return $instance->insert($params);
+            return true;
+        }
+
+
+        /**
+         * Destroy the session data for the given session id
+         * @param  string $sid the session id value
+         * @return boolean
+         */
+        public function destroy($sid){
+            $this->logger->debug('Destroy of session data for SID: ' . $sid);
+            $instance = $this->modelInstance;
+            $instance->delete($sid);
+            return true;
+        }
+
+        /**
+         * Clean the expire session data to save espace
+         * @param  integer $maxLifetime the max lifetime
+         * @return boolean
+         */
+        public function gc($maxLifetime){
+            $instance = $this->modelInstance;
+            $time = time() - $maxLifetime;
+            $this->logger->debug('Garbage collector of expired session. maxLifetime [' . $maxLifetime . '] sec, expired time [' . $time . ']');
+            $instance->deleteByTime($time);
+            return true;
+        }
+
+        /**
+         * Encode the session data using the openssl
+         * @param  mixed $data the session data to encode
+         * @return mixed the encoded session data
+         */
+        public function encode($data){
+            $key = base64_decode($this->sessionSecret);
+            $dataEncrypted = openssl_encrypt($data , self::DB_SESSION_HASH_METHOD, $key, OPENSSL_RAW_DATA, $this->getInitializerVector());
+            $output = base64_encode($dataEncrypted);
+            return $output;
+        }
+
+
+        /**
+         * Decode the session data using the openssl
+         * @param  mixed $data the data to decode
+         * @return mixed       the decoded data
+         */
+        public function decode($data){
+            $key = base64_decode($this->sessionSecret);
+            $data = base64_decode($data);
+            $data = openssl_decrypt($data, self::DB_SESSION_HASH_METHOD, $key, OPENSSL_RAW_DATA, $this->getInitializerVector());
+            return $data;
+        }
 
 		
-		/**
+        /**
          * Return the loader instance
          * @return object Loader the loader instance
          */
@@ -317,7 +317,7 @@ 
          * set the loader instance for future use
          * @param object Loader $loader the loader object
          */
-         public function setLoader($loader){
+            public function setLoader($loader){
             $this->loader = $loader;
             return $this;
         }
@@ -334,77 +334,77 @@ 
          * set the model instance for future use
          * @param DBSessionHandlerModel $modelInstance the model object
          */
-         public function setModelInstance(DBSessionHandlerModel $modelInstance){
+            public function setModelInstance(DBSessionHandlerModel $modelInstance){
             $this->modelInstance = $modelInstance;
             return $this;
         }
 
         /**
-	     * Return the Log instance
-	     * @return Log
-	     */
-	    public function getLogger(){
-	      return $this->logger;
-	    }
-
-	    /**
-	     * Set the log instance
-	     * @param Log $logger the log object
-	     */
-	    public function setLogger(Log $logger){
-	      $this->logger = $logger;
-	      return $this;
-	    }
-
-	    /**
-	     * Set the dependencies instance using argument or create new instance if is null
-	     * @param string $name this class property name.
-	     * @param object $instance the instance. If is not null will use it
-	     * otherwise will create new instance.
-	     * @param string $loadClassName the name of class to load using class_loader function.
-	     * @param string $loadClassPath the path of class to load using class_loader function.
-	     *
-	     * @return object this current instance
-	     */
-	    protected function setDependencyInstanceFromParamOrCreate($name, $instance = null, $loadClassName = null, $loadClassePath = 'classes'){
-	      if ($instance !== null){
-	        $this->{$name} = $instance;
-	        return $this;
-	      }
-	      $this->{$name} =& class_loader($loadClassName, $loadClassePath);
-	      return $this;
-	    }
+         * Return the Log instance
+         * @return Log
+         */
+        public function getLogger(){
+            return $this->logger;
+        }
+
+        /**
+         * Set the log instance
+         * @param Log $logger the log object
+         */
+        public function setLogger(Log $logger){
+            $this->logger = $logger;
+            return $this;
+        }
+
+        /**
+         * Set the dependencies instance using argument or create new instance if is null
+         * @param string $name this class property name.
+         * @param object $instance the instance. If is not null will use it
+         * otherwise will create new instance.
+         * @param string $loadClassName the name of class to load using class_loader function.
+         * @param string $loadClassPath the path of class to load using class_loader function.
+         *
+         * @return object this current instance
+         */
+        protected function setDependencyInstanceFromParamOrCreate($name, $instance = null, $loadClassName = null, $loadClassePath = 'classes'){
+            if ($instance !== null){
+            $this->{$name} = $instance;
+            return $this;
+            }
+            $this->{$name} =& class_loader($loadClassName, $loadClassePath);
+            return $this;
+        }
 	    
-		   /**
-	     * Set the Log instance using argument or create new instance
-	     * @param object $logger the Log instance if not null
-	     *
-	     * @return object this current instance
-	     */
-	    protected function setLoggerFromParamOrCreate(Log $logger = null){
-	      $this->setDependencyInstanceFromParamOrCreate('logger', $logger, 'Log', 'classes');
-	      if ($logger === null){
-	        $this->logger->setLogger('Library::DBSessionHandler');
-	      }
-	      return $this;
-	    }
-
-	    /**
-	     * Set the model instance using the configuration for session
-	     */
-	    protected function setModelInstanceFromConfig(){
-	    	$modelName = get_config('session_save_path');
-			$this->logger->info('The database session model: ' . $modelName);
-			$this->loader->model($modelName, 'dbsessionhandlerinstance'); 
-			//@codeCoverageIgnoreStart
+            /**
+             * Set the Log instance using argument or create new instance
+             * @param object $logger the Log instance if not null
+             *
+             * @return object this current instance
+             */
+        protected function setLoggerFromParamOrCreate(Log $logger = null){
+            $this->setDependencyInstanceFromParamOrCreate('logger', $logger, 'Log', 'classes');
+            if ($logger === null){
+            $this->logger->setLogger('Library::DBSessionHandler');
+            }
+            return $this;
+        }
+
+        /**
+         * Set the model instance using the configuration for session
+         */
+        protected function setModelInstanceFromConfig(){
+            $modelName = get_config('session_save_path');
+            $this->logger->info('The database session model: ' . $modelName);
+            $this->loader->model($modelName, 'dbsessionhandlerinstance'); 
+            //@codeCoverageIgnoreStart
             if (isset($this->OBJ->dbsessionhandlerinstance) 
-            	&& ! ($this->OBJ->dbsessionhandlerinstance instanceof DBSessionHandlerModel)
+                && ! ($this->OBJ->dbsessionhandlerinstance instanceof DBSessionHandlerModel)
             ) {
-				show_error('To use database session handler, your class model "' . get_class($this->OBJ->dbsessionhandlerinstance) . '" need extends "DBSessionHandlerModel"');
-			}  
-			//@codeCoverageIgnoreEnd
+                show_error('To use database session handler, your class model "' . get_class($this->OBJ->dbsessionhandlerinstance) . '" need extends "DBSessionHandlerModel"');
+            }  
+            //@codeCoverageIgnoreEnd
 			
-			//set model instance
-			$this->modelInstance = $this->OBJ->dbsessionhandlerinstance;
-	    }
-	}
+            //set model instance
+            $this->modelInstance = $this->OBJ->dbsessionhandlerinstance;
+        }
+    }

Spacing +38 added lines, -38 removed lines

@@ -27,11 +27,11 @@ 
 	/**
 	 * check if the interface "SessionHandlerInterface" exists (normally in PHP 5.4 this already exists)
 	 */
-	if ( !interface_exists('SessionHandlerInterface')){
+	if (!interface_exists('SessionHandlerInterface')) {
 		show_error('"SessionHandlerInterface" interface does not exists or is disabled can not use it to handler database session.');
 	}
 
-	class DBSessionHandler implements SessionHandlerInterface{
+	class DBSessionHandler implements SessionHandlerInterface {
 		
 		/**
 		 * The encryption method to use to encrypt session data in database
@@ -85,7 +85,7 @@ 
          * Create new instance of Database session handler
          * @param object $modelInstance the model instance
          */
-		public function __construct(DBSessionHandlerModel $modelInstance = null){
+		public function __construct(DBSessionHandlerModel $modelInstance = null) {
 			//Set Log instance to use
 	        $this->setLoggerFromParamOrCreate(null);
 			
@@ -94,7 +94,7 @@ 
 	       
 		    $this->OBJ = & get_instance();
 		    
-			if (is_object($modelInstance)){
+			if (is_object($modelInstance)) {
 				$this->setModelInstance($modelInstance);
 			}
 		}
@@ -103,7 +103,7 @@ 
 		 * Set the session secret used to encrypt the data in database 
 		 * @param string $secret the base64 string secret
 		 */
-		public function setSessionSecret($secret){
+		public function setSessionSecret($secret) {
 			$this->sessionSecret = $secret;
 			return $this;
 		}
@@ -112,7 +112,7 @@ 
 		 * Return the session secret
 		 * @return string 
 		 */
-		public function getSessionSecret(){
+		public function getSessionSecret() {
 			return $this->sessionSecret;
 		}
 
@@ -121,7 +121,7 @@ 
 		 * Set the initializer vector for openssl 
 		 * @param string $key the session secret used in base64 format
 		 */
-		public function setInitializerVector($key){
+		public function setInitializerVector($key) {
 			$ivLength = openssl_cipher_iv_length(self::DB_SESSION_HASH_METHOD);
 			$key = base64_decode($key);
 			$this->iv = substr(hash('sha256', $key), 0, $ivLength);
@@ -132,7 +132,7 @@ 
 		 * Return the initializer vector
 		 * @return string 
 		 */
-		public function getInitializerVector(){
+		public function getInitializerVector() {
 			return $this->iv;
 		}
 
@@ -142,17 +142,17 @@ 
 		 * @param  string $sessionName the session name
 		 * @return boolean 
 		 */
-		public function open($savePath, $sessionName){
+		public function open($savePath, $sessionName) {
 			$this->logger->debug('Opening database session handler for [' . $sessionName . ']');
 			//try to check if session secret is set before
 			$secret = $this->getSessionSecret();
-			if (empty($secret)){
+			if (empty($secret)) {
 				$secret = get_config('session_secret', null);
 				$this->setSessionSecret($secret);
 			}
 			$this->logger->info('Session secret: ' . $secret);
 
-			if (! is_object($this->modelInstance)){
+			if (!is_object($this->modelInstance)) {
 				$this->setModelInstanceFromConfig();
 			}
 			$this->setInitializerVector($secret);
@@ -160,7 +160,7 @@ 
 			//set session tables columns
 			$this->sessionTableColumns = $this->modelInstance->getSessionTableColumns();
 
-			if (empty($this->sessionTableColumns)){
+			if (empty($this->sessionTableColumns)) {
 				show_error('The session handler is "database" but the table columns not set');
 			}
 			$this->logger->info('Database session, the model columns are listed below: ' . stringfy_vars($this->sessionTableColumns));
@@ -176,7 +176,7 @@ 
 		 * Close the session
 		 * @return boolean
 		 */
-		public function close(){
+		public function close() {
 			$this->logger->debug('Closing database session handler');
 			return true;
 		}
@@ -186,7 +186,7 @@ 
 		 * @param  string $sid the session id to use
 		 * @return string      the session data in serialiaze format
 		 */
-		public function read($sid){
+		public function read($sid) {
 			$this->logger->debug('Reading database session data for SID: ' . $sid);
 			$instance = $this->getModelInstance();
 			$columns = $this->sessionTableColumns;
@@ -195,13 +195,13 @@ 
 			
 			$ip = get_ip();
 			$host = @gethostbyaddr($ip) or null;
-			$browser = $this->OBJ->browser->getPlatform().', '.$this->OBJ->browser->getBrowser().' '.$this->OBJ->browser->getVersion();
+			$browser = $this->OBJ->browser->getPlatform() . ', ' . $this->OBJ->browser->getBrowser() . ' ' . $this->OBJ->browser->getVersion();
 			
 			$data = $instance->get_by(array($columns['sid'] => $sid, $columns['shost'] => $host, $columns['sbrowser'] => $browser));
-			if ($data && isset($data->{$columns['sdata']})){
+			if ($data && isset($data->{$columns['sdata']})) {
 				//checking inactivity 
 				$timeInactivity = time() - get_config('session_inactivity_time', 100);
-				if ($data->{$columns['stime']} < $timeInactivity){
+				if ($data->{$columns['stime']} < $timeInactivity) {
 					$this->logger->info('Database session data for SID: ' . $sid . ' already expired, destroy it');
 					$this->destroy($sid);
 					return null;
@@ -218,7 +218,7 @@ 
 		 * @param  mixed $data the session data to save in serialize format
 		 * @return boolean 
 		 */
-		public function write($sid, $data){
+		public function write($sid, $data) {
 			$this->logger->debug('Saving database session data for SID: ' . $sid . ', data: ' . stringfy_vars($data));
 			$instance = $this->getModelInstance();
 			$columns = $this->sessionTableColumns;
@@ -229,7 +229,7 @@ 
 			$ip = get_ip();
 			$keyValue = $instance->getKeyValue();
 			$host = @gethostbyaddr($ip) or null;
-			$browser = $this->OBJ->browser->getPlatform().', '.$this->OBJ->browser->getBrowser().' '.$this->OBJ->browser->getVersion();
+			$browser = $this->OBJ->browser->getPlatform() . ', ' . $this->OBJ->browser->getBrowser() . ' ' . $this->OBJ->browser->getVersion();
 			$data = $this->encode($data);
 			$params = array(
 							$columns['sid'] => $sid,
@@ -242,7 +242,7 @@ 
 						);
 			$this->logger->info('Database session data to save are listed below :' . stringfy_vars($params));
 			$exists = $instance->get($sid);
-			if ($exists){
+			if ($exists) {
 				$this->logger->info('Session data for SID: ' . $sid . ' already exists, just update it');
 				//update
 				unset($params[$columns['sid']]);
@@ -259,7 +259,7 @@ 
 		 * @param  string $sid the session id value
 		 * @return boolean
 		 */
-		public function destroy($sid){
+		public function destroy($sid) {
 			$this->logger->debug('Destroy of session data for SID: ' . $sid);
 			$instance = $this->modelInstance;
 			$instance->delete($sid);
@@ -271,7 +271,7 @@ 
 		 * @param  integer $maxLifetime the max lifetime
 		 * @return boolean
 		 */
-		public function gc($maxLifetime){
+		public function gc($maxLifetime) {
 			$instance = $this->modelInstance;
 			$time = time() - $maxLifetime;
 			$this->logger->debug('Garbage collector of expired session. maxLifetime [' . $maxLifetime . '] sec, expired time [' . $time . ']');
@@ -284,9 +284,9 @@ 
 		 * @param  mixed $data the session data to encode
 		 * @return mixed the encoded session data
 		 */
-		public function encode($data){
+		public function encode($data) {
 			$key = base64_decode($this->sessionSecret);
-			$dataEncrypted = openssl_encrypt($data , self::DB_SESSION_HASH_METHOD, $key, OPENSSL_RAW_DATA, $this->getInitializerVector());
+			$dataEncrypted = openssl_encrypt($data, self::DB_SESSION_HASH_METHOD, $key, OPENSSL_RAW_DATA, $this->getInitializerVector());
 			$output = base64_encode($dataEncrypted);
 			return $output;
 		}
@@ -297,7 +297,7 @@ 
 		 * @param  mixed $data the data to decode
 		 * @return mixed       the decoded data
 		 */
-		public function decode($data){
+		public function decode($data) {
 			$key = base64_decode($this->sessionSecret);
 			$data = base64_decode($data);
 			$data = openssl_decrypt($data, self::DB_SESSION_HASH_METHOD, $key, OPENSSL_RAW_DATA, $this->getInitializerVector());
@@ -309,7 +309,7 @@ 
          * Return the loader instance
          * @return object Loader the loader instance
          */
-        public function getLoader(){
+        public function getLoader() {
             return $this->loader;
         }
 
@@ -317,7 +317,7 @@ 
          * set the loader instance for future use
          * @param object Loader $loader the loader object
          */
-         public function setLoader($loader){
+         public function setLoader($loader) {
             $this->loader = $loader;
             return $this;
         }
@@ -326,7 +326,7 @@ 
          * Return the model instance
          * @return object DBSessionHandlerModel the model instance
          */
-        public function getModelInstance(){
+        public function getModelInstance() {
             return $this->modelInstance;
         }
 
@@ -334,7 +334,7 @@ 
          * set the model instance for future use
          * @param DBSessionHandlerModel $modelInstance the model object
          */
-         public function setModelInstance(DBSessionHandlerModel $modelInstance){
+         public function setModelInstance(DBSessionHandlerModel $modelInstance) {
             $this->modelInstance = $modelInstance;
             return $this;
         }
@@ -343,7 +343,7 @@ 
 	     * Return the Log instance
 	     * @return Log
 	     */
-	    public function getLogger(){
+	    public function getLogger() {
 	      return $this->logger;
 	    }
 
@@ -351,7 +351,7 @@ 
 	     * Set the log instance
 	     * @param Log $logger the log object
 	     */
-	    public function setLogger(Log $logger){
+	    public function setLogger(Log $logger) {
 	      $this->logger = $logger;
 	      return $this;
 	    }
@@ -366,12 +366,12 @@ 
 	     *
 	     * @return object this current instance
 	     */
-	    protected function setDependencyInstanceFromParamOrCreate($name, $instance = null, $loadClassName = null, $loadClassePath = 'classes'){
-	      if ($instance !== null){
+	    protected function setDependencyInstanceFromParamOrCreate($name, $instance = null, $loadClassName = null, $loadClassePath = 'classes') {
+	      if ($instance !== null) {
 	        $this->{$name} = $instance;
 	        return $this;
 	      }
-	      $this->{$name} =& class_loader($loadClassName, $loadClassePath);
+	      $this->{$name} = & class_loader($loadClassName, $loadClassePath);
 	      return $this;
 	    }
 	    
@@ -381,9 +381,9 @@ 
 	     *
 	     * @return object this current instance
 	     */
-	    protected function setLoggerFromParamOrCreate(Log $logger = null){
+	    protected function setLoggerFromParamOrCreate(Log $logger = null) {
 	      $this->setDependencyInstanceFromParamOrCreate('logger', $logger, 'Log', 'classes');
-	      if ($logger === null){
+	      if ($logger === null) {
 	        $this->logger->setLogger('Library::DBSessionHandler');
 	      }
 	      return $this;
@@ -392,13 +392,13 @@ 
 	    /**
 	     * Set the model instance using the configuration for session
 	     */
-	    protected function setModelInstanceFromConfig(){
+	    protected function setModelInstanceFromConfig() {
 	    	$modelName = get_config('session_save_path');
 			$this->logger->info('The database session model: ' . $modelName);
 			$this->loader->model($modelName, 'dbsessionhandlerinstance'); 
 			//@codeCoverageIgnoreStart
             if (isset($this->OBJ->dbsessionhandlerinstance) 
-            	&& ! ($this->OBJ->dbsessionhandlerinstance instanceof DBSessionHandlerModel)
+            	&& !($this->OBJ->dbsessionhandlerinstance instanceof DBSessionHandlerModel)
             ) {
 				show_error('To use database session handler, your class model "' . get_class($this->OBJ->dbsessionhandlerinstance) . '" need extends "DBSessionHandlerModel"');
 			}  

core/libraries/Form.php

Indentation +294 added lines, -294 removed lines

@@ -1,322 +1,322 @@
 <?php
-	defined('ROOT_PATH') || exit('Access denied');
-	/**
-	 * TNH Framework
-	 *
-	 * A simple PHP framework using HMVC architecture
-	 *
-	 * This content is released under the GNU GPL License (GPL)
-	 *
-	 * Copyright (C) 2017 Tony NGUEREZA
-	 *
-	 * This program is free software; you can redistribute it and/or
-	 * modify it under the terms of the GNU General Public License
-	 * as published by the Free Software Foundation; either version 3
-	 * of the License, or (at your option) any later version.
-	 *
-	 * This program is distributed in the hope that it will be useful,
-	 * but WITHOUT ANY WARRANTY; without even the implied warranty of
-	 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-	 * GNU General Public License for more details.
-	 *
-	 * You should have received a copy of the GNU General Public License
-	 * along with this program; if not, write to the Free Software
-	 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
-	*/
+    defined('ROOT_PATH') || exit('Access denied');
+    /**
+     * TNH Framework
+     *
+     * A simple PHP framework using HMVC architecture
+     *
+     * This content is released under the GNU GPL License (GPL)
+     *
+     * Copyright (C) 2017 Tony NGUEREZA
+     *
+     * This program is free software; you can redistribute it and/or
+     * modify it under the terms of the GNU General Public License
+     * as published by the Free Software Foundation; either version 3
+     * of the License, or (at your option) any later version.
+     *
+     * This program is distributed in the hope that it will be useful,
+     * but WITHOUT ANY WARRANTY; without even the implied warranty of
+     * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+     * GNU General Public License for more details.
+     *
+     * You should have received a copy of the GNU General Public License
+     * along with this program; if not, write to the Free Software
+     * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+     */
 
 
-	class Form{
+    class Form{
 
-		/**
-		 * Generate the form opened tag
-		 * @param  string $path       the form action path
-		 * @param  array  $attributes the additional form attributes
-		 * @param  string $method     the form method like 'GET', 'POST'
-		 * @param  string $enctype    the form enctype like "multipart/form-data"
-		 * @return string             the generated form html
-		 */
-		public static function open($path = null, array $attributes = array(), $method = 'POST', $enctype = null){
-			if($path){
-				$path = Url::site_url($path);
-			}
-			$method = strtoupper($method);
-			$str = null;
-			$str .= '<form action = "'.$path.'" method = "'.$method.'"';
-			if(! empty($enctype)){
-				$str .= ' enctype = "'.$enctype.'" ';
-			}
-			if(! isset($attributes['accept-charset'])){
-				$attributes['accept-charset'] = get_config('charset', 'utf-8');
-			}
-			$str .= attributes_to_string($attributes);
-			$str .= '>';
-			//if CSRF is enabled in the configuration
-			if(get_config('csrf_enable', false) && $method == 'POST'){
-				$csrfValue = Security::generateCSRF();
-				$csrfName = get_config('csrf_key', 'csrf_key');
-				$str .= static::hidden($csrfName, $csrfValue);
-			}
-			return $str;
-		}
+        /**
+         * Generate the form opened tag
+         * @param  string $path       the form action path
+         * @param  array  $attributes the additional form attributes
+         * @param  string $method     the form method like 'GET', 'POST'
+         * @param  string $enctype    the form enctype like "multipart/form-data"
+         * @return string             the generated form html
+         */
+        public static function open($path = null, array $attributes = array(), $method = 'POST', $enctype = null){
+            if($path){
+                $path = Url::site_url($path);
+            }
+            $method = strtoupper($method);
+            $str = null;
+            $str .= '<form action = "'.$path.'" method = "'.$method.'"';
+            if(! empty($enctype)){
+                $str .= ' enctype = "'.$enctype.'" ';
+            }
+            if(! isset($attributes['accept-charset'])){
+                $attributes['accept-charset'] = get_config('charset', 'utf-8');
+            }
+            $str .= attributes_to_string($attributes);
+            $str .= '>';
+            //if CSRF is enabled in the configuration
+            if(get_config('csrf_enable', false) && $method == 'POST'){
+                $csrfValue = Security::generateCSRF();
+                $csrfName = get_config('csrf_key', 'csrf_key');
+                $str .= static::hidden($csrfName, $csrfValue);
+            }
+            return $str;
+        }
 
-		/**
-		 * Generate the form opened tag for multipart like to send a file
-		 * @see Form::open() for more details
-		 * @return string the generated multipart form html
-		 */
-		public static function openMultipart($path = null, array $attributes = array(), $method = 'POST'){
-			return self::open($path, $attributes, $method, 'multipart/form-data');
-		}
+        /**
+         * Generate the form opened tag for multipart like to send a file
+         * @see Form::open() for more details
+         * @return string the generated multipart form html
+         */
+        public static function openMultipart($path = null, array $attributes = array(), $method = 'POST'){
+            return self::open($path, $attributes, $method, 'multipart/form-data');
+        }
 
-		/**
-		 * Generate the form close
-		 * @return string the form close html
-		 */
-		public static function close(){
-			return '</form>';
-		}
+        /**
+         * Generate the form close
+         * @return string the form close html
+         */
+        public static function close(){
+            return '</form>';
+        }
 
-		/**
-		 * Generate the form fieldset & legend
-		 * @param  string $legend the legend tag value
-		 * @param  array  $fieldsetAttributes the fieldset additional HTML attributes
-		 * @param  array  $legendAttributes the legend additional HTML attributes. Is used only is $legend is not empty
-		 * @return string         the generated fieldset value
-		 */
-		public static function fieldset($legend = '', array $fieldsetAttributes = array(), array $legendAttributes = array()){
-			$str = '<fieldset' . attributes_to_string($fieldsetAttributes) . '>';
-			if($legend){
-				$str .= '<legend' . attributes_to_string($legendAttributes) . '>'.$legend.'</legend>';
-			}
-			return $str;
-		}
+        /**
+         * Generate the form fieldset & legend
+         * @param  string $legend the legend tag value
+         * @param  array  $fieldsetAttributes the fieldset additional HTML attributes
+         * @param  array  $legendAttributes the legend additional HTML attributes. Is used only is $legend is not empty
+         * @return string         the generated fieldset value
+         */
+        public static function fieldset($legend = '', array $fieldsetAttributes = array(), array $legendAttributes = array()){
+            $str = '<fieldset' . attributes_to_string($fieldsetAttributes) . '>';
+            if($legend){
+                $str .= '<legend' . attributes_to_string($legendAttributes) . '>'.$legend.'</legend>';
+            }
+            return $str;
+        }
 
-		/**
-		 * Generate the fieldset close tag
-		 * @return string the generated html for fieldset close
-		 */
-		public static function fieldsetClose(){
-			return '</fieldset>';
-		}
+        /**
+         * Generate the fieldset close tag
+         * @return string the generated html for fieldset close
+         */
+        public static function fieldsetClose(){
+            return '</fieldset>';
+        }
 
-		/**
-		 * Get the error message for the given form field name.
-		 * This use the form validation information to get the error information.
-		 * @param  string $name the form field name
-		 * @return string       the error message if exists and null if not
-		 */
-		public static function error($name){
-			$return = null;
-			$obj = & get_instance();
-			if(isset($obj->formvalidation)){
-				$errors = $obj->formvalidation->returnErrors();
-				if(isset($errors[$name])){
-					list($errorStart, $errorEnd) = $obj->formvalidation->getErrorDelimiter();
-					$return = $errorStart . $errors[$name] . $errorEnd;
-				}
-			}
-			return $return;
-		}
+        /**
+         * Get the error message for the given form field name.
+         * This use the form validation information to get the error information.
+         * @param  string $name the form field name
+         * @return string       the error message if exists and null if not
+         */
+        public static function error($name){
+            $return = null;
+            $obj = & get_instance();
+            if(isset($obj->formvalidation)){
+                $errors = $obj->formvalidation->returnErrors();
+                if(isset($errors[$name])){
+                    list($errorStart, $errorEnd) = $obj->formvalidation->getErrorDelimiter();
+                    $return = $errorStart . $errors[$name] . $errorEnd;
+                }
+            }
+            return $return;
+        }
 
-		/**
-		 * Get the form field value
-		 * @param  string $name    the form field name
-		 * @param  mixed $default the default value if can not found the given form field name
-		 * @return mixed the form field value if is set, otherwise return the default value.
-		 */
-		public static function value($name, $default = null){
-			$value = get_instance()->request->query($name);
-			if(strlen($value) > 0){
-				return $value;
-			}
-			return $default;
-		}
+        /**
+         * Get the form field value
+         * @param  string $name    the form field name
+         * @param  mixed $default the default value if can not found the given form field name
+         * @return mixed the form field value if is set, otherwise return the default value.
+         */
+        public static function value($name, $default = null){
+            $value = get_instance()->request->query($name);
+            if(strlen($value) > 0){
+                return $value;
+            }
+            return $default;
+        }
 
-		/**
-		 * Generate the form label html content
-		 * @param  string $label      the title of the label
-		 * @param  string $for        the value of the label "for" attribute
-		 * @param  array  $attributes the additional attributes to be added
-		 * @return string the generated label html content
-		 */
-		public static function label($label, $for = '', array $attributes = array()){
-			$str = '<label';
-			if($for){
-				$str .= ' for = "'.$for.'"';
-			}
-			$str .= attributes_to_string($attributes);
-			$str .= '>';
-			$str .= $label.'</label>';
-			return $str;
-		}
+        /**
+         * Generate the form label html content
+         * @param  string $label      the title of the label
+         * @param  string $for        the value of the label "for" attribute
+         * @param  array  $attributes the additional attributes to be added
+         * @return string the generated label html content
+         */
+        public static function label($label, $for = '', array $attributes = array()){
+            $str = '<label';
+            if($for){
+                $str .= ' for = "'.$for.'"';
+            }
+            $str .= attributes_to_string($attributes);
+            $str .= '>';
+            $str .= $label.'</label>';
+            return $str;
+        }
 
-		/**
-		 * Generate the form field for input like "text", "email", "password", etc.
-		 * @param  string $name       the form field name
-		 * @param  mixed $value      the form field value to be set
-		 * @param  array  $attributes the additional attributes to be added in the form input
-		 * @param  string $type       the type of the form field (password, text, submit, button, etc.)
-		 * @return string             the generated form field html content for the input
-		 */
-		public static function input($name, $value = null, array $attributes = array(), $type = 'text'){
-			$str = null;
-			$str .= '<input name = "'.$name.'" value = "'.$value.'" type = "'.$type.'"';
-			$str .= attributes_to_string($attributes);
-			$str .= '/>';
-			return $str;
-		}
+        /**
+         * Generate the form field for input like "text", "email", "password", etc.
+         * @param  string $name       the form field name
+         * @param  mixed $value      the form field value to be set
+         * @param  array  $attributes the additional attributes to be added in the form input
+         * @param  string $type       the type of the form field (password, text, submit, button, etc.)
+         * @return string             the generated form field html content for the input
+         */
+        public static function input($name, $value = null, array $attributes = array(), $type = 'text'){
+            $str = null;
+            $str .= '<input name = "'.$name.'" value = "'.$value.'" type = "'.$type.'"';
+            $str .= attributes_to_string($attributes);
+            $str .= '/>';
+            return $str;
+        }
 		
-		/**
-		 * Generate the form field for "text"
-		 * @see Form::input() for more details
-		 */
-		public static function text($name, $value = null, array $attributes = array()){
-			return self::input($name, $value, $attributes, 'text');
-		}
+        /**
+         * Generate the form field for "text"
+         * @see Form::input() for more details
+         */
+        public static function text($name, $value = null, array $attributes = array()){
+            return self::input($name, $value, $attributes, 'text');
+        }
 
-		/**
-		 * Generate the form field for "password"
-		 * @see Form::input() for more details
-		 */
-		public static function password($name, $value = null, array $attributes = array()){
-			return self::input($name, $value, $attributes, 'password');
-		}
+        /**
+         * Generate the form field for "password"
+         * @see Form::input() for more details
+         */
+        public static function password($name, $value = null, array $attributes = array()){
+            return self::input($name, $value, $attributes, 'password');
+        }
 
-		/**
-		 * Generate the form field for "radio"
-		 * @see Form::input() for more details
-		 */
-		public static function radio($name, $value = null,  $checked = false, array $attributes = array()){
-			if($checked){
-				$attributes['checked'] = true;
-			}
-			return self::input($name, $value, $attributes, 'radio');
-		}
+        /**
+         * Generate the form field for "radio"
+         * @see Form::input() for more details
+         */
+        public static function radio($name, $value = null,  $checked = false, array $attributes = array()){
+            if($checked){
+                $attributes['checked'] = true;
+            }
+            return self::input($name, $value, $attributes, 'radio');
+        }
 
-		/**
-		 * Generate the form field for "checkbox"
-		 * @see Form::input() for more details
-		 */
-		public static function checkbox($name, $value = null, $checked = false, array $attributes = array()){
-			if($checked){
-				$attributes['checked'] = true;
-			}
-			return self::input($name, $value, $attributes, 'checkbox');
-		}
+        /**
+         * Generate the form field for "checkbox"
+         * @see Form::input() for more details
+         */
+        public static function checkbox($name, $value = null, $checked = false, array $attributes = array()){
+            if($checked){
+                $attributes['checked'] = true;
+            }
+            return self::input($name, $value, $attributes, 'checkbox');
+        }
 
-		/**
-		 * Generate the form field for "number"
-		 * @see Form::input() for more details
-		 */
-		public static function number($name, $value = null, array $attributes = array()){
-			return self::input($name, $value, $attributes, 'number');
-		}
+        /**
+         * Generate the form field for "number"
+         * @see Form::input() for more details
+         */
+        public static function number($name, $value = null, array $attributes = array()){
+            return self::input($name, $value, $attributes, 'number');
+        }
 
-		/**
-		 * Generate the form field for "phone"
-		 * @see Form::input() for more details
-		 */
-		public static function phone($name, $value = null, array $attributes = array()){
-			return self::input($name, $value, $attributes, 'phone');
-		}
+        /**
+         * Generate the form field for "phone"
+         * @see Form::input() for more details
+         */
+        public static function phone($name, $value = null, array $attributes = array()){
+            return self::input($name, $value, $attributes, 'phone');
+        }
 
-		/**
-		 * Generate the form field for "email"
-		 * @see Form::input() for more details
-		 */
-		public static function email($name, $value = null, array $attributes = array()){
-			return self::input($name, $value, $attributes, 'email');
-		}
+        /**
+         * Generate the form field for "email"
+         * @see Form::input() for more details
+         */
+        public static function email($name, $value = null, array $attributes = array()){
+            return self::input($name, $value, $attributes, 'email');
+        }
 		
-		/**
-		 * Generate the form field for "search"
-		 * @see Form::input() for more details
-		 */
-		public static function search($name, $value = null, array $attributes = array()){
-			return self::input($name, $value, $attributes, 'search');
-		}
+        /**
+         * Generate the form field for "search"
+         * @see Form::input() for more details
+         */
+        public static function search($name, $value = null, array $attributes = array()){
+            return self::input($name, $value, $attributes, 'search');
+        }
 		
-		/**
-		 * Generate the form field for "hidden"
-		 * @see Form::input() for more details
-		 */
-		public static function hidden($name, $value = null, array $attributes = array()){
-			return self::input($name, $value, $attributes, 'hidden');
-		}
+        /**
+         * Generate the form field for "hidden"
+         * @see Form::input() for more details
+         */
+        public static function hidden($name, $value = null, array $attributes = array()){
+            return self::input($name, $value, $attributes, 'hidden');
+        }
 		
-		/**
-		 * Generate the form field for "file"
-		 * @see Form::input() for more details
-		 */
-		public static function file($name, array $attributes = array()){
-			return self::input($name, null, $attributes, 'file');
-		}
+        /**
+         * Generate the form field for "file"
+         * @see Form::input() for more details
+         */
+        public static function file($name, array $attributes = array()){
+            return self::input($name, null, $attributes, 'file');
+        }
 		
-		/**
-		 * Generate the form field for "button"
-		 * @see Form::input() for more details
-		 */
-		public static function button($name, $value = null, array $attributes = array()){
-			return self::input($name, $value, $attributes, 'button');
-		}
+        /**
+         * Generate the form field for "button"
+         * @see Form::input() for more details
+         */
+        public static function button($name, $value = null, array $attributes = array()){
+            return self::input($name, $value, $attributes, 'button');
+        }
 		
-		/**
-		 * Generate the form field for "reset"
-		 * @see Form::input() for more details
-		 */
-		public static function reset($name, $value = null, array $attributes = array()){
-			return self::input($name, $value, $attributes, 'reset');
-		}
+        /**
+         * Generate the form field for "reset"
+         * @see Form::input() for more details
+         */
+        public static function reset($name, $value = null, array $attributes = array()){
+            return self::input($name, $value, $attributes, 'reset');
+        }
 		
-		/**
-		 * Generate the form field for "submit"
-		 * @see Form::input() for more details
-		 */
-		public static function submit($name, $value = null, array $attributes = array()){
-			return self::input($name, $value, $attributes, 'submit');
-		}
+        /**
+         * Generate the form field for "submit"
+         * @see Form::input() for more details
+         */
+        public static function submit($name, $value = null, array $attributes = array()){
+            return self::input($name, $value, $attributes, 'submit');
+        }
 
-		/**
-		 * Generate the form field for textarea
-		 * @param  string $name       the name of the textarea field
-		 * @param  string $value      the textarea field value
-		 * @param  array  $attributes the additional attributes to be added
-		 * @return string             the generated textarea form html content
-		 */
-		public static function textarea($name, $value = '', array $attributes = array()){
-			$str = null;
-			$str .= '<textarea name = "'.$name.'"';
-			$str .= attributes_to_string($attributes);
-			$str .= '>';
-			$str .= $value.'</textarea>';
-			return $str;
-		}
+        /**
+         * Generate the form field for textarea
+         * @param  string $name       the name of the textarea field
+         * @param  string $value      the textarea field value
+         * @param  array  $attributes the additional attributes to be added
+         * @return string             the generated textarea form html content
+         */
+        public static function textarea($name, $value = '', array $attributes = array()){
+            $str = null;
+            $str .= '<textarea name = "'.$name.'"';
+            $str .= attributes_to_string($attributes);
+            $str .= '>';
+            $str .= $value.'</textarea>';
+            return $str;
+        }
 		
-		/**
-		 * Generate the form field for select
-		 * @param  string $name       the name of the form field
-		 * @param  mixed|array $values      the values used to populate the "option" tags
-		 * @param  mixed $selected   the selected value in the option list
-		 * @param  array  $attributes the additional attribute to be added
-		 * @return string             the generated form field html content for select
-		 */
-		public static function select($name, $values = null, $selected = null, array $attributes = array()){
-			if(! is_array($values)){
-				$values = array('' => $values);
-			}
-			$str = null;
-			$str .= '<select name = "'.$name.'"';
-			$str .= attributes_to_string($attributes);
-			$str .= '>';
-			foreach($values as $key => $val){
-				$select = '';
-				if($key == $selected){
-					$select = 'selected';
-				}
-				$str .= '<option value = "'.$key.'" '.$select.'>'.$val.'</option>';
-			}
-			$str .= '</select>';
-			return $str;
-		}
+        /**
+         * Generate the form field for select
+         * @param  string $name       the name of the form field
+         * @param  mixed|array $values      the values used to populate the "option" tags
+         * @param  mixed $selected   the selected value in the option list
+         * @param  array  $attributes the additional attribute to be added
+         * @return string             the generated form field html content for select
+         */
+        public static function select($name, $values = null, $selected = null, array $attributes = array()){
+            if(! is_array($values)){
+                $values = array('' => $values);
+            }
+            $str = null;
+            $str .= '<select name = "'.$name.'"';
+            $str .= attributes_to_string($attributes);
+            $str .= '>';
+            foreach($values as $key => $val){
+                $select = '';
+                if($key == $selected){
+                    $select = 'selected';
+                }
+                $str .= '<option value = "'.$key.'" '.$select.'>'.$val.'</option>';
+            }
+            $str .= '</select>';
+            return $str;
+        }
 
-	}
+    }

Spacing +49 added lines, -49 removed lines

@@ -25,7 +25,7 @@ 
 	*/
 
 
-	class Form{
+	class Form {
 
 		/**
 		 * Generate the form opened tag
@@ -35,23 +35,23 @@ 
 		 * @param  string $enctype    the form enctype like "multipart/form-data"
 		 * @return string             the generated form html
 		 */
-		public static function open($path = null, array $attributes = array(), $method = 'POST', $enctype = null){
-			if($path){
+		public static function open($path = null, array $attributes = array(), $method = 'POST', $enctype = null) {
+			if ($path) {
 				$path = Url::site_url($path);
 			}
 			$method = strtoupper($method);
 			$str = null;
-			$str .= '<form action = "'.$path.'" method = "'.$method.'"';
-			if(! empty($enctype)){
-				$str .= ' enctype = "'.$enctype.'" ';
+			$str .= '<form action = "' . $path . '" method = "' . $method . '"';
+			if (!empty($enctype)) {
+				$str .= ' enctype = "' . $enctype . '" ';
 			}
-			if(! isset($attributes['accept-charset'])){
+			if (!isset($attributes['accept-charset'])) {
 				$attributes['accept-charset'] = get_config('charset', 'utf-8');
 			}
 			$str .= attributes_to_string($attributes);
 			$str .= '>';
 			//if CSRF is enabled in the configuration
-			if(get_config('csrf_enable', false) && $method == 'POST'){
+			if (get_config('csrf_enable', false) && $method == 'POST') {
 				$csrfValue = Security::generateCSRF();
 				$csrfName = get_config('csrf_key', 'csrf_key');
 				$str .= static::hidden($csrfName, $csrfValue);
@@ -64,7 +64,7 @@ 
 		 * @see Form::open() for more details
 		 * @return string the generated multipart form html
 		 */
-		public static function openMultipart($path = null, array $attributes = array(), $method = 'POST'){
+		public static function openMultipart($path = null, array $attributes = array(), $method = 'POST') {
 			return self::open($path, $attributes, $method, 'multipart/form-data');
 		}
 
@@ -72,7 +72,7 @@ 
 		 * Generate the form close
 		 * @return string the form close html
 		 */
-		public static function close(){
+		public static function close() {
 			return '</form>';
 		}
 
@@ -83,10 +83,10 @@ 
 		 * @param  array  $legendAttributes the legend additional HTML attributes. Is used only is $legend is not empty
 		 * @return string         the generated fieldset value
 		 */
-		public static function fieldset($legend = '', array $fieldsetAttributes = array(), array $legendAttributes = array()){
+		public static function fieldset($legend = '', array $fieldsetAttributes = array(), array $legendAttributes = array()) {
 			$str = '<fieldset' . attributes_to_string($fieldsetAttributes) . '>';
-			if($legend){
-				$str .= '<legend' . attributes_to_string($legendAttributes) . '>'.$legend.'</legend>';
+			if ($legend) {
+				$str .= '<legend' . attributes_to_string($legendAttributes) . '>' . $legend . '</legend>';
 			}
 			return $str;
 		}
@@ -95,7 +95,7 @@ 
 		 * Generate the fieldset close tag
 		 * @return string the generated html for fieldset close
 		 */
-		public static function fieldsetClose(){
+		public static function fieldsetClose() {
 			return '</fieldset>';
 		}
 
@@ -105,12 +105,12 @@ 
 		 * @param  string $name the form field name
 		 * @return string       the error message if exists and null if not
 		 */
-		public static function error($name){
+		public static function error($name) {
 			$return = null;
 			$obj = & get_instance();
-			if(isset($obj->formvalidation)){
+			if (isset($obj->formvalidation)) {
 				$errors = $obj->formvalidation->returnErrors();
-				if(isset($errors[$name])){
+				if (isset($errors[$name])) {
 					list($errorStart, $errorEnd) = $obj->formvalidation->getErrorDelimiter();
 					$return = $errorStart . $errors[$name] . $errorEnd;
 				}
@@ -124,9 +124,9 @@ 
 		 * @param  mixed $default the default value if can not found the given form field name
 		 * @return mixed the form field value if is set, otherwise return the default value.
 		 */
-		public static function value($name, $default = null){
+		public static function value($name, $default = null) {
 			$value = get_instance()->request->query($name);
-			if(strlen($value) > 0){
+			if (strlen($value) > 0) {
 				return $value;
 			}
 			return $default;
@@ -139,14 +139,14 @@ 
 		 * @param  array  $attributes the additional attributes to be added
 		 * @return string the generated label html content
 		 */
-		public static function label($label, $for = '', array $attributes = array()){
+		public static function label($label, $for = '', array $attributes = array()) {
 			$str = '<label';
-			if($for){
-				$str .= ' for = "'.$for.'"';
+			if ($for) {
+				$str .= ' for = "' . $for . '"';
 			}
 			$str .= attributes_to_string($attributes);
 			$str .= '>';
-			$str .= $label.'</label>';
+			$str .= $label . '</label>';
 			return $str;
 		}
 
@@ -158,9 +158,9 @@ 
 		 * @param  string $type       the type of the form field (password, text, submit, button, etc.)
 		 * @return string             the generated form field html content for the input
 		 */
-		public static function input($name, $value = null, array $attributes = array(), $type = 'text'){
+		public static function input($name, $value = null, array $attributes = array(), $type = 'text') {
 			$str = null;
-			$str .= '<input name = "'.$name.'" value = "'.$value.'" type = "'.$type.'"';
+			$str .= '<input name = "' . $name . '" value = "' . $value . '" type = "' . $type . '"';
 			$str .= attributes_to_string($attributes);
 			$str .= '/>';
 			return $str;
@@ -170,7 +170,7 @@ 
 		 * Generate the form field for "text"
 		 * @see Form::input() for more details
 		 */
-		public static function text($name, $value = null, array $attributes = array()){
+		public static function text($name, $value = null, array $attributes = array()) {
 			return self::input($name, $value, $attributes, 'text');
 		}
 
@@ -178,7 +178,7 @@ 
 		 * Generate the form field for "password"
 		 * @see Form::input() for more details
 		 */
-		public static function password($name, $value = null, array $attributes = array()){
+		public static function password($name, $value = null, array $attributes = array()) {
 			return self::input($name, $value, $attributes, 'password');
 		}
 
@@ -186,8 +186,8 @@ 
 		 * Generate the form field for "radio"
 		 * @see Form::input() for more details
 		 */
-		public static function radio($name, $value = null,  $checked = false, array $attributes = array()){
-			if($checked){
+		public static function radio($name, $value = null, $checked = false, array $attributes = array()) {
+			if ($checked) {
 				$attributes['checked'] = true;
 			}
 			return self::input($name, $value, $attributes, 'radio');
@@ -197,8 +197,8 @@ 
 		 * Generate the form field for "checkbox"
 		 * @see Form::input() for more details
 		 */
-		public static function checkbox($name, $value = null, $checked = false, array $attributes = array()){
-			if($checked){
+		public static function checkbox($name, $value = null, $checked = false, array $attributes = array()) {
+			if ($checked) {
 				$attributes['checked'] = true;
 			}
 			return self::input($name, $value, $attributes, 'checkbox');
@@ -208,7 +208,7 @@ 
 		 * Generate the form field for "number"
 		 * @see Form::input() for more details
 		 */
-		public static function number($name, $value = null, array $attributes = array()){
+		public static function number($name, $value = null, array $attributes = array()) {
 			return self::input($name, $value, $attributes, 'number');
 		}
 
@@ -216,7 +216,7 @@ 
 		 * Generate the form field for "phone"
 		 * @see Form::input() for more details
 		 */
-		public static function phone($name, $value = null, array $attributes = array()){
+		public static function phone($name, $value = null, array $attributes = array()) {
 			return self::input($name, $value, $attributes, 'phone');
 		}
 
@@ -224,7 +224,7 @@ 
 		 * Generate the form field for "email"
 		 * @see Form::input() for more details
 		 */
-		public static function email($name, $value = null, array $attributes = array()){
+		public static function email($name, $value = null, array $attributes = array()) {
 			return self::input($name, $value, $attributes, 'email');
 		}
 		
@@ -232,7 +232,7 @@ 
 		 * Generate the form field for "search"
 		 * @see Form::input() for more details
 		 */
-		public static function search($name, $value = null, array $attributes = array()){
+		public static function search($name, $value = null, array $attributes = array()) {
 			return self::input($name, $value, $attributes, 'search');
 		}
 		
@@ -240,7 +240,7 @@ 
 		 * Generate the form field for "hidden"
 		 * @see Form::input() for more details
 		 */
-		public static function hidden($name, $value = null, array $attributes = array()){
+		public static function hidden($name, $value = null, array $attributes = array()) {
 			return self::input($name, $value, $attributes, 'hidden');
 		}
 		
@@ -248,7 +248,7 @@ 
 		 * Generate the form field for "file"
 		 * @see Form::input() for more details
 		 */
-		public static function file($name, array $attributes = array()){
+		public static function file($name, array $attributes = array()) {
 			return self::input($name, null, $attributes, 'file');
 		}
 		
@@ -256,7 +256,7 @@ 
 		 * Generate the form field for "button"
 		 * @see Form::input() for more details
 		 */
-		public static function button($name, $value = null, array $attributes = array()){
+		public static function button($name, $value = null, array $attributes = array()) {
 			return self::input($name, $value, $attributes, 'button');
 		}
 		
@@ -264,7 +264,7 @@ 
 		 * Generate the form field for "reset"
 		 * @see Form::input() for more details
 		 */
-		public static function reset($name, $value = null, array $attributes = array()){
+		public static function reset($name, $value = null, array $attributes = array()) {
 			return self::input($name, $value, $attributes, 'reset');
 		}
 		
@@ -272,7 +272,7 @@ 
 		 * Generate the form field for "submit"
 		 * @see Form::input() for more details
 		 */
-		public static function submit($name, $value = null, array $attributes = array()){
+		public static function submit($name, $value = null, array $attributes = array()) {
 			return self::input($name, $value, $attributes, 'submit');
 		}
 
@@ -283,12 +283,12 @@ 
 		 * @param  array  $attributes the additional attributes to be added
 		 * @return string             the generated textarea form html content
 		 */
-		public static function textarea($name, $value = '', array $attributes = array()){
+		public static function textarea($name, $value = '', array $attributes = array()) {
 			$str = null;
-			$str .= '<textarea name = "'.$name.'"';
+			$str .= '<textarea name = "' . $name . '"';
 			$str .= attributes_to_string($attributes);
 			$str .= '>';
-			$str .= $value.'</textarea>';
+			$str .= $value . '</textarea>';
 			return $str;
 		}
 		
@@ -300,20 +300,20 @@ 
 		 * @param  array  $attributes the additional attribute to be added
 		 * @return string             the generated form field html content for select
 		 */
-		public static function select($name, $values = null, $selected = null, array $attributes = array()){
-			if(! is_array($values)){
+		public static function select($name, $values = null, $selected = null, array $attributes = array()) {
+			if (!is_array($values)) {
 				$values = array('' => $values);
 			}
 			$str = null;
-			$str .= '<select name = "'.$name.'"';
+			$str .= '<select name = "' . $name . '"';
 			$str .= attributes_to_string($attributes);
 			$str .= '>';
-			foreach($values as $key => $val){
+			foreach ($values as $key => $val) {
 				$select = '';
-				if($key == $selected){
+				if ($key == $selected) {
 					$select = 'selected';
 				}
-				$str .= '<option value = "'.$key.'" '.$select.'>'.$val.'</option>';
+				$str .= '<option value = "' . $key . '" ' . $select . '>' . $val . '</option>';
 			}
 			$str .= '</select>';
 			return $str;