Issues in Jwt.php (master) - Issues in master - tmilos/jose-jwt - Measure and Improve Code Quality continuously with Scrutinizer

Issues (25)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Jwt.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the tmilos/jose-jwt package.
 *
 * (c) Milos Tomic <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Tmilos\JoseJwt;

use Tmilos\JoseJwt\Context\Context;
use Tmilos\JoseJwt\Error\IntegrityException;
use Tmilos\JoseJwt\Error\JoseJwtException;
use Tmilos\JoseJwt\Util\StringUtils;
use Tmilos\JoseJwt\Util\UrlSafeB64Encoder;

class Jwt
{
    private function __construct()
    {
    }

    /**
     * @param Context         $context
     * @param array|object    $payload
     * @param string|resource $key
     * @param string          $jwsAlgorithm
     * @param array           $extraHeaders
     *
     * @return string
     */
    public static function encode(Context $context, $payload, $key, $jwsAlgorithm, $extraHeaders = [])
    {
        $header = array_merge([
            'alg' => '',
            'typ' => 'JWT',
        ], $extraHeaders);

        $hashAlgorithm = $context->jwsAlgorithms()->get($jwsAlgorithm);
        if (null == $hashAlgorithm) {
            throw new JoseJwtException(sprintf('Unknown algorithm "%s"', $jwsAlgorithm));
        }

        $header['alg'] = $jwsAlgorithm;

        $payloadString = StringUtils::payload2string($payload, $context->jsonMapper());

        $signingInput = implode('.', [
            UrlSafeB64Encoder::encode(json_encode($header)),
            UrlSafeB64Encoder::encode($payloadString),
        ]);

        $signature = $hashAlgorithm->sign($signingInput, $key);
        $signature = UrlSafeB64Encoder::encode($signature);

        return $signingInput.'.'.$signature;
    }

    /**
     * @param Context         $context
     * @param string          $token
     * @param string|resource $key
     *
     * @return array
     */
    public static function decode(Context $context, $token, $key)
    {
        if (empty($token) || trim($token) === '') {
            throw new JoseJwtException('Incoming token expected to be in compact serialization form, but is empty');
        }

        $parts = explode('.', $token);
        if (count($parts) == 5) {
            return Jwe::decode($context, $token, $key);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $decodedParts = [];
        foreach ($parts as $part) {
            $decodedParts[] = UrlSafeB64Encoder::decode($part);
        }
        $header = json_decode($decodedParts[0], true);
        if (null == $header) {
            throw new JoseJwtException('Invalid header');
        }

        // signed or plain JWT
        $signedInput = $parts[0].'.'.$parts[1];
        $algorithmId = $header['alg'];
        $algorithm = $context->jwsAlgorithms()->get($algorithmId);
        if (null === $algorithm) {
            throw new JoseJwtException(sprintf('Invalid algorithm "%s"', $algorithmId));
        }

        if (false === $algorithm->verify($decodedParts[2], $signedInput, $key)) {
            throw new IntegrityException('Invalid signature');
        }

        return json_decode($decodedParts[1], true);
    }

    /**
     * @param $token
     *
     * @return array
     */
    public static function header($token)
    {
        if (null === $token || trim($token) === '') {
            throw new JoseJwtException('Incoming token expected to be in compact serialization form, but is empty');
        }

        $parts = explode('.', $token);
        if (count($parts) != 3 && count($parts) != 5) {
            throw new JoseJwtException('Invalid JWT');
        }

        $header = json_decode(UrlSafeB64Encoder::decode($parts[0]), true);
        if (null == $header) {
            throw new JoseJwtException('Invalid header');
        }

        return $header;
    }

    /**
     * @param $token
     *
     * @return array
     */
    public static function payload($token)
    {
        if (null === $token || trim($token) === '') {
            throw new JoseJwtException('Incoming token expected to be in compact serialization form, but is empty');
        }

        $parts = explode('.', $token);
        if (count($parts) != 3) {
            throw new JoseJwtException('Invalid JWT');
        }

        $payload = json_decode(UrlSafeB64Encoder::decode($parts[1]), true);
        if (null == $payload) {
            throw new JoseJwtException('Invalid payload');
        }

        return $payload;
    }
}


1		<?php
2
3		/*
4		* This file is part of the tmilos/jose-jwt package.
5		*
6		* (c) Milos Tomic <[email protected]>
7		*
8		* This source file is subject to the MIT license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		namespace Tmilos\JoseJwt;
13
14		use Tmilos\JoseJwt\Context\Context;
15		use Tmilos\JoseJwt\Error\IntegrityException;
16		use Tmilos\JoseJwt\Error\JoseJwtException;
17		use Tmilos\JoseJwt\Util\StringUtils;
18		use Tmilos\JoseJwt\Util\UrlSafeB64Encoder;
19
20		class Jwt
21		{
22		private function __construct()
23		{
24		}
25
26		/**
27		* @param Context $context
28		* @param array\|object $payload
29		* @param string\|resource $key
30		* @param string $jwsAlgorithm
31		* @param array $extraHeaders
32		*
33		* @return string
34		*/
35		public static function encode(Context $context, $payload, $key, $jwsAlgorithm, $extraHeaders = [])
36		{
37		$header = array_merge([
38		'alg' => '',
39		'typ' => 'JWT',
40		], $extraHeaders);
41
42		$hashAlgorithm = $context->jwsAlgorithms()->get($jwsAlgorithm);
43		if (null == $hashAlgorithm) {
44		throw new JoseJwtException(sprintf('Unknown algorithm "%s"', $jwsAlgorithm));
45		}
46
47		$header['alg'] = $jwsAlgorithm;
48
49		$payloadString = StringUtils::payload2string($payload, $context->jsonMapper());
50
51		$signingInput = implode('.', [
52		UrlSafeB64Encoder::encode(json_encode($header)),
53		UrlSafeB64Encoder::encode($payloadString),
54		]);
55
56		$signature = $hashAlgorithm->sign($signingInput, $key);
57		$signature = UrlSafeB64Encoder::encode($signature);
58
59		return $signingInput.'.'.$signature;
60		}
61
62		/**
63		* @param Context $context
64		* @param string $token
65		* @param string\|resource $key
66		*
67		* @return array
68		*/
69		public static function decode(Context $context, $token, $key)
70		{
71		if (empty($token) \|\| trim($token) === '') {
72		throw new JoseJwtException('Incoming token expected to be in compact serialization form, but is empty');
73		}
74
75		$parts = explode('.', $token);
76		if (count($parts) == 5) {
77		return Jwe::decode($context, $token, $key);
		0 ignored issues – show Bug Best Practice introduced 2017-01-26 09:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return \Tmilos\JoseJwt\J...context, $token, $key);` (`string`) is incompatible with the return type documented by `Tmilos\JoseJwt\Jwt::decode` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
78		}
79
80		$decodedParts = [];
81		foreach ($parts as $part) {
82		$decodedParts[] = UrlSafeB64Encoder::decode($part);
83		}
84		$header = json_decode($decodedParts[0], true);
85		if (null == $header) {
86		throw new JoseJwtException('Invalid header');
87		}
88
89		// signed or plain JWT
90		$signedInput = $parts[0].'.'.$parts[1];
91		$algorithmId = $header['alg'];
92		$algorithm = $context->jwsAlgorithms()->get($algorithmId);
93		if (null === $algorithm) {
94		throw new JoseJwtException(sprintf('Invalid algorithm "%s"', $algorithmId));
95		}
96
97		if (false === $algorithm->verify($decodedParts[2], $signedInput, $key)) {
98		throw new IntegrityException('Invalid signature');
99		}
100
101		return json_decode($decodedParts[1], true);
102		}
103
104		/**
105		* @param $token
106		*
107		* @return array
108		*/
109	View Code Duplication	public static function header($token)
110		{
111		if (null === $token \|\| trim($token) === '') {
112		throw new JoseJwtException('Incoming token expected to be in compact serialization form, but is empty');
113		}
114
115		$parts = explode('.', $token);
116		if (count($parts) != 3 && count($parts) != 5) {
117		throw new JoseJwtException('Invalid JWT');
118		}
119
120		$header = json_decode(UrlSafeB64Encoder::decode($parts[0]), true);
121		if (null == $header) {
122		throw new JoseJwtException('Invalid header');
123		}
124
125		return $header;
126		}
127
128		/**
129		* @param $token
130		*
131		* @return array
132		*/
133	View Code Duplication	public static function payload($token)
134		{
135		if (null === $token \|\| trim($token) === '') {
136		throw new JoseJwtException('Incoming token expected to be in compact serialization form, but is empty');
137		}
138
139		$parts = explode('.', $token);
140		if (count($parts) != 3) {
141		throw new JoseJwtException('Invalid JWT');
142		}
143
144		$payload = json_decode(UrlSafeB64Encoder::decode($parts[1]), true);
145		if (null == $payload) {
146		throw new JoseJwtException('Invalid payload');
147		}
148
149		return $payload;
150		}
151		}
152

tmilos / jose-jwt

Issues (25)

Security Analysis no request data

src/Jwt.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like