tmilos / jose-jwt

src/Jwe/RsaAlgorithm.php

<?php

/*
 * This file is part of the tmilos/jose-jwt package.
 *
 * (c) Milos Tomic <tmilos@gmail.com>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Tmilos\JoseJwt\Jwe;

use Tmilos\JoseJwt\Error\JoseJwtException;
use Tmilos\JoseJwt\Random\RandomGenerator;

class RsaAlgorithm implements JweAlgorithm
{
    /** @var int */
    private $padding;

    /** @var RandomGenerator */
    private $randomGenerator;

    /**
     * @param int             $padding
     * @param RandomGenerator $randomGenerator
     */
    public function __construct($padding, RandomGenerator $randomGenerator)
    {
        $this->padding = $padding;
        $this->randomGenerator = $randomGenerator;
    }

    /**
     * @param int             $cekSizeBits
     * @param string|resource $kek
     * @param array           $header
     *
     * @return array [cek, encryptedCek]
     */
    public function wrapNewKey($cekSizeBits, $kek, array $header)
    {
        $cek = $this->randomGenerator->get($cekSizeBits / 8);
        if (false == openssl_public_encrypt($cek, $cekEncrypted, $kek, $this->padding)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            throw new JoseJwtException('Unable to encrypt CEK');
        }

        return [$cek, $cekEncrypted];
    }

    /**
     * @param string          $encryptedCek
     * @param string|resource $key
     * @param int             $cekSizeBits
     * @param array           $header
     *
     * @return string
     */
    public function unwrap($encryptedCek, $key, $cekSizeBits, array $header)
    {
        if (false == openssl_private_decrypt($encryptedCek, $cek, $key, $this->padding)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            throw new JoseJwtException('Unable to decrypt CEK');
        }

        return $cek;
    }
}