Tkotosz\CommandScheduler\Model\CommandScheduleProcessor::processNext()

Complexity

Conditions	6
Paths	27

Size

Total Lines	42
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

<?php
    public function processNext(): string
    {
        $schedule = $this->commandScheduleRepository->getOneByStatus('pending');

        if ($schedule === null) {
            return 'no pending schedule';
        }

        try {
            $this->commandScheduleRepository->updateStatus($schedule, 'running');

            $command = $this->commandProvider->getByName($schedule->getCommandName());

It seems like $schedule->getCommandName() can also be of type null; however, parameter $name of Tkotosz\CommandScheduler\Model\CommandProvider::getByName() does only seem to accept string, maybe add an additional type check?

            if ($command === null) {
                throw new \Exception(sprintf('Invalid command: "%s"', $schedule->getCommandName()));
            }

            if (!empty($schedule->getCommandParams())) {
                if ($command->getApplication() !== null) {
                    $input = new StringInput($schedule->getCommandName() . ' ' . $schedule->getCommandParams());
                } else {
                    $input = new StringInput($schedule->getCommandParams());
                }
            } else {
                $input = new ArrayInput([]);
            }
            $output = new BufferedOutput();

            $command->run($input, $output);
            $result = $output->fetch();

            $this->commandScheduleRepository->updateStatus($schedule, 'done');
            $this->commandScheduleRepository->updateResult($schedule, $result);

            return $result;
        } catch (\Exception $e) {
            $this->logger->critical($e);

            $this->commandScheduleRepository->updateStatus($schedule, 'failed');
            $this->commandScheduleRepository->updateResult($schedule, $e->getMessage());

            return $e->getMessage();
        }