Issues in XML.php (develop) - Issues in develop - timw4mail/HummingBirdAnimeClient - Measure and Improve Code Quality continuously with Scrutinizer

Issues (287)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/API/XML.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php declare(strict_types=1);
/**
 * Anime List Client
 *
 * An API client for Kitsu and MyAnimeList to manage anime and manga watch lists
 *
 * PHP version 7
 *
 * @package     AnimeListClient
 * @author      Timothy J. Warren <[email protected]>
 * @copyright   2015 - 2017  Timothy J. Warren
 * @license     http://www.opensource.org/licenses/mit-license.html  MIT License
 * @version     4.0
 * @link        https://github.com/timw4mail/HummingBirdAnimeClient
 */

namespace Aviat\AnimeClient\API;

use DOMDocument, DOMNode, DOMNodelist;

/**
 * XML <=> PHP Array codec
 */
class XML {

	/**
	 * XML representation of the data
	 *
	 * @var string
	 */
	private $xml;

	/**
	 * PHP array version of the data
	 *
	 * @var array
	 */
	private $data;

	/**
	 * XML constructor
	 */
	public function __construct(string $xml = '', array $data = [])
	{
		$this->setXML($xml)->setData($data);
	}

	/**
	 * Serialize the data to an xml string
	 */
	public function __toString(): string
	{
		return static::toXML($this->getData());
	}

	/**
	 * Get the data parsed from the XML
	 *
	 * @return array
	 */
	public function getData(): array
	{
		return $this->data;
	}

	/**
	 * Set the data to create xml from
	 *
	 * @param array $data
	 * @return $this
	 */
	public function setData(array $data): self
	{
		$this->data = $data;
		return $this;
	}

	/**
	 * Get the xml created from the data
	 *
	 * @return string
	 */
	public function getXML(): string
	{
		return $this->xml;
	}

	/**
	 * Set the xml to parse the data from
	 *
	 * @param string $xml
	 * @return $this
	 */
	public function setXML(string $xml): self
	{
		$this->xml = $xml;
		return $this;
	}

	/**
	 * Parse an xml document string to a php array
	 *
	 * @param string $xml
	 * @return array
	 */
	public static function toArray(string $xml): array
	{
		$data = [];

		$xml = static::stripXMLWhitespace($xml);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}

		$dom = new DOMDocument();
		$dom->loadXML($xml);
		$root = $dom->documentElement;

		$data[$root->tagName] = [];

		if ($root->hasChildNodes())
		{
			static::childNodesToArray($data[$root->tagName], $root->childNodes);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
		}

		return $data;
	}

	/**
	 * Transform the array into XML
	 *
	 * @param array $data
	 * @return string
	 */
	public static function toXML(array $data): string
	{
		$dom = new DOMDocument();
		$dom->encoding = 'UTF-8';

		static::arrayPropertiesToXmlNodes($dom, $dom, $data);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}

		return $dom->saveXML();
	}

	/**
	 * Parse the xml document string to a php array
	 *
	 * @return array
	 */
	public function parse(): array
	{
		$xml = $this->getXML();
		$data = static::toArray($xml);
		return $this->setData($data)->getData();
	}

	/**
	 * Transform the array into XML
	 *
	 * @return string
	 */
	public function createXML(): string
	{
		return static::toXML($this->getData());
	}

	private static function stripXMLWhitespace(string $xml): string
	{
		// Get rid of unimportant text nodes by removing
		// whitespace characters from between xml tags,
		// except for the xml declaration tag, Which looks
		// something like:
		/* <?xml version="1.0" encoding="UTF-8"?> */
		return preg_replace('/([^\?])>\s+</', '$1><', $xml);
	}

	/**
	 * Recursively create array structure based on xml structure
	 *
	 * @param array &$root A reference to the current array location
	 * @param DOMNodeList $nodeList The current NodeList object

	 * @return void
	 */
	private static function childNodesToArray(array &$root, DOMNodelist $nodeList)
	{
		$length = $nodeList->length;
		for ($i = 0; $i < $length; $i++)
		{
			$el = $nodeList->item($i);
			$current =& $root[$el->nodeName];

			// It's a top level element!
			if (is_a($el->childNodes->item(0), 'DomText') || ( ! $el->hasChildNodes()))
			{
				$current = $el->textContent;
				continue;
			}

			// An empty value at the current root
			if (is_null($current))
			{
				$current = [];
				static::childNodesToArray($current, $el->childNodes);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
				continue;
			}

			$keys = array_keys($current);

			// Wrap the array in a containing array
			// if there are only string keys
			if ( ! is_numeric($keys[0]))
			{
				// But if there is only one key, don't wrap it in
				// an array, just recurse to parse the child nodes
				if (count($current) === 1)
				{
					static::childNodesToArray($current, $el->childNodes);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
					continue;
				}
				$current = [$current];
			}

			array_push($current, []);
			$index = count($current) - 1;

			static::childNodesToArray($current[$index], $el->childNodes);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
		}
	}

	/**
	 * Recursively create xml nodes from array properties
	 *
	 * @param DOMDocument $dom The current DOM object
	 * @param DOMNode $parent The parent element to append children to
	 * @param array $data The data for the current node
	 * @return void
	 */
	private static function arrayPropertiesToXmlNodes(DOMDocument &$dom, DOMNode &$parent, array $data)
	{
		foreach($data as $key => $props)
		{
			// 'Flatten' the array as you create the xml
			if (is_numeric($key))
			{
				foreach($props as $key => $props)
				{
					break;
				}
			}

			$node = $dom->createElement($key);

			if (is_array($props))
			{
				static::arrayPropertiesToXmlNodes($dom, $node, $props);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
			}
			else
			{
				$tNode = $dom->createTextNode((string)$props);
				$node->appendChild($tNode);
			}

			$parent->appendChild($node);
		}
	}
}

1			<?php declare(strict_types=1);
2			/**
3			* Anime List Client
4			*
5			* An API client for Kitsu and MyAnimeList to manage anime and manga watch lists
6			*
7			* PHP version 7
8			*
9			* @package AnimeListClient
10			* @author Timothy J. Warren <[email protected]>
11			* @copyright 2015 - 2017 Timothy J. Warren
12			* @license http://www.opensource.org/licenses/mit-license.html MIT License
13			* @version 4.0
14			* @link https://github.com/timw4mail/HummingBirdAnimeClient
15			*/
16
17			namespace Aviat\AnimeClient\API;
18
19			use DOMDocument, DOMNode, DOMNodelist;
20
21			/**
22			* XML <=> PHP Array codec
23			*/
24			class XML {
25
26			/**
27			* XML representation of the data
28			*
29			* @var string
30			*/
31			private $xml;
32
33			/**
34			* PHP array version of the data
35			*
36			* @var array
37			*/
38			private $data;
39
40			/**
41			* XML constructor
42			*/
43			public function __construct(string $xml = '', array $data = [])
44			{
45			$this->setXML($xml)->setData($data);
46			}
47
48			/**
49			* Serialize the data to an xml string
50			*/
51			public function __toString(): string
52			{
53			return static::toXML($this->getData());
54			}
55
56			/**
57			* Get the data parsed from the XML
58			*
59			* @return array
60			*/
61			public function getData(): array
62			{
63			return $this->data;
64			}
65
66			/**
67			* Set the data to create xml from
68			*
69			* @param array $data
70			* @return $this
71			*/
72			public function setData(array $data): self
73			{
74			$this->data = $data;
75			return $this;
76			}
77
78			/**
79			* Get the xml created from the data
80			*
81			* @return string
82			*/
83			public function getXML(): string
84			{
85			return $this->xml;
86			}
87
88			/**
89			* Set the xml to parse the data from
90			*
91			* @param string $xml
92			* @return $this
93			*/
94			public function setXML(string $xml): self
95			{
96			$this->xml = $xml;
97			return $this;
98			}
99
100			/**
101			* Parse an xml document string to a php array
102			*
103			* @param string $xml
104			* @return array
105			*/
106			public static function toArray(string $xml): array
107			{
108			$data = [];
109
110			$xml = static::stripXMLWhitespace($xml);
			0 ignored issues – show Bug introduced 2017-02-07 02:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `stripXMLWhitespace()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `stripXMLWhitespace()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
111
112			$dom = new DOMDocument();
113			$dom->loadXML($xml);
114			$root = $dom->documentElement;
115
116			$data[$root->tagName] = [];
117
118			if ($root->hasChildNodes())
119			{
120			static::childNodesToArray($data[$root->tagName], $root->childNodes);
			0 ignored issues – show Bug introduced 2017-02-07 02:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `childNodesToArray()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `childNodesToArray()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
121			}
122
123			return $data;
124			}
125
126			/**
127			* Transform the array into XML
128			*
129			* @param array $data
130			* @return string
131			*/
132			public static function toXML(array $data): string
133			{
134			$dom = new DOMDocument();
135			$dom->encoding = 'UTF-8';
136
137			static::arrayPropertiesToXmlNodes($dom, $dom, $data);
			0 ignored issues – show Bug introduced 2017-02-07 02:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `arrayPropertiesToXmlNodes()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `arrayPropertiesToXmlNodes()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
138
139			return $dom->saveXML();
140			}
141
142			/**
143			* Parse the xml document string to a php array
144			*
145			* @return array
146			*/
147			public function parse(): array
148			{
149			$xml = $this->getXML();
150			$data = static::toArray($xml);
151			return $this->setData($data)->getData();
152			}
153
154			/**
155			* Transform the array into XML
156			*
157			* @return string
158			*/
159			public function createXML(): string
160			{
161			return static::toXML($this->getData());
162			}
163
164			private static function stripXMLWhitespace(string $xml): string
165			{
166			// Get rid of unimportant text nodes by removing
167			// whitespace characters from between xml tags,
168			// except for the xml declaration tag, Which looks
169			// something like:
170			/* <?xml version="1.0" encoding="UTF-8"?> */
171			return preg_replace('/([^\?])>\s+</', '$1><', $xml);
172			}
173
174			/**
175			* Recursively create array structure based on xml structure
176			*
177			* @param array &$root A reference to the current array location
178			* @param DOMNodeList $nodeList The current NodeList object
			0 ignored issues – show Documentation introduced 2017-02-07 02:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$nodeList` not be `\DOMNodeList`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
179			* @return void
180			*/
181			private static function childNodesToArray(array &$root, DOMNodelist $nodeList)
182			{
183			$length = $nodeList->length;
184			for ($i = 0; $i < $length; $i++)
185			{
186			$el = $nodeList->item($i);
187			$current =& $root[$el->nodeName];
188
189			// It's a top level element!
190			if (is_a($el->childNodes->item(0), 'DomText') \|\| ( ! $el->hasChildNodes()))
191			{
192			$current = $el->textContent;
193			continue;
194			}
195
196			// An empty value at the current root
197			if (is_null($current))
198			{
199			$current = [];
200			static::childNodesToArray($current, $el->childNodes);
			0 ignored issues – show Bug introduced 2017-02-07 02:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `childNodesToArray()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `childNodesToArray()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
201			continue;
202			}
203
204			$keys = array_keys($current);
205
206			// Wrap the array in a containing array
207			// if there are only string keys
208			if ( ! is_numeric($keys[0]))
209			{
210			// But if there is only one key, don't wrap it in
211			// an array, just recurse to parse the child nodes
212			if (count($current) === 1)
213			{
214			static::childNodesToArray($current, $el->childNodes);
			0 ignored issues – show Bug introduced 2017-02-07 02:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `childNodesToArray()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `childNodesToArray()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
215			continue;
216			}
217			$current = [$current];
218			}
219
220			array_push($current, []);
221			$index = count($current) - 1;
222
223			static::childNodesToArray($current[$index], $el->childNodes);
			0 ignored issues – show Bug introduced 2017-02-07 02:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `childNodesToArray()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `childNodesToArray()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
224			}
225			}
226
227			/**
228			* Recursively create xml nodes from array properties
229			*
230			* @param DOMDocument $dom The current DOM object
231			* @param DOMNode $parent The parent element to append children to
232			* @param array $data The data for the current node
233			* @return void
234			*/
235			private static function arrayPropertiesToXmlNodes(DOMDocument &$dom, DOMNode &$parent, array $data)
236			{
237			foreach($data as $key => $props)
238			{
239			// 'Flatten' the array as you create the xml
240			if (is_numeric($key))
241			{
242			foreach($props as $key => $props)
243			{
244			break;
245			}
246			}
247
248			$node = $dom->createElement($key);
249
250			if (is_array($props))
251			{
252			static::arrayPropertiesToXmlNodes($dom, $node, $props);
			0 ignored issues – show Bug introduced 2017-02-07 02:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `arrayPropertiesToXmlNodes()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `arrayPropertiesToXmlNodes()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
253			}
254			else
255			{
256			$tNode = $dom->createTextNode((string)$props);
257			$node->appendChild($tNode);
258			}
259
260			$parent->appendChild($node);
261			}
262			}
263			}

timw4mail / HummingBirdAnimeClient

Issues (287)

Security Analysis not enabled

src/API/XML.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like