timw4mail / HummingBirdAnimeClient

build/CodeIgniter/Sniffs/WhiteSpace/LogicalNotSpacingSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return string[]
      */
     public function register()
     {

Indentation +31 added lines, -31 removed lines

@@ -33,41 +33,41 @@
 class LogicalNotSpacingSniff implements Sniff
 {
 
-    /**
-     * Returns an array of tokens this test wants to listen for.
-     *
-     * @return array
-     */
-    public function register()
-    {
-        return array(
-            T_BOOLEAN_NOT,
-        );
-    }//end register()
+	/**
+	 * Returns an array of tokens this test wants to listen for.
+	 *
+	 * @return array
+	 */
+	public function register()
+	{
+		return array(
+			T_BOOLEAN_NOT,
+		);
+	}//end register()
 
 
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param File $phpcsFile The current file being scanned.
-     * @param int                  $stackPtr  The position of the current token
-     *                                        in the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $tokens = $phpcsFile->getTokens();
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param File $phpcsFile The current file being scanned.
+	 * @param int                  $stackPtr  The position of the current token
+	 *                                        in the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		$tokens = $phpcsFile->getTokens();
 
-        $operator_token = $tokens[$stackPtr];
+		$operator_token = $tokens[$stackPtr];
 
-        $previous_token = $tokens[$stackPtr - 1];
-        $next_token = $tokens[$stackPtr + 1];
-        if (T_WHITESPACE !== $previous_token['code'] || T_WHITESPACE !== $next_token['code']) {
-            $error = 'Logical operator ! should always be preceded and followed with a whitespace.';
-            $phpcsFile->addError($error, $stackPtr);
-        }
-    }//end process()
+		$previous_token = $tokens[$stackPtr - 1];
+		$next_token = $tokens[$stackPtr + 1];
+		if (T_WHITESPACE !== $previous_token['code'] || T_WHITESPACE !== $next_token['code']) {
+			$error = 'Logical operator ! should always be preceded and followed with a whitespace.';
+			$phpcsFile->addError($error, $stackPtr);
+		}
+	}//end process()
 
 
 }//end class

Braces +3 added lines, -3 removed lines

@@ -30,8 +30,7 @@ 
 use PHP_CodeSniffer\Sniffs\Sniff;
 use PHP_CodeSniffer\Files\File;
 
-class LogicalNotSpacingSniff implements Sniff
-{
+class LogicalNotSpacingSniff implements Sniff {
 
     /**
      * Returns an array of tokens this test wants to listen for.
@@ -63,7 +62,8 @@ 
 
         $previous_token = $tokens[$stackPtr - 1];
         $next_token = $tokens[$stackPtr + 1];
-        if (T_WHITESPACE !== $previous_token['code'] || T_WHITESPACE !== $next_token['code']) {
+        if (T_WHITESPACE !== $previous_token['code'] || T_WHITESPACE !== $next_token['code'])
+        {
             $error = 'Logical operator ! should always be preceded and followed with a whitespace.';
             $phpcsFile->addError($error, $stackPtr);
         }

build/CodeIgniter/UnusedSniffs/Files/ClosingFileCommentSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {

Indentation +59 added lines, -59 removed lines

@@ -39,71 +39,71 @@
 class ClosingFileCommentSniff extends AbstractClosingCommentSniff
 {
 
-    /**
-     * Returns an array of tokens this test wants to listen for.
-     *
-     * @return array
-     */
-    public function register()
-    {
-        return array(
-            T_OPEN_TAG,
-        );
+	/**
+	 * Returns an array of tokens this test wants to listen for.
+	 *
+	 * @return array
+	 */
+	public function register()
+	{
+		return array(
+			T_OPEN_TAG,
+		);
 
-    }//end register()
+	}//end register()
 
 
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param File $phpcsFile The current file being scanned.
-     * @param int                  $stackPtr  The position of the current token
-     *                                        in the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        // We are only interested if this is the first open tag.
-        if ($stackPtr !== 0) {
-            if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false) {
-                return;
-            }
-        }
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param File $phpcsFile The current file being scanned.
+	 * @param int                  $stackPtr  The position of the current token
+	 *                                        in the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		// We are only interested if this is the first open tag.
+		if ($stackPtr !== 0) {
+			if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false) {
+				return;
+			}
+		}
 
-        $fullFilename = $phpcsFile->getFilename();
-        $filename = basename($fullFilename);
-        $commentTemplate = "End of file $filename";
+		$fullFilename = $phpcsFile->getFilename();
+		$filename = basename($fullFilename);
+		$commentTemplate = "End of file $filename";
 
-        $tokens = $phpcsFile->getTokens();
-        $currentToken = count($tokens) - 1;
-        $hasClosingFileComment = false;
-        $isNotAWhitespaceOrAComment = false;
-        while ($currentToken >= 0
-            && ! $isNotAWhitespaceOrAComment
-            && ! $hasClosingFileComment
-        ) {
-            $token = $tokens[$currentToken];
-            $tokenCode = $token['code'];
-            if (T_COMMENT === $tokenCode) {
-                $commentString = self::_getCommentContent($token['content']);
-                if (0 === strcmp($commentString, $commentTemplate)) {
-                    $hasClosingFileComment = true;
-                }
-            } else if (T_WHITESPACE === $tokenCode) {
-                // Whitespaces are allowed between the closing file comment,
-                // other comments and end of file
-            } else {
-                $isNotAWhitespaceOrAComment = true;
-            }
-            $currentToken--;
-        }
+		$tokens = $phpcsFile->getTokens();
+		$currentToken = count($tokens) - 1;
+		$hasClosingFileComment = false;
+		$isNotAWhitespaceOrAComment = false;
+		while ($currentToken >= 0
+			&& ! $isNotAWhitespaceOrAComment
+			&& ! $hasClosingFileComment
+		) {
+			$token = $tokens[$currentToken];
+			$tokenCode = $token['code'];
+			if (T_COMMENT === $tokenCode) {
+				$commentString = self::_getCommentContent($token['content']);
+				if (0 === strcmp($commentString, $commentTemplate)) {
+					$hasClosingFileComment = true;
+				}
+			} else if (T_WHITESPACE === $tokenCode) {
+				// Whitespaces are allowed between the closing file comment,
+				// other comments and end of file
+			} else {
+				$isNotAWhitespaceOrAComment = true;
+			}
+			$currentToken--;
+		}
 
-        if ( ! $hasClosingFileComment) {
-            $error = 'No comment block marks the end of file instead of the closing PHP tag. Please add a comment block containing only "' . $commentTemplate . '".';
-            $phpcsFile->addError($error, $currentToken);
-        }
-    }//end process()
+		if ( ! $hasClosingFileComment) {
+			$error = 'No comment block marks the end of file instead of the closing PHP tag. Please add a comment block containing only "' . $commentTemplate . '".';
+			$phpcsFile->addError($error, $currentToken);
+		}
+	}//end process()
 }//end class
 
 ?>

Braces +17 added lines, -9 removed lines

@@ -36,8 +36,7 @@ 
 
 use PHP_CodeSniffer\Files\File;
 
-class ClosingFileCommentSniff extends AbstractClosingCommentSniff
-{
+class ClosingFileCommentSniff extends AbstractClosingCommentSniff {
 
     /**
      * Returns an array of tokens this test wants to listen for.
@@ -65,8 +64,10 @@ 
     public function process(File $phpcsFile, $stackPtr)
     {
         // We are only interested if this is the first open tag.
-        if ($stackPtr !== 0) {
-            if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false) {
+        if ($stackPtr !== 0)
+        {
+            if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false)
+            {
                 return;
             }
         }
@@ -85,21 +86,28 @@ 
         ) {
             $token = $tokens[$currentToken];
             $tokenCode = $token['code'];
-            if (T_COMMENT === $tokenCode) {
+            if (T_COMMENT === $tokenCode)
+            {
                 $commentString = self::_getCommentContent($token['content']);
-                if (0 === strcmp($commentString, $commentTemplate)) {
+                if (0 === strcmp($commentString, $commentTemplate))
+                {
                     $hasClosingFileComment = true;
                 }
-            } else if (T_WHITESPACE === $tokenCode) {
+            }
+            else if (T_WHITESPACE === $tokenCode)
+            {
                 // Whitespaces are allowed between the closing file comment,
                 // other comments and end of file
-            } else {
+            }
+            else
+            {
                 $isNotAWhitespaceOrAComment = true;
             }
             $currentToken--;
         }
 
-        if ( ! $hasClosingFileComment) {
+        if ( ! $hasClosingFileComment)
+        {
             $error = 'No comment block marks the end of file instead of the closing PHP tag. Please add a comment block containing only "' . $commentTemplate . '".';
             $phpcsFile->addError($error, $currentToken);
         }

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -66,7 +66,7 @@ 
     {
         // We are only interested if this is the first open tag.
         if ($stackPtr !== 0) {
-            if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false) {
+            if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== FALSE) {
                 return;
             }
         }
@@ -77,8 +77,8 @@ 
 
         $tokens = $phpcsFile->getTokens();
         $currentToken = count($tokens) - 1;
-        $hasClosingFileComment = false;
-        $isNotAWhitespaceOrAComment = false;
+        $hasClosingFileComment = FALSE;
+        $isNotAWhitespaceOrAComment = FALSE;
         while ($currentToken >= 0
             && ! $isNotAWhitespaceOrAComment
             && ! $hasClosingFileComment
@@ -88,13 +88,13 @@ 
             if (T_COMMENT === $tokenCode) {
                 $commentString = self::_getCommentContent($token['content']);
                 if (0 === strcmp($commentString, $commentTemplate)) {
-                    $hasClosingFileComment = true;
+                    $hasClosingFileComment = TRUE;
                 }
             } else if (T_WHITESPACE === $tokenCode) {
                 // Whitespaces are allowed between the closing file comment,
                 // other comments and end of file
             } else {
-                $isNotAWhitespaceOrAComment = true;
+                $isNotAWhitespaceOrAComment = TRUE;
             }
             $currentToken--;
         }

build/CodeIgniter/UnusedSniffs/Files/ClosingLocationCommentSniff.php

Doc Comments +2 added lines, -2 removed lines

@@ -50,7 +50,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {
@@ -134,7 +134,7 @@ 
      * application root. Parent directory of the application root are allowed
      * but not mandatory.
      *
-     * @return string|bool The relative path from $appRoot to $filePath, or
+     * @return false|string The relative path from $appRoot to $filePath, or
      * false if $appRoot cannot be found in $filePath.
      */
     private static function _getLocationPath ($filePath, $appRoot)

Indentation +132 added lines, -132 removed lines

@@ -45,138 +45,138 @@
 
 class ClosingLocationCommentSniff extends AbstractClosingCommentSniff
 {
-    public $applicationRoot = '/application/';
-
-    /**
-     * Returns an array of tokens this test wants to listen for.
-     *
-     * @return array
-     */
-    public function register()
-    {
-        return array(
-            T_OPEN_TAG
-        );
-
-    }//end register()
-
-
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param File $phpcsFile The current file being scanned.
-     * @param int                  $stackPtr  The position of the current token
-     *                                        in the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        // We are only interested if this is the first open tag.
-        if ($stackPtr !== 0) {
-            if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false) {
-                return;
-            }
-        }
-
-        $filePath = $phpcsFile->getFilename();
-        $tokens = $phpcsFile->getTokens();
-        // removes the application root from the beginning of the file path
-        $locationPath = self::_getLocationPath($filePath, $this->_getAppRoot());
-        // add an error, if application root doesn't exist in current file path
-        if (false === $locationPath) {
-            $error = 'Unable to find "' . $this->_getAppRoot() . '" in file path "' . $filePath . '". Please set your project\'s application root.';
-            $phpcsFile->addError($error, count($tokens) - 1);
-            return;
-        }
-        // generates the expected comment
-        $commentTemplate = "Location: $locationPath";
-
-        $currentToken = count($tokens) - 1;
-        $hasClosingLocationComment = false;
-        $isNotAWhitespaceOrAComment = false;
-        while ($currentToken >= 0
-            && ! $isNotAWhitespaceOrAComment
-            && ! $hasClosingLocationComment
-        ) {
-            $token = $tokens[$currentToken];
-            $tokenCode = $token['code'];
-            if (T_COMMENT === $tokenCode) {
-                $commentString = self::_getCommentContent($token['content']);
-                if (0 === strcmp($commentString, $commentTemplate)) {
-                    $hasClosingLocationComment = true;
-                }
-            } else if (T_WHITESPACE === $tokenCode) {
-                // Whitespaces are allowed between the closing file comment,
-                //other comments and end of file
-            } else {
-                $isNotAWhitespaceOrAComment = true;
-            }
-            $currentToken--;
-        }
-
-        if ( ! $hasClosingLocationComment) {
-            $error = 'No comment block marks the end of file instead of the closing PHP tag. Please add a comment block containing only "' . $commentTemplate . '".';
-            $phpcsFile->addError($error, $currentToken);
-        }
-    }//end process()
-
-
-    /**
-     * Returns the relative path from $appRoot to $filePath, or false if
-     * $appRoot cannot be found in $filePath, because $appRoot is not a parent
-     * of $filePath.
-     *
-     * @param string $filePath Full path to the file being proceed.
-     * @param string $appRoot  Partial or full path to the CodeIgniter
-     * application root of the file being proceed. It must not contain the
-     * full path to the application root, but at least the name of the
-     * application root. Parent directory of the application root are allowed
-     * but not mandatory.
-     *
-     * @return string|bool The relative path from $appRoot to $filePath, or
-     * false if $appRoot cannot be found in $filePath.
-     */
-    private static function _getLocationPath ($filePath, $appRoot)
-    {
-        // removes the path to application root
-        // from the beginning of the file path
-        $appRootAt = strpos($filePath, $appRoot);
-        if (false === $appRootAt) {
-            return false;
-        }
-        $localPath = substr($filePath, $appRootAt + strlen($appRoot));
-        // ensures the location path to be a relative path starting with "./".
-        if ( ! self::_stringStartsWith($localPath, './')) {
-            $localPath = './' . $localPath;
-        } else if ( ! self::_stringStartsWith($localPath, '.')
-            && self::_stringStartsWith($localPath, '/')
-        ) {
-            $localPath = '.' . $localPath;
-        }
-        return $localPath;
-    }//end _getLocationPath()
-
-
-    /**
-     * Returns the application root that should be used first.
-     *
-     * There are several ways to configure the application root.
-     * In order of priority :
-     *   - Configuration variable ci_application_root.
-     *   - Rule property applicationRoot.
-     *   - Default value '/application/'
-     *
-     * @return string Path to your project application root.
-     */
-    private function _getAppRoot()
-    {
-        $appRoot = Common::getConfigData('ci_application_root');
-        if (null === $appRoot) {
-            $appRoot = $this->applicationRoot;
-        }
-        return $appRoot;
-    }//end _getAppRoot()
+	public $applicationRoot = '/application/';
+
+	/**
+	 * Returns an array of tokens this test wants to listen for.
+	 *
+	 * @return array
+	 */
+	public function register()
+	{
+		return array(
+			T_OPEN_TAG
+		);
+
+	}//end register()
+
+
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param File $phpcsFile The current file being scanned.
+	 * @param int                  $stackPtr  The position of the current token
+	 *                                        in the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		// We are only interested if this is the first open tag.
+		if ($stackPtr !== 0) {
+			if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false) {
+				return;
+			}
+		}
+
+		$filePath = $phpcsFile->getFilename();
+		$tokens = $phpcsFile->getTokens();
+		// removes the application root from the beginning of the file path
+		$locationPath = self::_getLocationPath($filePath, $this->_getAppRoot());
+		// add an error, if application root doesn't exist in current file path
+		if (false === $locationPath) {
+			$error = 'Unable to find "' . $this->_getAppRoot() . '" in file path "' . $filePath . '". Please set your project\'s application root.';
+			$phpcsFile->addError($error, count($tokens) - 1);
+			return;
+		}
+		// generates the expected comment
+		$commentTemplate = "Location: $locationPath";
+
+		$currentToken = count($tokens) - 1;
+		$hasClosingLocationComment = false;
+		$isNotAWhitespaceOrAComment = false;
+		while ($currentToken >= 0
+			&& ! $isNotAWhitespaceOrAComment
+			&& ! $hasClosingLocationComment
+		) {
+			$token = $tokens[$currentToken];
+			$tokenCode = $token['code'];
+			if (T_COMMENT === $tokenCode) {
+				$commentString = self::_getCommentContent($token['content']);
+				if (0 === strcmp($commentString, $commentTemplate)) {
+					$hasClosingLocationComment = true;
+				}
+			} else if (T_WHITESPACE === $tokenCode) {
+				// Whitespaces are allowed between the closing file comment,
+				//other comments and end of file
+			} else {
+				$isNotAWhitespaceOrAComment = true;
+			}
+			$currentToken--;
+		}
+
+		if ( ! $hasClosingLocationComment) {
+			$error = 'No comment block marks the end of file instead of the closing PHP tag. Please add a comment block containing only "' . $commentTemplate . '".';
+			$phpcsFile->addError($error, $currentToken);
+		}
+	}//end process()
+
+
+	/**
+	 * Returns the relative path from $appRoot to $filePath, or false if
+	 * $appRoot cannot be found in $filePath, because $appRoot is not a parent
+	 * of $filePath.
+	 *
+	 * @param string $filePath Full path to the file being proceed.
+	 * @param string $appRoot  Partial or full path to the CodeIgniter
+	 * application root of the file being proceed. It must not contain the
+	 * full path to the application root, but at least the name of the
+	 * application root. Parent directory of the application root are allowed
+	 * but not mandatory.
+	 *
+	 * @return string|bool The relative path from $appRoot to $filePath, or
+	 * false if $appRoot cannot be found in $filePath.
+	 */
+	private static function _getLocationPath ($filePath, $appRoot)
+	{
+		// removes the path to application root
+		// from the beginning of the file path
+		$appRootAt = strpos($filePath, $appRoot);
+		if (false === $appRootAt) {
+			return false;
+		}
+		$localPath = substr($filePath, $appRootAt + strlen($appRoot));
+		// ensures the location path to be a relative path starting with "./".
+		if ( ! self::_stringStartsWith($localPath, './')) {
+			$localPath = './' . $localPath;
+		} else if ( ! self::_stringStartsWith($localPath, '.')
+			&& self::_stringStartsWith($localPath, '/')
+		) {
+			$localPath = '.' . $localPath;
+		}
+		return $localPath;
+	}//end _getLocationPath()
+
+
+	/**
+	 * Returns the application root that should be used first.
+	 *
+	 * There are several ways to configure the application root.
+	 * In order of priority :
+	 *   - Configuration variable ci_application_root.
+	 *   - Rule property applicationRoot.
+	 *   - Default value '/application/'
+	 *
+	 * @return string Path to your project application root.
+	 */
+	private function _getAppRoot()
+	{
+		$appRoot = Common::getConfigData('ci_application_root');
+		if (null === $appRoot) {
+			$appRoot = $this->applicationRoot;
+		}
+		return $appRoot;
+	}//end _getAppRoot()
 }//end class
 
 ?>

Spacing +1 added lines, -1 removed lines

@@ -137,7 +137,7 @@
      * @return string|bool The relative path from $appRoot to $filePath, or
      * false if $appRoot cannot be found in $filePath.
      */
-    private static function _getLocationPath ($filePath, $appRoot)
+    private static function _getLocationPath($filePath, $appRoot)
     {
         // removes the path to application root
         // from the beginning of the file path

Braces +27 added lines, -14 removed lines

@@ -43,8 +43,7 @@ 
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Util\Common;
 
-class ClosingLocationCommentSniff extends AbstractClosingCommentSniff
-{
+class ClosingLocationCommentSniff extends AbstractClosingCommentSniff {
     public $applicationRoot = '/application/';
 
     /**
@@ -73,8 +72,10 @@ 
     public function process(File $phpcsFile, $stackPtr)
     {
         // We are only interested if this is the first open tag.
-        if ($stackPtr !== 0) {
-            if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false) {
+        if ($stackPtr !== 0)
+        {
+            if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false)
+            {
                 return;
             }
         }
@@ -84,7 +85,8 @@ 
         // removes the application root from the beginning of the file path
         $locationPath = self::_getLocationPath($filePath, $this->_getAppRoot());
         // add an error, if application root doesn't exist in current file path
-        if (false === $locationPath) {
+        if (false === $locationPath)
+        {
             $error = 'Unable to find "' . $this->_getAppRoot() . '" in file path "' . $filePath . '". Please set your project\'s application root.';
             $phpcsFile->addError($error, count($tokens) - 1);
             return;
@@ -101,21 +103,28 @@ 
         ) {
             $token = $tokens[$currentToken];
             $tokenCode = $token['code'];
-            if (T_COMMENT === $tokenCode) {
+            if (T_COMMENT === $tokenCode)
+            {
                 $commentString = self::_getCommentContent($token['content']);
-                if (0 === strcmp($commentString, $commentTemplate)) {
+                if (0 === strcmp($commentString, $commentTemplate))
+                {
                     $hasClosingLocationComment = true;
                 }
-            } else if (T_WHITESPACE === $tokenCode) {
+            }
+            else if (T_WHITESPACE === $tokenCode)
+            {
                 // Whitespaces are allowed between the closing file comment,
                 //other comments and end of file
-            } else {
+            }
+            else
+            {
                 $isNotAWhitespaceOrAComment = true;
             }
             $currentToken--;
         }
 
-        if ( ! $hasClosingLocationComment) {
+        if ( ! $hasClosingLocationComment)
+        {
             $error = 'No comment block marks the end of file instead of the closing PHP tag. Please add a comment block containing only "' . $commentTemplate . '".';
             $phpcsFile->addError($error, $currentToken);
         }
@@ -142,14 +151,17 @@ 
         // removes the path to application root
         // from the beginning of the file path
         $appRootAt = strpos($filePath, $appRoot);
-        if (false === $appRootAt) {
+        if (false === $appRootAt)
+        {
             return false;
         }
         $localPath = substr($filePath, $appRootAt + strlen($appRoot));
         // ensures the location path to be a relative path starting with "./".
-        if ( ! self::_stringStartsWith($localPath, './')) {
+        if ( ! self::_stringStartsWith($localPath, './'))
+        {
             $localPath = './' . $localPath;
-        } else if ( ! self::_stringStartsWith($localPath, '.')
+        }
+        else if ( ! self::_stringStartsWith($localPath, '.')
             && self::_stringStartsWith($localPath, '/')
         ) {
             $localPath = '.' . $localPath;
@@ -172,7 +184,8 @@ 
     private function _getAppRoot()
     {
         $appRoot = Common::getConfigData('ci_application_root');
-        if (null === $appRoot) {
+        if (null === $appRoot)
+        {
             $appRoot = $this->applicationRoot;
         }
         return $appRoot;

Upper-Lower-Casing +9 added lines, -9 removed lines

@@ -74,7 +74,7 @@ 
     {
         // We are only interested if this is the first open tag.
         if ($stackPtr !== 0) {
-            if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false) {
+            if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== FALSE) {
                 return;
             }
         }
@@ -84,7 +84,7 @@ 
         // removes the application root from the beginning of the file path
         $locationPath = self::_getLocationPath($filePath, $this->_getAppRoot());
         // add an error, if application root doesn't exist in current file path
-        if (false === $locationPath) {
+        if (FALSE === $locationPath) {
             $error = 'Unable to find "' . $this->_getAppRoot() . '" in file path "' . $filePath . '". Please set your project\'s application root.';
             $phpcsFile->addError($error, count($tokens) - 1);
             return;
@@ -93,8 +93,8 @@ 
         $commentTemplate = "Location: $locationPath";
 
         $currentToken = count($tokens) - 1;
-        $hasClosingLocationComment = false;
-        $isNotAWhitespaceOrAComment = false;
+        $hasClosingLocationComment = FALSE;
+        $isNotAWhitespaceOrAComment = FALSE;
         while ($currentToken >= 0
             && ! $isNotAWhitespaceOrAComment
             && ! $hasClosingLocationComment
@@ -104,13 +104,13 @@ 
             if (T_COMMENT === $tokenCode) {
                 $commentString = self::_getCommentContent($token['content']);
                 if (0 === strcmp($commentString, $commentTemplate)) {
-                    $hasClosingLocationComment = true;
+                    $hasClosingLocationComment = TRUE;
                 }
             } else if (T_WHITESPACE === $tokenCode) {
                 // Whitespaces are allowed between the closing file comment,
                 //other comments and end of file
             } else {
-                $isNotAWhitespaceOrAComment = true;
+                $isNotAWhitespaceOrAComment = TRUE;
             }
             $currentToken--;
         }
@@ -142,8 +142,8 @@ 
         // removes the path to application root
         // from the beginning of the file path
         $appRootAt = strpos($filePath, $appRoot);
-        if (false === $appRootAt) {
-            return false;
+        if (FALSE === $appRootAt) {
+            return FALSE;
         }
         $localPath = substr($filePath, $appRootAt + strlen($appRoot));
         // ensures the location path to be a relative path starting with "./".
@@ -172,7 +172,7 @@ 
     private function _getAppRoot()
     {
         $appRoot = Common::getConfigData('ci_application_root');
-        if (null === $appRoot) {
+        if (NULL === $appRoot) {
             $appRoot = $this->applicationRoot;
         }
         return $appRoot;

build/CodeIgniter/UnusedSniffs/NamingConventions/ValidClassNameSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {

Indentation +37 added lines, -37 removed lines

@@ -39,45 +39,45 @@
 {
 
 
-    /**
-     * Returns an array of tokens this test wants to listen for.
-     *
-     * @return array
-     */
-    public function register()
-    {
-        return array(
-            T_CLASS,
-            T_INTERFACE,
-        );
+	/**
+	 * Returns an array of tokens this test wants to listen for.
+	 *
+	 * @return array
+	 */
+	public function register()
+	{
+		return array(
+			T_CLASS,
+			T_INTERFACE,
+		);
 
-    }//end register()
+	}//end register()
 
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param File $phpcsFile The current file being processed.
-     * @param int                  $stackPtr  The position of the current token
-     *                                        in the stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        // get the class name
-        $className = trim($phpcsFile->getDeclarationName($stackPtr));
-        // compute the expected class name
-        // [^_] means "something different from _", but not "nothing or something different from _"
-        $lcClassNameChunk = preg_replace('/([^_])([A-Z])/', '${1}_${2}', $className);
-        $expectedClassName
-            = strtoupper($className[0]) . strtolower(substr($lcClassNameChunk,1));
-        // ensures that the current class name
-        // and the expected class name are identical
-        if (0 !== strcmp($className, $expectedClassName)) {
-            $error =  'Class names should always have their first letter uppercase. Multiple words should be separated with an underscore, and not CamelCased. Please consider ' . $expectedClassName . ' instead of ' . $className . '.';
-            $phpcsFile->addError($error, $stackPtr);
-        }
-    }//end process()
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param File $phpcsFile The current file being processed.
+	 * @param int                  $stackPtr  The position of the current token
+	 *                                        in the stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		// get the class name
+		$className = trim($phpcsFile->getDeclarationName($stackPtr));
+		// compute the expected class name
+		// [^_] means "something different from _", but not "nothing or something different from _"
+		$lcClassNameChunk = preg_replace('/([^_])([A-Z])/', '${1}_${2}', $className);
+		$expectedClassName
+			= strtoupper($className[0]) . strtolower(substr($lcClassNameChunk,1));
+		// ensures that the current class name
+		// and the expected class name are identical
+		if (0 !== strcmp($className, $expectedClassName)) {
+			$error =  'Class names should always have their first letter uppercase. Multiple words should be separated with an underscore, and not CamelCased. Please consider ' . $expectedClassName . ' instead of ' . $className . '.';
+			$phpcsFile->addError($error, $stackPtr);
+		}
+	}//end process()
 
 }//end class
 

Spacing +2 added lines, -2 removed lines

@@ -70,11 +70,11 @@
         // [^_] means "something different from _", but not "nothing or something different from _"
         $lcClassNameChunk = preg_replace('/([^_])([A-Z])/', '${1}_${2}', $className);
         $expectedClassName
-            = strtoupper($className[0]) . strtolower(substr($lcClassNameChunk,1));
+            = strtoupper($className[0]) . strtolower(substr($lcClassNameChunk, 1));
         // ensures that the current class name
         // and the expected class name are identical
         if (0 !== strcmp($className, $expectedClassName)) {
-            $error =  'Class names should always have their first letter uppercase. Multiple words should be separated with an underscore, and not CamelCased. Please consider ' . $expectedClassName . ' instead of ' . $className . '.';
+            $error = 'Class names should always have their first letter uppercase. Multiple words should be separated with an underscore, and not CamelCased. Please consider ' . $expectedClassName . ' instead of ' . $className . '.';
             $phpcsFile->addError($error, $stackPtr);
         }
     }//end process()

Braces +3 added lines, -3 removed lines

@@ -35,8 +35,7 @@ 
 use PHP_CodeSniffer\Sniffs\Sniff;
 use PHP_CodeSniffer\Files\File;
 
-class ValidClassNameSniff implements Sniff
-{
+class ValidClassNameSniff implements Sniff {
 
 
     /**
@@ -73,7 +72,8 @@ 
             = strtoupper($className[0]) . strtolower(substr($lcClassNameChunk,1));
         // ensures that the current class name
         // and the expected class name are identical
-        if (0 !== strcmp($className, $expectedClassName)) {
+        if (0 !== strcmp($className, $expectedClassName))
+        {
             $error =  'Class names should always have their first letter uppercase. Multiple words should be separated with an underscore, and not CamelCased. Please consider ' . $expectedClassName . ' instead of ' . $className . '.';
             $phpcsFile->addError($error, $stackPtr);
         }

build/CodeIgniter/UnusedSniffs/NamingConventions/ValidFileNameSniff.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {

Indentation +44 added lines, -44 removed lines

@@ -32,53 +32,53 @@
 
 class ValidFileNameSniff implements Sniff
 {
-    /**
-     * Returns an array of tokens this test wants to listen for.
-     *
-     * @return array
-     */
-    public function register()
-    {
-        return array(
-            T_CLASS,
-            T_INTERFACE,
-        );
-    }//end register()
+	/**
+	 * Returns an array of tokens this test wants to listen for.
+	 *
+	 * @return array
+	 */
+	public function register()
+	{
+		return array(
+			T_CLASS,
+			T_INTERFACE,
+		);
+	}//end register()
 
 
-    /**
-     * Processes this test, when one of its tokens is encountered.
-     *
-     * @param File $phpcsFile The file being scanned.
-     * @param int                  $stackPtr  The position of the current token in the
-     *                                        stack passed in $tokens.
-     *
-     * @return void
-     */
-    public function process(File $phpcsFile, $stackPtr)
-    {
-        $tokens = $phpcsFile->getTokens();
-        // computes the expected filename based on the name of the class or interface that it contains.
-        $decNamePtr = $phpcsFile->findNext(T_STRING, $stackPtr);
-        $decName = $tokens[$decNamePtr]['content'];
-        $expectedFileName = strtolower($decName);
-        // extracts filename without extension from its path.
-        $fullPath = $phpcsFile->getFilename();
-        $fileNameAndExt = basename($fullPath);
-        $fileName = substr($fileNameAndExt, 0, strrpos($fileNameAndExt, '.'));
+	/**
+	 * Processes this test, when one of its tokens is encountered.
+	 *
+	 * @param File $phpcsFile The file being scanned.
+	 * @param int                  $stackPtr  The position of the current token in the
+	 *                                        stack passed in $tokens.
+	 *
+	 * @return void
+	 */
+	public function process(File $phpcsFile, $stackPtr)
+	{
+		$tokens = $phpcsFile->getTokens();
+		// computes the expected filename based on the name of the class or interface that it contains.
+		$decNamePtr = $phpcsFile->findNext(T_STRING, $stackPtr);
+		$decName = $tokens[$decNamePtr]['content'];
+		$expectedFileName = strtolower($decName);
+		// extracts filename without extension from its path.
+		$fullPath = $phpcsFile->getFilename();
+		$fileNameAndExt = basename($fullPath);
+		$fileName = substr($fileNameAndExt, 0, strrpos($fileNameAndExt, '.'));
 
-        if ($expectedFileName !== $fileName) {
-            $errorTemplate = 'Filename "%s" doesn\'t match the name of the %s that it contains "%s" in lower case. "%s" was expected.';
-            $errorMessage = sprintf(
-                $errorTemplate,
-                $fileName,
-                strtolower($tokens[$stackPtr]['content']), // class or interface
-                $decName,
-                $expectedFileName
-            );
-            $phpcsFile->addError($errorMessage, 0);
-        }
-    }//end process()
+		if ($expectedFileName !== $fileName) {
+			$errorTemplate = 'Filename "%s" doesn\'t match the name of the %s that it contains "%s" in lower case. "%s" was expected.';
+			$errorMessage = sprintf(
+				$errorTemplate,
+				$fileName,
+				strtolower($tokens[$stackPtr]['content']), // class or interface
+				$decName,
+				$expectedFileName
+			);
+			$phpcsFile->addError($errorMessage, 0);
+		}
+	}//end process()
 }//end class
 
 ?>

Braces +3 added lines, -3 removed lines

@@ -30,8 +30,7 @@ 
 use PHP_CodeSniffer\Sniffs\Sniff;
 use PHP_CodeSniffer\Files\File;
 
-class ValidFileNameSniff implements Sniff
-{
+class ValidFileNameSniff implements Sniff {
     /**
      * Returns an array of tokens this test wants to listen for.
      *
@@ -67,7 +66,8 @@ 
         $fileNameAndExt = basename($fullPath);
         $fileName = substr($fileNameAndExt, 0, strrpos($fileNameAndExt, '.'));
 
-        if ($expectedFileName !== $fileName) {
+        if ($expectedFileName !== $fileName)
+        {
             $errorTemplate = 'Filename "%s" doesn\'t match the name of the %s that it contains "%s" in lower case. "%s" was expected.';
             $errorMessage = sprintf(
                 $errorTemplate,

RoboFile.php

Doc Comments +5 added lines, -1 removed lines

@@ -2,6 +2,10 @@ 
 if ( ! function_exists('glob_recursive'))
 {
 	// Does not support flag GLOB_BRACE
+
+	/**
+	 * @param string $pattern
+	 */
 	function glob_recursive($pattern, $flags = 0)
 	{
 		$files = glob($pattern, $flags);
@@ -320,7 +324,7 @@ 
 	 * Shortcut for joining an array of command arguments
 	 * and then running it
 	 *
-	 * @param array $cmd_parts - command arguments
+	 * @param string[] $cmd_parts - command arguments
 	 * @param string $join_on - what to join the command arguments with
 	 */
 	protected function _run(array $cmd_parts, $join_on = ' ')

Spacing +8 added lines, -8 removed lines

@@ -6,9 +6,9 @@ 
 	{
 		$files = glob($pattern, $flags);
 
-		foreach (glob(dirname($pattern).'/*', GLOB_ONLYDIR|GLOB_NOSORT) as $dir)
+		foreach (glob(dirname($pattern) . '/*', GLOB_ONLYDIR | GLOB_NOSORT) as $dir)
 		{
-			$files = array_merge($files, glob_recursive($dir.'/'.basename($pattern), $flags));
+			$files = array_merge($files, glob_recursive($dir . '/' . basename($pattern), $flags));
 		}
 
 		return $files;
@@ -80,13 +80,13 @@ 
 			'build/humbug.json',
 			'build/humbug-log.txt',
 		];
-		array_map(function ($file) {
+		array_map(function($file) {
 			@unlink($file);
 		}, $cleanFiles);
 
 		// So the task doesn't complain,
 		// make any 'missing' dirs to cleanup
-		array_map(function ($dir) {
+		array_map(function($dir) {
 			if ( ! is_dir($dir))
 			{
 				`mkdir -p {$dir}`;
@@ -130,7 +130,7 @@ 
 
 		$chunks = array_chunk($files, 6);
 
-		foreach($chunks as $chunk)
+		foreach ($chunks as $chunk)
 		{
 			$this->parallelLint($chunk);
 		}
@@ -241,10 +241,10 @@ 
 			->monitor('composer.json', function() {
 				$this->taskComposerUpdate()->run();
 			})
-			->monitor('src', function () {
+			->monitor('src', function() {
 				$this->taskExec('test')->run();
 			})
-			->monitor('tests', function () {
+			->monitor('tests', function() {
 				$this->taskExec('test')->run();
 			})
 			->run();
@@ -295,7 +295,7 @@ 
 			->timeout(5)
 			->printed(FALSE);
 
-		foreach($chunk as $file)
+		foreach ($chunk as $file)
 		{
 			$task = $task->process("php -l {$file}");
 		}

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -104,7 +104,7 @@ 
 	{
 		$this->taskPhpUnit()
 			->configFile('build/phpunit.xml')
-			->printed(true)
+			->printed(TRUE)
 			->run();
 	}
 
@@ -228,7 +228,7 @@ 
 		$this->lint();
 		$this->taskPHPUnit()
 			->configFile('phpunit.xml')
-			->printed(true)
+			->printed(TRUE)
 			->run();
 	}
 

src/API/CacheTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
 	/**
 	 * Generate a hash as a cache key from the current method call
 	 *
-	 * @param object $object
+	 * @param Kitsu\Model $object
 	 * @param string $method
 	 * @param array  $args
 	 * @return string

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 /**
  * Anime List Client
  *

src/API/Kitsu/Auth.php

Doc Comments +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 	/**
 	 * Constructor
 	 *
-	 * @param ContainerInterface $container
+	 * @param \Aviat\Ion\Di\ContainerInterface $container
 	 */
 	public function __construct(ContainerInterface $container)
 	{

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 /**
  * Anime List Client
  *

src/API/MAL/MALTrait.php

Doc Comments +2 added lines, -2 removed lines

@@ -50,7 +50,7 @@ 
 	 * This is a dirty hack until I can fully track down where
 	 * the dual-encoding happens
 	 *
-	 * @param FormBody $formBody The form builder object to fix
+	 * @param \Amp\Artax\FormBody $formBody The form builder object to fix
 	 * @return string
 	 */
 	private function fixBody(FormBody $formBody): string
@@ -157,7 +157,7 @@ 
 	/**
 	 * Remove some boilerplate for get requests
 	 *
-	 * @param array $args
+	 * @param string $args
 	 * @return array
 	 */
 	protected function getRequest(...$args): array

Spacing +6 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 /**
  * Anime List Client
  *
@@ -82,9 +82,9 @@ 
 		$config = $this->container->get('config');
 		$logger = $this->container->getLogger('mal_request');
 
-		$headers = array_merge($this->defaultHeaders, $options['headers'] ?? [],  [
+		$headers = array_merge($this->defaultHeaders, $options['headers'] ?? [], [
 			'Authorization' =>  'Basic ' .
-				base64_encode($config->get(['mal','username']) . ':' .$config->get(['mal','password']))
+				base64_encode($config->get(['mal', 'username']) . ':' . $config->get(['mal', 'password']))
 		]);
 
 		$query = $options['query'] ?? [];
@@ -143,7 +143,7 @@ 
 
 		$response = $this->getResponse($type, $url, $options);
 
-		if ((int) $response->getStatus() > 299 || (int) $response->getStatus() < 200)
+		if ((int)$response->getStatus() > 299 || (int)$response->getStatus() < 200)
 		{
 			if ($logger)
 			{
@@ -151,7 +151,7 @@ 
 			}
 		}
 
-		return XML::toArray((string) $response->getBody());
+		return XML::toArray((string)$response->getBody());
 	}
 
 	/**
@@ -182,7 +182,7 @@ 
 		$response = $this->getResponse('POST', ...$args);
 		$validResponseCodes = [200, 201];
 
-		if ( ! in_array((int) $response->getStatus(), $validResponseCodes))
+		if ( ! in_array((int)$response->getStatus(), $validResponseCodes))
 		{
 			if ($logger)
 			{

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -135,7 +135,7 @@ 
 	 */
 	private function request(string $type, string $url, array $options = []): array
 	{
-		$logger = null;
+		$logger = NULL;
 		if ($this->getContainer())
 		{
 			$logger = $this->container->getLogger('mal_request');
@@ -173,7 +173,7 @@ 
 	 */
 	protected function postRequest(...$args): array
 	{
-		$logger = null;
+		$logger = NULL;
 		if ($this->getContainer())
 		{
 			$logger = $this->container->getLogger('mal_request');