Inspection of "Minor spacing fixes" - timw4mail/HummingBirdAnimeClient - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 6555aa...f3a44e )

by Timothy

created 2016-02-03 02:38 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -69,7 +69,7 @@
 block discarded – undo
 		}
 		else
 		{
-			$pos =& $this->map->get($key);
+			$pos = & $this->map->get($key);
 			$pos = NULL;
 		}
 	}

Please login to merge, or discard this patch.

src/Aviat/AnimeClient/Hummingbird/Transformer/MangaListTransformer.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@
 block discarded – undo
 	 */
 	public function transform($item)
 	{
-		$manga =& $item['manga'];
+		$manga = & $item['manga'];
 
 		$rating = (is_numeric($item['rating']))
 			? intval(2 * $item['rating'])

Please login to merge, or discard this patch.

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * Hummingbird Anime Client
- *
- * An API client for Hummingbird to manage anime and manga watch lists
- *
- * @package     HummingbirdAnimeClient
- * @author      Timothy J. Warren
- * @copyright   Copyright (c) 2015 - 2016
- * @link        https://github.com/timw4mail/HummingBirdAnimeClient
- * @license     MIT
- */
+	 * Hummingbird Anime Client
+	 *
+	 * An API client for Hummingbird to manage anime and manga watch lists
+	 *
+	 * @package     HummingbirdAnimeClient
+	 * @author      Timothy J. Warren
+	 * @copyright   Copyright (c) 2015 - 2016
+	 * @link        https://github.com/timw4mail/HummingBirdAnimeClient
+	 * @license     MIT
+	 */
 
 namespace Aviat\AnimeClient\Auth;
 

Please login to merge, or discard this patch.

src/Aviat/Ion/Type/ArrayType.php 2 patches

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -73,7 +73,7 @@  discard block
 block discarded – undo
 	 */
 	public function __construct(array &$arr)
 	{
-		$this->arr =& $arr;
+		$this->arr = & $arr;
 	}
 
 	/**
@@ -176,13 +176,13 @@  discard block
 block discarded – undo
 		$value = NULL;
 		if (is_null($key))
 		{
-			$value =& $this->arr;
+			$value = & $this->arr;
 		}
 		else
 		{
 			if ($this->has_key($key))
 			{
-				$value =& $this->arr[$key];
+				$value = & $this->arr[$key];
 			}
 		}
 
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
 	 */
 	public function &get_deep_key(array $key)
 	{
-		$pos =& $this->arr;
+		$pos = & $this->arr;
 
 		foreach ($key as $level)
 		{
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
 				$pos = NULL;
 				return $pos;
 			}
-			$pos =& $pos[$level];
+			$pos = & $pos[$level];
 		}
 
 		return $pos;
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
 	 */
 	public function set_deep_key(array $key, $value)
 	{
-		$pos =& $this->arr;
+		$pos = & $this->arr;
 
 		// Iterate through the levels of the array,
 		// create the levels if they don't exist
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
 				$pos = [];
 				$pos[$level] = [];
 			}
-			$pos =& $pos[$level];
+			$pos = & $pos[$level];
 		}
 
 		$pos = $value;

Please login to merge, or discard this patch.

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -1,14 +1,14 @@
 block discarded – undo
 <?php
 /**
- * Ion
- *
- * Building blocks for web development
- *
- * @package     Ion
- * @author      Timothy J. Warren
- * @copyright   Copyright (c) 2015 - 2016
- * @license     MIT
- */
+	 * Ion
+	 *
+	 * Building blocks for web development
+	 *
+	 * @package     Ion
+	 * @author      Timothy J. Warren
+	 * @copyright   Copyright (c) 2015 - 2016
+	 * @license     MIT
+	 */
 
 namespace Aviat\Ion\Di\Exception;
 

Please login to merge, or discard this patch.

src/Aviat/AnimeClient/Hummingbird/Transformer/AnimeListTransformer.php 2 patches

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 	 */
 	public function transform($item)
 	{
-		$anime =& $item['anime'];
+		$anime = & $item['anime'];
 		$genres = $this->linearize_genres($item['anime']['genres']);
 
 		$rating = NULL;
@@ -82,10 +82,10 @@  discard block
 block discarded – undo
 			'id' => $item['id'],
 			'watching_status' => $item['status'],
 			'notes' => $item['notes'],
-			'rewatching' => (bool) $item['rewatching'],
+			'rewatching' => (bool)$item['rewatching'],
 			'rewatched' => $item['rewatched_times'],
 			'user_rating' => $rating,
-			'private' => (bool) $item['private'],
+			'private' => (bool)$item['private'],
 		];
 	}
 

Please login to merge, or discard this patch.

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * Hummingbird Anime Client
- *
- * An API client for Hummingbird to manage anime and manga watch lists
- *
- * @package     HummingbirdAnimeClient
- * @author      Timothy J. Warren
- * @copyright   Copyright (c) 2015 - 2016
- * @link        https://github.com/timw4mail/HummingBirdAnimeClient
- * @license     MIT
- */
+	 * Hummingbird Anime Client
+	 *
+	 * An API client for Hummingbird to manage anime and manga watch lists
+	 *
+	 * @package     HummingbirdAnimeClient
+	 * @author      Timothy J. Warren
+	 * @copyright   Copyright (c) 2015 - 2016
+	 * @link        https://github.com/timw4mail/HummingBirdAnimeClient
+	 * @license     MIT
+	 */
 
 namespace Aviat\AnimeClient\Auth;
 

Please login to merge, or discard this patch.

src/Aviat/AnimeClient/Controller/Manga.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -132,7 +132,7 @@
 block discarded – undo
 
 		if (array_key_exists('manga', $result))
 		{
-			$m =& $result['manga'][0];
+			$m = & $result['manga'][0];
 			$title = ( ! empty($m['english_title']))
 				? "{$m['romaji_title']} ({$m['english_title']})"
 				: "{$m['romaji_title']}";

Please login to merge, or discard this patch.

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * Hummingbird Anime Client
- *
- * An API client for Hummingbird to manage anime and manga watch lists
- *
- * @package     HummingbirdAnimeClient
- * @author      Timothy J. Warren
- * @copyright   Copyright (c) 2015 - 2016
- * @link        https://github.com/timw4mail/HummingBirdAnimeClient
- * @license     MIT
- */
+	 * Hummingbird Anime Client
+	 *
+	 * An API client for Hummingbird to manage anime and manga watch lists
+	 *
+	 * @package     HummingbirdAnimeClient
+	 * @author      Timothy J. Warren
+	 * @copyright   Copyright (c) 2015 - 2016
+	 * @link        https://github.com/timw4mail/HummingBirdAnimeClient
+	 * @license     MIT
+	 */
 
 namespace Aviat\AnimeClient\Auth;
 

Please login to merge, or discard this patch.

src/Aviat/Ion/Type/StringType.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -1,14 +1,14 @@
 block discarded – undo
 <?php
 /**
- * Ion
- *
- * Building blocks for web development
- *
- * @package     Ion
- * @author      Timothy J. Warren
- * @copyright   Copyright (c) 2015 - 2016
- * @license     MIT
- */
+	 * Ion
+	 *
+	 * Building blocks for web development
+	 *
+	 * @package     Ion
+	 * @author      Timothy J. Warren
+	 * @copyright   Copyright (c) 2015 - 2016
+	 * @license     MIT
+	 */
 
 namespace Aviat\Ion\Di\Exception;
 

Please login to merge, or discard this patch.

src/Aviat/Ion/ArrayWrapper.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -1,14 +1,14 @@
 block discarded – undo
 <?php
 /**
- * Ion
- *
- * Building blocks for web development
- *
- * @package     Ion
- * @author      Timothy J. Warren
- * @copyright   Copyright (c) 2015 - 2016
- * @license     MIT
- */
+	 * Ion
+	 *
+	 * Building blocks for web development
+	 *
+	 * @package     Ion
+	 * @author      Timothy J. Warren
+	 * @copyright   Copyright (c) 2015 - 2016
+	 * @license     MIT
+	 */
 
 namespace Aviat\Ion\Di\Exception;
 

Please login to merge, or discard this patch.

src/Aviat/Ion/Di/Container.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -1,14 +1,14 @@
 block discarded – undo
 <?php
 /**
- * Ion
- *
- * Building blocks for web development
- *
- * @package     Ion
- * @author      Timothy J. Warren
- * @copyright   Copyright (c) 2015 - 2016
- * @license     MIT
- */
+	 * Ion
+	 *
+	 * Building blocks for web development
+	 *
+	 * @package     Ion
+	 * @author      Timothy J. Warren
+	 * @copyright   Copyright (c) 2015 - 2016
+	 * @license     MIT
+	 */
 
 namespace Aviat\Ion\Di\Exception;
 

Please login to merge, or discard this patch.

src/Aviat/Ion/Di/ContainerAwareInterface.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -1,14 +1,14 @@
 block discarded – undo
 <?php
 /**
- * Ion
- *
- * Building blocks for web development
- *
- * @package     Ion
- * @author      Timothy J. Warren
- * @copyright   Copyright (c) 2015 - 2016
- * @license     MIT
- */
+	 * Ion
+	 *
+	 * Building blocks for web development
+	 *
+	 * @package     Ion
+	 * @author      Timothy J. Warren
+	 * @copyright   Copyright (c) 2015 - 2016
+	 * @license     MIT
+	 */
 
 namespace Aviat\Ion\Di\Exception;
 

Please login to merge, or discard this patch.

		@@ -73,7 +73,7 @@ discard block
		block discarded – undo
73	73	*/
74	74	public function __construct(array &$arr)
75	75	{
76		- $this->arr =& $arr;
	76	+ $this->arr = & $arr;
77	77	}
78	78
79	79	/**
		@@ -176,13 +176,13 @@ discard block
		block discarded – undo
176	176	$value = NULL;
177	177	if (is_null($key))
178	178	{
179		- $value =& $this->arr;
	179	+ $value = & $this->arr;
180	180	}
181	181	else
182	182	{
183	183	if ($this->has_key($key))
184	184	{
185		- $value =& $this->arr[$key];
	185	+ $value = & $this->arr[$key];
186	186	}
187	187	}
188	188
		@@ -210,7 +210,7 @@ discard block
		block discarded – undo
210	210	*/
211	211	public function &get_deep_key(array $key)
212	212	{
213		- $pos =& $this->arr;
	213	+ $pos = & $this->arr;
214	214
215	215	foreach ($key as $level)
216	216	{
		@@ -223,7 +223,7 @@ discard block
		block discarded – undo
223	223	$pos = NULL;
224	224	return $pos;
225	225	}
226		- $pos =& $pos[$level];
	226	+ $pos = & $pos[$level];
227	227	}
228	228
229	229	return $pos;
		@@ -239,7 +239,7 @@ discard block
		block discarded – undo
239	239	*/
240	240	public function set_deep_key(array $key, $value)
241	241	{
242		- $pos =& $this->arr;
	242	+ $pos = & $this->arr;
243	243
244	244	// Iterate through the levels of the array,
245	245	// create the levels if they don't exist
		@@ -250,7 +250,7 @@ discard block
		block discarded – undo
250	250	$pos = [];
251	251	$pos[$level] = [];
252	252	}
253		- $pos =& $pos[$level];
	253	+ $pos = & $pos[$level];
254	254	}
255	255
256	256	$pos = $value;

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29	*/
30	30	public function transform($item)
31	31	{
32		- $anime =& $item['anime'];
	32	+ $anime = & $item['anime'];
33	33	$genres = $this->linearize_genres($item['anime']['genres']);
34	34
35	35	$rating = NULL;
		@@ -82,10 +82,10 @@ discard block
		block discarded – undo
82	82	'id' => $item['id'],
83	83	'watching_status' => $item['status'],
84	84	'notes' => $item['notes'],
85		- 'rewatching' => (bool) $item['rewatching'],
	85	+ 'rewatching' => (bool)$item['rewatching'],
86	86	'rewatched' => $item['rewatched_times'],
87	87	'user_rating' => $rating,
88		- 'private' => (bool) $item['private'],
	88	+ 'private' => (bool)$item['private'],
89	89	];
90	90	}
91	91

		@@ -132,7 +132,7 @@
		block discarded – undo
132	132
133	133	if (array_key_exists('manga', $result))
134	134	{
135		- $m =& $result['manga'][0];
	135	+ $m = & $result['manga'][0];
136	136	$title = ( ! empty($m['english_title']))
137	137	? "{$m['romaji_title']} ({$m['english_title']})"
138	138	: "{$m['romaji_title']}";

		@@ -69,7 +69,7 @@
		block discarded – undo
69	69	}
70	70	else
71	71	{
72		- $pos =& $this->map->get($key);
	72	+ $pos = & $this->map->get($key);
73	73	$pos = NULL;
74	74	}
75	75	}

		@@ -28,7 +28,7 @@
		block discarded – undo
28	28	*/
29	29	public function transform($item)
30	30	{
31		- $manga =& $item['manga'];
	31	+ $manga = & $item['manga'];
32	32
33	33	$rating = (is_numeric($item['rating']))
34	34	? intval(2 * $item['rating'])

		@@ -1,15 +1,15 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Hummingbird Anime Client
4		- *
5		- * An API client for Hummingbird to manage anime and manga watch lists
6		- *
7		- * @package HummingbirdAnimeClient
8		- * @author Timothy J. Warren
9		- * @copyright Copyright (c) 2015 - 2016
10		- * @link https://github.com/timw4mail/HummingBirdAnimeClient
11		- * @license MIT
12		- */
	3	+ * Hummingbird Anime Client
	4	+ *
	5	+ * An API client for Hummingbird to manage anime and manga watch lists
	6	+ *
	7	+ * @package HummingbirdAnimeClient
	8	+ * @author Timothy J. Warren
	9	+ * @copyright Copyright (c) 2015 - 2016
	10	+ * @link https://github.com/timw4mail/HummingBirdAnimeClient
	11	+ * @license MIT
	12	+ */
13	13
14	14	namespace Aviat\AnimeClient\Auth;
15	15

		@@ -1,14 +1,14 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Ion
4		- *
5		- * Building blocks for web development
6		- *
7		- * @package Ion
8		- * @author Timothy J. Warren
9		- * @copyright Copyright (c) 2015 - 2016
10		- * @license MIT
11		- */
	3	+ * Ion
	4	+ *
	5	+ * Building blocks for web development
	6	+ *
	7	+ * @package Ion
	8	+ * @author Timothy J. Warren
	9	+ * @copyright Copyright (c) 2015 - 2016
	10	+ * @license MIT
	11	+ */
12	12
13	13	namespace Aviat\Ion\Di\Exception;
14	14

timw4mail / HummingBirdAnimeClient

Push — develop ( 6555aa...f3a44e )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch