AnimeListTransformer::transform() - Code Metrics - timw4mail/HummingBirdAnimeClient - Measure and Improve Code Quality continuously with Scrutinizer

AnimeListTransformer::transform() C
last analyzed 2017-02-13 19:31 UTC

↳ Parent: AnimeListTransformer

Complexity

Conditions	9
Paths	128

Size

Total Lines	67
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	46
nc	128
nop	1
dl	0
loc	67
rs	5.9
c	0
b	0
f	0

How to fix Long Method

<?php declare(strict_types=1);
/**
 * Anime List Client
 *
 * An API client for Kitsu and MyAnimeList to manage anime and manga watch lists
 *
 * PHP version 7
 *
 * @package     AnimeListClient
 * @author      Timothy J. Warren <[email protected]>
 * @copyright   2015 - 2017  Timothy J. Warren
 * @license     http://www.opensource.org/licenses/mit-license.html  MIT License
 * @version     4.0
 * @link        https://github.com/timw4mail/HummingBirdAnimeClient
 */

namespace Aviat\AnimeClient\API\Kitsu\Transformer;

use Aviat\AnimeClient\API\Kitsu;
use Aviat\Ion\Transformer\AbstractTransformer;

/**
 * Transformer for anime list
 */
class AnimeListTransformer extends AbstractTransformer {

	/**
	 * Convert raw api response to a more
	 * logical and workable structure
	 *
	 * @param  array  $item API library item
	 * @return array
	 */
	public function transform($item)
	{
/* ?><pre><?= json_encode($item, \JSON_PRETTY_PRINT) ?></pre><?php */
		$included = $item['included'];
		$animeId = $item['relationships']['media']['data']['id'];
		$anime = $included['anime'][$animeId];

		$genres = array_column($anime['relationships']['genres'], 'name') ?? [];
		sort($genres);
		
		$rating = (int) 2 * $item['attributes']['rating'];

		$total_episodes = array_key_exists('episodeCount', $anime) && (int) $anime['episodeCount'] !== 0
			? (int) $anime['episodeCount']
			: '-';
		
		$MALid = NULL;

		if (array_key_exists('mappings', $anime['relationships']))
		{
			foreach ($anime['relationships']['mappings'] as $mapping)
			{
				if ($mapping['externalSite'] === 'myanimelist/anime')
				{
					$MALid = $mapping['externalId'];
					break;
				}
			}
		}
		
		$streamingLinks = (array_key_exists('streamingLinks', $anime['relationships']))
			? Kitsu::parseListItemStreamingLinks($included, $animeId)
			: [];

		return [
			'id' => $item['id'],
			'mal_id' => $MALid,
			'episodes' => [
				'watched' => (int) $item['attributes']['progress'] !== '0'

					? (int) $item['attributes']['progress']
					: '-',
				'total' => $total_episodes,
				'length' => $anime['episodeLength'],
			],
			'airing' => [
				'status' => Kitsu::getAiringStatus($anime['startDate'], $anime['endDate']),
				'started' => $anime['startDate'],
				'ended' => $anime['endDate']
			],
			'anime' => [
				'age_rating' => $anime['ageRating'],
				'title' => $anime['canonicalTitle'],
				'titles' => Kitsu::filterTitles($anime),
				'slug' => $anime['slug'],
				'type' => $this->string($anime['showType'])->upperCaseFirst()->__toString(),
				'image' => $anime['posterImage']['small'],
				'genres' => $genres,
				'streaming_links' => $streamingLinks,
			],
			'watching_status' => $item['attributes']['status'],
			'notes' => $item['attributes']['notes'],
			'rewatching' => (bool) $item['attributes']['reconsuming'],
			'rewatched' => (int) $item['attributes']['reconsumeCount'],
			'user_rating' => ($rating === 0) ? '-' : (int) $rating,
			'private' => (bool) $item['attributes']['private'] ?? false,
		];
	}

	/**
	 * Convert transformed data to
	 * api response format
	 *
	 * @param array $item Transformed library item
	 * @return array API library item
	 */
	public function untransform($item)
	{
		$privacy = (array_key_exists('private', $item) && $item['private']);
		$rewatching = (array_key_exists('rewatching', $item) && $item['rewatching']);

		$untransformed = [
			'id' => $item['id'],
			'mal_id' => $item['mal_id'] ?? null,
			'data' => [
				'status' => $item['watching_status'],
				'reconsuming' => $rewatching,
				'reconsumeCount' => $item['rewatched'],
				'notes' => $item['notes'],
				'progress' => $item['episodes_watched'],
				'private' => $privacy
			]
		];
		
		if ( ! empty($item['user_rating']))
		{
			$untransformed['data']['rating'] = $item['user_rating'] / 2;
		}

		return $untransformed;
	}
}
// End of AnimeListTransformer.php

1			<?php declare(strict_types=1);
2			/**
3			* Anime List Client
4			*
5			* An API client for Kitsu and MyAnimeList to manage anime and manga watch lists
6			*
7			* PHP version 7
8			*
9			* @package AnimeListClient
10			* @author Timothy J. Warren <[email protected]>
11			* @copyright 2015 - 2017 Timothy J. Warren
12			* @license http://www.opensource.org/licenses/mit-license.html MIT License
13			* @version 4.0
14			* @link https://github.com/timw4mail/HummingBirdAnimeClient
15			*/
16
17			namespace Aviat\AnimeClient\API\Kitsu\Transformer;
18
19			use Aviat\AnimeClient\API\Kitsu;
20			use Aviat\Ion\Transformer\AbstractTransformer;
21
22			/**
23			* Transformer for anime list
24			*/
25			class AnimeListTransformer extends AbstractTransformer {
26
27			/**
28			* Convert raw api response to a more
29			* logical and workable structure
30			*
31			* @param array $item API library item
32			* @return array
33			*/
34			public function transform($item)
35			{
36			/* ?><pre><?= json_encode($item, \JSON_PRETTY_PRINT) ?></pre><?php */
37			$included = $item['included'];
38			$animeId = $item['relationships']['media']['data']['id'];
39			$anime = $included['anime'][$animeId];
40
41			$genres = array_column($anime['relationships']['genres'], 'name') ?? [];
42			sort($genres);
43
44			$rating = (int) 2 * $item['attributes']['rating'];
45
46			$total_episodes = array_key_exists('episodeCount', $anime) && (int) $anime['episodeCount'] !== 0
47			? (int) $anime['episodeCount']
48			: '-';
49
50			$MALid = NULL;
51
52			if (array_key_exists('mappings', $anime['relationships']))
53			{
54			foreach ($anime['relationships']['mappings'] as $mapping)
55			{
56			if ($mapping['externalSite'] === 'myanimelist/anime')
57			{
58			$MALid = $mapping['externalId'];
59			break;
60			}
61			}
62			}
63
64			$streamingLinks = (array_key_exists('streamingLinks', $anime['relationships']))
65			? Kitsu::parseListItemStreamingLinks($included, $animeId)
66			: [];
67
68			return [
69			'id' => $item['id'],
70			'mal_id' => $MALid,
71			'episodes' => [
72			'watched' => (int) $item['attributes']['progress'] !== '0'
			0 ignored issues – show Unused Code Bug introduced 2017-02-07 02:10 UTC by Report Bug Copy Issue Report The strict comparison `!==` seems to always evaluate to `true` as the types of `(int) $item['attributes']['progress']` (`integer`) and `'0'` (`string`) can never be identical. Maybe you want to use a loose comparison `!=` instead? Loading history...
73			? (int) $item['attributes']['progress']
74			: '-',
75			'total' => $total_episodes,
76			'length' => $anime['episodeLength'],
77			],
78			'airing' => [
79			'status' => Kitsu::getAiringStatus($anime['startDate'], $anime['endDate']),
80			'started' => $anime['startDate'],
81			'ended' => $anime['endDate']
82			],
83			'anime' => [
84			'age_rating' => $anime['ageRating'],
85			'title' => $anime['canonicalTitle'],
86			'titles' => Kitsu::filterTitles($anime),
87			'slug' => $anime['slug'],
88			'type' => $this->string($anime['showType'])->upperCaseFirst()->__toString(),
89			'image' => $anime['posterImage']['small'],
90			'genres' => $genres,
91			'streaming_links' => $streamingLinks,
92			],
93			'watching_status' => $item['attributes']['status'],
94			'notes' => $item['attributes']['notes'],
95			'rewatching' => (bool) $item['attributes']['reconsuming'],
96			'rewatched' => (int) $item['attributes']['reconsumeCount'],
97			'user_rating' => ($rating === 0) ? '-' : (int) $rating,
98			'private' => (bool) $item['attributes']['private'] ?? false,
99			];
100			}
101
102			/**
103			* Convert transformed data to
104			* api response format
105			*
106			* @param array $item Transformed library item
107			* @return array API library item
108			*/
109			public function untransform($item)
110			{
111			$privacy = (array_key_exists('private', $item) && $item['private']);
112			$rewatching = (array_key_exists('rewatching', $item) && $item['rewatching']);
113
114			$untransformed = [
115			'id' => $item['id'],
116			'mal_id' => $item['mal_id'] ?? null,
117			'data' => [
118			'status' => $item['watching_status'],
119			'reconsuming' => $rewatching,
120			'reconsumeCount' => $item['rewatched'],
121			'notes' => $item['notes'],
122			'progress' => $item['episodes_watched'],
123			'private' => $privacy
124			]
125			];
126
127			if ( ! empty($item['user_rating']))
128			{
129			$untransformed['data']['rating'] = $item['user_rating'] / 2;
130			}
131
132			return $untransformed;
133			}
134			}
135			// End of AnimeListTransformer.php

timw4mail / HummingBirdAnimeClient

AnimeListTransformer::transform() C last analyzed 2017-02-13 19:31 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

AnimeListTransformer::transform() C
last analyzed 2017-02-13 19:31 UTC