timohund / ext-solr

Classes/Search.php

Spacing +1 added lines, -1 removed lines

@@ -526,7 +526,7 @@
             $spellcheckingSuggestions = $suggestions;
 
             if (isset($this->response->spellcheck->collations)) {
-                $collections = (array) $this->response->spellcheck->collations;
+                $collections = (array)$this->response->spellcheck->collations;
                 $spellcheckingSuggestions['collation'] = $collections['collation'];
             }
         }

Classes/Domain/Search/ResultSet/SearchResultSetService.php

Spacing +3 added lines, -3 removed lines

@@ -286,7 +286,7 @@ 
      * @param Query $query The query that has been searched for.
      * @param \Apache_Solr_Response $response The search's response.
      */
-    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response &$response)
+    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response & $response)
     {
         if ($this->shouldHideResultsFromInitialSearch($rawQuery)) {
             // explicitly set number of results to 0 as we just wanted
@@ -314,7 +314,7 @@ 
      *
      * @param \Apache_Solr_Response $response
      */
-    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response &$response)
+    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response & $response)
     {
         if (!is_array($response->response->docs)) {
             return;
@@ -366,7 +366,7 @@ 
      * @param \Apache_Solr_Response $response
      * @throws \InvalidArgumentException
      */
-    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response &$response)
+    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response & $response)
     {
         if (!is_array($response->response->docs)) {
             return;

Classes/Domain/Search/SearchRequest.php

Spacing +3 added lines, -3 removed lines

@@ -154,7 +154,7 @@ 
         $activeFacets = $this->getActiveFacets();
         $facetNames = [];
 
-        array_map(function ($activeFacet) use (&$facetNames) {
+        array_map(function($activeFacet) use (&$facetNames) {
             $facetNames[] = substr($activeFacet, 0, strpos($activeFacet, ':'));
         }, $activeFacets);
 
@@ -171,7 +171,7 @@ 
         $values = [];
         $activeFacets = $this->getActiveFacets();
 
-        array_map(function ($activeFacet) use (&$values, $facetName) {
+        array_map(function($activeFacet) use (&$values, $facetName) {
             $parts = explode(':', $activeFacet, 2);
             if ($parts[0] === $facetName) {
                 $values[] = $parts[1];
@@ -273,7 +273,7 @@ 
     public function removeAllFacetValuesByName($facetName)
     {
         $facetValues = $this->getActiveFacets();
-        $facetValues = array_filter($facetValues, function ($facetValue) use ($facetName) {
+        $facetValues = array_filter($facetValues, function($facetValue) use ($facetName) {
             $parts = explode(':', $facetValue, 2);
             return $parts[0] !== $facetName;
         });

Classes/ContentObject/Relation.php

Spacing +1 added lines, -1 removed lines

@@ -370,7 +370,7 @@
             ));
 
             // restore
-            $this->configuration= $backupConfiguration;
+            $this->configuration = $backupConfiguration;
             $parentContentObject->data = $backupRecord;
         }
 

Classes/Query.php

Spacing +4 added lines, -4 removed lines

@@ -155,7 +155,7 @@ 
      */
     public function __construct($keywords, $solrConfiguration = null)
     {
-        $keywords = (string) $keywords;
+        $keywords = (string)$keywords;
         if ($solrConfiguration == null) {
             $this->solrConfiguration = Util::getSolrConfiguration();
         } else {
@@ -676,7 +676,7 @@ 
      */
     public function getGroupFields()
     {
-        return (array) $this->getQueryParameter('group.field', []);
+        return (array)$this->getQueryParameter('group.field', []);
     }
 
     /**
@@ -699,7 +699,7 @@ 
      */
     public function getGroupSortings()
     {
-        return (array) $this->getQueryParameter('group.sort', []);
+        return (array)$this->getQueryParameter('group.sort', []);
     }
 
     // faceting
@@ -725,7 +725,7 @@ 
      */
     public function getGroupQueries()
     {
-        return (array) $this->getQueryParameter('group.query', []);
+        return (array)$this->getQueryParameter('group.query', []);
     }
 
     /**

Doc Comments +3 added lines, -3 removed lines

@@ -193,7 +193,7 @@ 
      *
      * @param string $msg
      * @param int $severity
-     * @param mixed $dataVar
+     * @param string[] $dataVar
      */
     protected function writeDevLog($msg, $severity = 0, $dataVar = false)
     {
@@ -1003,7 +1003,7 @@ 
     /**
      * Sets the fields to return by a query.
      *
-     * @param array|string $fieldList an array or comma-separated list of field names
+     * @param string $fieldList an array or comma-separated list of field names
      * @throws \UnexpectedValueException on parameters other than comma-separated lists and arrays
      */
     public function setFieldList($fieldList = array('*', 'score'))
@@ -1079,7 +1079,7 @@ 
      *
      * This query supports the complete Lucene Query Language.
      *
-     * @param mixed $alternativeQuery String alternative query or boolean FALSE to disable / reset the q.alt parameter.
+     * @param string $alternativeQuery String alternative query or boolean FALSE to disable / reset the q.alt parameter.
      * @see http://wiki.apache.org/solr/DisMaxQParserPlugin#q.alt
      */
     public function setAlternativeQuery($alternativeQuery)

Classes/IndexQueue/PageIndexerRequest.php

Doc Comments +1 added lines, -1 removed lines

@@ -324,7 +324,7 @@
      * Sets a request's parameter and its value.
      *
      * @param string $parameter Parameter name
-     * @param mixed $value Parameter value.
+     * @param string $value Parameter value.
      */
     public function setParameter($parameter, $value)
     {

Classes/IndexQueue/Initializer/Page.php

Spacing +2 added lines, -2 removed lines

@@ -287,8 +287,8 @@
 
         $mountedPagesIdsWithQueueItems = [];
         foreach ($queueItemsOfExistingMountPoints as $id => $queueItemsOfExistingMountPoint) {
-            if (((int) $queueItemsOfExistingMountPoint['queueItemCount']) > 0) {
-                $mountedPagesIdsWithQueueItems[] = (int) $id;
+            if (((int)$queueItemsOfExistingMountPoint['queueItemCount']) > 0) {
+                $mountedPagesIdsWithQueueItems[] = (int)$id;
             }
         }
 

Classes/SolrService.php

Doc Comments +8 added lines, -8 removed lines

@@ -163,7 +163,7 @@ 
     /**
      * Returns the current time in milliseconds.
      *
-     * @return int
+     * @return double
      */
     protected function getMilliseconds()
     {
@@ -209,7 +209,7 @@ 
      *
      * Also does not report the time, see https://forge.typo3.org/issues/64551
      *
-     * @param float|int $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
+     * @param integer $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
      * @param boolean $useCache indicates if the ping result should be cached in the instance or not
      * @return bool TRUE if Solr can be reached, FALSE if not
      */
@@ -222,9 +222,9 @@ 
     /**
      * Call the /admin/ping servlet, can be used to get the runtime of a ping request.
      *
-     * @param float|int $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
+     * @param integer $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
      * @param boolean $useCache indicates if the ping result should be cached in the instance or not
-     * @return int runtime in milliseconds
+     * @return double runtime in milliseconds
      * @throws \ApacheSolrForTypo3\Solr\PingFailedException
      */
     public function getPingRoundTripRuntime($timeout = 2, $useCache = true)
@@ -633,7 +633,7 @@ 
      * a complete and well formed "delete" xml document
      *
      * @param string $rawPost Expected to be utf-8 encoded xml document
-     * @param float|int $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
+     * @param integer $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
      * @return \Apache_Solr_Response
      */
     public function delete($rawPost, $timeout = 3600)
@@ -730,7 +730,7 @@ 
     /**
      * Add list of synonyms for base word to managed synonyms map
      *
-     * @param $baseWord
+     * @param string $baseWord
      * @param array $synonyms
      *
      * @return \Apache_Solr_Response
@@ -751,7 +751,7 @@ 
     /**
      * Remove a synonym from the synonyms map
      *
-     * @param $baseWord
+     * @param string $baseWord
      * @return \Apache_Solr_Response
      * @throws \Apache_Solr_InvalidArgumentException
      */
@@ -767,7 +767,7 @@ 
     /**
      * Central method for making a HTTP DELETE operation against the Solr server
      *
-     * @param $url
+     * @param string $url
      * @param bool|float $timeout Read timeout in seconds
      * @return \Apache_Solr_Response
      */

Spacing +1 added lines, -1 removed lines

@@ -253,7 +253,7 @@
      */
     protected function performPingRequest($timeout = 2, $useCache = true)
     {
-        $cacheKey = (string) ($this);
+        $cacheKey = (string)($this);
         if ($useCache && isset(static::$pingCache[$cacheKey])) {
             return static::$pingCache[$cacheKey];
         }