Complex classes like Queue often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Queue, and based on these observations, apply Extract Interface, too.
| 1 | <?php  | 
            ||
| 45 | class Queue  | 
            ||
| 46 | { | 
            ||
| 47 | /**  | 
            ||
| 48 | * @var RootPageResolver  | 
            ||
| 49 | */  | 
            ||
| 50 | protected $rootPageResolver;  | 
            ||
| 51 | |||
| 52 | /**  | 
            ||
| 53 | * @var ConfigurationAwareRecordService  | 
            ||
| 54 | */  | 
            ||
| 55 | protected $recordService;  | 
            ||
| 56 | |||
| 57 | /**  | 
            ||
| 58 | * @var \ApacheSolrForTypo3\Solr\System\Logging\SolrLogManager  | 
            ||
| 59 | */  | 
            ||
| 60 | protected $logger = null;  | 
            ||
| 61 | |||
| 62 | /**  | 
            ||
| 63 | * @var QueueItemRepository  | 
            ||
| 64 | */  | 
            ||
| 65 | protected $queueItemRepository;  | 
            ||
| 66 | 102 | ||
| 67 | /**  | 
            ||
| 68 | 102 | * @var QueueStatisticsRepository  | 
            |
| 69 | 102 | */  | 
            |
| 70 | 102 | protected $queueStatisticsRepository;  | 
            |
| 71 | 102 | ||
| 72 | /**  | 
            ||
| 73 | * Queue constructor.  | 
            ||
| 74 | * @param RootPageResolver|null $rootPageResolver  | 
            ||
| 75 | * @param ConfigurationAwareRecordService|null $recordService  | 
            ||
| 76 | * @param QueueItemRepository|null $queueItemRepository  | 
            ||
| 77 | * @param QueueStatisticsRepository|null $queueStatisticsRepository  | 
            ||
| 78 | */  | 
            ||
| 79 | public function __construct(RootPageResolver $rootPageResolver = null, ConfigurationAwareRecordService $recordService = null, QueueItemRepository $queueItemRepository = null, QueueStatisticsRepository $queueStatisticsRepository = null)  | 
            ||
| 87 | 2 | ||
| 88 | // FIXME some of the methods should be renamed to plural forms  | 
            ||
| 89 | 2 | // FIXME singular form methods should deal with exactly one item only  | 
            |
| 90 | 1 | ||
| 91 | /**  | 
            ||
| 92 | * Returns the timestamp of the last indexing run.  | 
            ||
| 93 | 2 | *  | 
            |
| 94 | * @param int $rootPageId The root page uid for which to get  | 
            ||
| 95 | * the last indexed item id  | 
            ||
| 96 | * @return int Timestamp of last index run.  | 
            ||
| 97 | */  | 
            ||
| 98 | public function getLastIndexTime($rootPageId)  | 
            ||
| 110 | |||
| 111 | /**  | 
            ||
| 112 | 3 | * Returns the uid of the last indexed item in the queue  | 
            |
| 113 | *  | 
            ||
| 114 | * @param int $rootPageId The root page uid for which to get  | 
            ||
| 115 | * the last indexed item id  | 
            ||
| 116 | * @return int The last indexed item's ID.  | 
            ||
| 117 | */  | 
            ||
| 118 | public function getLastIndexedItemId($rootPageId)  | 
            ||
| 129 | 5 | ||
| 130 | /**  | 
            ||
| 131 | * Truncate and rebuild the tx_solr_indexqueue_item table. This is the most  | 
            ||
| 132 | 5 | * complete way to force reindexing, or to build the Index Queue for the  | 
            |
| 133 | 3 | * first time. The Index Queue initialization is site-specific.  | 
            |
| 134 | *  | 
            ||
| 135 | * @param Site $site The site to initialize  | 
            ||
| 136 | 2 | * @param string $indexingConfigurationName Name of a specific  | 
            |
| 137 | * indexing configuration  | 
            ||
| 138 | * @return array An array of booleans, each representing whether the  | 
            ||
| 139 | * initialization for an indexing configuration was successful  | 
            ||
| 140 | */  | 
            ||
| 141 | public function initialize(Site $site, $indexingConfigurationName = '')  | 
            ||
| 182 | |||
| 183 | /**  | 
            ||
| 184 | * Initializes the Index Queue for a specific indexing configuration.  | 
            ||
| 185 | *  | 
            ||
| 186 | * @param Site $site The site to initialize  | 
            ||
| 187 | * @param string $indexingConfigurationName name of a specific  | 
            ||
| 188 | * indexing configuration  | 
            ||
| 189 | 6 | * @return bool TRUE if the initialization was successful, FALSE otherwise  | 
            |
| 190 | */  | 
            ||
| 191 | protected function initializeIndexingConfiguration(Site $site, $indexingConfigurationName)  | 
            ||
| 212 | 6 | ||
| 213 | /**  | 
            ||
| 214 | 6 | * Marks an item as needing (re)indexing.  | 
            |
| 215 | 6 | *  | 
            |
| 216 | 6 | * Like with Solr itself, there's no add method, just a simple update method  | 
            |
| 217 | * that handles the adds, too.  | 
            ||
| 218 | 6 | *  | 
            |
| 219 | 6 | * The method creates or updates the index queue items for all related rootPageIds.  | 
            |
| 220 | *  | 
            ||
| 221 | 6 | * @param string $itemType The item's type, usually a table name.  | 
            |
| 222 | * @param string $itemUid The item's uid, usually an integer uid, could be a different value for non-database-record types.  | 
            ||
| 223 | * @param int $forcedChangeTime The change time for the item if set, otherwise value from getItemChangedTime() is used.  | 
            ||
| 224 | */  | 
            ||
| 225 | public function updateItem($itemType, $itemUid, $forcedChangeTime = 0)  | 
            ||
| 247 | 55 | ||
| 248 | 55 | /**  | 
            |
| 249 | 55 | * Finds indexing errors for the current site  | 
            |
| 250 | 55 | *  | 
            |
| 251 | * @param Site $site  | 
            ||
| 252 | 11 | * @return array Error items for the current site's Index Queue  | 
            |
| 253 | */  | 
            ||
| 254 | public function getErrorsBySite(Site $site)  | 
            ||
| 258 | 55 | ||
| 259 | /**  | 
            ||
| 260 | * Resets all the errors for all index queue items.  | 
            ||
| 261 | *  | 
            ||
| 262 | * @return mixed  | 
            ||
| 263 | */  | 
            ||
| 264 | public function resetAllErrors()  | 
            ||
| 268 | |||
| 269 | /**  | 
            ||
| 270 | * Adds an item to the index queue.  | 
            ||
| 271 | *  | 
            ||
| 272 | * Not meant for public use.  | 
            ||
| 273 | *  | 
            ||
| 274 | * @param string $itemType The item's type, usually a table name.  | 
            ||
| 275 | * @param string $itemUid The item's uid, usually an integer uid, could be a  | 
            ||
| 276 | * different value for non-database-record types.  | 
            ||
| 277 | * @param string $indexingConfiguration The item's indexing configuration to use.  | 
            ||
| 278 | * Optional, overwrites existing / determined configuration.  | 
            ||
| 279 | * @param $rootPageId  | 
            ||
| 280 | * @return void  | 
            ||
| 281 | */  | 
            ||
| 282 | private function addNewItem($itemType, $itemUid, $indexingConfiguration, $rootPageId)  | 
            ||
| 299 | 11 | ||
| 300 | /**  | 
            ||
| 301 | * Get record to be added in addNewItem  | 
            ||
| 302 | *  | 
            ||
| 303 | 11 | * @param string $itemType The item's type, usually a table name.  | 
            |
| 304 | * @param string $itemUid The item's uid, usually an integer uid, could be a  | 
            ||
| 305 | * different value for non-database-record types.  | 
            ||
| 306 | 11 | * @param string $additionalRecordFields for sql-query  | 
            |
| 307 | 11 | *  | 
            |
| 308 | * @return array|NULL  | 
            ||
| 309 | */  | 
            ||
| 310 | 11 | protected function getRecordCached($itemType, $itemUid, $additionalRecordFields)  | 
            |
| 323 | |||
| 324 | /**  | 
            ||
| 325 | * Determines the time for when an item should be indexed. This timestamp  | 
            ||
| 326 | * is then stored in the changed column in the Index Queue.  | 
            ||
| 327 | *  | 
            ||
| 328 | * The changed timestamp usually is now - time(). For records which are set  | 
            ||
| 329 | 49 | * to published at a later time, this timestamp is the start time. So if a  | 
            |
| 330 | * future start time has been set, that will be used to delay indexing  | 
            ||
| 331 | 49 | * of an item.  | 
            |
| 332 | 49 | *  | 
            |
| 333 | 30 | * @param string $itemType The item's table name.  | 
            |
| 334 | * @param string $itemUid The item's uid, usually an integer uid, could be a  | 
            ||
| 335 | * different value for non-database-record types.  | 
            ||
| 336 | 49 | * @return int Timestamp of the item's changed time or future start time  | 
            |
| 337 | */  | 
            ||
| 338 | 49 | protected function getItemChangedTime($itemType, $itemUid)  | 
            |
| 383 | |||
| 384 | /**  | 
            ||
| 385 | * Gets the most recent changed time of a page's content elements  | 
            ||
| 386 | *  | 
            ||
| 387 | * @param array $page Partial page record  | 
            ||
| 388 | * @return int Timestamp of the most recent content element change  | 
            ||
| 389 | */  | 
            ||
| 390 | protected function getPageItemChangedTime(array $page)  | 
            ||
| 398 | 54 | ||
| 399 | /**  | 
            ||
| 400 | 54 | * Checks whether the Index Queue contains a specific item.  | 
            |
| 401 | 54 | *  | 
            |
| 402 | 54 | * @param string $itemType The item's type, usually a table name.  | 
            |
| 403 | * @param string $itemUid The item's uid, usually an integer uid, could be a  | 
            ||
| 404 | 54 | * different value for non-database-record types.  | 
            |
| 405 | * @return bool TRUE if the item is found in the queue, FALSE otherwise  | 
            ||
| 406 | */  | 
            ||
| 407 | 35 | public function containsItem($itemType, $itemUid)  | 
            |
| 411 | 54 | ||
| 412 | /**  | 
            ||
| 413 | 54 | * Checks whether the Index Queue contains a specific item.  | 
            |
| 414 | 54 | *  | 
            |
| 415 | * @param string $itemType The item's type, usually a table name.  | 
            ||
| 416 | * @param string $itemUid The item's uid, usually an integer uid, could be a  | 
            ||
| 417 | 54 | * different value for non-database-record types.  | 
            |
| 418 | 35 | * @param integer $rootPageId  | 
            |
| 419 | * @return bool TRUE if the item is found in the queue, FALSE otherwise  | 
            ||
| 420 | */  | 
            ||
| 421 | 35 | public function containsItemWithRootPageId($itemType, $itemUid, $rootPageId)  | 
            |
| 425 | |||
| 426 | /**  | 
            ||
| 427 | * Checks whether the Index Queue contains a specific item that has been  | 
            ||
| 428 | * marked as indexed.  | 
            ||
| 429 | 54 | *  | 
            |
| 430 | * @param string $itemType The item's type, usually a table name.  | 
            ||
| 431 | * @param string $itemUid The item's uid, usually an integer uid, could be a  | 
            ||
| 432 | * different value for non-database-record types.  | 
            ||
| 433 | * @return bool TRUE if the item is found in the queue and marked as  | 
            ||
| 434 | * indexed, FALSE otherwise  | 
            ||
| 435 | */  | 
            ||
| 436 | 54 | public function containsIndexedItem($itemType, $itemUid)  | 
            |
| 440 | |||
| 441 | /**  | 
            ||
| 442 | * Removes an item from the Index Queue.  | 
            ||
| 443 | *  | 
            ||
| 444 | * @param string $itemType The type of the item to remove, usually a table name.  | 
            ||
| 445 | 35 | * @param int $itemUid The uid of the item to remove  | 
            |
| 446 | */  | 
            ||
| 447 | 35 | public function deleteItem($itemType, $itemUid)  | 
            |
| 451 | 35 | ||
| 452 | 35 | /**  | 
            |
| 453 | 35 | * Removes all items of a certain type from the Index Queue.  | 
            |
| 454 | 35 | *  | 
            |
| 455 | * @param string $itemType The type of items to remove, usually a table name.  | 
            ||
| 456 | 35 | */  | 
            |
| 457 | public function deleteItemsByType($itemType)  | 
            ||
| 461 | |||
| 462 | /**  | 
            ||
| 463 | * Removes all items of a certain site from the Index Queue. Accepts an  | 
            ||
| 464 | * optional parameter to limit the deleted items by indexing configuration.  | 
            ||
| 465 | *  | 
            ||
| 466 | * @param Site $site The site to remove items for.  | 
            ||
| 467 | * @param string $indexingConfigurationName Name of a specific indexing  | 
            ||
| 468 | * configuration  | 
            ||
| 469 | */  | 
            ||
| 470 | public function deleteItemsBySite(Site $site, $indexingConfigurationName = '')  | 
            ||
| 474 | |||
| 475 | 54 | /**  | 
            |
| 476 | 35 | * Removes all items from the Index Queue.  | 
            |
| 477 | *  | 
            ||
| 478 | */  | 
            ||
| 479 | 54 | public function deleteAllItems()  | 
            |
| 483 | 54 | ||
| 484 | 54 | /**  | 
            |
| 485 | 54 | * Gets a single Index Queue item by its uid.  | 
            |
| 486 | *  | 
            ||
| 487 | 54 | * @param int $itemId Index Queue item uid  | 
            |
| 488 | * @return Item The request Index Queue item or NULL if no item with $itemId was found  | 
            ||
| 489 | 54 | */  | 
            |
| 490 | public function getItem($itemId)  | 
            ||
| 494 | |||
| 495 | /**  | 
            ||
| 496 | * Gets Index Queue items by type and uid.  | 
            ||
| 497 | *  | 
            ||
| 498 | * @param string $itemType item type, usually the table name  | 
            ||
| 499 | * @param int $itemUid item uid  | 
            ||
| 500 | * @return Item[] An array of items matching $itemType and $itemUid  | 
            ||
| 501 | */  | 
            ||
| 502 | public function getItems($itemType, $itemUid)  | 
            ||
| 506 | 6 | ||
| 507 | 6 | /**  | 
            |
| 508 | 6 | * Returns all items in the queue.  | 
            |
| 509 | 6 | *  | 
            |
| 510 | 6 | * @return Item[] An array of items  | 
            |
| 511 | */  | 
            ||
| 512 | public function getAllItems()  | 
            ||
| 516 | |||
| 517 | /**  | 
            ||
| 518 | * Returns the number of items for all queues.  | 
            ||
| 519 | *  | 
            ||
| 520 | * @return int  | 
            ||
| 521 | */  | 
            ||
| 522 | public function getAllItemsCount()  | 
            ||
| 526 | |||
| 527 | 55 | /**  | 
            |
| 528 | 55 | * Extracts the number of pending, indexed and erroneous items from the  | 
            |
| 529 | 55 | * Index Queue.  | 
            |
| 530 | 55 | *  | 
            |
| 531 | 55 | * @param Site $site  | 
            |
| 532 | 55 | * @param string $indexingConfigurationName  | 
            |
| 533 | *  | 
            ||
| 534 | * @return QueueStatistic  | 
            ||
| 535 | 55 | */  | 
            |
| 536 | public function getStatisticsBySite(Site $site, $indexingConfigurationName = '')  | 
            ||
| 540 | |||
| 541 | /**  | 
            ||
| 542 | * Gets $limit number of items to index for a particular $site.  | 
            ||
| 543 | *  | 
            ||
| 544 | * @param Site $site TYPO3 site  | 
            ||
| 545 | * @param int $limit Number of items to get from the queue  | 
            ||
| 546 | * @return Item[] Items to index to the given solr server  | 
            ||
| 547 | */  | 
            ||
| 548 | 3 | public function getItemsToIndex(Site $site, $limit = 50)  | 
            |
| 552 | 3 | ||
| 553 | 3 | /**  | 
            |
| 554 | 3 | * Marks an item as failed and causes the indexer to skip the item in the  | 
            |
| 555 | 3 | * next run.  | 
            |
| 556 | 3 | *  | 
            |
| 557 | * @param int|Item $item Either the item's Index Queue uid or the complete item  | 
            ||
| 558 | * @param string $errorMessage Error message  | 
            ||
| 559 | 3 | */  | 
            |
| 560 | public function markItemAsFailed($item, $errorMessage = '')  | 
            ||
| 564 | |||
| 565 | /**  | 
            ||
| 566 | * Sets the timestamp of when an item last has been indexed.  | 
            ||
| 567 | *  | 
            ||
| 568 | 29 | * @param Item $item  | 
            |
| 569 | */  | 
            ||
| 570 | 29 | public function updateIndexTimeByItem(Item $item)  | 
            |
| 574 | }  | 
            ||
| 575 |