TreeManager::assignParent() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/timiTa..." - timiTao/material-management-domain - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( e86404...1009d9 )

by Tomasz

created 2016-04-25 20:05 UTC

TreeManager::assignParent() A

↳ Parent: TreeManager

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
rs	9.4285
cc	1
eloc	1
nc	1
nop	2

<?php
/**
 * (c) Tomasz Kunicki <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Domain\CategoryStructure\Structure\Tree;

use Domain\Category\Entity\CategoryInterface;
use Domain\CategoryStructure\Repository\CategoryTreeRepositoryInterface;

/**
 * Class TreeManager
 *
 * @package Domain\Category\Structure\Tree
 */
class TreeManager
{
    /** @var  CategoryTreeRepositoryInterface */
    private $categoryTreeRepository;

    /**
     * TreeManager constructor.
     *
     * @param CategoryTreeRepositoryInterface $categoryTreeRepository
     */
    public function __construct(CategoryTreeRepositoryInterface $categoryTreeRepository)
    {
        $this->categoryTreeRepository = $categoryTreeRepository;
    }

    /**
     * @param CategoryInterface $parent
     * @param CategoryInterface $newChild
     */
    public function assignParent(CategoryInterface $parent, CategoryInterface $newChild)

    {
//        $oldParent = $this->categoryTreeRepository->getParent($newChild);

//
//        if (!is_null($oldParent)) {
//            $oldParent->removeChild($newChild);
//            $this->categoryTreeRepository->update($oldParent);
//
//        }
//        $parent->addChild($newChild);
//        $this->categoryTreeRepository->update($parent);
    }
}


1			<?php
2			/**
3			* (c) Tomasz Kunicki <[email protected]>
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			namespace Domain\CategoryStructure\Structure\Tree;
9
10			use Domain\Category\Entity\CategoryInterface;
11			use Domain\CategoryStructure\Repository\CategoryTreeRepositoryInterface;
12
13			/**
14			* Class TreeManager
15			*
16			* @package Domain\Category\Structure\Tree
17			*/
18			class TreeManager
19			{
20			/** @var CategoryTreeRepositoryInterface */
21			private $categoryTreeRepository;
22
23			/**
24			* TreeManager constructor.
25			*
26			* @param CategoryTreeRepositoryInterface $categoryTreeRepository
27			*/
28			public function __construct(CategoryTreeRepositoryInterface $categoryTreeRepository)
29			{
30			$this->categoryTreeRepository = $categoryTreeRepository;
31			}
32
33			/**
34			* @param CategoryInterface $parent
35			* @param CategoryInterface $newChild
36			*/
37			public function assignParent(CategoryInterface $parent, CategoryInterface $newChild)
			0 ignored issues – show Unused Code introduced 2016-04-25 20:08 UTC by Report Bug Copy Issue Report The parameter `$parent` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-04-25 20:08 UTC by Report Bug Copy Issue Report The parameter `$newChild` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
38			{
39			// $oldParent = $this->categoryTreeRepository->getParent($newChild);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-25 20:08 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
40			//
41			// if (!is_null($oldParent)) {
42			// $oldParent->removeChild($newChild);
43			// $this->categoryTreeRepository->update($oldParent);
44			//
45			// }
46			// $parent->addChild($newChild);
47			// $this->categoryTreeRepository->update($parent);
48			}
49			}
50

timiTao / material-management-domain

Push — master ( e86404...1009d9 )

TreeManager::assignParent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like