Timegridio\Concierge\Addressbook

Complexity

Total Complexity

25

Size/Duplication

Total Lines	154
Duplicated Lines	10.39 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

15 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	listing()	0	4	1
A	find()	0	4	1
A	register()	0	21	3
A	update()	0	21	1
A	reuseExisting()	8	8	2
A	getExisting()	0	8	2
A	getSubscribed()	8	8	2
A	getRegisteredUserId()	0	4	1
A	reuseExistingByUserId()	0	4	1
A	remove()	0	4	1
A	linkToUserId()	0	7	1
A	copyFrom()	0	14	1
A	updateNotes()	0	6	2
B	sanitizeDate()	0	18	5

<?php

namespace Timegridio\Concierge;

use Carbon\Carbon;
use Models\Business;
use Timegridio\Concierge\Models\Contact;

/**
 * The Addressbook class acts as a simplified Contact repository with most
 * common read/write functions.
 */
class Addressbook
{
    private $business;

    public function __construct($business)
    {
        $this->business = $business;
    }

    public function listing($limit)
    {
        return $this->business->contacts()->orderBy('lastname', 'ASC')->simplePaginate($limit);
    }

    public function find(Contact $contact)
    {
        return $this->business->contacts()->find($contact->id);

The property id does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    public function register($data)
    {
        $contact = $this->reuseExisting($data['email']);

        if ($contact) {
            return $contact;
        }

        $this->sanitizeDate($data['birthdate']);

        $contact = Contact::create($data);

        $this->business->contacts()->attach($contact);
        $this->business->save();

        if (array_key_exists('notes', $data)) {
            $this->updateNotes($contact, $data['notes']);
        }

        return $contact;
    }

    public function update(Contact $contact, $data = [], $notes = null)
    {
        $birthdate = array_get($data, 'birthdate');
        $this->sanitizeDate($birthdate);

        $contact->firstname = array_get($data, 'firstname');

The property firstname does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __set, maybe consider adding a @property annotation.

        $contact->lastname = array_get($data, 'lastname');

The property lastname does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __set, maybe consider adding a @property annotation.

        $contact->email = array_get($data, 'email');

The property email does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __set, maybe consider adding a @property annotation.

        $contact->nin = array_get($data, 'nin');

The property nin does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __set, maybe consider adding a @property annotation.

        $contact->gender = array_get($data, 'gender');

The property gender does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __set, maybe consider adding a @property annotation.

        $contact->birthdate = $birthdate;

The property birthdate does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __set, maybe consider adding a @property annotation.

        $contact->mobile = array_get($data, 'mobile');

The property mobile does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __set, maybe consider adding a @property annotation.

        $contact->mobile_country = array_get($data, 'mobile_country');

The property mobile_country does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __set, maybe consider adding a @property annotation.

        $contact->postal_address = array_get($data, 'postal_address');

The property postal_address does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __set, maybe consider adding a @property annotation.

        $contact->save();

        $this->updateNotes($contact, $notes);

        return $contact;
    }

    public function reuseExisting($email)

This method seems to be duplicated in your project.

    {
        if (trim($email) == '') {
            return false;
        }

        return $this->business->contacts()->where('email', '=', $email)->first();
    }

    public function getExisting($email)
    {
        if (trim($email) == '') {
            return false;
        }

        return Contact::whereNotNull('user_id')->where('email', '=', $email)->first();
    }

    public function getSubscribed($email)

This method seems to be duplicated in your project.

    {
        if (trim($email) == '') {
            return false;
        }

        return $this->business->contacts()->where('email', '=', $email)->first();
    }

    public function getRegisteredUserId($userId)
    {
        return $this->business->contacts()->where('user_id', '=', $userId)->first();
    }

    public function reuseExistingByUserId($userId)
    {
        return $this->business->contacts()->where('user_id', '=', $userId)->first();
    }

    public function remove(Contact $contact)
    {
        return $this->business->contacts()->detach($contact->id);

The property id does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    public function linkToUserId(Contact $contact, $userId)
    {
        $contact->user()->associate($userId);
        $contact->save();

        return $contact->fresh();
    }

    public function copyFrom(Contact $existingContact, $userId)
    {
        $existingContactData = $existingContact->toArray();
        $this->sanitizeDate($existingContactData['birthdate']);
        $contact = Contact::create($existingContactData);
        $contact->user()->associate($userId);
        $contact->businesses()->detach();
        $contact->save();

        $this->business->contacts()->attach($contact);
        $this->business->save();

        return $contact;
    }

    protected function updateNotes(Contact $contact, $notes = null)
    {
        if ($notes) {
            $this->business->contacts()->find($contact->id)->pivot->update(compact('notes'));

The property id does not exist on object<Timegridio\Concierge\Models\Contact>. Since you implemented __get, maybe consider adding a @property annotation.

        }
    }

    protected function sanitizeDate(&$value)
    {
        if (!is_string($value)) {
            return $value;
        }

        if (trim($value) == '') {
            return $value = null;
        }

        if (strlen($value) == 19) {
            return $value = Carbon::parse($value);
        }

        if (strlen($value) == 10) {
            return $value = Carbon::createFromFormat(trans('app.dateformat.carbon'), $value);

It seems like trans('app.dateformat.carbon') targeting trans() can also be of type object<Symfony\Component\Translation\TranslatorInterface>; however, Carbon\Carbon::createFromFormat() does only seem to accept string, maybe add an additional type check?

        }
    }
}