TimetableDateslotStrategy - Code Metrics - Inspection of "Add BaseTimetableStrategy" - timegridio/concierge - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 566e3d...cbf465 )

by Ariel

created 2016-02-06 10:46 UTC

TimetableDateslotStrategy A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	5
c	2
b	0
f	1
lcom	1
cbo	3
dl	0
loc	50
rs	10

4 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	initTimetable()	8	1
A	buildTimetable()	10	2
A	updateTimeslots()	11	1

<?php

namespace Timegridio\Concierge\Timetable\Strategies;

use Timegridio\Concierge\Models\Vacancy;
use Timegridio\Concierge\Timetable\Timetable;

class TimetableDateslotStrategy  extends BaseTimetableStrategy  implements TimetableStrategyInterface

{
    private $interval = 30;


    public function __construct(Timetable $timetable)
    {
        $this->timetable = $timetable;
    }

    protected function initTimetable($starting, $days)
    {
        $this->timetable
             ->format('date.service.time')
             ->from($starting)
             ->future($days)
             ->init();
    }

    /**
     * Build timetable.
     *
     * @param \Illuminate\Database\Eloquent\Collection $vacancies
     * @param string                                  $starting
     * @param int                                     $days
     *
     * @return array
     */
    public function buildTimetable($vacancies, $starting = 'today', $days = 1)
    {
        $this->initTimetable($starting, $days);

        foreach ($vacancies as $vacancy) {
            $this->updateTimeslots($vacancy);
        }

        return $this->timetable->get();
    }

    protected function updateTimeslots(Vacancy $vacancy)
    {
        $fromTime = $vacancy->start_at;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $toTime = $vacancy->finish_at;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $capacity = $vacancy->getAvailableCapacityBetween($fromTime->timezone('UTC'), $toTime->timezone('UTC'));

        $time = $fromTime->timezone($vacancy->business->timezone)->format('H:i:s');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->timetable->capacity($vacancy->date, $time, $vacancy->service->slug, $capacity);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			namespace Timegridio\Concierge\Timetable\Strategies;
4
5			use Timegridio\Concierge\Models\Vacancy;
6			use Timegridio\Concierge\Timetable\Timetable;
7
8			class TimetableDateslotStrategy extends BaseTimetableStrategy implements TimetableStrategyInterface
			0 ignored issues – show Coding Style introduced 2016-02-06 10:52 UTC by Report Bug Copy Issue Report Expected 1 space after class name; 2 found Loading history... Coding Style introduced 2016-02-06 10:52 UTC by Report Bug Copy Issue Report Expected 1 space before extends keyword; 2 found Loading history... Coding Style introduced 2016-02-06 10:52 UTC by Report Bug Copy Issue Report Expected 1 space before implements keyword; 2 found Loading history...
9			{
10			private $interval = 30;
			0 ignored issues – show Unused Code introduced 2016-02-06 10:52 UTC by Report Bug Copy Issue Report The property `$interval` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
11
12			public function __construct(Timetable $timetable)
13			{
14			$this->timetable = $timetable;
15			}
16
17			protected function initTimetable($starting, $days)
18			{
19			$this->timetable
20			->format('date.service.time')
21			->from($starting)
22			->future($days)
23			->init();
24			}
25
26			/**
27			* Build timetable.
28			*
29			* @param \Illuminate\Database\Eloquent\Collection $vacancies
30			* @param string $starting
31			* @param int $days
32			*
33			* @return array
34			*/
35			public function buildTimetable($vacancies, $starting = 'today', $days = 1)
36			{
37			$this->initTimetable($starting, $days);
38
39			foreach ($vacancies as $vacancy) {
40			$this->updateTimeslots($vacancy);
41			}
42
43			return $this->timetable->get();
44			}
45
46			protected function updateTimeslots(Vacancy $vacancy)
47			{
48			$fromTime = $vacancy->start_at;
			0 ignored issues – show Documentation introduced 2016-02-06 10:21 UTC by Report Bug Copy Issue Report The property `start_at` does not exist on `object<Timegridio\Concierge\Models\Vacancy>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
49			$toTime = $vacancy->finish_at;
			0 ignored issues – show Documentation introduced 2016-02-06 10:21 UTC by Report Bug Copy Issue Report The property `finish_at` does not exist on `object<Timegridio\Concierge\Models\Vacancy>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
50
51			$capacity = $vacancy->getAvailableCapacityBetween($fromTime->timezone('UTC'), $toTime->timezone('UTC'));
52
53			$time = $fromTime->timezone($vacancy->business->timezone)->format('H:i:s');
			0 ignored issues – show Documentation introduced 2016-02-06 10:21 UTC by Report Bug Copy Issue Report The property `business` does not exist on `object<Timegridio\Concierge\Models\Vacancy>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
54
55			$this->timetable->capacity($vacancy->date, $time, $vacancy->service->slug, $capacity);
			0 ignored issues – show Documentation introduced 2016-02-06 10:21 UTC by Report Bug Copy Issue Report The property `date` does not exist on `object<Timegridio\Concierge\Models\Vacancy>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-02-06 10:21 UTC by Report Bug Copy Issue Report The property `service` does not exist on `object<Timegridio\Concierge\Models\Vacancy>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
56			}
57			}
58

timegridio / concierge

Push — master ( 566e3d...cbf465 )

TimetableDateslotStrategy A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like