Preferenceable - Code Metrics - Inspection of "Increase test coverage" - timegridio/concierge - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6f85e7...580597 )

by Ariel

created 2016-02-06 13:10 UTC

Preferenceable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

28.57%

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	9
c	2
b	0
f	0
lcom	0
cbo	1
dl	0
loc	62
ccs	6
cts	21
cp	0.2857
rs	10

3 Methods

Rating	Name	Size	Complexity
B	cast()	19	5
A	preferences()	4	1
A	pref()	12	3

<?php

namespace Timegridio\Concierge\Traits;

use Timegridio\Concierge\Models\Preference;

trait Preferenceable
{
    /**
     * Preferences morph.
     *
     * @return Illuminate\Database\Eloquent\Relations\MorphMany
     */
    public function preferences()
    {
        return $this->morphMany(Preference::class, 'preferenceable');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get or set preference value.
     *
     * @param  mixed $key
     * @param  mixed $value
     * @param  string $type
     *
     * @return mixed  Value.
     */
    public function pref($key, $value = null, $type = 'string')
    {
        if (isset($value)) {
            $this->preferences()->updateOrCreate(['key' => $key], ['value' => $this->cast($value, $type),
                                                                   'type'  => $type, ]);

            return $value;
        }
        $default = Preference::getDefault($this, $key);

        return($pref = $this->preferences()->forKey($key)->first()) ? $pref->value() : $default->value();
    }

    /**
     * Cast value.
     *
     * @param  mixed $value
     * @param  mixed $type
     *
     * @return mixed Value.
     */
    private function cast($value, $type)
    {
        switch ($type) {
            case 'bool':
                return boolval($value);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'int':
                return intval($value);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'float':
                return floatval($value);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'string':
                return $value;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                return $value;
        }
    }
}


1		<?php
2
3		namespace Timegridio\Concierge\Traits;
4
5		use Timegridio\Concierge\Models\Preference;
6
7		trait Preferenceable
8		{
9		/**
10		* Preferences morph.
11		*
12		* @return Illuminate\Database\Eloquent\Relations\MorphMany
13		*/
14	1	public function preferences()
15		{
16	1	return $this->morphMany(Preference::class, 'preferenceable');
		0 ignored issues – show Bug introduced 2016-02-03 04:24 UTC by Report Bug Copy Issue Report It seems like `morphMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17		}
18
19		/**
20		* Get or set preference value.
21		*
22		* @param mixed $key
23		* @param mixed $value
24		* @param string $type
25		*
26		* @return mixed Value.
27		*/
28	1	public function pref($key, $value = null, $type = 'string')
29		{
30	1	if (isset($value)) {
31		$this->preferences()->updateOrCreate(['key' => $key], ['value' => $this->cast($value, $type),
32		'type' => $type, ]);
33
34		return $value;
35		}
36	1	$default = Preference::getDefault($this, $key);
37
38	1	return($pref = $this->preferences()->forKey($key)->first()) ? $pref->value() : $default->value();
39		}
40
41		/**
42		* Cast value.
43		*
44		* @param mixed $value
45		* @param mixed $type
46		*
47		* @return mixed Value.
48		*/
49		private function cast($value, $type)
50		{
51		switch ($type) {
52		case 'bool':
53		return boolval($value);
54		break;
		0 ignored issues – show Unused Code introduced 2016-02-03 04:24 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
55		case 'int':
56		return intval($value);
57		break;
		0 ignored issues – show Unused Code introduced 2016-02-03 04:24 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
58		case 'float':
59		return floatval($value);
60		break;
		0 ignored issues – show Unused Code introduced 2016-02-03 04:24 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
61		case 'string':
62		return $value;
63		break;
		0 ignored issues – show Unused Code introduced 2016-02-03 04:24 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
64		default:
65		return $value;
66		}
67		}
68		}
69

timegridio / concierge

Push — master ( 6f85e7...580597 )

Preferenceable A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like