Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Appointment often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Appointment, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
17 | class Appointment extends EloquentModel implements HasPresenter |
||
18 | { |
||
19 | /** |
||
20 | * The attributes that are mass assignable. |
||
21 | * |
||
22 | * @var array |
||
23 | */ |
||
24 | protected $fillable = ['issuer_id', 'contact_id', 'business_id', |
||
25 | 'service_id', 'start_at', 'finish_at', 'duration', 'comments', ]; |
||
26 | |||
27 | /** |
||
28 | * The attributes that aren't mass assignable. |
||
29 | * |
||
30 | * @var array |
||
31 | */ |
||
32 | protected $guarded = ['id', 'hash', 'status', 'vacancy_id']; |
||
33 | |||
34 | /** |
||
35 | * The attributes that should be mutated to dates. |
||
36 | * |
||
37 | * @var array |
||
38 | */ |
||
39 | protected $dates = ['start_at', 'finish_at']; |
||
40 | |||
41 | /** |
||
42 | * Appointment Hard Status Constants. |
||
43 | */ |
||
44 | const STATUS_RESERVED = 'R'; |
||
45 | const STATUS_CONFIRMED = 'C'; |
||
46 | const STATUS_ANNULATED = 'A'; |
||
47 | const STATUS_SERVED = 'S'; |
||
48 | |||
49 | /////////////// |
||
50 | // PRESENTER // |
||
51 | /////////////// |
||
52 | |||
53 | /** |
||
54 | * Get Presenter Class. |
||
55 | * |
||
56 | * @return App\Presenters\AppointmentPresenter |
||
57 | */ |
||
58 | 1 | public function getPresenterClass() |
|
59 | { |
||
60 | 1 | return AppointmentPresenter::class; |
|
61 | } |
||
62 | |||
63 | /** |
||
64 | * Generate hash and save the model to the database. |
||
65 | * |
||
66 | * @param array $options |
||
67 | * |
||
68 | * @return bool |
||
69 | */ |
||
70 | 17 | public function save(array $options = []) |
|
76 | |||
77 | /////////////////// |
||
78 | // Relationships // |
||
79 | /////////////////// |
||
80 | |||
81 | /** |
||
82 | * Get the issuer (the User that generated the Appointment). |
||
83 | * |
||
84 | * @return \Illuminate\Database\Eloquent\Relations\BelongsTo |
||
85 | */ |
||
86 | 4 | public function issuer() |
|
90 | |||
91 | /** |
||
92 | * Get the target Contact (for whom is reserved the Appointment). |
||
93 | * |
||
94 | * @return \Illuminate\Database\Eloquent\Relations\BelongsTo |
||
95 | */ |
||
96 | 4 | public function contact() |
|
100 | |||
101 | /** |
||
102 | * Get the holding Business (that has taken the reservation). |
||
103 | * |
||
104 | * @return \Illuminate\Database\Eloquent\Relations\BelongsTo |
||
105 | */ |
||
106 | 6 | public function business() |
|
110 | |||
111 | /** |
||
112 | * Get the reserved Service. |
||
113 | * |
||
114 | * @return \Illuminate\Database\Eloquent\Relations\BelongsTo |
||
115 | */ |
||
116 | 8 | public function service() |
|
120 | |||
121 | /** |
||
122 | * Get the Vacancy (that justifies the availability of resources for the |
||
123 | * Appointment generation). |
||
124 | * |
||
125 | * @return \Illuminate\Database\Eloquent\Relations\BelongsTo |
||
126 | */ |
||
127 | 5 | public function vacancy() |
|
131 | |||
132 | /////////// |
||
133 | // Other // |
||
134 | /////////// |
||
135 | |||
136 | /** |
||
137 | * Get the User through Contact. |
||
138 | * |
||
139 | * @return User |
||
140 | */ |
||
141 | 2 | public function user() |
|
145 | |||
146 | /** |
||
147 | * Determine if the new Appointment will hash-crash with another existing |
||
148 | * Appointment. |
||
149 | * |
||
150 | * @return bool |
||
151 | */ |
||
152 | 5 | public function duplicates() |
|
156 | |||
157 | /////////////// |
||
158 | // Accessors // |
||
159 | /////////////// |
||
160 | |||
161 | /** |
||
162 | * Get Hash. |
||
163 | * |
||
164 | * @return string |
||
165 | */ |
||
166 | 5 | public function getHashAttribute() |
|
172 | |||
173 | /** |
||
174 | * Get Finish At: |
||
175 | * Calculates the start_at time plus duration in minutes. |
||
176 | * |
||
177 | * @return Carbon |
||
178 | */ |
||
179 | 1 | public function getFinishAtAttribute() |
|
191 | |||
192 | /** |
||
193 | * Get TimeZone (from the Business). |
||
194 | * |
||
195 | * @return string |
||
196 | */ |
||
197 | public function getTZAttribute() |
||
201 | |||
202 | /** |
||
203 | * Get the human readable status name. |
||
204 | * |
||
205 | * @return string |
||
206 | */ |
||
207 | public function getStatusLabelAttribute() |
||
220 | |||
221 | /** |
||
222 | * Get the date of the Appointment. |
||
223 | * |
||
224 | * @return string |
||
225 | */ |
||
226 | 3 | public function getDateAttribute() |
|
232 | |||
233 | ////////////// |
||
234 | // Mutators // |
||
235 | ////////////// |
||
236 | |||
237 | /** |
||
238 | * Generate Appointment hash. |
||
239 | * |
||
240 | * @return string |
||
241 | */ |
||
242 | 17 | public function doHash() |
|
251 | |||
252 | /** |
||
253 | * Set start at. |
||
254 | * |
||
255 | * @param Carbon $datetime |
||
256 | */ |
||
257 | 17 | public function setStartAtAttribute(Carbon $datetime) |
|
261 | |||
262 | /** |
||
263 | * Set finish_at attribute. |
||
264 | * |
||
265 | * @param Carbon $datetime |
||
266 | */ |
||
267 | 8 | public function setFinishAtAttribute(Carbon $datetime) |
|
271 | |||
272 | /** |
||
273 | * Set Comments. |
||
274 | * |
||
275 | * @param string $comments |
||
276 | */ |
||
277 | 17 | public function setCommentsAttribute($comments) |
|
281 | |||
282 | ///////////////// |
||
283 | // HARD STATUS // |
||
284 | ///////////////// |
||
285 | |||
286 | /** |
||
287 | * Determine if is Reserved. |
||
288 | * |
||
289 | * @return bool |
||
290 | */ |
||
291 | 1 | public function isReserved() |
|
295 | |||
296 | /////////////////////////// |
||
297 | // Calculated attributes // |
||
298 | /////////////////////////// |
||
299 | |||
300 | /** |
||
301 | * Appointment Status Workflow. |
||
302 | * |
||
303 | * Hard Status: Those concrete values stored in DB |
||
304 | * Soft Status: Those values calculated from stored values in DB |
||
305 | * |
||
306 | * Suggested transitions (Binding is not mandatory) |
||
307 | * Reserved -> Confirmed -> Served |
||
308 | * Reserved -> Served |
||
309 | * Reserved -> Annulated |
||
310 | * Reserved -> Confirmed -> Annulated |
||
311 | * |
||
312 | * Soft Status |
||
313 | * (Active) [ Reserved | Confirmed ] |
||
314 | * (InActive) [ Annulated | Served ] |
||
315 | */ |
||
316 | |||
317 | /** |
||
318 | * Determine if is Active. |
||
319 | * |
||
320 | * @return bool |
||
321 | */ |
||
322 | public function isActive() |
||
328 | |||
329 | /** |
||
330 | * Determine if is Pending. |
||
331 | * |
||
332 | * @return bool |
||
333 | */ |
||
334 | 2 | public function isPending() |
|
338 | |||
339 | /** |
||
340 | * Determine if is Future. |
||
341 | * |
||
342 | * @return bool |
||
343 | */ |
||
344 | public function isFuture() |
||
348 | |||
349 | /** |
||
350 | * Determine if is due. |
||
351 | * |
||
352 | * @return bool |
||
353 | */ |
||
354 | public function isDue() |
||
358 | |||
359 | //////////// |
||
360 | // Scopes // |
||
361 | //////////// |
||
362 | |||
363 | ///////////////////////// |
||
364 | // Hard Status Scoping // |
||
365 | ///////////////////////// |
||
366 | |||
367 | /** |
||
368 | * Scope to Unarchived Appointments. |
||
369 | * |
||
370 | * @param Illuminate\Database\Query $query |
||
371 | * |
||
372 | * @return Illuminate\Database\Query |
||
373 | */ |
||
374 | public function scopeUnarchived($query) |
||
385 | |||
386 | /** |
||
387 | * Scope to Served Appointments. |
||
388 | * |
||
389 | * @param Illuminate\Database\Query $query |
||
390 | * |
||
391 | * @return Illuminate\Database\Query |
||
392 | */ |
||
393 | public function scopeServed($query) |
||
397 | |||
398 | /** |
||
399 | * Scope to Annulated Appointments. |
||
400 | * |
||
401 | * @param Illuminate\Database\Query $query |
||
402 | * |
||
403 | * @return Illuminate\Database\Query |
||
404 | */ |
||
405 | public function scopeAnnulated($query) |
||
409 | |||
410 | ///////////////////////// |
||
411 | // Soft Status Scoping // |
||
412 | ///////////////////////// |
||
413 | |||
414 | /** |
||
415 | * Scope to not Served Appointments. |
||
416 | * |
||
417 | * @param Illuminate\Database\Query $query |
||
418 | * |
||
419 | * @return Illuminate\Database\Query |
||
420 | */ |
||
421 | public function scopeUnServed($query) |
||
425 | |||
426 | /** |
||
427 | * Scope to Active Appointments. |
||
428 | * |
||
429 | * @param Illuminate\Database\Query $query |
||
430 | * |
||
431 | * @return Illuminate\Database\Query |
||
432 | */ |
||
433 | 12 | public function scopeActive($query) |
|
437 | |||
438 | /** |
||
439 | * Scope of Business. |
||
440 | * |
||
441 | * @param Illuminate\Database\Query $query |
||
442 | * @param int $businessId |
||
443 | * |
||
444 | * @return Illuminate\Database\Query |
||
445 | */ |
||
446 | public function scopeOfBusiness($query, $businessId) |
||
450 | |||
451 | /** |
||
452 | * Scope of date. |
||
453 | * |
||
454 | * @param Illuminate\Database\Query $query |
||
455 | * @param Carbon $date |
||
456 | * |
||
457 | * @return Illuminate\Database\Query |
||
458 | */ |
||
459 | public function scopeOfDate($query, Carbon $date) |
||
463 | |||
464 | /** |
||
465 | * Scope only future appointments. |
||
466 | * |
||
467 | * @param Illuminate\Database\Query $query |
||
468 | * |
||
469 | * @return Illuminate\Database\Query |
||
470 | */ |
||
471 | public function scopeFuture($query) |
||
477 | |||
478 | /** |
||
479 | * Scope only till date. |
||
480 | * |
||
481 | * @param Illuminate\Database\Query $query |
||
482 | * @param Carbon $date |
||
483 | * |
||
484 | * @return Illuminate\Database\Query |
||
485 | */ |
||
486 | public function scopeTillDate($query, Carbon $date) |
||
490 | |||
491 | /** |
||
492 | * Between Dates. |
||
493 | * |
||
494 | * @param Illuminate\Database\Query $query |
||
495 | * @param Carbon $startAt |
||
496 | * @param Carbon $finishAt |
||
497 | * |
||
498 | * @return Illuminate\Database\Query |
||
499 | */ |
||
500 | 8 | public function scopeAffectingInterval($query, Carbon $startAt, Carbon $finishAt) |
|
524 | |||
525 | /** |
||
526 | * Determine if the Serve action can be performed. |
||
527 | * |
||
528 | * @return bool |
||
529 | */ |
||
530 | public function isServeable() |
||
534 | |||
535 | /** |
||
536 | * Determine if the Confirm action can be performed. |
||
537 | * |
||
538 | * @return bool |
||
539 | */ |
||
540 | public function isConfirmable() |
||
544 | |||
545 | /** |
||
546 | * Determine if the Annulate action can be performed. |
||
547 | * |
||
548 | * @return bool |
||
549 | */ |
||
550 | public function isAnnulable() |
||
554 | |||
555 | ///////////////////////// |
||
556 | // Hard Status Actions // |
||
557 | ///////////////////////// |
||
558 | |||
559 | /** |
||
560 | * Check and perform Confirm action. |
||
561 | * |
||
562 | * @return $this |
||
563 | */ |
||
564 | 5 | public function doReserve() |
|
572 | |||
573 | /** |
||
574 | * Check and perform Confirm action. |
||
575 | * |
||
576 | * @return $this |
||
577 | */ |
||
578 | 1 | public function doConfirm() |
|
588 | |||
589 | /** |
||
590 | * Check and perform Annulate action. |
||
591 | * |
||
592 | * @return $this |
||
593 | */ |
||
594 | 1 | public function doAnnulate() |
|
604 | |||
605 | /** |
||
606 | * Check and perform Serve action. |
||
607 | * |
||
608 | * @return $this |
||
609 | */ |
||
610 | 2 | public function doServe() |
|
620 | } |
||
621 |
Since your code implements the magic getter
_get
, this function will be called for any read access on an undefined variable. You can add the@property
annotation to your class or interface to document the existence of this variable.If the property has read access only, you can use the @property-read annotation instead.
Of course, you may also just have mistyped another name, in which case you should fix the error.
See also the PhpDoc documentation for @property.