ContactPresenter::quality() - Code Metrics - Inspection of "Enhance age handling" - timegridio/concierge - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 75326d...ecee01 )

by Ariel

created 2016-02-14 01:21 UTC

ContactPresenter::quality() A

↳ Parent: ContactPresenter

Complexity

Conditions	3
Paths	3

Size

Total Lines	23
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	23
ccs	18
cts	18
cp	1
rs	9.0856
cc	3
eloc	16
nc	3
nop	0
crap	3

<?php

namespace Timegridio\Concierge\Presenters;

use McCool\LaravelAutoPresenter\BasePresenter;
use Timegridio\Concierge\Exceptions\InvalidContactAgeException;
use Timegridio\Concierge\Models\Contact;

class ContactPresenter extends BasePresenter
{
    public function __construct(Contact $resource)
    {
        $this->wrappedObject = $resource;
    }

    /**
     * get fullname.
     *
     * @return string Contact firstname and lastname
     */
    public function fullname()
    {
        return trim($this->wrappedObject->firstname.' '.$this->wrappedObject->lastname);
    }

    /**
     * TODO: Check if needs to get moved to a calculator class.
     *
     * get Quality
     *
     * @return float Contact quality percentual score calculated from profile completion
     */
    public function quality()
    {
        $propertiesScore = [
            'firstname'      => 3,
            'lastname'       => 7,
            'nin'            => 10,
            'birthdate'      => 5,
            'mobile'         => 20,
            'email'          => 15,
            'postal_address' => 15,
            'user'           => 25,
        ];
        $totalScore = array_sum($propertiesScore);

        $qualityScore = 0;
        foreach ($propertiesScore as $property => $score) {
            if (trim($this->wrappedObject->$property) !== '') {
                $qualityScore += $score;
            }
        }

        return ceil($qualityScore / $totalScore * 100);
    }

    /**
     * ToDo: Use Carbon instead of DateTime.
     *
     * get Age
     *
     * @return int Age in years
     */
    public function age()
    {
        if ($this->wrappedObject->birthdate == null) {
            return;
        }

        $reference = new \DateTime();
        $born = new \DateTime($this->wrappedObject->birthdate);

        if ($this->wrappedObject->birthdate > $reference) {
            throw new InvalidContactAgeException;
        }

        $diff = $reference->diff($born);

        return $diff->y;
    }
}


1		<?php
2
3		namespace Timegridio\Concierge\Presenters;
4
5		use McCool\LaravelAutoPresenter\BasePresenter;
6		use Timegridio\Concierge\Exceptions\InvalidContactAgeException;
7		use Timegridio\Concierge\Models\Contact;
8
9		class ContactPresenter extends BasePresenter
10		{
11	6	public function __construct(Contact $resource)
12		{
13	6	$this->wrappedObject = $resource;
14	6	}
15
16		/**
17		* get fullname.
18		*
19		* @return string Contact firstname and lastname
20		*/
21	1	public function fullname()
22		{
23	1	return trim($this->wrappedObject->firstname.' '.$this->wrappedObject->lastname);
24		}
25
26		/**
27		* TODO: Check if needs to get moved to a calculator class.
28		*
29		* get Quality
30		*
31		* @return float Contact quality percentual score calculated from profile completion
32		*/
33	1	public function quality()
34		{
35		$propertiesScore = [
36	1	'firstname' => 3,
37	1	'lastname' => 7,
38	1	'nin' => 10,
39	1	'birthdate' => 5,
40	1	'mobile' => 20,
41	1	'email' => 15,
42	1	'postal_address' => 15,
43	1	'user' => 25,
44	1	];
45	1	$totalScore = array_sum($propertiesScore);
46
47	1	$qualityScore = 0;
48	1	foreach ($propertiesScore as $property => $score) {
49	1	if (trim($this->wrappedObject->$property) !== '') {
50	1	$qualityScore += $score;
51	1	}
52	1	}
53
54	1	return ceil($qualityScore / $totalScore * 100);
55		}
56
57		/**
58		* ToDo: Use Carbon instead of DateTime.
59		*
60		* get Age
61		*
62		* @return int Age in years
63		*/
64	3	public function age()
65		{
66	3	if ($this->wrappedObject->birthdate == null) {
67	1	return;
68		}
69
70	2	$reference = new \DateTime();
71	2	$born = new \DateTime($this->wrappedObject->birthdate);
72
73	2	if ($this->wrappedObject->birthdate > $reference) {
74	1	throw new InvalidContactAgeException;
75		}
76
77	1	$diff = $reference->diff($born);
78
79	1	return $diff->y;
80		}
81		}
82

timegridio / concierge

Push — master ( 75326d...ecee01 )

ContactPresenter::quality() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like