VacancyManager::processServiceStatements() - Code Metrics - Inspection of "Increase test coverage" - timegridio/concierge - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c1caf9...097277 )

by Ariel

created 2016-03-01 21:11 UTC

VacancyManager::processServiceStatements() B

↳ Parent: VacancyManager

Complexity

Conditions	4
Paths	4

Size

Total Lines	25
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	25
ccs	13
cts	13
cp	1
rs	8.5806
cc	4
eloc	11
nc	4
nop	3
crap	4

<?php

namespace Timegridio\Concierge\Vacancy;

use Carbon\Carbon;
use Timegridio\Concierge\Models\Business;
use Timegridio\Concierge\Models\Service;
use Timegridio\Concierge\Models\Vacancy;

class VacancyManager
{
    protected $business;

    public function __construct(Business $business)
    {
        $this->business = $business;
    }

    /**
     * Update vacancies from batch statements.
     *
     * @param Business $business
     * @param array    $parsedStatements
     *
     * @return bool
     */
    public function updateBatch(Business $business, $parsedStatements)
    {
        $changed = false;
        $dates = $this->arrayGroupBy('date', $parsedStatements);

        foreach ($dates as $date => $statements) {
            $services = $this->arrayGroupBy('service', $statements);

            $changed |= $this->processServiceStatements($business, $date, $services);
        }

        return $changed;
    }

    protected function processServiceStatements($business, $date, $services)
    {
        $changed = false;
        foreach ($services as $serviceSlug => $statements) {
            $service = Service::where('slug', $serviceSlug)->get()->first();

            if ($service === null) {

                //  Invalid services are skipped to avoid user frustration.
                //  TODO: Still, a user-level WARNING should be raised with no fatal error

                continue;
            }

            $vacancy = $business->vacancies()->forDate(Carbon::parse($date))->forService($service->id);

            if ($vacancy) {
                $vacancy->delete();
            }

            $changed |= $this->processStatements($business, $date, $service, $statements);
        }

        return $changed;
    }

    protected function processStatements($business, $date, $service, $statements)
    {
        $changed = false;
        foreach ($statements as $statement) {
            $changed |= $this->publishVacancy($business, $date, $service, $statement);
        }

        return $changed;
    }

    protected function publishVacancy($business, $date, $service, $statement)

    {
        $date = $statement['date'];
        $startAt = $statement['startAt'];
        $finishAt = $statement['finishAt'];

        $startAt = Carbon::parse("{$date} {$startAt} {$business->timezone}")->timezone('UTC');
        $finishAt = Carbon::parse("{$date} {$finishAt} {$business->timezone}")->timezone('UTC');

        $vacancyValues = [
            'business_id' => $business->id,
            'service_id'  => $service->id,
            'date'        => $statement['date'],
            'capacity'    => intval($statement['capacity']),
            'start_at'    => $startAt,
            'finish_at'   => $finishAt,
            ];

        $vacancy = Vacancy::create($vacancyValues);

        return $vacancy !== null;
    }

    protected function arrayGroupBy($key, $array)
    {
        $grouped = [];
        foreach ($array as $hash => $item) {
            if (!array_key_exists($item[$key], $grouped)) {
                $grouped[$item[$key]] = [];
            }
            $grouped[$item[$key]][] = $item;
        }

        return $grouped;
    }

    public function publish($date, Carbon $startAt, Carbon $finishAt, $serviceId, $capacity = 1)
    {
        $vacancyKeys = [
            'business_id' => $this->business->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'service_id'  => $serviceId,
            'date'        => $date,
            ];
        $vacancyValues = [
            'capacity'    => intval($capacity),
            'start_at'    => $startAt->timezone('UTC')->toDateTimeString(),
            'finish_at'   => $finishAt->timezone('UTC')->toDateTimeString(),
            ];

        return Vacancy::updateOrCreate($vacancyKeys, $vacancyValues);

    }

    /**
     * [generateAvailability description].
     *
     * @param Illuminate\Database\Eloquent\Collection $vacancies
     * @param string                                  $startDate
     * @param int                                     $futureDays
     *
     * @return array
     */
    public static function generateAvailability($vacancies, $startDate = 'today', $futureDays = 10)
    {
        $dates = [];
        for ($i = 0; $i < $futureDays; $i++) {

            $dates[date('Y-m-d', strtotime("$startDate +$i days"))] = [];
        }

        foreach ($vacancies as $vacancy) {
            if (array_key_exists($vacancy->date, $dates)) {
                $dates[$vacancy->date][$vacancy->service->slug] = $vacancy;
            }
        }

        return $dates;
    }
}


1			<?php
2
3			namespace Timegridio\Concierge\Vacancy;
4
5			use Carbon\Carbon;
6			use Timegridio\Concierge\Models\Business;
7			use Timegridio\Concierge\Models\Service;
8			use Timegridio\Concierge\Models\Vacancy;
9
10			class VacancyManager
11			{
12			protected $business;
13
14	4		public function __construct(Business $business)
15			{
16	4		$this->business = $business;
17	4		}
18
19			/**
20			* Update vacancies from batch statements.
21			*
22			* @param Business $business
23			* @param array $parsedStatements
24			*
25			* @return bool
26			*/
27	2		public function updateBatch(Business $business, $parsedStatements)
28			{
29	2		$changed = false;
30	2		$dates = $this->arrayGroupBy('date', $parsedStatements);
31
32	2		foreach ($dates as $date => $statements) {
33	2		$services = $this->arrayGroupBy('service', $statements);
34
35	2		$changed \|= $this->processServiceStatements($business, $date, $services);
36	2		}
37
38	2		return $changed;
39			}
40
41	2		protected function processServiceStatements($business, $date, $services)
42			{
43	2		$changed = false;
44	2		foreach ($services as $serviceSlug => $statements) {
45	2		$service = Service::where('slug', $serviceSlug)->get()->first();
46
47	2		if ($service === null) {
48
49			// Invalid services are skipped to avoid user frustration.
50			// TODO: Still, a user-level WARNING should be raised with no fatal error
51
52	1		continue;
53			}
54
55	1		$vacancy = $business->vacancies()->forDate(Carbon::parse($date))->forService($service->id);
56
57	1		if ($vacancy) {
58	1		$vacancy->delete();
59	1		}
60
61	1		$changed \|= $this->processStatements($business, $date, $service, $statements);
62	2		}
63
64	2		return $changed;
65			}
66
67	1		protected function processStatements($business, $date, $service, $statements)
68			{
69	1		$changed = false;
70	1		foreach ($statements as $statement) {
71	1		$changed \|= $this->publishVacancy($business, $date, $service, $statement);
72	1		}
73
74	1		return $changed;
75			}
76
77	1		protected function publishVacancy($business, $date, $service, $statement)
			0 ignored issues – show Unused Code introduced 2016-03-01 00:13 UTC by Report Bug Copy Issue Report The parameter `$date` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
78			{
79	1		$date = $statement['date'];
80	1		$startAt = $statement['startAt'];
81	1		$finishAt = $statement['finishAt'];
82
83	1		$startAt = Carbon::parse("{$date} {$startAt} {$business->timezone}")->timezone('UTC');
84	1		$finishAt = Carbon::parse("{$date} {$finishAt} {$business->timezone}")->timezone('UTC');
85
86			$vacancyValues = [
87	1		'business_id' => $business->id,
88	1		'service_id' => $service->id,
89	1		'date' => $statement['date'],
90	1		'capacity' => intval($statement['capacity']),
91	1		'start_at' => $startAt,
92	1		'finish_at' => $finishAt,
93	1		];
94
95	1		$vacancy = Vacancy::create($vacancyValues);
96
97	1		return $vacancy !== null;
98			}
99
100	2		protected function arrayGroupBy($key, $array)
101			{
102	2		$grouped = [];
103	2		foreach ($array as $hash => $item) {
104	2		if (!array_key_exists($item[$key], $grouped)) {
105	2		$grouped[$item[$key]] = [];
106	2		}
107	2		$grouped[$item[$key]][] = $item;
108	2		}
109
110	2		return $grouped;
111			}
112
113	1		public function publish($date, Carbon $startAt, Carbon $finishAt, $serviceId, $capacity = 1)
114			{
115			$vacancyKeys = [
116	1		'business_id' => $this->business->id,
			0 ignored issues – show Documentation introduced 2016-02-14 19:12 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Timegridio\Concierge\Models\Business>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
117	1		'service_id' => $serviceId,
118	1		'date' => $date,
119	1		];
120			$vacancyValues = [
121	1		'capacity' => intval($capacity),
122	1		'start_at' => $startAt->timezone('UTC')->toDateTimeString(),
123	1		'finish_at' => $finishAt->timezone('UTC')->toDateTimeString(),
124	1		];
125
126	1		return Vacancy::updateOrCreate($vacancyKeys, $vacancyValues);
			0 ignored issues – show Bug introduced 2016-02-25 01:13 UTC by Report Bug Copy Issue Report The method `updateOrCreate()` does not exist on `Timegridio\Concierge\Models\Vacancy`. Did you maybe mean `create()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
127			}
128
129			/**
130			* [generateAvailability description].
131			*
132			* @param Illuminate\Database\Eloquent\Collection $vacancies
133			* @param string $startDate
134			* @param int $futureDays
135			*
136			* @return array
137			*/
138	1		public static function generateAvailability($vacancies, $startDate = 'today', $futureDays = 10)
139			{
140	1		$dates = [];
141	1	View Code Duplication	for ($i = 0; $i < $futureDays; $i++) {
			0 ignored issues – show Duplication introduced 2016-02-14 23:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
142	1		$dates[date('Y-m-d', strtotime("$startDate +$i days"))] = [];
143	1		}
144
145	1		foreach ($vacancies as $vacancy) {
146	1		if (array_key_exists($vacancy->date, $dates)) {
147	1		$dates[$vacancy->date][$vacancy->service->slug] = $vacancy;
148	1		}
149	1		}
150
151	1		return $dates;
152			}
153			}
154

timegridio / concierge

Push — master ( c1caf9...097277 )

VacancyManager::processServiceStatements() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like