Service - Code Metrics - Inspection of "Minor fix and increment test coverage" - timegridio/concierge - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( df45e0...e7ba61 )

by Ariel

created 2016-02-11 17:36 UTC

Service A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	2	Features	0

Metric	Value
wmc	8
c	3
b	2
f	0
lcom	1
cbo	1
dl	0
loc	97
ccs	15
cts	15
cp	1
rs	10

6 Methods

Rating	Name	Size	Complexity
A	type()	4	1
A	business()	4	1
A	save()	6	1
A	setDurationAttribute()	4	2
A	scopeSlug()	4	1
A	getTypeNameAttribute()	8	2

<?php

namespace Timegridio\Concierge\Models;

use Illuminate\Database\Eloquent\Model as EloquentModel;

class Service extends EloquentModel
{
    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = ['name', 'business_id', 'description', 'prerequisites', 'duration', 'type_id', 'color'];

    /**
     * The attributes that aren't mass assignable.
     *
     * @var array
     */
    protected $guarded = ['id', 'slug'];

    /**
     * Belongs to service type.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo Relationship Service belongs to type query
     */
    public function type()
    {
        return $this->belongsTo(ServiceType::class);
    }

    /**
     * Get service type name.
     *
     * @return string
     */
    public function getTypeNameAttribute()
    {
        if ($this->type) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return $this->type->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        return '';
    }

    /**
     * belongs to Business.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo Relationship Service belongs to Business query
     */
    public function business()
    {
        return $this->belongsTo(Business::class);
    }

    /**
     * TODO: Check slug setting can be moved to a more proper place.
     *
     * Save the model to the database.
     *
     * @param array $options
     *
     * @return bool
     */
    public function save(array $options = [])
    {
        $this->attributes['slug'] = str_slug($this->attributes['name']);

        return parent::save($options);
    }

    //////////////
    // Mutators //
    //////////////

    /**
     * set Duration Attribute.
     *
     * @param int $duration
     */
    public function setDurationAttribute($duration)
    {
        return $this->attributes['duration'] = $duration ? intval($duration) : null;
    }

    ////////////
    // Scopes //
    ////////////

    /**
     * Scope Slug.
     *
     * @param Illuminate\Database\Query $query
     * @param string                    $slug  Slug of the desired Service
     *
     * @return Illuminate\Database\Query Scoped query
     */
    public function scopeSlug($query, $slug)
    {
        return $query->where('slug', '=', $slug)->get();
    }
}


1		<?php
2
3		namespace Timegridio\Concierge\Models;
4
5		use Illuminate\Database\Eloquent\Model as EloquentModel;
6
7		class Service extends EloquentModel
8		{
9		/**
10		* The attributes that are mass assignable.
11		*
12		* @var array
13		*/
14		protected $fillable = ['name', 'business_id', 'description', 'prerequisites', 'duration', 'type_id', 'color'];
15
16		/**
17		* The attributes that aren't mass assignable.
18		*
19		* @var array
20		*/
21		protected $guarded = ['id', 'slug'];
22
23		/**
24		* Belongs to service type.
25		*
26		* @return \Illuminate\Database\Eloquent\Relations\BelongsTo Relationship Service belongs to type query
27		*/
28	3	public function type()
29		{
30	3	return $this->belongsTo(ServiceType::class);
31		}
32
33		/**
34		* Get service type name.
35		*
36		* @return string
37		*/
38	2	public function getTypeNameAttribute()
39		{
40	2	if ($this->type) {
		0 ignored issues – show Documentation introduced 2016-02-11 17:44 UTC by Report Bug Copy Issue Report The property `type` does not exist on `object<Timegridio\Concierge\Models\Service>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41	1	return $this->type->name;
		0 ignored issues – show Documentation introduced 2016-02-03 04:24 UTC by Report Bug Copy Issue Report The property `type` does not exist on `object<Timegridio\Concierge\Models\Service>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
42		}
43
44	1	return '';
45		}
46
47		/**
48		* belongs to Business.
49		*
50		* @return \Illuminate\Database\Eloquent\Relations\BelongsTo Relationship Service belongs to Business query
51		*/
52	3	public function business()
53		{
54	3	return $this->belongsTo(Business::class);
55		}
56
57		/**
58		* TODO: Check slug setting can be moved to a more proper place.
59		*
60		* Save the model to the database.
61		*
62		* @param array $options
63		*
64		* @return bool
65		*/
66	38	public function save(array $options = [])
67		{
68	38	$this->attributes['slug'] = str_slug($this->attributes['name']);
69
70	38	return parent::save($options);
71		}
72
73		//////////////
74		// Mutators //
75		//////////////
76
77		/**
78		* set Duration Attribute.
79		*
80		* @param int $duration
81		*/
82	38	public function setDurationAttribute($duration)
83		{
84	38	return $this->attributes['duration'] = $duration ? intval($duration) : null;
85		}
86
87		////////////
88		// Scopes //
89		////////////
90
91		/**
92		* Scope Slug.
93		*
94		* @param Illuminate\Database\Query $query
95		* @param string $slug Slug of the desired Service
96		*
97		* @return Illuminate\Database\Query Scoped query
98		*/
99	1	public function scopeSlug($query, $slug)
100		{
101	1	return $query->where('slug', '=', $slug)->get();
102		}
103		}
104

timegridio / concierge

Push — master ( df45e0...e7ba61 )

Service A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like