CommandTrait - Code Metrics - tidal/phpspec-behavior - Measure and Improve Code Quality continuously with Scrutinizer

CommandTrait A
last analyzed 2017-04-23 10:16 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	9
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	1
lcom	0
cbo	0
dl	0
loc	9
rs	10
c	1
b	0
f	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	setPuts()	0	5	1

<?php
/**
 * This file is part of the phpspec-behavior package.
 * (c) 2017 Timo Michna <timomichna/yahoo.de>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tidal\PhpSpec\BehaviorExtension\Behavior\Console\Command;


use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Trait Behavior\Console\Command\CommandTrait
 */
trait CommandTrait
{

    protected function setPuts(InputInterface $input, OutputInterface $output)
    {
        $this->setInput($input);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->setOutput($output);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}



1			<?php
2			/**
3			* This file is part of the phpspec-behavior package.
4			* (c) 2017 Timo Michna <timomichna/yahoo.de>
5			*
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*/
9
10			namespace Tidal\PhpSpec\BehaviorExtension\Behavior\Console\Command;
11
12
13			use Symfony\Component\Console\Input\InputInterface;
14			use Symfony\Component\Console\Output\OutputInterface;
15
16			/**
17			* Trait Behavior\Console\Command\CommandTrait
18			*/
19			trait CommandTrait
20			{
21
22			protected function setPuts(InputInterface $input, OutputInterface $output)
23			{
24			$this->setInput($input);
			0 ignored issues – show Bug introduced 2017-04-23 05:54 UTC by Report Bug Copy Issue Report It seems like `setInput()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			$this->setOutput($output);
			0 ignored issues – show Bug introduced 2017-04-23 05:54 UTC by Report Bug Copy Issue Report It seems like `setOutput()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26			}
27			}
28
29

tidal / phpspec-behavior

CommandTrait A last analyzed 2017-04-23 10:16 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like

CommandTrait A
last analyzed 2017-04-23 10:16 UTC