Tidal\WampWatch\Model\Property\Collection\HasRealmsTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	64
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	addRealm()	4	4	1
A	getRealms()	4	4	1
A	hasRealm()	4	4	1
A	getRealm()	4	4	1
A	removeRealm()	4	4	1
A	listRealms()	6	6	2
A	setRealms()	5	5	1

<?php

/*
 * This file is part of the Tidal/WampWatch package.
 *   (c) 2016 Timo Michna <timomichna/yahoo.de>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 *
 */

namespace Tidal\WampWatch\Model\Property\Collection;

use Tidal\WampWatch\Model\Contract;
use Tidal\WampWatch\Model\Contract\Property\ObjectCollectionInterface;
use Tidal\WampWatch\Model\Contract\RealmInterface;

/**
 * Class HasRealmsTrait.
 *
 * Important! Classes using this trait have to also use trait
 * Tidal\WampWatch\Model\Behavior\Property\HasCollectionsTrait
 * for this trait to work;
 */
trait HasRealmsTrait

This class seems to be duplicated in your project.

{
    protected $realmsPropertyName = 'realms';

    /**
     * @var ObjectCollectionInterface
     */
    private $realms;

    public function addRealm(Contract\RealmInterface $realm)
    {
        $this->getRealms()->set($realm->getName(), $realm);
    }

    /**
     * @return ObjectCollectionInterface
     */
    private function getRealms()
    {
        return $this->getCollection($this->realmsPropertyName);

It seems like getCollection() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function hasRealm($name)
    {
        return $this->getRealms()->has($name);
    }

    /**
     * @param $name
     *
     * @return Contract\RealmInterface
     */
    public function getRealm($name)
    {
        return $this->getRealms()->get($name);
    }

    /**
     * @param $name
     */
    public function removeRealm($name)
    {
        $this->getRealms()->offsetUnset($name);
    }

    /**
     * @return \Generator
     */
    public function listRealms()
    {
        foreach ($this->getRealms()->getIterator() as $name => $realm) {
            yield $name => $realm;
        }
    }

    /**
     * @param ObjectCollectionInterface $realms
     */
    private function setRealms(ObjectCollectionInterface $realms)
    {
        $this->initCollection($this->realmsPropertyName, $realms);

It seems like initCollection() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $realms->setObjectConstrain(RealmInterface::class);
    }
}