tidal / PEIP

src/Context/XMLContext.php

Doc Comments +11 added lines, -7 removed lines

@@ -141,7 +141,7 @@ 
      * 

      * @implements \PEIP\INF\Context\Context

      * @access public

-     * @param \PEIP\INF\Context\Context_Plugin $plugin a plugin instance

+     * @param \PEIP\INF\Context\ContextPlugin $plugin a plugin instance

      */

     public function addPlugin(\PEIP\INF\Context\ContextPlugin $plugin){ 

         $plugin->init($this);   

@@ -173,7 +173,6 @@ 
      * </config>     

      * 

      * @access public

-     * @param XMLContext $config the config to include

      */    

     public function includeContext(XMLContext $context){

         $this->services = array_merge($this->services, $context->getServices());

@@ -184,7 +183,7 @@ 
      * 

      * @see XMLContext::includeContext

      * @access public

-     * @param XMLContext $context the config to include

+     * @param string $filePath
      */    

     public function includeContextFromFile($filePath){

         if(file_exists($filePath)){

@@ -363,7 +362,7 @@ 
      * 

      * @access public

      * @param $config 

-     * @return object the initialized service instance

+     * @return \PEIP\INF\Context\ContextPlugin the initialized service instance

      */

     public function createService($config){

         return ServiceFactory::createService($config);      

@@ -692,7 +691,7 @@ 
      * 

      * @access protected

      * @param object $config configuration object to create arguments from.  

-     * @return mixed build arguments 

+     * @return \PEIP\INF\Channel\Channel[] build arguments 

      */

     protected function getReplyHandlerArguments($config){

         $args = array(

@@ -737,7 +736,8 @@ 
      * 

      * @access protected

      * @param string the configuration type ofthe channel (e.g.: 'reply', 'request')

-     * @param object $config configuration object to return channel from. 

+     * @param object $config configuration object to return channel from.
+     * @param string $type 

      * @return \PEIP\INF\Channel\Channel reply-channel

      */

     public function doGetChannel($type, $config){

@@ -832,7 +832,7 @@ 
      * @see GenericBuilder

      * @static

      * @access protected

-     * @param object $className name of class to build instance for. 

+     * @param string $className name of class to build instance for. 

      * @param array $arguments arguments for the constructor 

      * @return object build and modified srvice instance

      */     

@@ -840,6 +840,10 @@ 
         return GenericBuilder::getInstance($className)->build($arguments);

     }

 

+    /**
+     * @param string $type
+     * @param string $name
+     */
     protected static function hasPublicProperty($service, $type, $name){

         $reflection = GenericBuilder::getInstance(get_class($service))->getReflectionClass();

         if($reflection->{'has'.$type}($name) && $reflection->{'get'.$type}($name)->isPublic()){

Braces +14 added lines, -14 removed lines

@@ -94,7 +94,7 @@ 
     public static function createFromFile($file){

         if(file_exists($file)){

             return self::createFromString(file_get_contents($file));

-        }else{

+        } else{

             throw new \RuntimeException('Cannot open file  "'.$file.'".');

         }

     }

@@ -386,7 +386,7 @@ 
                     $setter = self::getSetter($property);               

                     if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){

                         $service->{$setter}($arg);  

-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

+                    } elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

                         $service->$setter = $arg;

                     }                   

                 }

@@ -619,7 +619,7 @@ 
         $ref = trim((string)$config['ref']);

         if($ref != ''){

             $service = $this->getService($ref); 

-        }else{

+        } else{

             $service = $this->createService($config);

         }

         return $service;

@@ -639,7 +639,7 @@ 
     protected static function getSetter($config){

         if($config['setter']){

             $setter = (string)$config['setter'];

-        }elseif($config['name']){

+        } elseif($config['name']){

             $setter = 'set'.ucfirst((string)$config['name']);   

         }

         return $setter;     

@@ -655,26 +655,26 @@ 
     protected function buildArg($config){ 

         if(trim((string)$config['value']) != ''){

             $arg = (string)$config['value'];

-        }elseif($config->getName() == 'value'){

+        } elseif($config->getName() == 'value'){

             $arg = (string)$config;

-        }elseif($config->getName() == 'list'){

+        } elseif($config->getName() == 'list'){

             $arg = array();

             foreach($config->children() as $entry){ 

                 if($entry->getName() == 'value'){

                     if($entry['key']){

                         $arg[(string)$entry['key']] = (string)$entry;   

-                    }else{

+                    } else{

                         $arg[] = (string)$entry;

                     }

-                }elseif($entry->getName() == 'service'){

+                } elseif($entry->getName() == 'service'){

                     $arg[] = $this->provideService($entry);

                 }

             }

-        }elseif($config->getName() == 'service'){

+        } elseif($config->getName() == 'service'){

             $arg = $this->provideService($config);

-        }elseif($config->list){

+        } elseif($config->list){

             $arg = $this->buildArg($config->list);

-        }elseif($config->service){

+        } elseif($config->service){

             $arg = $this->buildArg($config->service);

         } 

         return $arg; 

@@ -742,7 +742,7 @@ 
         $channel =  $this->services[trim((string)$channelName)];

         if($channel instanceof \PEIP\INF\Channel\Channel){

             return $channel;    

-        }else{

+        } else{

             return NULL;

         }       

     }

@@ -781,10 +781,10 @@ 
                 $constructor = (string)$config["constructor"];

         if($constructor != ''){

             $service = call_user_func_array(array($cls, $constructor), $arguments); 

-        }else{

+        } else{

             $service = self::build($cls, $arguments); 

         }        

-            }catch(\Exception $e){

+            } catch(\Exception $e){

                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());

             }           

         }