tidal / PEIP

src/Factory/DedicatedFactory.php

Doc Comments +3 added lines

@@ -47,6 +47,9 @@
         return new DedicatedFactory(array($class, '__construct'), $parameters); 

     } 

 

+    /**
+     * @param string[] $callable
+     */
     public static function getfromCallable($callable, array $parameters = array()){

         return new DedicatedFactory($callable, $parameters); 

     } 

Spacing +5 added lines, -5 removed lines

@@ -38,16 +38,16 @@ 
      * @param $parameters 

      * @return 

      */

-    protected function __construct($callable ,array $parameters = array()){

+    protected function __construct($callable, array $parameters = array()) {

         $this->callable = $callable;

         $this->setParameters($parameters);

     }

 

-    public static function getfromClass($class, array $parameters = array()){

+    public static function getfromClass($class, array $parameters = array()) {

         return new DedicatedFactory(array($class, '__construct'), $parameters); 

     } 

 

-    public static function getfromCallable($callable, array $parameters = array()){

+    public static function getfromCallable($callable, array $parameters = array()) {

         return new DedicatedFactory($callable, $parameters); 

     } 

     

@@ -57,7 +57,7 @@ 
      * @param $arguments 

      * @return 

      */

-    public function build(array $arguments = array()){

+    public function build(array $arguments = array()) {

         $arguments = count($arguments) > 0 ? $arguments : $this->getParameters();

         return (is_array($this->callable) && $this->callable[1] == '__construct') 

             ? GenericBuilder::GetInstance($this->callable[0])->build($arguments) 

@@ -70,7 +70,7 @@ 
      * @param $method 

      * @return 

      */

-    public function setConstructor($method){

+    public function setConstructor($method) {

         $this->constructor = (string)$method;

         return $this;

     }   

src/Factory/ServiceFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
      * @see GenericBuilder

      * @static

      * @access protected

-     * @param object $className name of class to build instance for.

+     * @param string $className name of class to build instance for.

      * @param array $arguments arguments for the constructor

      * @return object build and modified srvice instance

      */

Unused Use Statements +2 added lines, -2 removed lines

@@ -11,8 +11,8 @@
  *

  * @author timo

  */

-use PEIP\Util\Test;

-use PEIP\Base\GenericBuilder;

+use PEIP\Util\Test;
+use PEIP\Base\GenericBuilder;
 use PEIP\Context\XMLContext;

 

 class ServiceFactory {

Indentation +23 added lines, -23 removed lines

@@ -16,13 +16,13 @@ 
 use PEIP\Context\XMLContext;

 

 class ServiceFactory {

-     /**

-     * Creates and initializes service instance from a given configuration.

-     *

-     * @access public

-     * @param $config

-     * @return object the initialized service instance

-     */

+        /**

+         * Creates and initializes service instance from a given configuration.

+         *

+         * @access public

+         * @param $config

+         * @return object the initialized service instance

+         */

     public static function createService($config){

         $args = array();

         //build arguments for constructor

@@ -35,15 +35,15 @@ 
     }

 

         /**

-     * Builds an arbitrary service/object instance from a config-obect.

-     *

-     * @static

-     * @access protected

-     * @param object $config configuration object to build a service instance from.

-     * @param array $arguments arguments for the service constructor

-     * @param string $defaultClass class to create instance for if none is set in config

-     * @return object build and modified srvice instance

-     */

+         * Builds an arbitrary service/object instance from a config-obect.

+         *

+         * @static

+         * @access protected

+         * @param object $config configuration object to build a service instance from.

+         * @param array $arguments arguments for the service constructor

+         * @param string $defaultClass class to create instance for if none is set in config

+         * @return object build and modified srvice instance

+         */

     public static function doBuild($config, $arguments, $defaultClass = false){

         $cls = $config["class"] ? trim((string)$config["class"]) : (string)$defaultClass;

         if($cls != ''){

@@ -80,12 +80,12 @@ 
     }

 

         /**

-     * Builds single argument (to call a method with later) from a config-obect.

-     *

-     * @access protected

-     * @param object $config configuration object to create argument from.

-     * @return mixed build argument

-     */

+         * Builds single argument (to call a method with later) from a config-obect.

+         *

+         * @access protected

+         * @param object $config configuration object to create argument from.

+         * @return mixed build argument

+         */

     protected static function buildArg($config){

         if(trim((string)$config['value']) != ''){

             $arg = (string)$config['value'];

@@ -128,7 +128,7 @@ 
      */

     public static function buildAndModify($config, $arguments, $defaultClass = false){

         if("" != (string)$config["class"]  || $defaultClass){

-             $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

+                $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

         }else{

             throw new \RuntimeException('Could not create Service. no class or reference given.');

         }

Spacing +44 added lines, -44 removed lines

@@ -23,11 +23,11 @@ 
      * @param $config

      * @return object the initialized service instance

      */

-    public static function createService($config){

+    public static function createService($config) {

         $args = array();

         //build arguments for constructor

-        if($config->constructor_arg){

-            foreach($config->constructor_arg as $arg){

+        if ($config->constructor_arg) {

+            foreach ($config->constructor_arg as $arg) {

                 $args[] = self::buildArg($arg);

             }

         }

@@ -44,21 +44,21 @@ 
      * @param string $defaultClass class to create instance for if none is set in config

      * @return object build and modified srvice instance

      */

-    public static function doBuild($config, $arguments, $defaultClass = false){

+    public static function doBuild($config, $arguments, $defaultClass = false) {

         $cls = isset($config["class"]) ? trim((string)$config["class"]) : (string)$defaultClass;

-        if($cls != ''){

+        if ($cls != '') {

             try {

-                $constructor = isset($config["constructor"])?(string)$config["constructor"]:"";

-                if($constructor != '' && Test::assertMethod($cls, $constructor)){

+                $constructor = isset($config["constructor"]) ? (string)$config["constructor"] : "";

+                if ($constructor != '' && Test::assertMethod($cls, $constructor)) {

                     $service = call_user_func_array(array($cls, $constructor), $arguments);

-                }else{

+                }else {

                     $service = self::build($cls, $arguments);

                 }

-            }catch(\Exception $e){

+            } catch (\Exception $e) {

                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());

             }

         }

-        if(is_object($service)){

+        if (is_object($service)) {

             return $service;

         }

         throw new \RuntimeException('Could not create Service "'.$cls.'". Class does not exist.');

@@ -75,7 +75,7 @@ 
      * @param array $arguments arguments for the constructor

      * @return object build and modified srvice instance

      */

-    public static function build($className, $arguments){

+    public static function build($className, $arguments) {

         return GenericBuilder::getInstance($className)->build($arguments);

     }

 

@@ -86,29 +86,29 @@ 
      * @param object $config configuration object to create argument from.

      * @return mixed build argument

      */

-    protected static function buildArg($config){

-        if(trim((string)$config['value']) != ''){

+    protected static function buildArg($config) {

+        if (trim((string)$config['value']) != '') {

             $arg = (string)$config['value'];

-        }elseif($config->getName() == 'value'){

+        }elseif ($config->getName() == 'value') {

             $arg = (string)$config;

-        }elseif($config->getName() == 'list'){

+        }elseif ($config->getName() == 'list') {

             $arg = array();

-            foreach($config->children() as $entry){

-                if($entry->getName() == 'value'){

-                    if($entry['key']){

+            foreach ($config->children() as $entry) {

+                if ($entry->getName() == 'value') {

+                    if ($entry['key']) {

                         $arg[(string)$entry['key']] = (string)$entry;

-                    }else{

+                    }else {

                         $arg[] = (string)$entry;

                     }

-                }elseif($entry->getName() == 'service'){

+                }elseif ($entry->getName() == 'service') {

                     $arg[] = $this->provideService($entry);

                 }

             }

-        }elseif($config->getName() == 'service'){

+        }elseif ($config->getName() == 'service') {

             $arg = self::provideService($config);

-        }elseif($config->list){

+        }elseif ($config->list) {

             $arg = self::buildArg($config->list);

-        }elseif($config->service){

+        }elseif ($config->service) {

             $arg = self::buildArg($config->service);

         }

         return $arg;

@@ -126,24 +126,24 @@ 
      * @param string $defaultClass class to create instance for if none is set in config

      * @return object build and modified srvice instance

      */

-    public static function buildAndModify($config, $arguments, $defaultClass = ""){

-        if((isset($config["class"]) && "" != (string)$config["class"])  || $defaultClass !== ""){

+    public static function buildAndModify($config, $arguments, $defaultClass = "") {

+        if ((isset($config["class"]) && "" != (string)$config["class"]) || $defaultClass !== "") {

              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

-        }else{

+        }else {

             throw new \RuntimeException('Could not create Service. no class or reference given.');

         }

-        if(isset($config["ref_property"])){

+        if (isset($config["ref_property"])) {

             $service = $service->{(string)$config["ref_property"]};

-        }elseif(isset($config["ref_method"])){

+        }elseif (isset($config["ref_method"])) {

                 $args = array();

-            if($config->argument){

-                        foreach($config->argument as $arg){

+            if ($config->argument) {

+                        foreach ($config->argument as $arg) {

                             $args[] = $this->buildArg($arg);

                         }

                 }

             $service = call_user_func_array(array($service, (string)$config["ref_method"]), $args);

         }

-        if(!is_object($service)){

+        if (!is_object($service)) {

             throw new \RuntimeException('Could not create Service.');

         }

         $service = self::modifyService($service, $config);

@@ -166,30 +166,30 @@ 
      * @param object $config configuration to get the modification instructions from.

      * @return object the modificated service

      */

-    protected function modifyService($service, $config){        

+    protected function modifyService($service, $config) {        

         $config = is_array($config) ? new \ArrayObject($config) : $config;

         $reflection = GenericBuilder::getInstance(get_class($service))->getReflectionClass();

         // set instance properties

-        if(isset($config->property)){

-            foreach($config->property as $property){

+        if (isset($config->property)) {

+            foreach ($config->property as $property) {

                 $arg = self::buildArg($property);

-                if($arg){

+                if ($arg) {

                     $setter = self::getSetter($property);

-                    if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){

+                    if ($setter && self::hasPublicProperty($service, 'Method', $setter)) {

                         $service->{$setter}($arg);

-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

+                    }elseif (in_array($property, self::hasPublicProperty($service, 'Property', $setter))) {

                         $service->$setter = $arg;

                     }

                 }

             }

         }

         // call instance methods

-        if(isset($config->action)){

-            foreach($config->action as $action){

+        if (isset($config->action)) {

+            foreach ($config->action as $action) {

                 $method = (string)$action['method'] != '' ? (string)$action['method'] : NULL;

-                if($method && self::hasPublicProperty($service, 'Method', $method)){

+                if ($method && self::hasPublicProperty($service, 'Method', $method)) {

                     $args = array();

-                    foreach($action->children() as $argument){

+                    foreach ($action->children() as $argument) {

                         $args[] = $this->buildArg($argument);

                     }

                     call_user_func_array(array($service, (string)$action['method']), $args);

@@ -197,9 +197,9 @@ 
             }

         }

         // register instance listeners

-        if($service instanceof \PEIP\INF\Event\Connectable){

-            if(isset($config->listener)){

-                foreach($config->listener as $listenerConf){

+        if ($service instanceof \PEIP\INF\Event\Connectable) {

+            if (isset($config->listener)) {

+                foreach ($config->listener as $listenerConf) {

                     $event = (string)$listenerConf['event'];

                     $listener = $this->provideService($listenerConf);

                     $service->connect($event, $listener);

Braces +12 added lines, -12 removed lines

@@ -51,10 +51,10 @@ 
                 $constructor = isset($config["constructor"])?(string)$config["constructor"]:"";

                 if($constructor != '' && Test::assertMethod($cls, $constructor)){

                     $service = call_user_func_array(array($cls, $constructor), $arguments);

-                }else{

+                } else{

                     $service = self::build($cls, $arguments);

                 }

-            }catch(\Exception $e){

+            } catch(\Exception $e){

                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());

             }

         }

@@ -89,26 +89,26 @@ 
     protected static function buildArg($config){

         if(trim((string)$config['value']) != ''){

             $arg = (string)$config['value'];

-        }elseif($config->getName() == 'value'){

+        } elseif($config->getName() == 'value'){

             $arg = (string)$config;

-        }elseif($config->getName() == 'list'){

+        } elseif($config->getName() == 'list'){

             $arg = array();

             foreach($config->children() as $entry){

                 if($entry->getName() == 'value'){

                     if($entry['key']){

                         $arg[(string)$entry['key']] = (string)$entry;

-                    }else{

+                    } else{

                         $arg[] = (string)$entry;

                     }

-                }elseif($entry->getName() == 'service'){

+                } elseif($entry->getName() == 'service'){

                     $arg[] = $this->provideService($entry);

                 }

             }

-        }elseif($config->getName() == 'service'){

+        } elseif($config->getName() == 'service'){

             $arg = self::provideService($config);

-        }elseif($config->list){

+        } elseif($config->list){

             $arg = self::buildArg($config->list);

-        }elseif($config->service){

+        } elseif($config->service){

             $arg = self::buildArg($config->service);

         }

         return $arg;

@@ -129,12 +129,12 @@ 
     public static function buildAndModify($config, $arguments, $defaultClass = ""){

         if((isset($config["class"]) && "" != (string)$config["class"])  || $defaultClass !== ""){

              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

-        }else{

+        } else{

             throw new \RuntimeException('Could not create Service. no class or reference given.');

         }

         if(isset($config["ref_property"])){

             $service = $service->{(string)$config["ref_property"]};

-        }elseif(isset($config["ref_method"])){

+        } elseif(isset($config["ref_method"])){

                 $args = array();

             if($config->argument){

                         foreach($config->argument as $arg){

@@ -177,7 +177,7 @@ 
                     $setter = self::getSetter($property);

                     if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){

                         $service->{$setter}($arg);

-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

+                    } elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

                         $service->$setter = $arg;

                     }

                 }

src/Gateway/SimpleMessagingGateway.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  * @implements \PEIP\INF\Gateway\MessagingGateway, \PEIP\INF\Message\MessageBuilder

  */

 

-use PEIP\Message\GenericMessage;

+use PEIP\Message\GenericMessage;
 use PEIP\Message\MessageBuilder;

 

 class SimpleMessagingGateway 

Spacing +15 added lines, -15 removed lines

@@ -43,9 +43,9 @@ 
      * @param \PEIP\INF\Channel\PollableChannel $replyChannel The default channel to receive requests from the gateway

      * @param array $defaultHeaders The default headers to apply to request messages 

      */

-    public function __construct(\PEIP\INF\Channel\Channel $requestChannel, \PEIP\INF\Channel\Channel $replyChannel = NULL, array $defaultHeaders = array()){

+    public function __construct(\PEIP\INF\Channel\Channel $requestChannel, \PEIP\INF\Channel\Channel $replyChannel = NULL, array $defaultHeaders = array()) {

         $this->setRequestChannel($requestChannel);

-        if($replyChannel){

+        if ($replyChannel) {

             $this->setReplyChannel($replyChannel);

         }     

         $this->defaultHeaders = $defaultHeaders;

@@ -59,7 +59,7 @@ 
      * @param \PEIP\INF\Channel\Channel $replyChannel The default channel to receive requests from the gateway

      * @return 

      */

-    public function setRequestChannel(\PEIP\INF\Channel\Channel $requestChannel){

+    public function setRequestChannel(\PEIP\INF\Channel\Channel $requestChannel) {

         $this->requestChannel = $requestChannel;

     }

   

@@ -70,8 +70,8 @@ 
      * @param \PEIP\INF\Channel\PollableChannel $replyChannel The default channel to receive requests from the gateway

      * @return 

      */

-    public function setReplyChannel(\PEIP\INF\Channel\Channel $replyChannel){

-        if(!($replyChannel instanceof \PEIP\INF\Channel\PollableChannel)){

+    public function setReplyChannel(\PEIP\INF\Channel\Channel $replyChannel) {

+        if (!($replyChannel instanceof \PEIP\INF\Channel\PollableChannel)) {

             throw new \InvalidArgumentException('reply channel must be instance of \PEIP\INF\Channel\PollableChannel.');

         }       

         $this->replyChannel = $replyChannel;

@@ -84,7 +84,7 @@ 
      * @param mixed $content the content/payload for the message to send 

      * @return 

      */

-    public function send($content){

+    public function send($content) {

         return $this->requestChannel->send($this->buildMessage($content));

     }

    

@@ -94,12 +94,12 @@ 
      * @access public

      * @return mixed content/payload of the received message

      */

-    public function receive(){

-        if(!isset($this->replyChannel)){

+    public function receive() {

+        if (!isset($this->replyChannel)) {

             throw new \LogicException('No replyChannel set.');

         }       

         $message = $this->replyChannel->receive();

-        if($message){

+        if ($message) {

             return $message->getContent();

         }

         return NULL;

@@ -112,12 +112,12 @@ 
      * @param mixed $content the content/payload for the message to send 

      * @return mixed content/payload of the received message

      */

-    public function sendAndReceive($content){

+    public function sendAndReceive($content) {

         $this->send($content);

         try {

             $res = $this->receive();

         }

-        catch(\Exception $e){

+        catch (\Exception $e) {

             return NULL;

         }

         return $res;

@@ -130,7 +130,7 @@ 
      * @param mixed $content the content/payload for the message to send 

      * @return \PEIP\INF\Message\Message the built message

      */

-    protected function buildMessage($content){

+    protected function buildMessage($content) {

         return $this->getMessageBuilder()->setContent($content)->build();   

     }   

       

@@ -140,7 +140,7 @@ 
      * @access protected

      * @return MessageBuilder message builder instance for the registerd message class

      */

-    protected function getMessageBuilder(){

+    protected function getMessageBuilder() {

         return isset($this->messageBuilder) && ($this->messageBuilder->getMessageClass() == $this->getMessageClass())

             ? $this->messageBuilder

             : $this->messageBuilder = MessageBuilder::getInstance($this->messageClass)->setHeaders($this->defaultHeaders);

@@ -153,7 +153,7 @@ 
      * @param   string $messageClass message class to create instances from

      * @return 

      */

-    public function setMessageClass($messageClass){

+    public function setMessageClass($messageClass) {

         $this->messageClass = $messageClass;

     }

     

@@ -163,7 +163,7 @@ 
      * @access public

      * @return string message class to create instances from

      */

-    public function getMessageClass(){

+    public function getMessageClass() {

         return $this->messageClass;

     }   

 

Braces +1 added lines, -2 removed lines

@@ -116,8 +116,7 @@
         $this->send($content);

         try {

             $res = $this->receive();

-        }

-        catch(\Exception $e){

+        } catch(\Exception $e){

             return NULL;

         }

         return $res;

Doc Comments +1 added lines, -2 removed lines

@@ -56,7 +56,6 @@ 
      * sets the channel to send requests from the gateway

      * 

      * @access public

-     * @param \PEIP\INF\Channel\Channel $replyChannel The default channel to receive requests from the gateway

      * @return 

      */

     public function setRequestChannel(\PEIP\INF\Channel\Channel $requestChannel){

@@ -109,7 +108,7 @@ 
      * sends and receives a request/message through the gateway

      * 

      * @access public

-     * @param mixed $content the content/payload for the message to send 

+     * @param \Order $content the content/payload for the message to send 

      * @return mixed content/payload of the received message

      */

     public function sendAndReceive($content){

src/INF/Channel/Channel.php

Doc Comments +3 added lines, -3 removed lines

@@ -33,10 +33,10 @@
      * Send a message, blocking until either the message is accepted or the

      * specified timeout period elapses.

      * 

-     * @param message the {@link Message} to send

-     * @param timeout the timeout in milliseconds

+     * @param message \PEIP\INF\Message\Message {@link Message} to send

+     * @param timeout integer timeout in milliseconds

      * 

-     * @return <code>true</code> if the message is sent successfully,

+     * @return void if the message is sent successfully,

      * <code>false</false> if the specified timeout period elapses or

      * the send is interrupted

      */

src/Message/GenericMessage.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  * @implements \PEIP\INF\Base\Container, \PEIP\INF\Message\Message, \PEIP\INF\Base\Buildable

  */

 

-use PEIP\Util\Test;

+use PEIP\Util\Test;
 use PEIP\Base\GenericBuilder;

 

 class GenericMessage 

Indentation +5 added lines, -5 removed lines

@@ -76,11 +76,11 @@
     }

 

         /**

-     * returns all headers of the message

-     * 

-     * @access public

-     * @return ArrayAccess ArrayAccess object of headers

-     */

+         * returns all headers of the message

+         * 

+         * @access public

+         * @return ArrayAccess ArrayAccess object of headers

+         */

     public function getHeaders(){

         return (array) $this->headers;

     }

Spacing +15 added lines, -15 removed lines

@@ -41,7 +41,7 @@ 
      * @param mixed $content The content/payload of the message 

      * @param array|ArrayAccess $headers headers as key/value pairs

      */

-    public function __construct($content, $headers = array()){

+    public function __construct($content, $headers = array()) {

         $this->doSetContent($content);

         $this->doSetHeaders($headers);          

     }

@@ -53,7 +53,7 @@ 
      * @access public

      * @return

      */

-    public function getContent(){

+    public function getContent() {

         return $this->content;

     }

 

@@ -63,13 +63,13 @@ 
      * @access protected

      * @param mixed $content The content/payload of the message 

      */

-    protected function doSetContent($content){

+    protected function doSetContent($content) {

         $this->content = Test::castType($content, self::CONTENT_CAST_TYPE);

     }

 

-    protected function doSetHeaders($headers){

+    protected function doSetHeaders($headers) {

         $headers = Test::ensureArrayAccess($headers);

-        if(is_array($headers)){

+        if (is_array($headers)) {

             $headers = new \ArrayObject($headers);

         }

         $this->headers = $headers;

@@ -81,8 +81,8 @@ 
      * @access public

      * @return ArrayAccess ArrayAccess object of headers

      */

-    public function getHeaders(){

-        return (array) $this->headers;

+    public function getHeaders() {

+        return (array)$this->headers;

     }

   

     /**

@@ -92,7 +92,7 @@ 
      * @param string $name the name of the header  

      * @return mixed the value of the header

      */

-    public function getHeader($name){

+    public function getHeader($name) {

         $name = (string)$name;

         return isset($this->headers[$name]) ? $this->headers[$name] : NULL;

     }

@@ -105,8 +105,8 @@ 
      * @param string $name the name of the header

      * @return boolean wether the header has been successfully  set

      */

-    public function addHeader($name, $value){

-        if(!$this->hasHeader($name)){

+    public function addHeader($name, $value) {

+        if (!$this->hasHeader($name)) {

             $this->headers[$name] = $value;

             return true;

         }

@@ -120,7 +120,7 @@ 
      * @param string $name the name of the header

      * @return boolean wether the header is set

      */

-    public function hasHeader($name){

+    public function hasHeader($name) {

         return isset($this->headers[$name]);

     }

 

@@ -130,16 +130,16 @@ 
      * @access public

      * @return string  content/payload of the message

      */

-    public function __toString(){

+    public function __toString() {

         $res = false;

         try {

             $res = (string)$this->getContent();

         }

-        catch(\Exception $e){           

+        catch (\Exception $e) {           

             try {

                 $res = get_class($this->getContent());

             }

-            catch(\Exception $e){

+            catch (\Exception $e) {

 

             }

         }

@@ -159,7 +159,7 @@ 
      * @param array $arguments argumends for the constructor

      * @return GenericMessage new class instance

      */    

-    public static function build(array $arguments = array()){

+    public static function build(array $arguments = array()) {

         return GenericBuilder::getInstance(__CLASS__)->build($arguments);

     }     

 } 
\ No newline at end of file

Braces +2 added lines, -4 removed lines

@@ -134,12 +134,10 @@
         $res = false;

         try {

             $res = (string)$this->getContent();

-        }

-        catch(\Exception $e){           

+        } catch(\Exception $e){           

             try {

                 $res = get_class($this->getContent());

-            }

-            catch(\Exception $e){

+            } catch(\Exception $e){

 

             }

         }

src/Message/TextMessage.php

Doc Comments -1 removed lines

@@ -64,7 +64,6 @@
      * @static

      * @access public

      * @implements \PEIP\INF\Base\Buildable

-     * @param string $name the name of the header

      * @return boolean wether the header is set

      */

     public static function build(array $arguments = array()){

Spacing +4 added lines, -4 removed lines

@@ -34,7 +34,7 @@ 
      * @param $title 

      * @return 

      */

-    public function __construct($content, $title){

+    public function __construct($content, $title) {

         $this->setContent((string)$content);

     }

 

@@ -44,7 +44,7 @@ 
      * @param $title 

      * @return 

      */

-    public function setTitle($title){

+    public function setTitle($title) {

         $this->title = (string)$title;

     }

 

@@ -53,7 +53,7 @@ 
      * @access public

      * @return 

      */

-    public function getTitle(){

+    public function getTitle() {

         return $this->title;

     }

 

@@ -67,7 +67,7 @@ 
      * @param string $name the name of the header

      * @return boolean wether the header is set

      */

-    public static function build(array $arguments = array()){

+    public static function build(array $arguments = array()) {

         return GenericBuilder::getInstance('\PEIP\Message\StringMessage')->build($arguments);

     }

 

src/Pipe/FixedEventPipe.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
     

     /**

      * @access public

-     * @param $eventName 

+     * @param string $eventName 

      * @return 

      */

     public function setEventName($eventName){

Spacing +6 added lines, -6 removed lines

@@ -31,10 +31,10 @@ 
      * @param $inputChannel 

      * @return 

      */

-    public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel){        

-        if(isset($this->eventName)){

+    public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel) {        

+        if (isset($this->eventName)) {

             $this->connectChannel($inputChannel);   

-        }else{

+        }else {

             $this->inputChannel = $inputChannel;    

         }               

     }       

@@ -45,10 +45,10 @@ 
      * @param $eventName 

      * @return 

      */

-    public function setEventName($eventName){

-        if(!isset($this->eventName)){

+    public function setEventName($eventName) {

+        if (!isset($this->eventName)) {

             $this->eventName = $eventName;

-            if($this->inputChannel){

+            if ($this->inputChannel) {

                 $this->inputChannel->connect($this->eventName, $this);

             }   

         }

Braces +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     protected function getMessage($object){

         if($this->channel instanceof \PEIP\INF\Channel\SubscribableChannel){

             return $object; 

-        }else{

+        } else{

             return $object->getContent()->receive();

         }

     }

src/Pipe/Pipe.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -24,8 +24,8 @@
  */

 

 

-use PEIP\Dispatcher\Dispatcher;

-use PEIP\Event\Event;

+use PEIP\Dispatcher\Dispatcher;
+use PEIP\Event\Event;
 use PEIP\Util\Test;

 

 class Pipe 

Doc Comments +1 added lines, -1 removed lines

@@ -188,7 +188,7 @@
     

     /**

      * @access protected

-     * @param $commandName 

+     * @param string $commandName 

      * @param $callable 

      * @return 

      */

Spacing +17 added lines, -17 removed lines

@@ -64,7 +64,7 @@ 
      * @param $name 

      * @return 

      */

-    public function setName($name){

+    public function setName($name) {

         $this->name = $name;

     }

     

@@ -73,7 +73,7 @@ 
      * @access public

      * @return 

      */

-    public function getName(){

+    public function getName() {

         return $this->name;

     }

 

@@ -84,7 +84,7 @@ 
      * @param $timeout 

      * @return 

      */

-    public function send(\PEIP\INF\Message\Message $message, $timeout = -1){

+    public function send(\PEIP\INF\Message\Message $message, $timeout = -1) {

         return $this->handle($message);

     }

 

@@ -94,7 +94,7 @@ 
      * @param $message 

      * @return 

      */

-    protected function doSend(\PEIP\INF\Message\Message $message){

+    protected function doSend(\PEIP\INF\Message\Message $message) {

         $this->doFireEvent(self::EVENT_PRE_PUBLISH, array(self::HEADER_MESSAGE=>$message));

         $this->getMessageDispatcher()->notify($message);

         $this->doFireEvent(self::EVENT_POST_PUBLISH, array(self::HEADER_MESSAGE=>$message));

@@ -107,12 +107,12 @@ 
      * @param $content 

      * @return 

      */

-    protected function replyMessage($message){ 

+    protected function replyMessage($message) { 

         $message = $this->ensureMessage($message);

         //if(\PEIP\Util\Test::assertMessage($message)){

-            if($this->getOutputChannel()){ 

+            if ($this->getOutputChannel()) { 

                 $this->getOutputChannel()->send($message);

-            }else{ 

+            }else { 

                 $this->doSend($message);

             }

         //}

@@ -124,7 +124,7 @@ 
      * @param $message 

      * @return 

      */

-    protected function doReply(\PEIP\INF\Message\Message $message){

+    protected function doReply(\PEIP\INF\Message\Message $message) {

         $this->replyMessage($message);

     }

 

@@ -134,7 +134,7 @@ 
      * @param $handler 

      * @return 

      */

-    public function subscribe($handler){

+    public function subscribe($handler) {

         Test::ensureHandler($handler);

         $this->getMessageDispatcher()->connect($handler);

         $this->doFireEvent(self::EVENT_SUBSCRIBE, array(self::HEADER_SUBSCRIBER=>$handler));

@@ -146,7 +146,7 @@ 
      * @param $handler e

      * @return 

      */

-    public function unsubscribe($handler){

+    public function unsubscribe($handler) {

         Test::ensureHandler($handler);

         $this->getMessageDispatcher()->disconnect($handler);

         $this->doFireEvent(

@@ -164,9 +164,9 @@ 
      * @param $transferListeners 

      * @return 

      */

-    public function setMessageDispatcher(\PEIP\INF\Dispatcher\Dispatcher $dispatcher, $transferListeners = true){

-        if(isset($this->dispatcher) && $transferListeners){

-            foreach($this->dispatcher->getListeners() as $listener){

+    public function setMessageDispatcher(\PEIP\INF\Dispatcher\Dispatcher $dispatcher, $transferListeners = true) {

+        if (isset($this->dispatcher) && $transferListeners) {

+            foreach ($this->dispatcher->getListeners() as $listener) {

                 $dispatcher->connect($listener);

                 $this->dispatcher->disconnect($listener);       

             }   

@@ -180,7 +180,7 @@ 
      * @access public

      * @return 

      */

-    public function getMessageDispatcher(){

+    public function getMessageDispatcher() {

         $defaultDispatcher = self::DEFAULT_CLASS_MESSAGE_DISPATCHER;

         return isset($this->dispatcher) ? $this->dispatcher : $this->dispatcher = new $defaultDispatcher;

     }   

@@ -192,7 +192,7 @@ 
      * @param $callable 

      * @return 

      */

-    protected function registerCommand($commandName, $callable){

+    protected function registerCommand($commandName, $callable) {

         $this->commands[$commandName] = $callable;  

     }

     

@@ -202,10 +202,10 @@ 
      * @param $cmdMessage 

      * @return 

      */

-    public function command(\PEIP\INF\Message\Message $cmdMessage){

+    public function command(\PEIP\INF\Message\Message $cmdMessage) {

         $this->doFireEvent(self::EVENT_PRE_COMMAND, array(self::HEADER_MESSAGE=>$cmdMessage));

         $commandName = trim((string)$cmdMessage->getHeader('COMMAND'));

-        if($commandName != '' && array_key_exists($commandName, $this->commands)){

+        if ($commandName != '' && array_key_exists($commandName, $this->commands)) {

             call_user_func($this->commands[$commandName], $cmdMessage->getContent());   

         }

         $this->doFireEvent(self::EVENT_POST_COMMAND, array(self::HEADER_MESSAGE=>$cmdMessage));

Braces +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
         //if(\PEIP\Util\Test::assertMessage($message)){

             if($this->getOutputChannel()){ 

                 $this->getOutputChannel()->send($message);

-            }else{ 

+            } else{ 

                 $this->doSend($message);

             }

         //}

src/Plugins/BasePlugin.php

Doc Comments +3 added lines, -2 removed lines

@@ -217,7 +217,7 @@ 
      *

      * @access protected

      * @param object $config configuration object to create arguments from.

-     * @return mixed build arguments

+     * @return \PEIP\INF\Channel\Channel[] build arguments

      */

     protected function getReplyHandlerArguments($config){

         $args = array(

@@ -262,7 +262,8 @@ 
      *

      * @access protected

      * @param string the configuration type ofthe channel (e.g.: 'reply', 'request')

-     * @param object $config configuration object to return channel from.

+     * @param object $config configuration object to return channel from.
+     * @param string $type

      * @return \PEIP\INF\Channel\Channel reply-channel

      */

     public function doGetChannel($type, $config){

Unused Use Statements +5 added lines, -5 removed lines

@@ -11,11 +11,11 @@
  *

  * @author timo

  */

-use PEIP\Context\XMLContext;

-use PEIP\Channel\PollableChannel;

-use PEIP\Channel\PublishSubscribeChannel;

-use PEIP\Gateway\SimpleMessagingGateway;

-use PEIP\Listener\Wiretap;

+use PEIP\Context\XMLContext;
+use PEIP\Channel\PollableChannel;
+use PEIP\Channel\PublishSubscribeChannel;
+use PEIP\Gateway\SimpleMessagingGateway;
+use PEIP\Listener\Wiretap;
 use PEIP\Service\ServiceActivator;

 

 class BasePlugin extends \PEIP\ABS\Context\ContextPlugin {

Spacing +22 added lines, -22 removed lines

@@ -46,7 +46,7 @@ 
      * @param object $config configuration object for the pollable channel.

      * @return \PEIP\INF\Channel\Channel the created pollable channel instance

      */

-    public function createChannel($config){

+    public function createChannel($config) {

         return $this->doCreateChannel($config, 'PollableChannel');

     }

 

@@ -58,7 +58,7 @@ 
      * @param object $config configuration object for the subscribable channel.

      * @return \PEIP\INF\Channel\Channel the created subscribable channel instance

      */

-    public function createSubscribableChannel($config){

+    public function createSubscribableChannel($config) {

         return $this->doCreateChannel($config, 'PublishSubscribeChannel');

     }

 

@@ -71,9 +71,9 @@ 
      * @param $additionalArguments additional arguments for the channel constructor (without first arg = id)

      * @return \PEIP\INF\Channel\Channel the created channel instance

      */

-    public function doCreateChannel($config, $defaultChannelClass, array $additionalArguments = array()){

+    public function doCreateChannel($config, $defaultChannelClass, array $additionalArguments = array()) {

         $id = (string)$config['id'];

-        if($id != ''){

+        if ($id != '') {

             array_unshift($additionalArguments, $id);

             $channel = $this->buildAndModify($config, $additionalArguments, $defaultChannelClass);

             //$this->channelRegistry->register($channel);

@@ -91,7 +91,7 @@ 
      * @param string $defaultClass the class to use if none is set in config.

      * @return object the gateway instance

      */

-    public function createGateway($config, $defaultClass = false){

+    public function createGateway($config, $defaultClass = false) {

         $args = array(

             $this->getRequestChannel($config),

             $this->getReplyChannel($config)

@@ -115,7 +115,7 @@ 
      * @param string $defaultClass the class to use if none is set in config.

      * @return object the router instance

      */

-    public function createRouter($config, $defaultClass = false){

+    public function createRouter($config, $defaultClass = false) {

         $resolver = $config['channel_resolver'] ? (string)$config['channel_resolver'] : $this->channelRegistry;

         return $this->buildAndModify($config, array(

             $resolver,

@@ -132,7 +132,7 @@ 
      * @param object $config configuration object for the splitter.

      * @return object the splitter instance

      */

-    public function createSplitter($config){

+    public function createSplitter($config) {

         return $this->createReplyMessageHandler($config);

     }

 

@@ -145,7 +145,7 @@ 
      * @param object $config configuration object for the transformer.

      * @return object the transformer instance

      */

-    public function createTransformer($config){

+    public function createTransformer($config) {

         return $this->createReplyMessageHandler($config);

     }

 

@@ -158,7 +158,7 @@ 
      * @param object $config configuration object for the aggregator.

      * @return object the aggregator instance

      */

-    public function createAggregator($config){

+    public function createAggregator($config) {

         return $this->createReplyMessageHandler($config);

     }

 

@@ -171,7 +171,7 @@ 
      * @param object $config configuration object for the wiretap.

      * @return object the wiretap instance

      */

-    public function createWiretap($config){

+    public function createWiretap($config) {

         return $this->createReplyMessageHandler($config, 'Wiretap');

     }

 

@@ -184,7 +184,7 @@ 
      * @param string $defaultClass the class to use if none is set in config.

      * @return object the reply-message-handler instance

      */

-    public function createReplyMessageHandler($config, $defaultClass = false){

+    public function createReplyMessageHandler($config, $defaultClass = false) {

         return $this->buildAndModify($config, $this->getReplyHandlerArguments($config), $defaultClass);

     }

 

@@ -197,12 +197,12 @@ 
      * @param string $defaultClass the class to use if none is set in config.

      * @return object the service-activator instance

      */

-    public function createServiceActivator($config, $defaultClass = false){

+    public function createServiceActivator($config, $defaultClass = false) {

         $method = (string)$config['method'];

         $service = $this->context->getServiceProvider()->provideService((string)$config['ref']);

-        if($method && $service){

+        if ($method && $service) {

             $args = $this->getReplyHandlerArguments($config);

-            array_unshift($args,array(

+            array_unshift($args, array(

                 $service,

                 $method

             ));

@@ -219,12 +219,12 @@ 
      * @param object $config configuration object to create arguments from.

      * @return mixed build arguments

      */

-    protected function getReplyHandlerArguments($config){

+    protected function getReplyHandlerArguments($config) {

         $args = array(

             $this->doGetChannel('input', $config),

             $this->doGetChannel('output', $config)

         );

-        if($args[0] == NULL){

+        if ($args[0] == NULL) {

             throw new \RuntimeException('Could not receive input channel.');

         }

         return $args;

@@ -239,7 +239,7 @@ 
      * @param object $config configuration object to return request-channel from.

      * @return \PEIP\INF\Channel\Channel request-channel

      */

-    protected function getRequestChannel($config){

+    protected function getRequestChannel($config) {

         return $this->doGetChannel('request', $config);

     }

 

@@ -252,7 +252,7 @@ 
      * @param object $config configuration object to return reply-channel from.

      * @return \PEIP\INF\Channel\Channel reply-channel

      */

-    protected function getReplyChannel($config){

+    protected function getReplyChannel($config) {

         return $this->doGetChannel('reply', $config);

     }

 

@@ -265,15 +265,15 @@ 
      * @param object $config configuration object to return channel from.

      * @return \PEIP\INF\Channel\Channel reply-channel

      */

-    public function doGetChannel($type, $config){

+    public function doGetChannel($type, $config) {

         $channelName = $config[$type."_channel"]

             ? $config[$type."_channel"]

             : $config["default_".$type."_channel"];

         return $this->context->getServiceProvider()->provideService(trim((string)$channelName));

-        $channel =  $this->services[trim((string)$channelName)];

-        if($channel instanceof \PEIP\INF\Channel\Channel){

+        $channel = $this->services[trim((string)$channelName)];

+        if ($channel instanceof \PEIP\INF\Channel\Channel) {

             return $channel;

-        }else{

+        }else {

             return NULL;

         }

     }

Braces +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     protected function getMessage($object){

         if($this->channel instanceof \PEIP\INF\Channel\SubscribableChannel){

             return $object; 

-        }else{

+        } else{

             return $object->getContent()->receive();

         }

     }