tidal / PEIP

src/Dispatcher/EventClassDispatcher.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
  *

  * @author timo

  */

-use PEIP\Event\EventBuilder;

+use PEIP\Event\EventBuilder;
 use PEIP\Util\ReflectionPool;

 

 class EventClassDispatcher

Spacing +8 added lines, -8 removed lines

@@ -25,9 +25,9 @@ 
      * @param \PEIP\INF\Event\Event $object an event object

      * @return boolean

      */

-    public function notify($name, $object){ 

-        if($object instanceof \PEIP\INF\Event\Event){

-            if(is_object($object->getContent())){

+    public function notify($name, $object) { 

+        if ($object instanceof \PEIP\INF\Event\Event) {

+            if (is_object($object->getContent())) {

                 return self::doNotify(

                     $this->getListeners(

                         $name,

@@ -35,10 +35,10 @@ 
                      ),

                      $object->getContent()

                  );

-            }else{

+            }else {

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }

-        }else{

+        }else {

             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');

         }

     }       //put your code here

@@ -55,8 +55,8 @@ 
      * @return

      * @see EventBuilder

      */

-    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){

-        if(!$this->hasListeners($name, ($object))){

+    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false) {

+        if (!$this->hasListeners($name, ($object))) {

             return false;

         }

 

@@ -79,7 +79,7 @@ 
      * @param object $object object to check for listeners

      * @return boolean

      */

-    public function hasListeners($name, $object){

+    public function hasListeners($name, $object) {

         return parent::hasListeners(

             $name,

             ReflectionPool::getInstance($object)

src/Factory/ServiceFactory.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -11,8 +11,8 @@
  *

  * @author timo

  */

-use PEIP\Util\Test;

-use PEIP\Base\GenericBuilder;

+use PEIP\Util\Test;
+use PEIP\Base\GenericBuilder;
 use PEIP\Context\XMLContext;

 

 class ServiceFactory {

Spacing +44 added lines, -44 removed lines

@@ -23,11 +23,11 @@ 
      * @param $config configuration of the service

      * @return object the initialized service instance

      */

-    public static function createService(array $config){

+    public static function createService(array $config) {

         $args = array();

         //build arguments for constructor

-        if(isset($config['constructor_arg'])){

-            foreach($config['constructor_arg'] as $arg){

+        if (isset($config['constructor_arg'])) {

+            foreach ($config['constructor_arg'] as $arg) {

                 $args[] = self::buildArg($arg);

             }

         }

@@ -44,21 +44,21 @@ 
      * @param string $defaultClass class to create instance for if none is set in config

      * @return object build and modified srvice instance

      */

-    public static function doBuild($config, $arguments, $defaultClass = false){

+    public static function doBuild($config, $arguments, $defaultClass = false) {

         $cls = isset($config["class"]) ? trim((string)$config["class"]) : (string)$defaultClass;

-        if($cls != ''){

+        if ($cls != '') {

             try {

-                $constructor = isset($config["constructor"])?(string)$config["constructor"]:"";

-                if($constructor != '' && Test::assertMethod($cls, $constructor)){

+                $constructor = isset($config["constructor"]) ? (string)$config["constructor"] : "";

+                if ($constructor != '' && Test::assertMethod($cls, $constructor)) {

                     $service = call_user_func_array(array($cls, $constructor), $arguments);

-                }else{

+                }else {

                     $service = self::build($cls, $arguments);

                 }

-            }catch(\Exception $e){

+            } catch (\Exception $e) {

                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());

             }

         }

-        if(is_object($service)){

+        if (is_object($service)) {

             return $service;

         }

         throw new \RuntimeException('Could not create Service "'.$cls.'". Class does not exist.');

@@ -75,7 +75,7 @@ 
      * @param array $arguments arguments for the constructor

      * @return object build and modified srvice instance

      */

-    public static function build($className, $arguments){

+    public static function build($className, $arguments) {

         return GenericBuilder::getInstance($className)->build($arguments);

     }

 

@@ -86,29 +86,29 @@ 
      * @param object $config configuration object to create argument from.

      * @return mixed build argument

      */

-    protected function buildArg($config){

-        if(trim((string)$config['value']) != ''){

+    protected function buildArg($config) {

+        if (trim((string)$config['value']) != '') {

             $arg = (string)$config['value'];

-        }elseif($config->getName() == 'value'){

+        }elseif ($config->getName() == 'value') {

             $arg = (string)$config;

-        }elseif($config->getName() == 'list'){

+        }elseif ($config->getName() == 'list') {

             $arg = array();

-            foreach($config->children() as $entry){

-                if($entry->getName() == 'value'){

-                    if($entry['key']){

+            foreach ($config->children() as $entry) {

+                if ($entry->getName() == 'value') {

+                    if ($entry['key']) {

                         $arg[(string)$entry['key']] = (string)$entry;

-                    }else{

+                    }else {

                         $arg[] = (string)$entry;

                     }

-                }elseif($entry->getName() == 'service'){

+                }elseif ($entry->getName() == 'service') {

                     $arg[] = $this->provideService($entry);

                 }

             }

-        }elseif($config->getName() == 'service'){

+        }elseif ($config->getName() == 'service') {

             $arg = self::provideService($config);

-        }elseif($config->list){

+        }elseif ($config->list) {

             $arg = $this->buildArg($config->list);

-        }elseif($config->service){

+        }elseif ($config->service) {

             $arg = $this->buildArg($config->service);

         }

         return $arg;

@@ -126,24 +126,24 @@ 
      * @param string $defaultClass class to create instance for if none is set in config

      * @return object build and modified srvice instance

      */

-    public static function buildAndModify(array $config, $arguments, $defaultClass = ""){

-        if((isset($config["class"]) && "" != (string)$config["class"])  || $defaultClass !== ""){

+    public static function buildAndModify(array $config, $arguments, $defaultClass = "") {

+        if ((isset($config["class"]) && "" != (string)$config["class"]) || $defaultClass !== "") {

              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

-        }else{

+        }else {

             throw new \RuntimeException('Could not create Service. no class or reference given.');

         }

-        if(isset($config["ref_property"])){

+        if (isset($config["ref_property"])) {

             $service = $service->{(string)$config["ref_property"]};

-        }elseif(isset($config["ref_method"])){

+        }elseif (isset($config["ref_method"])) {

                 $args = array();

-            if(isset($config['argument'])){

-                        foreach($config['argument'] as $arg){

+            if (isset($config['argument'])) {

+                        foreach ($config['argument'] as $arg) {

                             $args[] = $this->buildArg($arg);

                         }

                 }

             $service = call_user_func_array(array($service, (string)$config["ref_method"]), $args);

         }

-        if(!is_object($service)){

+        if (!is_object($service)) {

             throw new \RuntimeException('Could not create Service.');

         }

         $service = self::modifyService($service, $config);

@@ -165,29 +165,29 @@ 
      * @param object $config configuration to get the modification instructions from.

      * @return object the modificated service

      */

-    protected function modifyService($service, $config){        

+    protected function modifyService($service, $config) {        

         $config = is_array($config) ? new \ArrayObject($config) : $config;

         // set instance properties

-        if(isset($config->property)){

-            foreach($config->property as $property){

+        if (isset($config->property)) {

+            foreach ($config->property as $property) {

                 $arg = $this->buildArg($property);

-                if($arg){

+                if ($arg) {

                     $setter = self::getSetter($property);

-                    if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){

+                    if ($setter && self::hasPublicProperty($service, 'Method', $setter)) {

                         $service->{$setter}($arg);

-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

+                    }elseif (in_array($property, self::hasPublicProperty($service, 'Property', $setter))) {

                         $service->$setter = $arg;

                     }

                 }

             }

         }

         // call instance methods

-        if(isset($config->action)){

-            foreach($config->action as $action){

+        if (isset($config->action)) {

+            foreach ($config->action as $action) {

                 $method = (string)$action['method'] != '' ? (string)$action['method'] : NULL;

-                if($method && self::hasPublicProperty($service, 'Method', $method)){

+                if ($method && self::hasPublicProperty($service, 'Method', $method)) {

                     $args = array();

-                    foreach($action->children() as $argument){

+                    foreach ($action->children() as $argument) {

                         $args[] = $this->buildArg($argument);

                     }

                     call_user_func_array(array($service, (string)$action['method']), $args);

@@ -195,9 +195,9 @@ 
             }

         }

         // register instance listeners

-        if($service instanceof \PEIP\INF\Event\Connectable){

-            if(isset($config->listener)){

-                foreach($config->listener as $listenerConf){

+        if ($service instanceof \PEIP\INF\Event\Connectable) {

+            if (isset($config->listener)) {

+                foreach ($config->listener as $listenerConf) {

                     $event = (string)$listenerConf['event'];

                     $listener = $this->provideService($listenerConf);

                     $service->connect($event, $listener);

src/Message/GenericMessage.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  * @implements \PEIP\INF\Base\Container, \PEIP\INF\Message\Message, \PEIP\INF\Base\Buildable

  */

 

-use PEIP\Util\Test;

+use PEIP\Util\Test;
 use PEIP\Base\GenericBuilder;

 

 class GenericMessage 

Spacing +15 added lines, -15 removed lines

@@ -41,7 +41,7 @@ 
      * @param mixed $content The content/payload of the message 

      * @param array|ArrayAccess $headers headers as key/value pairs

      */

-    public function __construct($content, $headers = array()){

+    public function __construct($content, $headers = array()) {

         $this->doSetContent($content);

         $this->doSetHeaders($headers);          

     }

@@ -53,7 +53,7 @@ 
      * @access public

      * @return

      */

-    public function getContent(){

+    public function getContent() {

         return $this->content;

     }

 

@@ -63,13 +63,13 @@ 
      * @access protected

      * @param mixed $content The content/payload of the message 

      */

-    protected function doSetContent($content){

+    protected function doSetContent($content) {

         $this->content = Test::castType($content, self::CONTENT_CAST_TYPE);

     }

 

-    protected function doSetHeaders($headers){

+    protected function doSetHeaders($headers) {

         $headers = Test::ensureArrayAccess($headers);

-        if(is_array($headers)){

+        if (is_array($headers)) {

             $headers = new \ArrayObject($headers);

         }

         $this->headers = $headers;

@@ -81,8 +81,8 @@ 
      * @access public

      * @return ArrayAccess ArrayAccess object of headers

      */

-    public function getHeaders(){

-        return (array) $this->headers;

+    public function getHeaders() {

+        return (array)$this->headers;

     }

   

     /**

@@ -92,7 +92,7 @@ 
      * @param string $name the name of the header  

      * @return mixed the value of the header

      */

-    public function getHeader($name){

+    public function getHeader($name) {

         $name = (string)$name;

         return isset($this->headers[$name]) ? $this->headers[$name] : NULL;

     }

@@ -105,8 +105,8 @@ 
      * @param string $name the name of the header

      * @return boolean wether the header has been successfully  set

      */

-    public function addHeader($name, $value){

-        if(!$this->hasHeader($name)){

+    public function addHeader($name, $value) {

+        if (!$this->hasHeader($name)) {

             $this->headers[$name] = $value;

             return true;

         }

@@ -120,7 +120,7 @@ 
      * @param string $name the name of the header

      * @return boolean wether the header is set

      */

-    public function hasHeader($name){

+    public function hasHeader($name) {

         return isset($this->headers[$name]);

     }

 

@@ -130,16 +130,16 @@ 
      * @access public

      * @return string  content/payload of the message

      */

-    public function __toString(){

+    public function __toString() {

         $res = false;

         try {

             $res = (string)$this->getContent();

         }

-        catch(\Exception $e){           

+        catch (\Exception $e) {           

             try {

                 $res = get_class($this->getContent());

             }

-            catch(\Exception $e){

+            catch (\Exception $e) {

 

             }

         }

@@ -159,7 +159,7 @@ 
      * @param array $arguments argumends for the constructor

      * @return GenericMessage new class instance

      */    

-    public static function build(array $arguments = array()){

+    public static function build(array $arguments = array()) {

         return GenericBuilder::getInstance(__CLASS__)->build($arguments);

     }     

 } 
\ No newline at end of file

src/Service/ServiceProvider.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
  *

  * @author timo

  */

-use PEIP\Context\XMLContext;

+use PEIP\Context\XMLContext;
 use PEIP\Plugins\BasePlugin;

 

 class ServiceProvider extends \PEIP\Service\ServiceContainer  {

Spacing +31 added lines, -31 removed lines

@@ -14,7 +14,7 @@ 
 use PEIP\Context\XMLContext;

 use PEIP\Plugins\BasePlugin;

 

-class ServiceProvider extends \PEIP\Service\ServiceContainer  {

+class ServiceProvider extends \PEIP\Service\ServiceContainer {

 

     const

         /* Headers */

@@ -47,7 +47,7 @@ 
     public function  __construct(array $config = array(), $idAttribute = 'id') {

         $this->idAttribute = $idAttribute;

         $this->initNodeBuilders();

-        foreach($config as $serviceConfig){

+        foreach ($config as $serviceConfig) {

             $this->addConfig($serviceConfig);

         }

         

@@ -58,7 +58,7 @@ 
      * @access public

      * @return array registered services

      */

-    public function getServices(){

+    public function getServices() {

         return $this->services;

     }

 

@@ -70,7 +70,7 @@ 
      * @param string $nodeName the name of the node

      * @param callable $callable a callable which creates instances for node-name

      */

-    public function registerNodeBuilder($nodeName, $callable){

+    public function registerNodeBuilder($nodeName, $callable) {

         $this->nodeBuilders[$nodeName] = $callable;

     }

   /**

@@ -83,17 +83,17 @@ 
      * @see XMLContext::includeContext

      * @access protected

      */

-    protected function initNodeBuilders(){ return;

+    protected function initNodeBuilders() { return;

         $builders = array(

             'service' => 'initService'

         );

         $plugin = new BasePlugin();

-        foreach($builders as $nodeName => $method){

+        foreach ($builders as $nodeName => $method) {

            $this->registerNodeBuilder($nodeName, array($this, $method));

         }

     }

 

-    public function addConfig($config){ 

+    public function addConfig($config) { 

         $this->doFireEvent(

             self::EVENT_BEFORE_ADD_CONFIG,

             array(

@@ -112,15 +112,15 @@ 
         );

     }

 

-    public function provideService($key){

+    public function provideService($key) {

         $this->doFireEvent(self::EVENT_BEFORE_PROVIDE_SERVICE, array(

             self::HEADER_KEY=>$key)

         );

 

-        if($this->hasService($key)){

-            $service =  $this->getService($key);

-        }else{

-            $service =  $this->createService($key);

+        if ($this->hasService($key)) {

+            $service = $this->getService($key);

+        }else {

+            $service = $this->createService($key);

         }

 

         $this->doFireEvent(self::EVENT_AFTER_PROVIDE_SERVICE, array(

@@ -131,16 +131,16 @@ 
         return $service;

     }

 

-    protected function createService($key){

+    protected function createService($key) {

         $this->doFireEvent(self::EVENT_BEFORE_CREATE_SERVICE, array(

             self::HEADER_KEY=>$key)

         );

         $errorMessage = '';

         $config = $this->getServiceConfig($key);

 

-        if($config){

+        if ($config) {

             $node = $this->buildNode($config);

-            if($node){

+            if ($node) {

                 $this->setService(

                     $key,

                     $node

@@ -151,11 +151,11 @@ 
                 ));

 

                 return $node;                

-            }else{

+            }else {

                 $errorMessage = 'COULD NOT BUILD NODE FOR KEY: '.$key;

             }

 

-        }else{

+        }else {

             $errorMessage = 'NO CONFIG FOR KEY: '.$key;

         }

         $this->doFireEvent(self::EVENT_CREATE_SERVICE_ERROR, array(

@@ -165,8 +165,8 @@ 
         return NULL;

     }

 

-    public function getServiceConfig($key){

-        if(!isset($this->ids[$key])){

+    public function getServiceConfig($key) {

+        if (!isset($this->ids[$key])) {

             return false;

         }

         return $this->config[$this->ids[$key]];

@@ -181,7 +181,7 @@ 
      * @param object $config configuration-node

      * @return void

      */

-    protected function buildNode($config){

+    protected function buildNode($config) {

         $nodeName = (string)$config['type'];

 

         $this->doFireEvent(self::EVENT_BEFORE_BUILD_NODE, array(

@@ -189,20 +189,20 @@ 
             self::HEADER_NODE_NAME=> $nodeName

         ));

         // call the builder method registered for the node.

-        if(array_key_exists($nodeName, $this->nodeBuilders)){

+        if (array_key_exists($nodeName, $this->nodeBuilders)) {

 

             $nodeInstance = call_user_func($this->nodeBuilders[$nodeName], $config);

-            if(is_object($nodeInstance)){

+            if (is_object($nodeInstance)) {

                 $this->doFireEvent(self::EVENT_BUILD_NODE_SUCCESS, array(

                     self::HEADER_NODE_CONFIG=>$config,

                     self::HEADER_NODE_NAME=> $nodeName,

                     self::HEADER_NODE => $nodeInstance

                 ));

                 return $nodeInstance;

-            }else{

+            }else {

                 $errorMessage = 'BUILDER RETURNED NO OBJECT FOR NODE-TYPE: '.$nodeName;

             }

-        }else{

+        }else {

             $errorMessage = 'NO BUILDER FOUND FOR NODE-TYPE: '.$nodeName;

         }

 

@@ -213,27 +213,27 @@ 
         ));

     }

 

-    protected function getIdFromConfig($config){

+    protected function getIdFromConfig($config) {

         $id = '';

-        if(isset($config[$this->idAttribute])){

+        if (isset($config[$this->idAttribute])) {

             $id = trim((string)($config[$this->idAttribute]));

         }

         return $id;

     }

 

-    protected function getCountConfig(){

+    protected function getCountConfig() {

         return count($this->config);

     }

 

-    protected function doAddConfig($config){

+    protected function doAddConfig($config) {

         $countConfig = $this->getCountConfig();

         $this->config[$countConfig] = $config;

         return $countConfig;

     }

 

-    protected function doRegisterConfig($config){

-        $id  = $this->getIdFromConfig($config);

-        if($id != ''){

+    protected function doRegisterConfig($config) {

+        $id = $this->getIdFromConfig($config);

+        if ($id != '') {

             $this->ids[$id] = $this->getCountConfig() - 1;

         }

         return $id;

examples/Cafe/lib/model/Barista.php

Spacing +4 added lines, -4 removed lines

@@ -30,16 +30,16 @@
         return $this->prepareDrink($orderItem['order'], $orderItem['type'], true);
     }    
 	
-    protected function prepareDrink($orderNumber, $type, $iced){
+    protected function prepareDrink($orderNumber, $type, $iced) {
     	$drink = new Drink($orderNumber, $type, $iced);	
     	return $drink;
     }
 
-    protected function printAction($cold, $orderNr){
-    	if($cold){
+    protected function printAction($cold, $orderNr) {
+    	if ($cold) {
     		$type = 'cold';
     		$count = $this->coldDrinkCounter;
-    	}else{
+    	}else {
     		$type = 'hot';
     		$count = $this->hotDrinkCounter;    		
     	}

examples/Cafe/lib/model/Order.php

Spacing +6 added lines, -6 removed lines

@@ -7,16 +7,16 @@ 
 		$orderNumber;
 	protected static $orderCount = 0;
 
-	public function __construct(){
+	public function __construct() {
 		self::$orderCount++;
 		$this->orderNumber = self::$orderCount;
 	}	
 
-	public function getOrderNumber(){
+	public function getOrderNumber() {
 		return $this->orderNumber;
 	}
 	
-	public function addItem($type, $number, $iced = false){
+	public function addItem($type, $number, $iced = false) {
 		$this->items[] = 
 			array(
 				'type' => $type,
@@ -25,13 +25,13 @@ 
 			);
 	}
 
-	public function getItems(){
+	public function getItems() {
 		return $this->items;
 	}
 
-	public function getTotalCount(){
+	public function getTotalCount() {
 		$x = 0;
-		foreach($this->items as $item){
+		foreach ($this->items as $item) {
 			$x += (int)$item['number'];
 		}
 		return $x;

examples/Cafe/lib/model/Delivery.php

Spacing +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
 		$deliveredDrinks,
 		$orderNumber;
 	
-	public function __construct(array $deliveredDrinks){
+	public function __construct(array $deliveredDrinks) {
 		$this->deliveredDrinks = $deliveredDrinks;
 		$this->orderNumber = $deliveredDrinks[0]->getOrderNumber();
 	}

examples/Cafe/lib/model/Drink.php

Spacing +4 added lines, -4 removed lines

@@ -8,21 +8,21 @@
 		$type,
 		$iced;
 	
-	public function __construct($orderNumber, $type, $iced){
+	public function __construct($orderNumber, $type, $iced) {
 		$this->orderNumber = $orderNumber;
 		$this->type = $type;
 		$this->iced = $iced;
 	}
 
-	public function getType(){
+	public function getType() {
 		return $this->type; 
 	}
 
-	public function getIced(){
+	public function getIced() {
 		return $this->iced; 
 	}	
 
-	public function getOrderNumber(){
+	public function getOrderNumber() {
 		return $this->orderNumber;
 	}
 	

examples/Cafe/lib/model/Waiter.php

Spacing +3 added lines, -3 removed lines

@@ -5,18 +5,18 @@
 
 	protected $orders;
 	
-	public function prepareDelivery(array $drinks){
+	public function prepareDelivery(array $drinks) {
 		echo PEIP_LINE_SEPARATOR.'Waiter: prepareDelivery: #'.$drinks[0]->getOrderNumber();
 		return new Delivery($drinks);
 	}
 
 	
-	public function receiveOrder(Order $order){
+	public function receiveOrder(Order $order) {
 		echo PEIP_LINE_SEPARATOR.'Waiter: receiveOrder';
 		$this->orders[$order->getOrderNumber()] = $order;	
 	}
 	
-	public function getOrder($nr){
+	public function getOrder($nr) {
 		return $this->orders[$nr];
 	}