tidal / PEIP

src/ABS/Dispatcher/MapDispatcher.php

Doc Comments -1 removed lines

@@ -80,7 +80,6 @@
      *

      * @access public

      * @param string $name name of the event

-     * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect

      * @return

      */

     public function disconnectAll($name){

Indentation +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
     public function connect($name, $listener){

         Test::ensureHandler($listener);

         if (!$this->hasListeners($name)){

-          $this->listeners[$name] = array();

+            $this->listeners[$name] = array();

         }

         $this->listeners[$name][] = $listener;

         return true;

@@ -67,10 +67,10 @@ 
         }

         $res = false;

         foreach ($this->listeners[$name] as $i => $callable){

-          if ($listener === $callable){

+            if ($listener === $callable){

             unset($this->listeners[$name][$i]);

             $res = true;

-          }

+            }

         }

         return $res;

     }

Spacing +17 added lines, -17 removed lines

@@ -44,9 +44,9 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect

      * @return 

      */

-    public function connect($name, $listener){

+    public function connect($name, $listener) {

         Test::ensureHandler($listener);

-        if (!$this->hasListeners($name)){

+        if (!$this->hasListeners($name)) {

           $this->listeners[$name] = array();

         }

         $this->listeners[$name][] = $listener;

@@ -61,13 +61,13 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect

      * @return 

      */

-    public function disconnect($name, $listener){

-        if (!$this->hasListeners($name)){

+    public function disconnect($name, $listener) {

+        if (!$this->hasListeners($name)) {

             return false;

         }

         $res = false;

-        foreach ($this->listeners[$name] as $i => $callable){

-          if ($listener === $callable){

+        foreach ($this->listeners[$name] as $i => $callable) {

+          if ($listener === $callable) {

             unset($this->listeners[$name][$i]);

             $res = true;

           }

@@ -83,8 +83,8 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect

      * @return

      */

-    public function disconnectAll($name){

-        if (!isset($this->listeners[$name])){

+    public function disconnectAll($name) {

+        if (!isset($this->listeners[$name])) {

             return false;

         }

         $this->listeners[$name] = array();

@@ -98,11 +98,11 @@ 
      * @param string $name name of the event 

      * @return boolean wether any listener is registered for event-name

      */

-    public function hasListeners($name){

-        if (!isset($this->listeners[$name])){

+    public function hasListeners($name) {

+        if (!isset($this->listeners[$name])) {

             return false;

         }

-        return (boolean) count($this->listeners[$name]);

+        return (boolean)count($this->listeners[$name]);

     }

     

     /**

@@ -113,8 +113,8 @@ 
      * @param mixed $subject the subject 

      * @return boolean success

      */

-    public function notify($name, $subject){

-        if($this->hasListeners($name)){

+    public function notify($name, $subject) {

+        if ($this->hasListeners($name)) {

             self::doNotify($this->getListeners($name), $subject);

             return true;

         }

@@ -129,8 +129,8 @@ 
      * @param mixed $subject the subject 

      * @return \PEIP\INF\Handler\Handler listener which returned a boolean true value

      */

-    public function notifyUntil($name, $subject){

-        if($this->hasListeners($name)){

+    public function notifyUntil($name, $subject) {

+        if ($this->hasListeners($name)) {

             return self::doNotifyUntil($this->getListeners($name), $subject);   

         }

         return NULL;

@@ -143,8 +143,8 @@ 
      * @param $name 

      * @return array array of \PEIP\INF\Handler\Handler instances

      */

-    public function getListeners($name){

-        if (!isset($this->listeners[$name])){

+    public function getListeners($name) {

+        if (!isset($this->listeners[$name])) {

         return array();

         }

         return $this->listeners[$name];

src/ABS/Handler/MessageHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
      * @see PEIP\ABS\Handler\MessageHandler::doSetInputChannel

      * @access public

      * @param \PEIP\INF\Channel\Channel $inputChannel the input-channel

-     * @return PEIP\ABS\Handler\MessageHandler $this;

+     * @return MessageHandler $this;

      */

     public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel){

         $this->doSetInputChannel($inputChannel);

Indentation +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
      * @return 

      */

     public function handle($message){

-         $this->doHandle($this->getMessageFromObject($message));      

+            $this->doHandle($this->getMessageFromObject($message));      

     }

    

     /**

@@ -90,7 +90,7 @@ 
             && $object->getName() == 'postSend'

             && $object->hasHeader(Pipe::HEADER_MESSAGE)

             && $content instanceof \PEIP\INF\Channel\PollableChannel

-         ){

+            ){

             $object = $content->receive();

         }

         if (!($object instanceof \PEIP\INF\Message\Message)) {

Spacing +9 added lines, -9 removed lines

@@ -42,7 +42,7 @@ 
      * @param object $message the message to handle

      * @return 

      */

-    public function handle($message){

+    public function handle($message) {

          $this->doHandle($this->getMessageFromObject($message));      

     }

    

@@ -56,7 +56,7 @@ 
      * @param \PEIP\INF\Channel\Channel $inputChannel the input-channel

      * @return PEIP\ABS\Handler\MessageHandler $this;

      */

-    public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel){

+    public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel) {

         $this->doSetInputChannel($inputChannel);

         return $this;

     }

@@ -73,24 +73,24 @@ 
      * @param \PEIP\INF\Channel\Channel $inputChannel the input-channel to connect the handler to

      * @return 

      */

-    protected function doSetInputChannel(\PEIP\INF\Channel\Channel $inputChannel){

+    protected function doSetInputChannel(\PEIP\INF\Channel\Channel $inputChannel) {

         $this->inputChannel = $inputChannel;    

-        if($this->inputChannel instanceof \PEIP\INF\Channel\SubscribableChannel){

+        if ($this->inputChannel instanceof \PEIP\INF\Channel\SubscribableChannel) {

                 $this->inputChannel->subscribe($this);

-        }else{          

+        }else {          

             $this->unwrapEvents = true;

             $this->inputChannel->connect('postSend', $this);

         }  

     }

   

-    protected function getMessageFromObject($object){ 

+    protected function getMessageFromObject($object) { 

         $content = $object->getContent();

-        if($this->unwrapEvents

+        if ($this->unwrapEvents

             && $object instanceof \PEIP\INF\Event\Event

             && $object->getName() == 'postSend'

             && $object->hasHeader(Pipe::HEADER_MESSAGE)

             && $content instanceof \PEIP\INF\Channel\PollableChannel

-         ){

+         ) {

             $object = $content->receive();

         }

         if (!($object instanceof \PEIP\INF\Message\Message)) {

@@ -106,7 +106,7 @@ 
      * @access public

      * @return \PEIP\INF\Channel\Channel input-channel for this handler

      */

-    public function getInputChannel(){

+    public function getInputChannel() {

         return $this->inputChannel;

     }   

       

Braces +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
         $this->inputChannel = $inputChannel;    

         if($this->inputChannel instanceof \PEIP\INF\Channel\SubscribableChannel){

                 $this->inputChannel->subscribe($this);

-        }else{          

+        } else{          

             $this->unwrapEvents = true;

             $this->inputChannel->connect('postSend', $this);

         }  

src/ABS/Handler/ReplyProducingMessageHandler.php

Doc Comments +3 added lines, -3 removed lines

@@ -53,7 +53,7 @@ 
      * Connects the handler to the output-channel. 

      * 

      * @access protected

-     * @param \PEIP\INF\Channel\Channel $inputChannel the output-channel to connect the handler to

+     * @param \PEIP\INF\Channel\Channel $outputChannel the output-channel to connect the handler to

      * @return 

      */

     protected function doSetOutputChannel(\PEIP\INF\Channel\Channel $outputChannel){

@@ -162,7 +162,7 @@ 
      * 

      * @access public

      * @param string $messageClass name of the message-class to create reply-messages from. 

-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this

+     * @return ReplyProducingMessageHandler $this

      */

     public function setMessageClass($messageClass){

         $this->messageClass = $messageClass;

@@ -195,7 +195,7 @@ 
      * 

      * @access public

      * @param array $headerNames array of message-header names to look for a reply-channel

-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this

+     * @return ReplyProducingMessageHandler $this

      */

     public function setReplyChannelHeaders(array $headerNames){

         $this->replyChannelHeaders = $headerNames;

Spacing +17 added lines, -17 removed lines

@@ -44,7 +44,7 @@ 
      * @param \PEIP\INF\Channel\Channel $outputChannel the output-channel

      * @return \PEIP\ABS\Handler\MessageHandler $this;

      */

-    public function setOutputChannel(\PEIP\INF\Channel\Channel $outputChannel){

+    public function setOutputChannel(\PEIP\INF\Channel\Channel $outputChannel) {

         $this->doSetOutputChannel($outputChannel);

         return $this;

     }   

@@ -56,7 +56,7 @@ 
      * @param \PEIP\INF\Channel\Channel $inputChannel the output-channel to connect the handler to

      * @return 

      */

-    protected function doSetOutputChannel(\PEIP\INF\Channel\Channel $outputChannel){

+    protected function doSetOutputChannel(\PEIP\INF\Channel\Channel $outputChannel) {

         $this->outputChannel = $outputChannel;

     }

        

@@ -66,7 +66,7 @@ 
      * @access public

      * @return \PEIP\INF\Channel\Channel output-channel for this handler

      */

-    public function getOutputChannel(){

+    public function getOutputChannel() {

         return $this->outputChannel;

     }

 

@@ -80,7 +80,7 @@ 
      * @param \PEIP\INF\Message\Message $message the message to resolve output-channel for

      * @return \PEIP\INF\Channel\Channel the output-channel for the message

      */    

-    protected function doGetOutputChannel(\PEIP\INF\Message\Message $message){

+    protected function doGetOutputChannel(\PEIP\INF\Message\Message $message) {

         $replyChannel = $this->resolveReplyChannel($message);

         return $replyChannel ? $replyChannel : $this->getOutputChannel();       

     }

@@ -94,9 +94,9 @@ 
      * @param \PEIP\INF\Message\Message $message 

      * @return \PEIP\INF\Channel\Channel the reply-channel if found

      */     

-    protected function resolveReplyChannel(\PEIP\INF\Message\Message $message){

-        foreach($this->replyChannelHeaders as $header){

-            if($message->hasHeader($header)){

+    protected function resolveReplyChannel(\PEIP\INF\Message\Message $message) {

+        foreach ($this->replyChannelHeaders as $header) {

+            if ($message->hasHeader($header)) {

                 return $message->getHeader($header);

             }

         }

@@ -113,7 +113,7 @@ 
      * @access protected

      * @param mixed $content \PEIP\INF\Message\Message or content/payload for new message 

      */

-    protected function replyMessage($content){

+    protected function replyMessage($content) {

         $message = $this->ensureMessage($content);      

         $this->doGetOutputChannel($message)->send($message);      

     }

@@ -127,7 +127,7 @@ 
      * @param mixed $message \PEIP\INF\Message\Message or content/payload for new message

      * @return \PEIP\INF\Message\Message

      */

-    protected function ensureMessage($message){

+    protected function ensureMessage($message) {

         return ($message instanceof \PEIP\INF\Message\Message) ? $message : $this->buildMessage($message);   

     }

        

@@ -140,7 +140,7 @@ 
      * @return \PEIP\INF\Message\Message

      * @see MessageBuilder

      */

-    protected function buildMessage($content){

+    protected function buildMessage($content) {

         return $this->getMessageBuilder()->setContent($content)->build();   

     }   

        

@@ -151,7 +151,7 @@ 
      * @access protected

      * @return MessageBuilder builder for the registered message class

      */

-    protected function getMessageBuilder(){

+    protected function getMessageBuilder() {

         return isset($this->messageBuilder) && ($this->messageBuilder->getMessageClass() == $this->getMessageClass())

             ? $this->messageBuilder

             : $this->messageBuilder = MessageBuilder::getInstance($this->messageClass);

@@ -164,7 +164,7 @@ 
      * @param string $messageClass name of the message-class to create reply-messages from. 

      * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this

      */

-    public function setMessageClass($messageClass){

+    public function setMessageClass($messageClass) {

         $this->messageClass = $messageClass;

         return $this;

     }

@@ -175,7 +175,7 @@ 
      * @access public

      * @return string name of the message-class to create reply-messages from. 

      */

-    public function getMessageClass(){

+    public function getMessageClass() {

         return $this->messageClass;

     }       

 

@@ -186,7 +186,7 @@ 
      * @param string $headerName name of a message-header to look for a reply-channel

      * @return void

      */

-    public function addReplyChannelHeader($headerName){

+    public function addReplyChannelHeader($headerName) {

         $this->replyChannelHeaders[] = $headerName;

     }

     

@@ -197,7 +197,7 @@ 
      * @param array $headerNames array of message-header names to look for a reply-channel

      * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this

      */

-    public function setReplyChannelHeaders(array $headerNames){

+    public function setReplyChannelHeaders(array $headerNames) {

         $this->replyChannelHeaders = $headerNames;

         return $this;

     } 

@@ -208,7 +208,7 @@ 
      * @access public

      * @return array array of message-header names to look for a reply-channel

      */

-    public function getReplyChannelHeaders(){

+    public function getReplyChannelHeaders() {

         return $this->replyChannelHeaders;

     }

          

@@ -222,7 +222,7 @@ 
      * @param \PEIP\INF\Message\Message $message 

      * @return 

      */

-    protected function doHandle(\PEIP\INF\Message\Message $message){

+    protected function doHandle(\PEIP\INF\Message\Message $message) {

         return $this->doReply($message);

     }

        

src/Dispatcher/ClassDispatcher.php

Doc Comments -1 removed lines

@@ -71,7 +71,6 @@
      * notifies all listeners on a event on a subject

      *

      * @access public

-     * @param string $name name of the event

      * @param mixed $subject the subject

      * @return

      */

Spacing +13 added lines, -13 removed lines

@@ -18,11 +18,11 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect

      * @return

      */

-    public function connect($name, $listener){

+    public function connect($name, $listener) {

         $name = is_object($name) ? get_class($name) : (string)$name;

-        if(Test::assertClassOrInterfaceExists($name)){

+        if (Test::assertClassOrInterfaceExists($name)) {

             parent::connect($name, $listener);

-        }else{

+        }else {

             throw new \InvalidArgumentException($name." is not an Class nor Interface");

         }

     }

@@ -35,10 +35,10 @@ 
      * @param mixed $subject the subject

      * @return

      */

-    public function notify($name, $subject){

+    public function notify($name, $subject) {

         $res = false;

-        foreach(Reflection::getImplementedClassesAndInterfaces($name) as $cls){

-            if(parent::hasListeners($cls)){

+        foreach (Reflection::getImplementedClassesAndInterfaces($name) as $cls) {

+            if (parent::hasListeners($cls)) {

                 self::doNotify($this->getListeners($cls), $subject);

                 $res = true;

             }

@@ -56,10 +56,10 @@ 
      * @param mixed $subject the subject

      * @return \PEIP\INF\Handler\Handler listener which returned a boolean true value

      */

-    public function notifyUntil($name, $subject){

+    public function notifyUntil($name, $subject) {

         $res = NULL;

-        foreach(Reflection::getImplementedClassesAndInterfaces($name) as $cls){

-            if(!$res && parent::hasListeners($cls)){

+        foreach (Reflection::getImplementedClassesAndInterfaces($name) as $cls) {

+            if (!$res && parent::hasListeners($cls)) {

                 $res = self::doNotifyUntil($this->getListeners($cls), $subject);

             }

         }

@@ -75,7 +75,7 @@ 
      * @param mixed $subject the subject

      * @return

      */

-    public function notifyOfInstance($subject){

+    public function notifyOfInstance($subject) {

 

         return $this->notify(get_class($subject), $subject);

     }

@@ -86,9 +86,9 @@ 
      * @param string $name name of the event

      * @return boolean wether any listener is registered for event-name

      */

-    public function hasListeners($name){

-        foreach(Reflection::getImplementedClassesAndInterfaces($name) as $cls){

-            if(parent::hasListeners($cls)){

+    public function hasListeners($name) {

+        foreach (Reflection::getImplementedClassesAndInterfaces($name) as $cls) {

+            if (parent::hasListeners($cls)) {

                 return true;

             }

         }

Unused Use Statements +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  * @implements \PEIP\INF\Base\Container, \PEIP\INF\Message\Message, \PEIP\INF\Base\Buildable

  */

 

-use PEIP\Util\Test;

+use PEIP\Util\Test;
 use PEIP\Base\GenericBuilder;

 

 class GenericMessage 

Braces +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     protected function getMessage($object){

         if($this->channel instanceof \PEIP\INF\Channel\SubscribableChannel){

             return $object; 

-        }else{

+        } else{

             return $object->getContent()->receive();

         }

     }

src/Dispatcher/Dispatcher.php

Doc Comments -1 removed lines

@@ -65,7 +65,6 @@
      * Disconnects all listeners.

      * 

      * @access public

-     * @param Callable|PEIP\INF\Handler\Handler $listener

      * @return void

      */

     public function disconnectAll(){

Spacing +12 added lines, -12 removed lines

@@ -40,7 +40,7 @@ 
      * @param Callable|PEIP\INF\Handler\Handler  $listener

      * @return void

      */

-    public function connect($listener){

+    public function connect($listener) {

         Test::ensureHandler($listener);

         $this->listeners[] = $listener;

     }

@@ -52,10 +52,10 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener

      * @return void

      */

-    public function disconnect($listener){

+    public function disconnect($listener) {

         Test::ensureHandler($listener);

-        foreach ($this->listeners as $i => $callable){

-            if ($listener === $callable){

+        foreach ($this->listeners as $i => $callable) {

+            if ($listener === $callable) {

                 unset($this->listeners[$i]);

             }

         }

@@ -68,7 +68,7 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener

      * @return void

      */

-    public function disconnectAll(){

+    public function disconnectAll() {

         $this->listeners = array();

     }

 

@@ -78,8 +78,8 @@ 
      * @access public

      * @return boolean wether any listeners are registered

      */

-    public function hasListeners(){

-        return (boolean) count($this->listeners);

+    public function hasListeners() {

+        return (boolean)count($this->listeners);

     }

     

     /**

@@ -89,9 +89,9 @@ 
      * @param mixed $subject the subject

      * @return void

      */

-    public function notify($subject){

+    public function notify($subject) {

         $res = NULL;

-        if($this->hasListeners()){

+        if ($this->hasListeners()) {

             $res = self::doNotify($this->getListeners(), $subject); 

         }   

         return $res;      

@@ -104,8 +104,8 @@ 
      * @param mixed $subject the subject 

      * @return \PEIP\INF\Handler\Handler the listener which returned a boolean true value

      */

-    public function notifyUntil($subject){

-        if($this->hasListeners()){

+    public function notifyUntil($subject) {

+        if ($this->hasListeners()) {

             $res = self::doNotifyUntil($this->getListeners(), $subject);    

         }

         return $res;

@@ -117,7 +117,7 @@ 
      * @access public

      * @return array the listeners

      */

-    public function getListeners(){

+    public function getListeners() {

         return $this->listeners;

     }

 

src/Dispatcher/EventClassDispatcher.php

Doc Comments +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
      * @access public

      * @param string $name name of the event

      * @param \PEIP\INF\Event\Event $object an event object

-     * @return boolean

+     * @return boolean|null

      */

     public function notify($name, $object){ 

         if($object instanceof \PEIP\INF\Event\Event){

@@ -53,7 +53,7 @@ 
      * @param array $headers headers of the event-object as key/value pairs

      * @param string $eventClass event-class to create instances from

      * @return

-     * @see EventBuilder

+     boolean|null @see EventBuilder

      */

     public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){

         if(!$this->hasListeners($name, ($object))){

Unused Use Statements +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
  *

  * @author timo

  */

-use PEIP\Event\EventBuilder;

+use PEIP\Event\EventBuilder;
 use PEIP\Util\ReflectionPool;

 

 class EventClassDispatcher

Indentation +15 added lines, -15 removed lines

@@ -32,9 +32,9 @@ 
                     $this->getListeners(

                         $name,

                         $object

-                     ),

-                     $object->getContent()

-                 );

+                        ),

+                        $object->getContent()

+                    );

             }else{

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }

@@ -43,18 +43,18 @@ 
         }

     }       //put your code here

 

-     /**

-     * Creates an event-object with given object as content/subject and notifies

-     * all registers listeners of the event.

-     *

-     * @access public

-     * @param string $name name of the event

-     * @param object $object the subject of the event

-     * @param array $headers headers of the event-object as key/value pairs

-     * @param string $eventClass event-class to create instances from

-     * @return

-     * @see EventBuilder

-     */

+        /**

+         * Creates an event-object with given object as content/subject and notifies

+         * all registers listeners of the event.

+         *

+         * @access public

+         * @param string $name name of the event

+         * @param object $object the subject of the event

+         * @param array $headers headers of the event-object as key/value pairs

+         * @param string $eventClass event-class to create instances from

+         * @return

+         * @see EventBuilder

+         */

     public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){

         if(!$this->hasListeners($name, ($object))){

             return false;

Spacing +8 added lines, -8 removed lines

@@ -25,9 +25,9 @@ 
      * @param \PEIP\INF\Event\Event $object an event object

      * @return boolean

      */

-    public function notify($name, $object){ 

-        if($object instanceof \PEIP\INF\Event\Event){

-            if(is_object($object->getContent())){

+    public function notify($name, $object) { 

+        if ($object instanceof \PEIP\INF\Event\Event) {

+            if (is_object($object->getContent())) {

                 return self::doNotify(

                     $this->getListeners(

                         $name,

@@ -35,10 +35,10 @@ 
                      ),

                      $object->getContent()

                  );

-            }else{

+            }else {

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }

-        }else{

+        }else {

             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');

         }

     }       //put your code here

@@ -55,8 +55,8 @@ 
      * @return

      * @see EventBuilder

      */

-    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){

-        if(!$this->hasListeners($name, ($object))){

+    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false) {

+        if (!$this->hasListeners($name, ($object))) {

             return false;

         }

 

@@ -79,7 +79,7 @@ 
      * @param object $object object to check for listeners

      * @return boolean

      */

-    public function hasListeners($name, $object){

+    public function hasListeners($name, $object) {

         return parent::hasListeners(

             $name,

             ReflectionPool::getInstance($object)

Braces +2 added lines, -2 removed lines

@@ -70,10 +70,10 @@
                      ),

                      $object

                  );

-            }else{

+            } else{

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }

-        }else{

+        } else{

             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');

         }

     }       //put your code here

src/Dispatcher/ObjectEventDispatcher.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
      * @access public

      * @param string $name name of the event 

      * @param \PEIP\INF\Event\Event $object an event object

-     * @return boolean

+     * @return boolean|null

      */

     public function notify($name, $object){

         if($object instanceof \PEIP\INF\Event\Event){

Spacing +8 added lines, -8 removed lines

@@ -40,16 +40,16 @@ 
      * @param \PEIP\INF\Event\Event $object an event object

      * @return boolean

      */

-    public function notify($name, $object){

-        if($object instanceof \PEIP\INF\Event\Event){

-            if(is_object($object->getContent())){

-                if($this->hasListeners($name, $object->getContent())){

+    public function notify($name, $object) {

+        if ($object instanceof \PEIP\INF\Event\Event) {

+            if (is_object($object->getContent())) {

+                if ($this->hasListeners($name, $object->getContent())) {

                     return self::doNotify($this->getListeners($name, $object->getContent()), $object);  

                 }                   

-            }else{

+            }else {

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }   

-        }else{

+        }else {

             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');

         }  

     }   

@@ -66,8 +66,8 @@ 
      * @return

      * @see EventBuilder 

      */

-    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){

-        if(!$this->hasListeners($name, $object)){

+    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false) {

+        if (!$this->hasListeners($name, $object)) {

             return false;

         }

         $event = EventBuilder::getInstance($eventClass)->build(

Braces +2 added lines, -2 removed lines

@@ -70,10 +70,10 @@
                      ),

                      $object

                  );

-            }else{

+            } else{

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }

-        }else{

+        } else{

             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');

         }

     }       //put your code here

src/Dispatcher/ObjectMapDispatcher.php

Doc Comments +2 added lines, -2 removed lines

@@ -162,7 +162,7 @@ 
      * @access public

      * @param $name 

      * @param $subject 

-     * @return mixed

+     * @return \PEIP\INF\Handler\Handler

      */

     public function notifyUntil($name, $subject){

         if($this->hasListeners($name, $subject)){       

@@ -205,7 +205,7 @@ 
      * @access protected

      * @param $name 

      * @param $object 

-     * @return boolean

+     * @return boolean|null

      */    

     protected static function doNotify(array $listeners, $subject){

         foreach($listeners as $listener){ 

Indentation +4 added lines, -4 removed lines

@@ -209,11 +209,11 @@
      */    

     protected static function doNotify(array $listeners, $subject){

         foreach($listeners as $listener){ 

-             if($listener instanceof \PEIP\INF\Handler\Handler){

+                if($listener instanceof \PEIP\INF\Handler\Handler){

                 $listener->handle($subject);

-             }elseif(is_callable($listener)){

-                 call_user_func($listener, $subject);

-             }

+                }elseif(is_callable($listener)){

+                    call_user_func($listener, $subject);

+                }

         }   

     }  

 

Spacing +33 added lines, -33 removed lines

@@ -43,13 +43,13 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener event-handler

      * @return boolean

      */

-    public function connect($name, $object, $listener){

+    public function connect($name, $object, $listener) {

         Test::ensureHandler($listener);

         $listners = $this->doGetListeners();

-        if (!$this->listeners->contains($object)){

+        if (!$this->listeners->contains($object)) {

             $this->listeners->attach($object, new \ArrayObject);

         }

-        if (!array_key_exists($name, $listners[$object])){ 

+        if (!array_key_exists($name, $listners[$object])) { 

             $this->listeners[$object][$name] = array();

         }

         $hash = $this->getListenerHash($listener);

@@ -67,14 +67,14 @@ 
      * @param \PEIP\INF\Handler\Handler $listener event-handler

      * @return boolean

      */

-    public function disconnect($name, $object, $listener){

+    public function disconnect($name, $object, $listener) {

         $listners = $this->doGetListeners();

-        if (!$listners->contains($object) || !isset($listners[$object][$name])){

+        if (!$listners->contains($object) || !isset($listners[$object][$name])) {

             return false;

         }

         $eventListeners = $listners[$object][$name];

         $hash = $this->getListenerHash($listener);

-        if(isset($eventListeners[$hash])){

+        if (isset($eventListeners[$hash])) {

             unset($eventListeners[$hash]); 

 

             $listners[$object][$name] = $eventListeners;

@@ -83,10 +83,10 @@ 
         return false;

     }

 

-    public function disconnectAll($name, $object){

-        if(is_object($object)){

+    public function disconnectAll($name, $object) {

+        if (is_object($object)) {

             $listners = $this->doGetListeners();

-            if($listners && $this->hadListeners($name, $object)){

+            if ($listners && $this->hadListeners($name, $object)) {

                     $listners[$object][$name] = array();

             }        

         }

@@ -100,13 +100,13 @@ 
      * @param object $object object to check for listeners

      * @return boolean

      */

-    public function hasListeners($name, $object){

+    public function hasListeners($name, $object) {

         $listners = $this->doGetListeners();

-        if (!$this->hadListeners($name, $object)){

+        if (!$this->hadListeners($name, $object)) {

             $res = false;

-        }else{

+        }else {

             $listners = $this->doGetListeners();

-            $res = (boolean) count($listners[$object][$name]);

+            $res = (boolean)count($listners[$object][$name]);

         }

         return $res;

     }

@@ -119,7 +119,7 @@ 
      * @param object $object object to check for listeners

      * @return boolean

      */

-    public function hadListeners($name, $object){

+    public function hadListeners($name, $object) {

         $listners = $this->doGetListeners();

         return ($listners->contains($object) && isset($listners[$object][$name])) ? true : false;

     }

@@ -131,9 +131,9 @@ 
      * @param object $object object to get event-names for

      * @return string[] array of event-names

      */

-    public function getEventNames($object){

+    public function getEventNames($object) {

         $listeners = $this->doGetListeners();

-        if (!$listeners->contains($object)){

+        if (!$listeners->contains($object)) {

             return array();

         }

         return array_keys($listeners[$object]->getArrayCopy());

@@ -147,8 +147,8 @@ 
      * @param $object 

      * @return boolean

      */

-    public function notify($name, $object){

-        if($this->hasListeners($name, $object)){

+    public function notify($name, $object) {

+        if ($this->hasListeners($name, $object)) {

             $listners = $this->doGetListeners();

             self::doNotify($listners[$object][$name], $object);

         }

@@ -164,8 +164,8 @@ 
      * @param $subject 

      * @return mixed

      */

-    public function notifyUntil($name, $subject){

-        if($this->hasListeners($name, $subject)){       

+    public function notifyUntil($name, $subject) {

+        if ($this->hasListeners($name, $subject)) {       

             $res = self::doNotifyUntil($this->getListeners($name, $subject), $subject);   

         }

         return $res;

@@ -179,8 +179,8 @@ 
      * @param object $object object to check for listeners

      * @return array array of listeners

      */

-    public function getListeners($name, $object){

-        if (!$this->hadListeners($name, $object)){

+    public function getListeners($name, $object) {

+        if (!$this->hadListeners($name, $object)) {

             return array();

         }

         $listeners = $this->listeners[$object]->getArrayCopy();

@@ -194,7 +194,7 @@ 
      * @access protected

      * @return ObjectStorage

      */

-    protected function doGetListeners(){

+    protected function doGetListeners() {

         return isset($this->listeners) ? $this->listeners : $this->listeners = new ObjectStorage();

     }

    

@@ -207,11 +207,11 @@ 
      * @param $object 

      * @return boolean

      */    

-    protected static function doNotify(array $listeners, $subject){

-        foreach($listeners as $listener){ 

-             if($listener instanceof \PEIP\INF\Handler\Handler){

+    protected static function doNotify(array $listeners, $subject) {

+        foreach ($listeners as $listener) { 

+             if ($listener instanceof \PEIP\INF\Handler\Handler) {

                 $listener->handle($subject);

-             }elseif(is_callable($listener)){

+             }elseif (is_callable($listener)) {

                  call_user_func($listener, $subject);

              }

         }   

@@ -226,12 +226,12 @@ 
      * @param $object 

      * @return \PEIP\INF\Handler\Handler the listener which returned a boolean true value

      */     

-    protected static function doNotifyUntil(array $listeners, $subject){  

+    protected static function doNotifyUntil(array $listeners, $subject) {  

         $res = NULL; 

-        foreach ($listeners as $listener){ 

-            if($listener instanceof \PEIP\INF\Handler\Handler){

+        foreach ($listeners as $listener) { 

+            if ($listener instanceof \PEIP\INF\Handler\Handler) {

                 $res = $listener->handle($subject);

-                if ($res){ 

+                if ($res) { 

                     return $listener;

                 }

             }

@@ -239,8 +239,8 @@ 
         return $res;

     }

 

-    protected function getListenerHash($listener){

-        if(!is_object($listener)){

+    protected function getListenerHash($listener) {

+        if (!is_object($listener)) {

             $o = new \stdClass();

             $o->listener = $listener;

             $listener = $o;

Braces +2 added lines, -2 removed lines

@@ -104,7 +104,7 @@ 
         $listners = $this->doGetListeners();

         if (!$this->hadListeners($name, $object)){

             $res = false;

-        }else{

+        } else{

             $listners = $this->doGetListeners();

             $res = (boolean) count($listners[$object][$name]);

         }

@@ -211,7 +211,7 @@ 
         foreach($listeners as $listener){ 

              if($listener instanceof \PEIP\INF\Handler\Handler){

                 $listener->handle($subject);

-             }elseif(is_callable($listener)){

+             } elseif(is_callable($listener)){

                  call_user_func($listener, $subject);

              }

         }   

Unused Use Statements +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  * @implements \PEIP\INF\Base\Container, \PEIP\INF\Message\Message, \PEIP\INF\Base\Buildable

  */

 

-use PEIP\Util\Test;

+use PEIP\Util\Test;
 use PEIP\Base\GenericBuilder;

 

 class GenericMessage 

src/Event/Event.php

Doc Comments -1 removed lines

@@ -49,7 +49,6 @@
      * @access public

      * @param mixed $subject the subject for the event

      * @param string $name the name of the event

-     * @param array|ArrayAccess $headers the headers for the event 

      */

     public function __construct($subject, $name, $parameters = array(), $type = false){

         parent::__construct($subject, Test::ensureArrayAccess($parameters));

Spacing +9 added lines, -9 removed lines

@@ -51,7 +51,7 @@ 
      * @param string $name the name of the event

      * @param array|ArrayAccess $headers the headers for the event 

      */

-    public function __construct($subject, $name, $parameters = array(), $type = false){

+    public function __construct($subject, $name, $parameters = array(), $type = false) {

         parent::__construct($subject, Test::ensureArrayAccess($parameters));

         $this->name = $name;

         $this->type = $type ? $type : get_class($this);

@@ -63,7 +63,7 @@ 
      * @access public

      * @return string the name of the event

      */

-    public function getName(){

+    public function getName() {

         return $this->name;

     }

 

@@ -74,7 +74,7 @@ 
      * @access public

      * @return string the type of the event

      */

-    public function getType(){

+    public function getType() {

         return $this->name;

     }

   

@@ -84,7 +84,7 @@ 
      * @access public

      * @param mixed $value the return-value to set 

      */

-    public function setReturnValue($value){

+    public function setReturnValue($value) {

         $this->value = $value;

     }

   

@@ -94,7 +94,7 @@ 
      * @access public

      * @return mixed the return-value to set

      */

-    public function getReturnValue(){

+    public function getReturnValue() {

         return $this->value;

     }

   

@@ -104,8 +104,8 @@ 
      * @access public

      * @param boolean $processed 

      */

-    public function setProcessed($processed){

-        $this->processed = (boolean) $processed;

+    public function setProcessed($processed) {

+        $this->processed = (boolean)$processed;

     }

 

     /**

@@ -114,7 +114,7 @@ 
      * @access public

      * @return boolean wether the event is processed 

      */

-    public function isProcessed(){

+    public function isProcessed() {

         return $this->processed;

     }

 

@@ -124,7 +124,7 @@ 
      * @access public

      * @return mixed the subject/content

      */

-    public function getSubject(){

+    public function getSubject() {

         return $this->getContent();

     }

 }