Completed
Push — v1.ns ( ab319d...410f3f )
by Timo
04:00
created
src/Base/GenericBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
      * 
40 40
      * @access public
41 41
      * @param string $className class-name to create objects for
42
-     * @param ReflectionClass $reflectionClass reflection-class for class. default: NULL 
42
+     * @param \ReflectionClass $reflectionClass reflection-class for class. default: NULL 
43 43
      * @param boolean $storeRef wether to store a reference for new instance. default: true 
44 44
      * @return 
45 45
      */
Please login to merge, or discard this patch.
src/Event/EventBuilder.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,6 @@
 block discarded – undo
83 83
      * @param ObjectEventDispatcher $dispatcher the dispatcher to dispatch the event 
84 84
      * @param mixed $subject the subject for the event
85 85
      * @param string $name the name of the event
86
-     * @param array $parameters the headers for the event
87 86
      * @return 
88 87
      */
89 88
     public function buildAndDispatch(ObjectEventDispatcher $dispatcher, $subject, $name, array $headers = array()){
Please login to merge, or discard this patch.
src/ABS/Base/Connectable.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     
39 39
     /**
40 40
      * @access public
41
-     * @param $name
41
+     * @param string $name
42 42
      * @param Callable|PEIP\INF\Handler\Handler $listener
43 43
      * @return
44 44
      */
Please login to merge, or discard this patch.
src/ABS/Dispatcher/MapDispatcher.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,6 @@
 block discarded – undo
80 80
      *
81 81
      * @access public
82 82
      * @param string $name name of the event
83
-     * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect
84 83
      * @return
85 84
      */
86 85
     public function disconnectAll($name){
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
     public function connect($name, $listener){
48 48
         Test::ensureHandler($listener);
49 49
         if (!$this->hasListeners($name)){
50
-          $this->listeners[$name] = array();
50
+            $this->listeners[$name] = array();
51 51
         }
52 52
         $this->listeners[$name][] = $listener;
53 53
         return true;
@@ -67,10 +67,10 @@  discard block
 block discarded – undo
67 67
         }
68 68
         $res = false;
69 69
         foreach ($this->listeners[$name] as $i => $callable){
70
-          if ($listener === $callable){
70
+            if ($listener === $callable){
71 71
             unset($this->listeners[$name][$i]);
72 72
             $res = true;
73
-          }
73
+            }
74 74
         }
75 75
         return $res;
76 76
     }
Please login to merge, or discard this patch.
src/ABS/Handler/MessageHandler.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
      * @see PEIP\ABS\Handler\MessageHandler::doSetInputChannel
55 55
      * @access public
56 56
      * @param \PEIP\INF\Channel\Channel $inputChannel the input-channel
57
-     * @return PEIP\ABS\Handler\MessageHandler $this;
57
+     * @return MessageHandler $this;
58 58
      */
59 59
     public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel){
60 60
         $this->doSetInputChannel($inputChannel);
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      * @return 
44 44
      */
45 45
     public function handle($message){
46
-         $this->doHandle($this->getMessageFromObject($message));      
46
+            $this->doHandle($this->getMessageFromObject($message));      
47 47
     }
48 48
    
49 49
     /**
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
             && $object->getName() == 'postSend'
91 91
             && $object->hasHeader(Pipe::HEADER_MESSAGE)
92 92
             && $content instanceof \PEIP\INF\Channel\PollableChannel
93
-         ){
93
+            ){
94 94
             $object = $content->receive();
95 95
         }
96 96
         if (!($object instanceof \PEIP\INF\Message\Message)) {
Please login to merge, or discard this patch.
src/ABS/Handler/ReplyProducingMessageHandler.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      * Connects the handler to the output-channel. 
52 52
      * 
53 53
      * @access protected
54
-     * @param \PEIP\INF\Channel\Channel $inputChannel the output-channel to connect the handler to
54
+     * @param \PEIP\INF\Channel\Channel $outputChannel the output-channel to connect the handler to
55 55
      * @return 
56 56
      */
57 57
     protected function doSetOutputChannel(\PEIP\INF\Channel\Channel $outputChannel){
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
      * 
161 161
      * @access public
162 162
      * @param string $messageClass name of the message-class to create reply-messages from. 
163
-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this
163
+     * @return ReplyProducingMessageHandler $this
164 164
      */
165 165
     public function setMessageClass($messageClass){
166 166
         $this->messageClass = $messageClass;
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
      * 
194 194
      * @access public
195 195
      * @param array $headerNames array of message-header names to look for a reply-channel
196
-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this
196
+     * @return ReplyProducingMessageHandler $this
197 197
      */
198 198
     public function setReplyChannelHeaders(array $headerNames){
199 199
         $this->replyChannelHeaders = $headerNames;
Please login to merge, or discard this patch.
src/Context/XMLContext.php 2 patches
Doc Comments   +11 added lines, -7 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
      * 
136 136
      * @implements \PEIP\INF\Context\Context
137 137
      * @access public
138
-     * @param \PEIP\INF\Context\Context_Plugin $plugin a plugin instance
138
+     * @param \PEIP\INF\Context\ContextPlugin $plugin a plugin instance
139 139
      */
140 140
     public function addPlugin(\PEIP\INF\Context\ContextPlugin $plugin){ 
141 141
         $plugin->init($this);   
@@ -167,7 +167,6 @@  discard block
 block discarded – undo
167 167
      * </config>     
168 168
      * 
169 169
      * @access public
170
-     * @param XMLContext $config the config to include
171 170
      */    
172 171
     public function includeContext(XMLContext $context){
173 172
         $this->services = array_merge($this->services, $context->getServices());
@@ -178,7 +177,7 @@  discard block
 block discarded – undo
178 177
      * 
179 178
      * @see XMLContext::includeContext
180 179
      * @access public
181
-     * @param XMLContext $context the config to include
180
+     * @param string $filePath
182 181
      */    
183 182
     public function includeContextFromFile($filePath){
184 183
         if(file_exists($filePath)){
@@ -357,7 +356,7 @@  discard block
 block discarded – undo
357 356
      * 
358 357
      * @access public
359 358
      * @param $config 
360
-     * @return object the initialized service instance
359
+     * @return \PEIP\INF\Context\ContextPlugin the initialized service instance
361 360
      */
362 361
     public function createService($config){
363 362
         return ServiceFactory::createService($config);      
@@ -685,7 +684,7 @@  discard block
 block discarded – undo
685 684
      * 
686 685
      * @access protected
687 686
      * @param object $config configuration object to create arguments from.  
688
-     * @return mixed build arguments 
687
+     * @return \PEIP\INF\Channel\Channel[] build arguments 
689 688
      */
690 689
     protected function getReplyHandlerArguments($config){
691 690
         $args = array(
@@ -730,7 +729,8 @@  discard block
 block discarded – undo
730 729
      * 
731 730
      * @access protected
732 731
      * @param string the configuration type ofthe channel (e.g.: 'reply', 'request')
733
-     * @param object $config configuration object to return channel from. 
732
+     * @param object $config configuration object to return channel from.
733
+     * @param string $type 
734 734
      * @return \PEIP\INF\Channel\Channel reply-channel
735 735
      */
736 736
     public function doGetChannel($type, $config){
@@ -793,7 +793,7 @@  discard block
 block discarded – undo
793 793
      * @see GenericBuilder
794 794
      * @static
795 795
      * @access protected
796
-     * @param object $className name of class to build instance for. 
796
+     * @param string $className name of class to build instance for. 
797 797
      * @param array $arguments arguments for the constructor 
798 798
      * @return object build and modified srvice instance
799 799
      */     
@@ -801,6 +801,10 @@  discard block
 block discarded – undo
801 801
         return GenericBuilder::getInstance($className)->build($arguments);
802 802
     }
803 803
 
804
+    /**
805
+     * @param string $type
806
+     * @param string $name
807
+     */
804 808
     protected static function hasPublicProperty($service, $type, $name){
805 809
         $reflection = GenericBuilder::getInstance(get_class($service))->getReflectionClass();
806 810
         if($reflection->{'has'.$type}($name) && $reflection->{'get'.$type}($name)->isPublic()){
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
      * @param callable $callable a callable which creates instances for node-name 
128 128
      */
129 129
     public function registerNodeBuilder($nodeName, $callable){
130
-       return  $this->getServiceProvider()->registerNodeBuilder($nodeName, $callable);
130
+        return  $this->getServiceProvider()->registerNodeBuilder($nodeName, $callable);
131 131
     }
132 132
    
133 133
     /**
Please login to merge, or discard this patch.
src/Dispatcher/ClassDispatcher.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,6 @@
 block discarded – undo
71 71
      * notifies all listeners on a event on a subject
72 72
      *
73 73
      * @access public
74
-     * @param string $name name of the event
75 74
      * @param mixed $subject the subject
76 75
      * @return
77 76
      */
Please login to merge, or discard this patch.
src/Dispatcher/ClassEventDispatcher.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
      * @access public
56 56
      * @param string $name name of the event
57 57
      * @param \PEIP\INF\Event\Event $object an event object
58
-     * @return boolean
58
+     * @return boolean|null
59 59
      */
60 60
     public function notify($name, $object){ 
61 61
         if($object instanceof \PEIP\INF\Event\Event){
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      * @param array $headers headers of the event-object as key/value pairs
88 88
      * @param string $eventClass event-class to create instances from
89 89
      * @return
90
-     * @see EventBuilder
90
+     boolean|null @see EventBuilder
91 91
      */
92 92
     public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){
93 93
         if(!$this->hasListeners($name, ($object))){
Please login to merge, or discard this patch.
Indentation   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -66,9 +66,9 @@  discard block
 block discarded – undo
66 66
                         Reflection_Pool::getInstance(
67 67
                             $object->getContent()
68 68
                         )
69
-                     ),
70
-                     $object
71
-                 );
69
+                        ),
70
+                        $object
71
+                    );
72 72
             }else{
73 73
                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');
74 74
             }
@@ -77,18 +77,18 @@  discard block
 block discarded – undo
77 77
         }
78 78
     }       //put your code here
79 79
 
80
-     /**
81
-     * Creates an event-object with given object as content/subject and notifies
82
-     * all registers listeners of the event.
83
-     *
84
-     * @access public
85
-     * @param string $name name of the event
86
-     * @param object $object the subject of the event
87
-     * @param array $headers headers of the event-object as key/value pairs
88
-     * @param string $eventClass event-class to create instances from
89
-     * @return
90
-     * @see EventBuilder
91
-     */
80
+        /**
81
+         * Creates an event-object with given object as content/subject and notifies
82
+         * all registers listeners of the event.
83
+         *
84
+         * @access public
85
+         * @param string $name name of the event
86
+         * @param object $object the subject of the event
87
+         * @param array $headers headers of the event-object as key/value pairs
88
+         * @param string $eventClass event-class to create instances from
89
+         * @return
90
+         * @see EventBuilder
91
+         */
92 92
     public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){
93 93
         if(!$this->hasListeners($name, ($object))){
94 94
             return false;
Please login to merge, or discard this patch.