tidal / PEIP

src/Base/GenericBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
      * 
      * @access public
      * @param string $className class-name to create objects for
-     * @param ReflectionClass $reflectionClass reflection-class for class. default: NULL 
+     * @param \ReflectionClass $reflectionClass reflection-class for class. default: NULL 
      * @param boolean $storeRef wether to store a reference for new instance. default: true 
      * @return 
      */

Spacing +10 added lines, -10 removed lines

@@ -43,10 +43,10 @@ 
      * @param boolean $storeRef wether to store a reference for new instance. default: true 
      * @return 
      */
-    public function __construct($className, \ReflectionClass $reflectionClass = NULL, $storeRef = true){
-        if($reflectionClass ){
+    public function __construct($className, \ReflectionClass $reflectionClass = NULL, $storeRef = true) {
+        if ($reflectionClass) {
             
-            if($reflectionClass->getName() != $className){
+            if ($reflectionClass->getName() != $className) {
                 throw new \Exception(
                     'Constructing GenericBuilder with wrong ReflectionClass'
                 );
@@ -56,7 +56,7 @@ 
             $this->reflectionClass = $reflectionClass;
         }
         $this->className = $className;
-        if($storeRef){
+        if ($storeRef) {
             self::$instances[$this->className] = $this;
         }            
     }
@@ -68,8 +68,8 @@ 
      * @param string $className class-name to return builder instance for 
      * @return GenericBuilder builder instance for class
      */
-    public static function getInstance($className){
-        if(!array_key_exists((string)$className, self::$instances)) {
+    public static function getInstance($className) {
+        if (!array_key_exists((string)$className, self::$instances)) {
             new GenericBuilder($className);
         }
         return self::$instances[$className];
@@ -82,9 +82,9 @@ 
      * @param array $arguments array of constructore arguments
      * @return object the created object instance
      */
-    public function build(array $arguments = array()){      
-        if(Test::assertClassHasConstructor($this->className)){
-            if(!Test::assertRequiredConstructorParameters($this->className, $arguments)){
+    public function build(array $arguments = array()) {      
+        if (Test::assertClassHasConstructor($this->className)) {
+            if (!Test::assertRequiredConstructorParameters($this->className, $arguments)) {
                 throw new \Exception('Missing Argument '.(count($arguments) + 1).' for '.$this->className.'::__construct');
             }
             return $this->getReflectionClass()->newInstanceArgs($arguments);
@@ -98,7 +98,7 @@ 
      * @access public
      * @return ReflectionClass
      */
-    public function getReflectionClass(){
+    public function getReflectionClass() {
         return ReflectionPool::getInstance($this->className);
     }
     

src/Event/EventBuilder.php

Doc Comments -1 removed lines

@@ -83,7 +83,6 @@
      * @param ObjectEventDispatcher $dispatcher the dispatcher to dispatch the event 
      * @param mixed $subject the subject for the event
      * @param string $name the name of the event
-     * @param array $parameters the headers for the event
      * @return 
      */
     public function buildAndDispatch(ObjectEventDispatcher $dispatcher, $subject, $name, array $headers = array()){

Spacing +4 added lines, -4 removed lines

@@ -37,7 +37,7 @@ 
      * @param string $eventClass the event-class the builder shall create instances for 
      * @param array $defaultHeaders default headers for the created events 
      */
-    public function __construct($eventClass = '\PEIP\Event\Event', array $defaultHeaders = array()){
+    public function __construct($eventClass = '\PEIP\Event\Event', array $defaultHeaders = array()) {
         $this->eventClass = $eventClass;
         $this->defaultParameters = $defaultHeaders;
     }
@@ -49,7 +49,7 @@ 
      * @param string $eventClass the event-class the builder shall create instances for 
      * @return EventBuilder the instance of EventBuilder for the given event-class 
      */    
-    public static function getInstance($eventClass = '\PEIP\Event\Event'){ 
+    public static function getInstance($eventClass = '\PEIP\Event\Event') { 
 
         return isset(self::$instances[$eventClass]) 
             ? self::$instances[$eventClass] 
@@ -67,7 +67,7 @@ 
      * @param array $headers the headers for the event 
      * @return object event instance
      */
-    public function build($subject, $name, array $headers = array()){
+    public function build($subject, $name, array $headers = array()) {
 
         return new $this->eventClass(
             $subject,
@@ -86,7 +86,7 @@ 
      * @param array $parameters the headers for the event
      * @return 
      */
-    public function buildAndDispatch(ObjectEventDispatcher $dispatcher, $subject, $name, array $headers = array()){
+    public function buildAndDispatch(ObjectEventDispatcher $dispatcher, $subject, $name, array $headers = array()) {
   
         return $dispatcher->notify(
             $name,

src/ABS/Handler/DiscardingMessageHandler.php

Spacing +4 added lines, -4 removed lines

@@ -33,7 +33,7 @@ 
      * @param $discardChannel 
      * @return 
      */
-    public function setDiscardChannel(\PEIP\INF\Channel\Channel $discardChannel){
+    public function setDiscardChannel(\PEIP\INF\Channel\Channel $discardChannel) {
         $this->discardChannel = $discardChannel;    
     }   
 
@@ -42,7 +42,7 @@ 
      * @access public
      * @return 
      */
-    public function getDiscardChannel(){
+    public function getDiscardChannel() {
         return $this->discardChannel;   
     }   
 
@@ -52,8 +52,8 @@ 
      * @param $message 
      * @return 
      */
-    protected function discardMessage(\PEIP\INF\Message\Message $message){
-        if(isset($this->discardChannel)){
+    protected function discardMessage(\PEIP\INF\Message\Message $message) {
+        if (isset($this->discardChannel)) {
             $this->discardChannel->send($message);
         }
     }

src/INF/Base/Singleton.php

Spacing +1 added lines, -1 removed lines

@@ -22,6 +22,6 @@
 
 interface Singleton {
 
-    public static function getInstance ();
+    public static function getInstance();
 
 }

src/ABS/Base/Connectable.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     
     /**
      * @access public
-     * @param $name
+     * @param string $name
      * @param Callable|PEIP\INF\Handler\Handler $listener
      * @return
      */

Spacing +15 added lines, -15 removed lines

@@ -17,7 +17,7 @@ 
  * @subpackage base 
  */
 
-abstract class Connectable  implements \PEIP\INF\Event\Connectable{
+abstract class Connectable  implements \PEIP\INF\Event\Connectable {
 
     const
         DEFAULT_CLASS_MESSAGE_DISPATCHER = '\PEIP\Dispatcher\Dispatcher',
@@ -42,7 +42,7 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener
      * @return
      */
-    public function connect($name, $listener){
+    public function connect($name, $listener) {
         \PEIP\Util\Test::ensureHandler($listener);
         $this->getEventDispatcher()->connect($name, $this, $listener);
         $this->doFireEvent(
@@ -61,7 +61,7 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener
      * @return
      */
-    public function disconnect($name, $listener){
+    public function disconnect($name, $listener) {
         \PEIP\Util\Test::ensureHandler($listener);
         $this->getEventDispatcher()->disconnect($name, $this, $listener);
         $this->doFireEvent(
@@ -82,7 +82,7 @@ 
      * @param $name
      * @return
      */
-    public function hasListeners($name){
+    public function hasListeners($name) {
         return $this->getEventDispatcher()->hasListeners($name, $this);
     }
 
@@ -92,7 +92,7 @@ 
      * @param $name
      * @return
      */
-    public function getListeners($name){
+    public function getListeners($name) {
         return $this->getEventDispatcher()->getListeners($name, $this);
     }
 
@@ -102,7 +102,7 @@ 
      * @param $callable
      * @return
      */
-    public function disconnectAll($name){
+    public function disconnectAll($name) {
         $this->getEventDispatcher()->disconnectAll($name, $this);
     }
 
@@ -112,11 +112,11 @@ 
      * @param $transferListners
      * @return
      */
-    public function setEventDispatcher(\PEIP\Dispatcher\ObjectEventDispatcher $dispatcher, $transferListners = true){
-        if($transferListners){
-            foreach($this->getEventDispatcher()->getEventNames($this) as $name){
-                if($this->getEventDispatcher()->hasListeners($name, $this)){
-                    foreach($this->getEventDispatcher()->getListeners($name, $this) as $listener){
+    public function setEventDispatcher(\PEIP\Dispatcher\ObjectEventDispatcher $dispatcher, $transferListners = true) {
+        if ($transferListners) {
+            foreach ($this->getEventDispatcher()->getEventNames($this) as $name) {
+                if ($this->getEventDispatcher()->hasListeners($name, $this)) {
+                    foreach ($this->getEventDispatcher()->getListeners($name, $this) as $listener) {
                         $dispatcher->connect($name, $this, $listener);
                     }
                 }
@@ -131,11 +131,11 @@ 
      * @access public
      * @return
      */
-    public function getEventDispatcher(){
+    public function getEventDispatcher() {
         return $this->eventDispatcher ? $this->eventDispatcher : $this->eventDispatcher = self::getSharedEventDispatcher();
     }
 
-    protected static function getSharedEventDispatcher(){
+    protected static function getSharedEventDispatcher() {
         $defaultDispatcher = self::DEFAULT_CLASS_EVENT_DISPATCHER;
         return self::$sharedEventDispatcher ? self::$sharedEventDispatcher : self::$sharedEventDispatcher = new $defaultDispatcher;
     }
@@ -148,12 +148,12 @@ 
      * @param $eventClass
      * @return
      */
-    protected function doFireEvent($name, array $headers = array(), $eventClass = '', $type = false){
+    protected function doFireEvent($name, array $headers = array(), $eventClass = '', $type = false) {
         $eventClass = trim($eventClass) == '' ? static::DEFAULT_EVENT_CLASS : $eventClass;
         return $this->getEventDispatcher()->buildAndNotify($name, $this, $headers, $eventClass, $type);
     }
 
-    protected static function getDefaultEventClass(){
+    protected static function getDefaultEventClass() {
         return self::DEFAULT_EVENT_CLASS;
     }
 }

src/ABS/Dispatcher/MapDispatcher.php

Doc Comments -1 removed lines

@@ -80,7 +80,6 @@
      *
      * @access public
      * @param string $name name of the event
-     * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect
      * @return
      */
     public function disconnectAll($name){

Spacing +17 added lines, -17 removed lines

@@ -44,9 +44,9 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect
      * @return 
      */
-    public function connect($name, $listener){
+    public function connect($name, $listener) {
         Test::ensureHandler($listener);
-        if (!$this->hasListeners($name)){
+        if (!$this->hasListeners($name)) {
           $this->listeners[$name] = array();
         }
         $this->listeners[$name][] = $listener;
@@ -61,13 +61,13 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect
      * @return 
      */
-    public function disconnect($name, $listener){
-        if (!$this->hasListeners($name)){
+    public function disconnect($name, $listener) {
+        if (!$this->hasListeners($name)) {
             return false;
         }
         $res = false;
-        foreach ($this->listeners[$name] as $i => $callable){
-          if ($listener === $callable){
+        foreach ($this->listeners[$name] as $i => $callable) {
+          if ($listener === $callable) {
             unset($this->listeners[$name][$i]);
             $res = true;
           }
@@ -83,8 +83,8 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect
      * @return
      */
-    public function disconnectAll($name){
-        if (!isset($this->listeners[$name])){
+    public function disconnectAll($name) {
+        if (!isset($this->listeners[$name])) {
             return false;
         }
         $this->listeners[$name] = array();
@@ -98,11 +98,11 @@ 
      * @param string $name name of the event 
      * @return boolean wether any listener is registered for event-name
      */
-    public function hasListeners($name){
-        if (!isset($this->listeners[$name])){
+    public function hasListeners($name) {
+        if (!isset($this->listeners[$name])) {
             return false;
         }
-        return (boolean) count($this->listeners[$name]);
+        return (boolean)count($this->listeners[$name]);
     }
     
     /**
@@ -113,8 +113,8 @@ 
      * @param mixed $subject the subject 
      * @return boolean success
      */
-    public function notify($name, $subject){
-        if($this->hasListeners($name)){
+    public function notify($name, $subject) {
+        if ($this->hasListeners($name)) {
             self::doNotify($this->getListeners($name), $subject);
             return true;
         }
@@ -129,8 +129,8 @@ 
      * @param mixed $subject the subject 
      * @return \PEIP\INF\Handler\Handler listener which returned a boolean true value
      */
-    public function notifyUntil($name, $subject){
-        if($this->hasListeners($name)){
+    public function notifyUntil($name, $subject) {
+        if ($this->hasListeners($name)) {
             return self::doNotifyUntil($this->getListeners($name), $subject);   
         }
         return NULL;
@@ -143,8 +143,8 @@ 
      * @param $name 
      * @return array array of \PEIP\INF\Handler\Handler instances
      */
-    public function getListeners($name){
-        if (!isset($this->listeners[$name])){
+    public function getListeners($name) {
+        if (!isset($this->listeners[$name])) {
         return array();
         }
         return $this->listeners[$name];

src/ABS/Handler/MessageHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
      * @see PEIP\ABS\Handler\MessageHandler::doSetInputChannel
      * @access public
      * @param \PEIP\INF\Channel\Channel $inputChannel the input-channel
-     * @return PEIP\ABS\Handler\MessageHandler $this;
+     * @return MessageHandler $this;
      */
     public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel){
         $this->doSetInputChannel($inputChannel);

Spacing +9 added lines, -9 removed lines

@@ -42,7 +42,7 @@ 
      * @param object $message the message to handle
      * @return 
      */
-    public function handle($message){
+    public function handle($message) {
          $this->doHandle($this->getMessageFromObject($message));      
     }
    
@@ -56,7 +56,7 @@ 
      * @param \PEIP\INF\Channel\Channel $inputChannel the input-channel
      * @return PEIP\ABS\Handler\MessageHandler $this;
      */
-    public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel){
+    public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel) {
         $this->doSetInputChannel($inputChannel);
         return $this;
     }
@@ -73,24 +73,24 @@ 
      * @param \PEIP\INF\Channel\Channel $inputChannel the input-channel to connect the handler to
      * @return 
      */
-    protected function doSetInputChannel(\PEIP\INF\Channel\Channel $inputChannel){
+    protected function doSetInputChannel(\PEIP\INF\Channel\Channel $inputChannel) {
         $this->inputChannel = $inputChannel;    
-        if($this->inputChannel instanceof \PEIP\INF\Channel\SubscribableChannel){
+        if ($this->inputChannel instanceof \PEIP\INF\Channel\SubscribableChannel) {
                 $this->inputChannel->subscribe($this);
-        }else{          
+        }else {          
             $this->unwrapEvents = true;
             $this->inputChannel->connect('postSend', $this);
         }  
     }
   
-    protected function getMessageFromObject($object){ 
+    protected function getMessageFromObject($object) { 
         $content = $object->getContent();
-        if($this->unwrapEvents
+        if ($this->unwrapEvents
             && $object instanceof \PEIP\INF\Event\Event
             && $object->getName() == 'postSend'
             && $object->hasHeader(Pipe::HEADER_MESSAGE)
             && $content instanceof \PEIP\INF\Channel\PollableChannel
-         ){
+         ) {
             $object = $content->receive();
         }
         if (!($object instanceof \PEIP\INF\Message\Message)) {
@@ -106,7 +106,7 @@ 
      * @access public
      * @return \PEIP\INF\Channel\Channel input-channel for this handler
      */
-    public function getInputChannel(){
+    public function getInputChannel() {
         return $this->inputChannel;
     }   
       

src/ABS/Handler/ReplyProducingMessageHandler.php

Doc Comments +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
      * Connects the handler to the output-channel. 
      * 
      * @access protected
-     * @param \PEIP\INF\Channel\Channel $inputChannel the output-channel to connect the handler to
+     * @param \PEIP\INF\Channel\Channel $outputChannel the output-channel to connect the handler to
      * @return 
      */
     protected function doSetOutputChannel(\PEIP\INF\Channel\Channel $outputChannel){
@@ -160,7 +160,7 @@ 
      * 
      * @access public
      * @param string $messageClass name of the message-class to create reply-messages from. 
-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this
+     * @return ReplyProducingMessageHandler $this
      */
     public function setMessageClass($messageClass){
         $this->messageClass = $messageClass;
@@ -193,7 +193,7 @@ 
      * 
      * @access public
      * @param array $headerNames array of message-header names to look for a reply-channel
-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this
+     * @return ReplyProducingMessageHandler $this
      */
     public function setReplyChannelHeaders(array $headerNames){
         $this->replyChannelHeaders = $headerNames;

Spacing +17 added lines, -17 removed lines

@@ -42,7 +42,7 @@ 
      * @param \PEIP\INF\Channel\Channel $outputChannel the output-channel
      * @return \PEIP\ABS\Handler\MessageHandler $this;
      */
-    public function setOutputChannel(\PEIP\INF\Channel\Channel $outputChannel){
+    public function setOutputChannel(\PEIP\INF\Channel\Channel $outputChannel) {
         $this->doSetOutputChannel($outputChannel);
         return $this;
     }   
@@ -54,7 +54,7 @@ 
      * @param \PEIP\INF\Channel\Channel $inputChannel the output-channel to connect the handler to
      * @return 
      */
-    protected function doSetOutputChannel(\PEIP\INF\Channel\Channel $outputChannel){
+    protected function doSetOutputChannel(\PEIP\INF\Channel\Channel $outputChannel) {
         $this->outputChannel = $outputChannel;
     }
        
@@ -64,7 +64,7 @@ 
      * @access public
      * @return \PEIP\INF\Channel\Channel output-channel for this handler
      */
-    public function getOutputChannel(){
+    public function getOutputChannel() {
         return $this->outputChannel;
     }
 
@@ -78,7 +78,7 @@ 
      * @param \PEIP\INF\Message\Message $message the message to resolve output-channel for
      * @return \PEIP\INF\Channel\Channel the output-channel for the message
      */    
-    protected function doGetOutputChannel(\PEIP\INF\Message\Message $message){
+    protected function doGetOutputChannel(\PEIP\INF\Message\Message $message) {
         $replyChannel = $this->resolveReplyChannel($message);
         return $replyChannel ? $replyChannel : $this->getOutputChannel();       
     }
@@ -92,9 +92,9 @@ 
      * @param \PEIP\INF\Message\Message $message 
      * @return \PEIP\INF\Channel\Channel the reply-channel if found
      */     
-    protected function resolveReplyChannel(\PEIP\INF\Message\Message $message){
-        foreach($this->replyChannelHeaders as $header){
-            if($message->hasHeader($header)){
+    protected function resolveReplyChannel(\PEIP\INF\Message\Message $message) {
+        foreach ($this->replyChannelHeaders as $header) {
+            if ($message->hasHeader($header)) {
                 return $message->getHeader($header);
             }
         }
@@ -111,7 +111,7 @@ 
      * @access protected
      * @param mixed $content \PEIP\INF\Message\Message or content/payload for new message 
      */
-    protected function replyMessage($content){
+    protected function replyMessage($content) {
         $message = $this->ensureMessage($content);      
         $this->doGetOutputChannel($message)->send($message);      
     }
@@ -125,7 +125,7 @@ 
      * @param mixed $message \PEIP\INF\Message\Message or content/payload for new message
      * @return \PEIP\INF\Message\Message
      */
-    protected function ensureMessage($message){
+    protected function ensureMessage($message) {
         return ($message instanceof \PEIP\INF\Message\Message) ? $message : $this->buildMessage($message);   
     }
        
@@ -138,7 +138,7 @@ 
      * @return \PEIP\INF\Message\Message
      * @see MessageBuilder
      */
-    protected function buildMessage($content){
+    protected function buildMessage($content) {
         return $this->getMessageBuilder()->setContent($content)->build();   
     }   
        
@@ -149,7 +149,7 @@ 
      * @access protected
      * @return MessageBuilder builder for the registered message class
      */
-    protected function getMessageBuilder(){
+    protected function getMessageBuilder() {
         return isset($this->messageBuilder) && ($this->messageBuilder->getMessageClass() == $this->getMessageClass())
             ? $this->messageBuilder
             : $this->messageBuilder = MessageBuilder::getInstance($this->messageClass);
@@ -162,7 +162,7 @@ 
      * @param string $messageClass name of the message-class to create reply-messages from. 
      * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this
      */
-    public function setMessageClass($messageClass){
+    public function setMessageClass($messageClass) {
         $this->messageClass = $messageClass;
         return $this;
     }
@@ -173,7 +173,7 @@ 
      * @access public
      * @return string name of the message-class to create reply-messages from. 
      */
-    public function getMessageClass(){
+    public function getMessageClass() {
         return $this->messageClass;
     }       
 
@@ -184,7 +184,7 @@ 
      * @param string $headerName name of a message-header to look for a reply-channel
      * @return void
      */
-    public function addReplyChannelHeader($headerName){
+    public function addReplyChannelHeader($headerName) {
         $this->replyChannelHeaders[] = $headerName;
     }
     
@@ -195,7 +195,7 @@ 
      * @param array $headerNames array of message-header names to look for a reply-channel
      * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this
      */
-    public function setReplyChannelHeaders(array $headerNames){
+    public function setReplyChannelHeaders(array $headerNames) {
         $this->replyChannelHeaders = $headerNames;
         return $this;
     } 
@@ -206,7 +206,7 @@ 
      * @access public
      * @return array array of message-header names to look for a reply-channel
      */
-    public function getReplyChannelHeaders(){
+    public function getReplyChannelHeaders() {
         return $this->replyChannelHeaders;
     }
          
@@ -220,7 +220,7 @@ 
      * @param \PEIP\INF\Message\Message $message 
      * @return 
      */
-    protected function doHandle(\PEIP\INF\Message\Message $message){
+    protected function doHandle(\PEIP\INF\Message\Message $message) {
         return $this->doReply($message);
     }
        

src/Context/XMLContext.php

Doc Comments +11 added lines, -7 removed lines

@@ -135,7 +135,7 @@ 
      * 
      * @implements \PEIP\INF\Context\Context
      * @access public
-     * @param \PEIP\INF\Context\Context_Plugin $plugin a plugin instance
+     * @param \PEIP\INF\Context\ContextPlugin $plugin a plugin instance
      */
     public function addPlugin(\PEIP\INF\Context\ContextPlugin $plugin){ 
         $plugin->init($this);   
@@ -167,7 +167,6 @@ 
      * </config>     
      * 
      * @access public
-     * @param XMLContext $config the config to include
      */    
     public function includeContext(XMLContext $context){
         $this->services = array_merge($this->services, $context->getServices());
@@ -178,7 +177,7 @@ 
      * 
      * @see XMLContext::includeContext
      * @access public
-     * @param XMLContext $context the config to include
+     * @param string $filePath
      */    
     public function includeContextFromFile($filePath){
         if(file_exists($filePath)){
@@ -357,7 +356,7 @@ 
      * 
      * @access public
      * @param $config 
-     * @return object the initialized service instance
+     * @return \PEIP\INF\Context\ContextPlugin the initialized service instance
      */
     public function createService($config){
         return ServiceFactory::createService($config);      
@@ -685,7 +684,7 @@ 
      * 
      * @access protected
      * @param object $config configuration object to create arguments from.  
-     * @return mixed build arguments 
+     * @return \PEIP\INF\Channel\Channel[] build arguments 
      */
     protected function getReplyHandlerArguments($config){
         $args = array(
@@ -730,7 +729,8 @@ 
      * 
      * @access protected
      * @param string the configuration type ofthe channel (e.g.: 'reply', 'request')
-     * @param object $config configuration object to return channel from. 
+     * @param object $config configuration object to return channel from.
+     * @param string $type 
      * @return \PEIP\INF\Channel\Channel reply-channel
      */
     public function doGetChannel($type, $config){
@@ -793,7 +793,7 @@ 
      * @see GenericBuilder
      * @static
      * @access protected
-     * @param object $className name of class to build instance for. 
+     * @param string $className name of class to build instance for. 
      * @param array $arguments arguments for the constructor 
      * @return object build and modified srvice instance
      */     
@@ -801,6 +801,10 @@ 
         return GenericBuilder::getInstance($className)->build($arguments);
     }
 
+    /**
+     * @param string $type
+     * @param string $name
+     */
     protected static function hasPublicProperty($service, $type, $name){
         $reflection = GenericBuilder::getInstance(get_class($service))->getReflectionClass();
         if($reflection->{'has'.$type}($name) && $reflection->{'get'.$type}($name)->isPublic()){

Spacing +95 added lines, -95 removed lines

@@ -50,24 +50,24 @@ 
      * @param string $string the configuration string 
      * @return 
      */
-    public function __construct($string){
+    public function __construct($string) {
         $this->initNodeBuilders();
         $reader = new XMLContextReader($string);
  
 
         $serviceActivator = new HeaderServiceActivator(array($this, 'addConfig'), 'NODE');
 
-        $reader->connect('read_node',  $serviceActivator);
+        $reader->connect('read_node', $serviceActivator);
         $reader->read();
 
        
     }
 
-    public function addConfig($config){ 
+    public function addConfig($config) { 
         return $this->getServiceProvider()->addConfig($config);
     }
 
-    public function handleReadConfig(\PEIP\INF\Event\Event $event){
+    public function handleReadConfig(\PEIP\INF\Event\Event $event) {
         $this->addConfig($event->getHeader('NODE'));
     }
 
@@ -79,7 +79,7 @@ 
      * @return XMLContext the context instance
      * @throws RuntimeException 
      */      
-    public static function createFromString($string){
+    public static function createFromString($string) {
         return new XMLContext($string);
     }
 
@@ -91,10 +91,10 @@ 
      * @return XMLContext the context instance
      * @throws RuntimeException 
      */    
-    public static function createFromFile($file){
-        if(file_exists($file)){
+    public static function createFromFile($file) {
+        if (file_exists($file)) {
             return self::createFromString(file_get_contents($file));
-        }else{
+        }else {
             throw new \RuntimeException('Cannot open file  "'.$file.'".');
         }
     }
@@ -105,15 +105,15 @@ 
      * @access protected
      * @return void
      */
-    protected function init(){
+    protected function init() {
         $xml = $this->simpleXML;
         $this->channelRegistry = ChannelRegistry::getInstance();
         // register this context as a service if id is set.
-        if($xml['id']){
+        if ($xml['id']) {
             $this->services[(string)$xml['id']] = $this;    
         }
         // build services
-        foreach($xml->children() as $entry){
+        foreach ($xml->children() as $entry) {
             $this->buildNode($entry);
         }
     }    
@@ -126,7 +126,7 @@ 
      * @param string $nodeName the name of the node 
      * @param callable $callable a callable which creates instances for node-name 
      */
-    public function registerNodeBuilder($nodeName, $callable){
+    public function registerNodeBuilder($nodeName, $callable) {
        return  $this->getServiceProvider()->registerNodeBuilder($nodeName, $callable);
     }
    
@@ -137,7 +137,7 @@ 
      * @access public
      * @param \PEIP\INF\Context\Context_Plugin $plugin a plugin instance
      */
-    public function addPlugin(\PEIP\INF\Context\ContextPlugin $plugin){ 
+    public function addPlugin(\PEIP\INF\Context\ContextPlugin $plugin) { 
         $plugin->init($this);   
     }
   
@@ -148,7 +148,7 @@ 
      * @param object $config configuration object for the plugin 
      * @return 
      */
-    public function createPlugin($config){
+    public function createPlugin($config) {
         $plugin = $this->createService($config);    
         $this->addPlugin($plugin);
     }
@@ -169,7 +169,7 @@ 
      * @access public
      * @param XMLContext $config the config to include
      */    
-    public function includeContext(XMLContext $context){
+    public function includeContext(XMLContext $context) {
         $this->services = array_merge($this->services, $context->getServices());
     }
 
@@ -180,8 +180,8 @@ 
      * @access public
      * @param XMLContext $context the config to include
      */    
-    public function includeContextFromFile($filePath){
-        if(file_exists($filePath)){
+    public function includeContextFromFile($filePath) {
+        if (file_exists($filePath)) {
             $this->includeContextFromString(file_get_contents($filePath));
         }           
     }
@@ -193,7 +193,7 @@ 
      * @access public
      * @param string $configString the config to include
      */    
-    public function includeContextFromString($configString){
+    public function includeContextFromString($configString) {
         $context = new XMLContext($configString);
         $this->includeContext($context);            
     }   
@@ -205,14 +205,14 @@ 
      * @access protected
      * @param object $config the configuration for the context
      */    
-    protected function createContext($config){
-        if((string)$config['file'] != ''){
+    protected function createContext($config) {
+        if ((string)$config['file'] != '') {
             $this->includeContextFromFile((string)$config['file']);
         }           
     }   
      
 
-    public function getServiceProvider(){
+    public function getServiceProvider() {
         return isset($this->serviceProvider)
             ? $this->serviceProvider
             : $this->serviceProvider = new ServiceProvider();
@@ -228,7 +228,7 @@ 
      * @see XMLContext::includeContext
      * @access protected
      */     
-    protected function initNodeBuilders(){
+    protected function initNodeBuilders() {
         $builders = array(
             'include' => 'createContext',
             'plugin' => 'createPlugin',
@@ -246,7 +246,7 @@ 
         );
         $plugin = new BasePlugin();
         $this->addPlugin($plugin); 
-        foreach($builders as $nodeName => $method){
+        foreach ($builders as $nodeName => $method) {
             $this->registerNodeBuilder($nodeName, array($this, $method));   
         }       
     }
@@ -260,10 +260,10 @@ 
      * @param object $node configuration-node
      * @return void
      */
-    protected function buildNode($node){
+    protected function buildNode($node) {
         $nodeName = $node->getName();
         // call the builder method registered for the node.
-        if(array_key_exists($nodeName, $this->nodeBuilders)){
+        if (array_key_exists($nodeName, $this->nodeBuilders)) {
             call_user_func($this->nodeBuilders[$nodeName], $node);
         }           
     }
@@ -282,7 +282,7 @@ 
      * @param string $channelName the name/id of the channel to return 
      * @return \PEIP\INF\Channel\Channel
      */
-    public function resolveChannelName($channelName){
+    public function resolveChannelName($channelName) {
         return $this->channelRegistry->get($channelName);
     }   
      
@@ -294,7 +294,7 @@ 
      * @param mixed $id the id for the service
      * @return object the service instance if found
      */
-    public function getService($id){     
+    public function getService($id) {     
         return $this->getServiceProvider()->provideService($id);
     }
              
@@ -304,7 +304,7 @@ 
      * @access public
      * @return array registered services
      */
-    public function getServices(){    
+    public function getServices() {    
         return $this->getServiceProvider()->getServices();
     }  
     
@@ -315,7 +315,7 @@ 
      * @param mixed $id the id for the service 
      * @return boolean wether service is registered
      */
-    public function hasService($id){
+    public function hasService($id) {
         return isset($this->services[$id]);
     }
       
@@ -329,9 +329,9 @@ 
      * @return object the service instance if found
      * 
      */
-    protected function requestService($id){
+    protected function requestService($id) {
         $service = $this->getService($id);
-        if($service === NULL){
+        if ($service === NULL) {
             throw new \RuntimeException('Service "'.$id.'" not found.');
         } 
         return $service;
@@ -345,9 +345,9 @@ 
      * @param object $config 
      * @return object the initialized service instance
      */
-    protected function initService($config){
+    protected function initService($config) {
         $id = trim((string)$config['id']);
-        if($id != ''){
+        if ($id != '') {
             return $this->services[$id] = $this->createService($config);    
         }   
     }
@@ -359,7 +359,7 @@ 
      * @param $config 
      * @return object the initialized service instance
      */
-    public function createService($config){
+    public function createService($config) {
         return ServiceFactory::createService($config);      
     }
  
@@ -376,28 +376,28 @@ 
      * @param object $config configuration to get the modification instructions from. 
      * @return object the modificated service
      */
-    protected function modifyService($service, $config){ 
+    protected function modifyService($service, $config) { 
         // set instance properties
-        if($config->property){          
-            foreach($config->property as $property){                          
+        if ($config->property) {          
+            foreach ($config->property as $property) {                          
                 $arg = $this->buildArg($property);
-                if($arg){
+                if ($arg) {
                     $setter = self::getSetter($property);               
-                    if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){
+                    if ($setter && self::hasPublicProperty($service, 'Method', $setter)) {
                         $service->{$setter}($arg);  
-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){
+                    }elseif (in_array($property, self::hasPublicProperty($service, 'Property', $setter))) {
                         $service->$setter = $arg;
                     }                   
                 }
             }
         }   
         // call instance methods
-        if($config->action){            
-            foreach($config->action as $action){
+        if ($config->action) {            
+            foreach ($config->action as $action) {
                 $method = (string)$action['method'] != '' ? (string)$action['method'] : NULL;
-                if($method && self::hasPublicProperty($service, 'Method', $method)){
+                if ($method && self::hasPublicProperty($service, 'Method', $method)) {
                     $args = array(); 
-                    foreach($action->children() as $argument){
+                    foreach ($action->children() as $argument) {
                         $args[] = $this->buildArg($argument);
                     } 
                     call_user_func_array(array($service, (string)$action['method']), $args);
@@ -405,9 +405,9 @@ 
             }
         }       
         // register instance listeners
-        if($service instanceof \PEIP\INF\Event\Connectable){
-            if($config->listener){
-                foreach($config->listener as $listenerConf){
+        if ($service instanceof \PEIP\INF\Event\Connectable) {
+            if ($config->listener) {
+                foreach ($config->listener as $listenerConf) {
                     $event = (string)$listenerConf['event'];
                     $listener = $this->provideService($listenerConf);  
                     $service->connect($event, $listener);   
@@ -426,7 +426,7 @@ 
      * @param mixed $id the id ofthe gateway 
      * @return object the gateway instance
      */
-    public function getGateway($id){ 
+    public function getGateway($id) { 
         return $this->getServiceProvider()->provideService($id); 
     }   
   
@@ -438,7 +438,7 @@ 
      * @param object $config configuration object for the pollable channel. 
      * @return \PEIP\INF\Channel\Channel the created pollable channel instance
      */
-    public function createChannel($config){
+    public function createChannel($config) {
         return $this->doCreateChannel($config, 'PollableChannel');        
     }
   
@@ -450,7 +450,7 @@ 
      * @param object $config configuration object for the subscribable channel. 
      * @return \PEIP\INF\Channel\Channel the created subscribable channel instance
      */
-    public function createSubscribableChannel($config){
+    public function createSubscribableChannel($config) {
         return $this->doCreateChannel($config, 'PublishSubscribeChannel');       
     }   
    
@@ -463,9 +463,9 @@ 
      * @param $additionalArguments additional arguments for the channel constructor (without first arg = id)
      * @return \PEIP\INF\Channel\Channel the created channel instance
      */
-    public function doCreateChannel($config, $defaultChannelClass, array $additionalArguments = array()){
+    public function doCreateChannel($config, $defaultChannelClass, array $additionalArguments = array()) {
         $id = (string)$config['id'];
-        if($id != ''){ 
+        if ($id != '') { 
             array_unshift($additionalArguments, $id);
             $channel = $this->buildAndModify($config, $additionalArguments, $defaultChannelClass);
             $this->channelRegistry->register($channel);
@@ -482,7 +482,7 @@ 
      * @param string $defaultClass the class to use if none is set in config. 
      * @return object the gateway instance
      */
-    public function createGateway($config, $defaultClass = false){
+    public function createGateway($config, $defaultClass = false) {
         $args = array(
             $this->getRequestChannel($config), 
             $this->getReplyChannel($config)
@@ -506,7 +506,7 @@ 
      * @param string $defaultClass the class to use if none is set in config. 
      * @return object the router instance
      */
-    public function createRouter($config, $defaultClass = false){
+    public function createRouter($config, $defaultClass = false) {
         $resolver = $config['channel_resolver'] ? (string)$config['channel_resolver'] : $this->channelRegistry;
         return $this->buildAndModify($config, array(
             $resolver,
@@ -523,7 +523,7 @@ 
      * @param object $config configuration object for the splitter. 
      * @return object the splitter instance
      */    
-    public function createSplitter($config){
+    public function createSplitter($config) {
         return $this->createReplyMessageHandler($config);           
     }   
  
@@ -536,7 +536,7 @@ 
      * @param object $config configuration object for the transformer. 
      * @return object the transformer instance
      */    
-    public function createTransformer($config){
+    public function createTransformer($config) {
         return $this->createReplyMessageHandler($config);           
     } 
       
@@ -549,7 +549,7 @@ 
      * @param object $config configuration object for the aggregator. 
      * @return object the aggregator instance
      */  
-    public function createAggregator($config){
+    public function createAggregator($config) {
         return $this->createReplyMessageHandler($config);       
     }
   
@@ -562,7 +562,7 @@ 
      * @param object $config configuration object for the wiretap. 
      * @return object the wiretap instance
      */ 
-    public function createWiretap($config){
+    public function createWiretap($config) {
         return $this->createReplyMessageHandler($config, 'Wiretap');       
     }
   
@@ -575,7 +575,7 @@ 
      * @param string $defaultClass the class to use if none is set in config.
      * @return object the reply-message-handler instance
      */ 
-    public function createReplyMessageHandler($config, $defaultClass = false){
+    public function createReplyMessageHandler($config, $defaultClass = false) {
         return $this->buildAndModify($config, $this->getReplyHandlerArguments($config), $defaultClass); 
     }
     
@@ -588,12 +588,12 @@ 
      * @param string $defaultClass the class to use if none is set in config. 
      * @return object the service-activator instance
      */
-    public function createServiceActivator($config, $defaultClass = false){
+    public function createServiceActivator($config, $defaultClass = false) {
         $method = (string)$config['method'];
         $service = $this->getService((string)$config['ref']);
-        if($method && $service){        
+        if ($method && $service) {        
             $args = $this->getReplyHandlerArguments($config);
-            array_unshift($args,array(
+            array_unshift($args, array(
                 $service,
                 $method             
             )); 
@@ -614,11 +614,11 @@ 
      * @param object $config configuration object for the service. 
      * @return 
      */
-    protected function provideService($config){
+    protected function provideService($config) {
         $ref = trim((string)$config['ref']);
-        if($ref != ''){
+        if ($ref != '') {
             $service = $this->getService($ref); 
-        }else{
+        }else {
             $service = $this->createService($config);
         }
         return $service;
@@ -635,10 +635,10 @@ 
      * @param object $config configuration object for the setter-method. 
      * @return string camel-cased 
      */    
-    protected static function getSetter($config){
-        if($config['setter']){
+    protected static function getSetter($config) {
+        if ($config['setter']) {
             $setter = (string)$config['setter'];
-        }elseif($config['name']){
+        }elseif ($config['name']) {
             $setter = 'set'.ucfirst((string)$config['name']);   
         }
         return $setter;     
@@ -651,29 +651,29 @@ 
      * @param object $config configuration object to create argument from.  
      * @return mixed build argument 
      */
-    protected function buildArg($config){ 
-        if(trim((string)$config['value']) != ''){
+    protected function buildArg($config) { 
+        if (trim((string)$config['value']) != '') {
             $arg = (string)$config['value'];
-        }elseif($config->getName() == 'value'){
+        }elseif ($config->getName() == 'value') {
             $arg = (string)$config;
-        }elseif($config->getName() == 'list'){
+        }elseif ($config->getName() == 'list') {
             $arg = array();
-            foreach($config->children() as $entry){ 
-                if($entry->getName() == 'value'){
-                    if($entry['key']){
+            foreach ($config->children() as $entry) { 
+                if ($entry->getName() == 'value') {
+                    if ($entry['key']) {
                         $arg[(string)$entry['key']] = (string)$entry;   
-                    }else{
+                    }else {
                         $arg[] = (string)$entry;
                     }
-                }elseif($entry->getName() == 'service'){
+                }elseif ($entry->getName() == 'service') {
                     $arg[] = $this->provideService($entry);
                 }
             }
-        }elseif($config->getName() == 'service'){
+        }elseif ($config->getName() == 'service') {
             $arg = $this->provideService($config);
-        }elseif($config->list){
+        }elseif ($config->list) {
             $arg = $this->buildArg($config->list);
-        }elseif($config->service){
+        }elseif ($config->service) {
             $arg = $this->buildArg($config->service);
         } 
         return $arg; 
@@ -687,12 +687,12 @@ 
      * @param object $config configuration object to create arguments from.  
      * @return mixed build arguments 
      */
-    protected function getReplyHandlerArguments($config){
+    protected function getReplyHandlerArguments($config) {
         $args = array(
             $this->doGetChannel('input', $config),
             $this->doGetChannel('output', $config)
         );
-        if($args[0] == NULL){
+        if ($args[0] == NULL) {
             throw new \RuntimeException('Could not receive input channel.');
         }
         return $args;
@@ -707,7 +707,7 @@ 
      * @param object $config configuration object to return request-channel from. 
      * @return \PEIP\INF\Channel\Channel request-channel
      */
-    protected function getRequestChannel($config){
+    protected function getRequestChannel($config) {
         return $this->doGetChannel('request', $config); 
     }
     
@@ -720,7 +720,7 @@ 
      * @param object $config configuration object to return reply-channel from. 
      * @return \PEIP\INF\Channel\Channel reply-channel
      */
-    protected function getReplyChannel($config){
+    protected function getReplyChannel($config) {
         return $this->doGetChannel('reply', $config);   
     }
     
@@ -733,7 +733,7 @@ 
      * @param object $config configuration object to return channel from. 
      * @return \PEIP\INF\Channel\Channel reply-channel
      */
-    public function doGetChannel($type, $config){
+    public function doGetChannel($type, $config) {
         $channelName = $config[$type."_channel"] 
             ? $config[$type."_channel"] 
             : $config["default_".$type."_channel"];
@@ -753,7 +753,7 @@ 
      * @param string $defaultClass class to create instance for if none is set in config 
      * @return object build and modified srvice instance
      */
-    public function buildAndModify($config, $arguments, $defaultClass = false){   
+    public function buildAndModify($config, $arguments, $defaultClass = false) {   
         return ServiceFactory::buildAndModify($config, $arguments, $defaultClass);
     }
 
@@ -767,21 +767,21 @@ 
      * @param string $defaultClass class to create instance for if none is set in config 
      * @return object build and modified srvice instance
      */    
-    protected static function doBuild($config, $arguments, $defaultClass = false){
+    protected static function doBuild($config, $arguments, $defaultClass = false) {
         $cls = $config["class"] ? trim((string)$config["class"]) : (string)$defaultClass;
-        if($cls != ''){
+        if ($cls != '') {
             try {
                 $constructor = (string)$config["constructor"];
-        if($constructor != ''){
+        if ($constructor != '') {
             $service = call_user_func_array(array($cls, $constructor), $arguments); 
-        }else{
+        }else {
             $service = self::build($cls, $arguments); 
         }        
-            }catch(\Exception $e){
+            } catch (\Exception $e) {
                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());
             }           
         }
-        if(is_object($service)){
+        if (is_object($service)) {
             return $service;
         }       
         throw new \RuntimeException('Could not create Service "'.$cls.'". Class does not exist.');           
@@ -797,13 +797,13 @@ 
      * @param array $arguments arguments for the constructor 
      * @return object build and modified srvice instance
      */     
-    protected static function build($className, $arguments){
+    protected static function build($className, $arguments) {
         return GenericBuilder::getInstance($className)->build($arguments);
     }
 
-    protected static function hasPublicProperty($service, $type, $name){
+    protected static function hasPublicProperty($service, $type, $name) {
         $reflection = GenericBuilder::getInstance(get_class($service))->getReflectionClass();
-        if($reflection->{'has'.$type}($name) && $reflection->{'get'.$type}($name)->isPublic()){
+        if ($reflection->{'has'.$type}($name) && $reflection->{'get'.$type}($name)->isPublic()) {
                 return true;
         }
         return false;