tidal / PEIP

src/ABS/Dispatcher/MapDispatcher.php

Doc Comments -1 removed lines

@@ -80,7 +80,6 @@
      *

      * @access public

      * @param string $name name of the event

-     * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect

      * @return

      */

     public function disconnectAll($name){

src/ABS/Handler/MessageHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
      * @see PEIP\ABS\Handler\MessageHandler::doSetInputChannel

      * @access public

      * @param \PEIP\INF\Channel\Channel $inputChannel the input-channel

-     * @return PEIP\ABS\Handler\MessageHandler $this;

+     * @return MessageHandler $this;

      */

     public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel){

         $this->doSetInputChannel($inputChannel);

Braces +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
         $this->inputChannel = $inputChannel;    

         if($this->inputChannel instanceof \PEIP\INF\Channel\SubscribableChannel){

                 $this->inputChannel->subscribe($this);

-        }else{          

+        } else{          

             $this->unwrapEvents = true;

             $this->inputChannel->connect('postSend', $this);

         }  

src/ABS/Handler/ReplyProducingMessageHandler.php

Doc Comments +3 added lines, -3 removed lines

@@ -53,7 +53,7 @@ 
      * Connects the handler to the output-channel. 

      * 

      * @access protected

-     * @param \PEIP\INF\Channel\Channel $inputChannel the output-channel to connect the handler to

+     * @param \PEIP\INF\Channel\Channel $outputChannel the output-channel to connect the handler to

      * @return 

      */

     protected function doSetOutputChannel(\PEIP\INF\Channel\Channel $outputChannel){

@@ -162,7 +162,7 @@ 
      * 

      * @access public

      * @param string $messageClass name of the message-class to create reply-messages from. 

-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this

+     * @return ReplyProducingMessageHandler $this

      */

     public function setMessageClass($messageClass){

         $this->messageClass = $messageClass;

@@ -195,7 +195,7 @@ 
      * 

      * @access public

      * @param array $headerNames array of message-header names to look for a reply-channel

-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this

+     * @return ReplyProducingMessageHandler $this

      */

     public function setReplyChannelHeaders(array $headerNames){

         $this->replyChannelHeaders = $headerNames;

src/Autoload/Autoload.php

Doc Comments +2 added lines, -1 removed lines

@@ -66,7 +66,8 @@
      * Scans a directory recursively for php-files and adds them to autoload

      * 

      * @access public

-     * @param string directoy to scan

+     * @param string directoy to scan
+     * @param string $dir

      * @return void

      */ 

     public function scanDirectory($dir){

Braces +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
         while($iterator->valid()){

             if($iterator->isDir() && !$iterator->isDot()){

                 $paths = self::findPaths($baseDir, $iterator->getChildren(), $paths);

-            }elseif($iterator->isFile() && strrchr($iterator->getFilename(), '.') == '.php'){

+            } elseif($iterator->isFile() && strrchr($iterator->getFilename(), '.') == '.php'){

                 $class = $iterator->getBasename('.php');

                 $paths[$class] = str_replace($baseDir, '', $iterator->getPathName());                       

             }

src/Base/GenericBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
      * 
      * @access public
      * @param string $className class-name to create objects for
-     * @param ReflectionClass $reflectionClass reflection-class for class. default: NULL 
+     * @param \ReflectionClass $reflectionClass reflection-class for class. default: NULL 
      * @param boolean $storeRef wether to store a reference for new instance. default: true 
      * @return 
      */

src/Context/XMLContext.php

Doc Comments +9 added lines, -5 removed lines

@@ -174,7 +174,6 @@ 
      * </config>     

      * 

      * @access public

-     * @param XMLContext $config the config to include

      */    

     public function includeContext(XMLContext $context){

         $this->services = array_merge($this->services, $context->getServices());

@@ -185,7 +184,7 @@ 
      * 

      * @see XMLContext::includeContext

      * @access public

-     * @param XMLContext $context the config to include

+     * @param string $filePath
      */    

     public function includeContextFromFile($filePath){

         if(file_exists($filePath)){

@@ -693,7 +692,7 @@ 
      * 

      * @access protected

      * @param object $config configuration object to create arguments from.  

-     * @return mixed build arguments 

+     * @return \PEIP\INF\Channel\Channel[] build arguments 

      */

     protected function getReplyHandlerArguments($config){

         $args = array(

@@ -738,7 +737,8 @@ 
      * 

      * @access protected

      * @param string the configuration type ofthe channel (e.g.: 'reply', 'request')

-     * @param object $config configuration object to return channel from. 

+     * @param object $config configuration object to return channel from.
+     * @param string $type 

      * @return \PEIP\INF\Channel\Channel reply-channel

      */

     public function doGetChannel($type, $config){

@@ -833,7 +833,7 @@ 
      * @see GenericBuilder

      * @static

      * @access protected

-     * @param object $className name of class to build instance for. 

+     * @param string $className name of class to build instance for. 

      * @param array $arguments arguments for the constructor 

      * @return object build and modified srvice instance

      */     

@@ -841,6 +841,10 @@ 
         return GenericBuilder::getInstance($className)->build($arguments);

     }

 

+    /**
+     * @param string $type
+     * @param string $name
+     */
     protected static function hasPublicProperty($service, $type, $name){

         $reflection = GenericBuilder::getInstance(get_class($service))->getReflectionClass();

         if($reflection->{'has'.$type}($name) && $reflection->{'get'.$type}($name)->isPublic()){

Braces +17 added lines, -17 removed lines

@@ -101,7 +101,7 @@ 
     public static function createFromFile($file){

         if(file_exists($file)){

             return self::createFromString(file_get_contents($file));

-        }else{

+        } else{

             throw new \RuntimeException('Cannot open file  "'.$file.'".');

         }

     }

@@ -393,7 +393,7 @@ 
                     $setter = self::getSetter($property);               

                     if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){

                         $service->{$setter}($arg);  

-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

+                    } elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

                         $service->$setter = $arg;

                     }                   

                 }

@@ -626,7 +626,7 @@ 
         $ref = trim((string)$config['ref']);

         if($ref != ''){

             $service = $this->getService($ref); 

-        }else{

+        } else{

             $service = $this->createService($config);

         }

         return $service;

@@ -646,7 +646,7 @@ 
     protected static function getSetter($config){

         if($config['setter']){

             $setter = (string)$config['setter'];

-        }elseif($config['name']){

+        } elseif($config['name']){

             $setter = 'set'.ucfirst((string)$config['name']);   

         }

         return $setter;     

@@ -662,26 +662,26 @@ 
     protected function buildArg($config){ 

         if(trim((string)$config['value']) != ''){

             $arg = (string)$config['value'];

-        }elseif($config->getName() == 'value'){

+        } elseif($config->getName() == 'value'){

             $arg = (string)$config;

-        }elseif($config->getName() == 'list'){

+        } elseif($config->getName() == 'list'){

             $arg = array();

             foreach($config->children() as $entry){ 

                 if($entry->getName() == 'value'){

                     if($entry['key']){

                         $arg[(string)$entry['key']] = (string)$entry;   

-                    }else{

+                    } else{

                         $arg[] = (string)$entry;

                     }

-                }elseif($entry->getName() == 'service'){

+                } elseif($entry->getName() == 'service'){

                     $arg[] = $this->provideService($entry);

                 }

             }

-        }elseif($config->getName() == 'service'){

+        } elseif($config->getName() == 'service'){

             $arg = $this->provideService($config);

-        }elseif($config->list){

+        } elseif($config->list){

             $arg = $this->buildArg($config->list);

-        }elseif($config->service){

+        } elseif($config->service){

             $arg = $this->buildArg($config->service);

         } 

         return $arg; 

@@ -749,7 +749,7 @@ 
         $channel =  $this->services[trim((string)$channelName)];

         if($channel instanceof \PEIP\INF\Channel\Channel){

             return $channel;    

-        }else{

+        } else{

             return NULL;

         }       

     }

@@ -770,14 +770,14 @@ 
     public function buildAndModify($config, $arguments, $defaultClass = false){

         if("" != (string)$config["class"]  || $defaultClass){

              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

-        }elseif($config["ref"]){

+        } elseif($config["ref"]){

             $service = $this->getService((string)$config['ref']);

-        }else{

+        } else{

             throw new \RuntimeException('Could not create Service. no class or reference given.');

         }

         if($config["ref_property"]){

             $service = $service->{(string)$config["ref_property"]}; 

-        }elseif($config["ref_method"]){

+        } elseif($config["ref_method"]){

                 $args = array();

             if($config->argument){

                         foreach($config->argument as $arg){

@@ -814,10 +814,10 @@ 
                 $constructor = (string)$config["constructor"];

         if($constructor != ''){

             $service = call_user_func_array(array($cls, $constructor), $arguments); 

-        }else{

+        } else{

             $service = self::build($cls, $arguments); 

         }        

-            }catch(\Exception $e){

+            } catch(\Exception $e){

                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());

             }           

         }

src/Dispatcher/ClassDispatcher.php

Doc Comments -1 removed lines

@@ -71,7 +71,6 @@
      * notifies all listeners on a event on a subject

      *

      * @access public

-     * @param string $name name of the event

      * @param mixed $subject the subject

      * @return

      */

Braces +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     protected function getMessage($object){

         if($this->channel instanceof \PEIP\INF\Channel\SubscribableChannel){

             return $object; 

-        }else{

+        } else{

             return $object->getContent()->receive();

         }

     }

src/Dispatcher/Dispatcher.php

Doc Comments -1 removed lines

@@ -65,7 +65,6 @@
      * Disconnects all listeners.

      * 

      * @access public

-     * @param Callable|PEIP\INF\Handler\Handler $listener

      * @return void

      */

     public function disconnectAll(){

src/Dispatcher/EventClassDispatcher.php

Doc Comments +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
      * @access public

      * @param string $name name of the event

      * @param \PEIP\INF\Event\Event $object an event object

-     * @return boolean

+     * @return boolean|null

      */

     public function notify($name, $object){ 

         if($object instanceof \PEIP\INF\Event\Event){

@@ -53,7 +53,7 @@ 
      * @param array $headers headers of the event-object as key/value pairs

      * @param string $eventClass event-class to create instances from

      * @return

-     * @see EventBuilder

+     boolean|null @see EventBuilder

      */

     public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){

         if(!$this->hasListeners($name, ($object))){

Braces +2 added lines, -2 removed lines

@@ -70,10 +70,10 @@
                      ),

                      $object

                  );

-            }else{

+            } else{

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }

-        }else{

+        } else{

             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');

         }

     }       //put your code here