tidal / PEIP

src/Dispatcher/ObjectEventDispatcher.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
      * @access public

      * @param string $name name of the event 

      * @param \PEIP\INF\Event\Event $object an event object

-     * @return boolean

+     * @return boolean|null

      */

     public function notify($name, $object){

         if($object instanceof \PEIP\INF\Event\Event){

Spacing +8 added lines, -8 removed lines

@@ -40,16 +40,16 @@ 
      * @param \PEIP\INF\Event\Event $object an event object

      * @return boolean

      */

-    public function notify($name, $object){

-        if($object instanceof \PEIP\INF\Event\Event){

-            if(is_object($object->getContent())){

-                if($this->hasListeners($name, $object->getContent())){

+    public function notify($name, $object) {

+        if ($object instanceof \PEIP\INF\Event\Event) {

+            if (is_object($object->getContent())) {

+                if ($this->hasListeners($name, $object->getContent())) {

                     return self::doNotify($this->getListeners($name, $object->getContent()), $object);  

                 }                   

-            }else{

+            }else {

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }   

-        }else{

+        }else {

             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');

         }  

     }   

@@ -66,8 +66,8 @@ 
      * @return

      * @see EventBuilder 

      */

-    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){

-        if(!$this->hasListeners($name, $object)){

+    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false) {

+        if (!$this->hasListeners($name, $object)) {

             return false;

         }

         $event = EventBuilder::getInstance($eventClass)->build(

Braces +2 added lines, -2 removed lines

@@ -70,10 +70,10 @@
                      ),

                      $object

                  );

-            }else{

+            } else{

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }

-        }else{

+        } else{

             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');

         }

     }       //put your code here

src/Dispatcher/ObjectMapDispatcher.php

Doc Comments +2 added lines, -2 removed lines

@@ -162,7 +162,7 @@ 
      * @access public

      * @param $name 

      * @param $subject 

-     * @return mixed

+     * @return \PEIP\INF\Handler\Handler

      */

     public function notifyUntil($name, $subject){

         if($this->hasListeners($name, $subject)){       

@@ -205,7 +205,7 @@ 
      * @access protected

      * @param $name 

      * @param $object 

-     * @return boolean

+     * @return boolean|null

      */    

     protected static function doNotify(array $listeners, $subject){

         foreach($listeners as $listener){ 

Indentation +4 added lines, -4 removed lines

@@ -209,11 +209,11 @@
      */    

     protected static function doNotify(array $listeners, $subject){

         foreach($listeners as $listener){ 

-             if($listener instanceof \PEIP\INF\Handler\Handler){

+                if($listener instanceof \PEIP\INF\Handler\Handler){

                 $listener->handle($subject);

-             }elseif(is_callable($listener)){

-                 call_user_func($listener, $subject);

-             }

+                }elseif(is_callable($listener)){

+                    call_user_func($listener, $subject);

+                }

         }   

     }  

 

Spacing +33 added lines, -33 removed lines

@@ -43,13 +43,13 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener event-handler

      * @return boolean

      */

-    public function connect($name, $object, $listener){

+    public function connect($name, $object, $listener) {

         Test::ensureHandler($listener);

         $listners = $this->doGetListeners();

-        if (!$this->listeners->contains($object)){

+        if (!$this->listeners->contains($object)) {

             $this->listeners->attach($object, new \ArrayObject);

         }

-        if (!array_key_exists($name, $listners[$object])){ 

+        if (!array_key_exists($name, $listners[$object])) { 

             $this->listeners[$object][$name] = array();

         }

         $hash = $this->getListenerHash($listener);

@@ -67,14 +67,14 @@ 
      * @param \PEIP\INF\Handler\Handler $listener event-handler

      * @return boolean

      */

-    public function disconnect($name, $object, $listener){

+    public function disconnect($name, $object, $listener) {

         $listners = $this->doGetListeners();

-        if (!$listners->contains($object) || !isset($listners[$object][$name])){

+        if (!$listners->contains($object) || !isset($listners[$object][$name])) {

             return false;

         }

         $eventListeners = $listners[$object][$name];

         $hash = $this->getListenerHash($listener);

-        if(isset($eventListeners[$hash])){

+        if (isset($eventListeners[$hash])) {

             unset($eventListeners[$hash]); 

 

             $listners[$object][$name] = $eventListeners;

@@ -83,10 +83,10 @@ 
         return false;

     }

 

-    public function disconnectAll($name, $object){

-        if(is_object($object)){

+    public function disconnectAll($name, $object) {

+        if (is_object($object)) {

             $listners = $this->doGetListeners();

-            if($listners && $this->hadListeners($name, $object)){

+            if ($listners && $this->hadListeners($name, $object)) {

                     $listners[$object][$name] = array();

             }        

         }

@@ -100,13 +100,13 @@ 
      * @param object $object object to check for listeners

      * @return boolean

      */

-    public function hasListeners($name, $object){

+    public function hasListeners($name, $object) {

         $listners = $this->doGetListeners();

-        if (!$this->hadListeners($name, $object)){

+        if (!$this->hadListeners($name, $object)) {

             $res = false;

-        }else{

+        }else {

             $listners = $this->doGetListeners();

-            $res = (boolean) count($listners[$object][$name]);

+            $res = (boolean)count($listners[$object][$name]);

         }

         return $res;

     }

@@ -119,7 +119,7 @@ 
      * @param object $object object to check for listeners

      * @return boolean

      */

-    public function hadListeners($name, $object){

+    public function hadListeners($name, $object) {

         $listners = $this->doGetListeners();

         return ($listners->contains($object) && isset($listners[$object][$name])) ? true : false;

     }

@@ -131,9 +131,9 @@ 
      * @param object $object object to get event-names for

      * @return string[] array of event-names

      */

-    public function getEventNames($object){

+    public function getEventNames($object) {

         $listeners = $this->doGetListeners();

-        if (!$listeners->contains($object)){

+        if (!$listeners->contains($object)) {

             return array();

         }

         return array_keys($listeners[$object]->getArrayCopy());

@@ -147,8 +147,8 @@ 
      * @param $object 

      * @return boolean

      */

-    public function notify($name, $object){

-        if($this->hasListeners($name, $object)){

+    public function notify($name, $object) {

+        if ($this->hasListeners($name, $object)) {

             $listners = $this->doGetListeners();

             self::doNotify($listners[$object][$name], $object);

         }

@@ -164,8 +164,8 @@ 
      * @param $subject 

      * @return mixed

      */

-    public function notifyUntil($name, $subject){

-        if($this->hasListeners($name, $subject)){       

+    public function notifyUntil($name, $subject) {

+        if ($this->hasListeners($name, $subject)) {       

             $res = self::doNotifyUntil($this->getListeners($name, $subject), $subject);   

         }

         return $res;

@@ -179,8 +179,8 @@ 
      * @param object $object object to check for listeners

      * @return array array of listeners

      */

-    public function getListeners($name, $object){

-        if (!$this->hadListeners($name, $object)){

+    public function getListeners($name, $object) {

+        if (!$this->hadListeners($name, $object)) {

             return array();

         }

         $listeners = $this->listeners[$object]->getArrayCopy();

@@ -194,7 +194,7 @@ 
      * @access protected

      * @return ObjectStorage

      */

-    protected function doGetListeners(){

+    protected function doGetListeners() {

         return isset($this->listeners) ? $this->listeners : $this->listeners = new ObjectStorage();

     }

    

@@ -207,11 +207,11 @@ 
      * @param $object 

      * @return boolean

      */    

-    protected static function doNotify(array $listeners, $subject){

-        foreach($listeners as $listener){ 

-             if($listener instanceof \PEIP\INF\Handler\Handler){

+    protected static function doNotify(array $listeners, $subject) {

+        foreach ($listeners as $listener) { 

+             if ($listener instanceof \PEIP\INF\Handler\Handler) {

                 $listener->handle($subject);

-             }elseif(is_callable($listener)){

+             }elseif (is_callable($listener)) {

                  call_user_func($listener, $subject);

              }

         }   

@@ -226,12 +226,12 @@ 
      * @param $object 

      * @return \PEIP\INF\Handler\Handler the listener which returned a boolean true value

      */     

-    protected static function doNotifyUntil(array $listeners, $subject){  

+    protected static function doNotifyUntil(array $listeners, $subject) {  

         $res = NULL; 

-        foreach ($listeners as $listener){ 

-            if($listener instanceof \PEIP\INF\Handler\Handler){

+        foreach ($listeners as $listener) { 

+            if ($listener instanceof \PEIP\INF\Handler\Handler) {

                 $res = $listener->handle($subject);

-                if ($res){ 

+                if ($res) { 

                     return $listener;

                 }

             }

@@ -239,8 +239,8 @@ 
         return $res;

     }

 

-    protected function getListenerHash($listener){

-        if(!is_object($listener)){

+    protected function getListenerHash($listener) {

+        if (!is_object($listener)) {

             $o = new \stdClass();

             $o->listener = $listener;

             $listener = $o;

Braces +2 added lines, -2 removed lines

@@ -104,7 +104,7 @@ 
         $listners = $this->doGetListeners();

         if (!$this->hadListeners($name, $object)){

             $res = false;

-        }else{

+        } else{

             $listners = $this->doGetListeners();

             $res = (boolean) count($listners[$object][$name]);

         }

@@ -211,7 +211,7 @@ 
         foreach($listeners as $listener){ 

              if($listener instanceof \PEIP\INF\Handler\Handler){

                 $listener->handle($subject);

-             }elseif(is_callable($listener)){

+             } elseif(is_callable($listener)){

                  call_user_func($listener, $subject);

              }

         }   

Unused Use Statements +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  * @implements \PEIP\INF\Base\Container, \PEIP\INF\Message\Message, \PEIP\INF\Base\Buildable

  */

 

-use PEIP\Util\Test;

+use PEIP\Util\Test;
 use PEIP\Base\GenericBuilder;

 

 class GenericMessage 

src/Event/Event.php

Doc Comments -1 removed lines

@@ -49,7 +49,6 @@
      * @access public

      * @param mixed $subject the subject for the event

      * @param string $name the name of the event

-     * @param array|ArrayAccess $headers the headers for the event 

      */

     public function __construct($subject, $name, $parameters = array(), $type = false){

         parent::__construct($subject, Test::ensureArrayAccess($parameters));

Spacing +9 added lines, -9 removed lines

@@ -51,7 +51,7 @@ 
      * @param string $name the name of the event

      * @param array|ArrayAccess $headers the headers for the event 

      */

-    public function __construct($subject, $name, $parameters = array(), $type = false){

+    public function __construct($subject, $name, $parameters = array(), $type = false) {

         parent::__construct($subject, Test::ensureArrayAccess($parameters));

         $this->name = $name;

         $this->type = $type ? $type : get_class($this);

@@ -63,7 +63,7 @@ 
      * @access public

      * @return string the name of the event

      */

-    public function getName(){

+    public function getName() {

         return $this->name;

     }

 

@@ -74,7 +74,7 @@ 
      * @access public

      * @return string the type of the event

      */

-    public function getType(){

+    public function getType() {

         return $this->name;

     }

   

@@ -84,7 +84,7 @@ 
      * @access public

      * @param mixed $value the return-value to set 

      */

-    public function setReturnValue($value){

+    public function setReturnValue($value) {

         $this->value = $value;

     }

   

@@ -94,7 +94,7 @@ 
      * @access public

      * @return mixed the return-value to set

      */

-    public function getReturnValue(){

+    public function getReturnValue() {

         return $this->value;

     }

   

@@ -104,8 +104,8 @@ 
      * @access public

      * @param boolean $processed 

      */

-    public function setProcessed($processed){

-        $this->processed = (boolean) $processed;

+    public function setProcessed($processed) {

+        $this->processed = (boolean)$processed;

     }

 

     /**

@@ -114,7 +114,7 @@ 
      * @access public

      * @return boolean wether the event is processed 

      */

-    public function isProcessed(){

+    public function isProcessed() {

         return $this->processed;

     }

 

@@ -124,7 +124,7 @@ 
      * @access public

      * @return mixed the subject/content

      */

-    public function getSubject(){

+    public function getSubject() {

         return $this->getContent();

     }

 }

src/Event/EventBuilder.php

Doc Comments -1 removed lines

@@ -83,7 +83,6 @@
      * @param ObjectEventDispatcher $dispatcher the dispatcher to dispatch the event 
      * @param mixed $subject the subject for the event
      * @param string $name the name of the event
-     * @param array $parameters the headers for the event
      * @return 
      */
     public function buildAndDispatch(ObjectEventDispatcher $dispatcher, $subject, $name, array $headers = array()){

Spacing +4 added lines, -4 removed lines

@@ -37,7 +37,7 @@ 
      * @param string $eventClass the event-class the builder shall create instances for 
      * @param array $defaultHeaders default headers for the created events 
      */
-    public function __construct($eventClass = '\PEIP\Event\Event', array $defaultHeaders = array()){
+    public function __construct($eventClass = '\PEIP\Event\Event', array $defaultHeaders = array()) {
         $this->eventClass = $eventClass;
         $this->defaultParameters = $defaultHeaders;
     }
@@ -49,7 +49,7 @@ 
      * @param string $eventClass the event-class the builder shall create instances for 
      * @return EventBuilder the instance of EventBuilder for the given event-class 
      */    
-    public static function getInstance($eventClass = '\PEIP\Event\Event'){ 
+    public static function getInstance($eventClass = '\PEIP\Event\Event') { 
 
         return isset(self::$instances[$eventClass]) 
             ? self::$instances[$eventClass] 
@@ -67,7 +67,7 @@ 
      * @param array $headers the headers for the event 
      * @return object event instance
      */
-    public function build($subject, $name, array $headers = array()){
+    public function build($subject, $name, array $headers = array()) {
 
         return new $this->eventClass(
             $subject,
@@ -86,7 +86,7 @@ 
      * @param array $parameters the headers for the event
      * @return 
      */
-    public function buildAndDispatch(ObjectEventDispatcher $dispatcher, $subject, $name, array $headers = array()){
+    public function buildAndDispatch(ObjectEventDispatcher $dispatcher, $subject, $name, array $headers = array()) {
   
         return $dispatcher->notify(
             $name,

src/Factory/DedicatedFactory.php

Doc Comments +3 added lines

@@ -47,6 +47,9 @@
         return new DedicatedFactory(array($class, '__construct'), $parameters); 

     } 

 

+    /**
+     * @param string[] $callable
+     */
     public static function getfromCallable($callable, array $parameters = array()){

         return new DedicatedFactory($callable, $parameters); 

     } 

Spacing +5 added lines, -5 removed lines

@@ -38,16 +38,16 @@ 
      * @param $parameters 

      * @return 

      */

-    protected function __construct($callable ,array $parameters = array()){

+    protected function __construct($callable, array $parameters = array()) {

         $this->callable = $callable;

         $this->setParameters($parameters);

     }

 

-    public static function getfromClass($class, array $parameters = array()){

+    public static function getfromClass($class, array $parameters = array()) {

         return new DedicatedFactory(array($class, '__construct'), $parameters); 

     } 

 

-    public static function getfromCallable($callable, array $parameters = array()){

+    public static function getfromCallable($callable, array $parameters = array()) {

         return new DedicatedFactory($callable, $parameters); 

     } 

     

@@ -57,7 +57,7 @@ 
      * @param $arguments 

      * @return 

      */

-    public function build(array $arguments = array()){

+    public function build(array $arguments = array()) {

         $arguments = count($arguments) > 0 ? $arguments : $this->getParameters();

         return (is_array($this->callable) && $this->callable[1] == '__construct') 

             ? GenericBuilder::GetInstance($this->callable[0])->build($arguments) 

@@ -70,7 +70,7 @@ 
      * @param $method 

      * @return 

      */

-    public function setConstructor($method){

+    public function setConstructor($method) {

         $this->constructor = (string)$method;

         return $this;

     }   

src/Factory/ServiceFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
      * @see GenericBuilder

      * @static

      * @access protected

-     * @param object $className name of class to build instance for.

+     * @param string $className name of class to build instance for.

      * @param array $arguments arguments for the constructor

      * @return object build and modified srvice instance

      */

Unused Use Statements +2 added lines, -2 removed lines

@@ -11,8 +11,8 @@
  *

  * @author timo

  */

-use PEIP\Util\Test;

-use PEIP\Base\GenericBuilder;

+use PEIP\Util\Test;
+use PEIP\Base\GenericBuilder;
 use PEIP\Context\XMLContext;

 

 class ServiceFactory {

Indentation +23 added lines, -23 removed lines

@@ -16,13 +16,13 @@ 
 use PEIP\Context\XMLContext;

 

 class ServiceFactory {

-     /**

-     * Creates and initializes service instance from a given configuration.

-     *

-     * @access public

-     * @param $config

-     * @return object the initialized service instance

-     */

+        /**

+         * Creates and initializes service instance from a given configuration.

+         *

+         * @access public

+         * @param $config

+         * @return object the initialized service instance

+         */

     public static function createService($config){

         $args = array();

         //build arguments for constructor

@@ -35,15 +35,15 @@ 
     }

 

         /**

-     * Builds an arbitrary service/object instance from a config-obect.

-     *

-     * @static

-     * @access protected

-     * @param object $config configuration object to build a service instance from.

-     * @param array $arguments arguments for the service constructor

-     * @param string $defaultClass class to create instance for if none is set in config

-     * @return object build and modified srvice instance

-     */

+         * Builds an arbitrary service/object instance from a config-obect.

+         *

+         * @static

+         * @access protected

+         * @param object $config configuration object to build a service instance from.

+         * @param array $arguments arguments for the service constructor

+         * @param string $defaultClass class to create instance for if none is set in config

+         * @return object build and modified srvice instance

+         */

     public static function doBuild($config, $arguments, $defaultClass = false){

         $cls = $config["class"] ? trim((string)$config["class"]) : (string)$defaultClass;

         if($cls != ''){

@@ -80,12 +80,12 @@ 
     }

 

         /**

-     * Builds single argument (to call a method with later) from a config-obect.

-     *

-     * @access protected

-     * @param object $config configuration object to create argument from.

-     * @return mixed build argument

-     */

+         * Builds single argument (to call a method with later) from a config-obect.

+         *

+         * @access protected

+         * @param object $config configuration object to create argument from.

+         * @return mixed build argument

+         */

     protected static function buildArg($config){

         if(trim((string)$config['value']) != ''){

             $arg = (string)$config['value'];

@@ -128,7 +128,7 @@ 
      */

     public static function buildAndModify($config, $arguments, $defaultClass = false){

         if("" != (string)$config["class"]  || $defaultClass){

-             $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

+                $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

         }else{

             throw new \RuntimeException('Could not create Service. no class or reference given.');

         }

Spacing +43 added lines, -43 removed lines

@@ -23,11 +23,11 @@ 
      * @param $config

      * @return object the initialized service instance

      */

-    public static function createService($config){

+    public static function createService($config) {

         $args = array();

         //build arguments for constructor

-        if($config->constructor_arg){

-            foreach($config->constructor_arg as $arg){

+        if ($config->constructor_arg) {

+            foreach ($config->constructor_arg as $arg) {

                 $args[] = self::buildArg($arg);

             }

         }

@@ -44,21 +44,21 @@ 
      * @param string $defaultClass class to create instance for if none is set in config

      * @return object build and modified srvice instance

      */

-    public static function doBuild($config, $arguments, $defaultClass = false){

+    public static function doBuild($config, $arguments, $defaultClass = false) {

         $cls = $config["class"] ? trim((string)$config["class"]) : (string)$defaultClass;

-        if($cls != ''){

+        if ($cls != '') {

             try {

                 $constructor = (string)$config["constructor"];

-        if($constructor != '' && Test::assertMethod($cls, $constructor)){

+        if ($constructor != '' && Test::assertMethod($cls, $constructor)) {

             $service = call_user_func_array(array($cls, $constructor), $arguments);

-        }else{

+        }else {

             $service = self::build($cls, $arguments);

         }

-            }catch(\Exception $e){

+            } catch (\Exception $e) {

                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());

             }

         }

-        if(is_object($service)){

+        if (is_object($service)) {

             return $service;

         }

         throw new \RuntimeException('Could not create Service "'.$cls.'". Class does not exist.');

@@ -75,7 +75,7 @@ 
      * @param array $arguments arguments for the constructor

      * @return object build and modified srvice instance

      */

-    public static function build($className, $arguments){

+    public static function build($className, $arguments) {

         return GenericBuilder::getInstance($className)->build($arguments);

     }

 

@@ -86,29 +86,29 @@ 
      * @param object $config configuration object to create argument from.

      * @return mixed build argument

      */

-    protected static function buildArg($config){

-        if(trim((string)$config['value']) != ''){

+    protected static function buildArg($config) {

+        if (trim((string)$config['value']) != '') {

             $arg = (string)$config['value'];

-        }elseif($config->getName() == 'value'){

+        }elseif ($config->getName() == 'value') {

             $arg = (string)$config;

-        }elseif($config->getName() == 'list'){

+        }elseif ($config->getName() == 'list') {

             $arg = array();

-            foreach($config->children() as $entry){

-                if($entry->getName() == 'value'){

-                    if($entry['key']){

+            foreach ($config->children() as $entry) {

+                if ($entry->getName() == 'value') {

+                    if ($entry['key']) {

                         $arg[(string)$entry['key']] = (string)$entry;

-                    }else{

+                    }else {

                         $arg[] = (string)$entry;

                     }

-                }elseif($entry->getName() == 'service'){

+                }elseif ($entry->getName() == 'service') {

                     $arg[] = $this->provideService($entry);

                 }

             }

-        }elseif($config->getName() == 'service'){

+        }elseif ($config->getName() == 'service') {

             $arg = self::provideService($config);

-        }elseif($config->list){

+        }elseif ($config->list) {

             $arg = self::buildArg($config->list);

-        }elseif($config->service){

+        }elseif ($config->service) {

             $arg = self::buildArg($config->service);

         }

         return $arg;

@@ -126,24 +126,24 @@ 
      * @param string $defaultClass class to create instance for if none is set in config

      * @return object build and modified srvice instance

      */

-    public static function buildAndModify($config, $arguments, $defaultClass = false){

-        if("" != (string)$config["class"]  || $defaultClass){

+    public static function buildAndModify($config, $arguments, $defaultClass = false) {

+        if ("" != (string)$config["class"] || $defaultClass) {

              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

-        }else{

+        }else {

             throw new \RuntimeException('Could not create Service. no class or reference given.');

         }

-        if($config["ref_property"]){

+        if ($config["ref_property"]) {

             $service = $service->{(string)$config["ref_property"]};

-        }elseif($config["ref_method"]){

+        }elseif ($config["ref_method"]) {

                 $args = array();

-            if($config->argument){

-                        foreach($config->argument as $arg){

+            if ($config->argument) {

+                        foreach ($config->argument as $arg) {

                             $args[] = $this->buildArg($arg);

                         }

                 }

             $service = call_user_func_array(array($service, (string)$config["ref_method"]), $args);

         }

-        if(!is_object($service)){

+        if (!is_object($service)) {

             throw new \RuntimeException('Could not create Service.');

         }

         $service = self::modifyService($service, $config);

@@ -166,29 +166,29 @@ 
      * @param object $config configuration to get the modification instructions from.

      * @return object the modificated service

      */

-    protected function modifyService($service, $config){

+    protected function modifyService($service, $config) {

         $reflection = GenericBuilder::getInstance(get_class($service))->getReflectionClass();

         // set instance properties

-        if($config->property){

-            foreach($config->property as $property){

+        if ($config->property) {

+            foreach ($config->property as $property) {

                 $arg = self::buildArg($property);

-                if($arg){

+                if ($arg) {

                     $setter = self::getSetter($property);

-                    if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){

+                    if ($setter && self::hasPublicProperty($service, 'Method', $setter)) {

                         $service->{$setter}($arg);

-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

+                    }elseif (in_array($property, self::hasPublicProperty($service, 'Property', $setter))) {

                         $service->$setter = $arg;

                     }

                 }

             }

         }

         // call instance methods

-        if($config->action){

-            foreach($config->action as $action){

+        if ($config->action) {

+            foreach ($config->action as $action) {

                 $method = (string)$action['method'] != '' ? (string)$action['method'] : NULL;

-                if($method && self::hasPublicProperty($service, 'Method', $method)){

+                if ($method && self::hasPublicProperty($service, 'Method', $method)) {

                     $args = array();

-                    foreach($action->children() as $argument){

+                    foreach ($action->children() as $argument) {

                         $args[] = $this->buildArg($argument);

                     }

                     call_user_func_array(array($service, (string)$action['method']), $args);

@@ -196,9 +196,9 @@ 
             }

         }

         // register instance listeners

-        if($service instanceof \PEIP\INF\Event\Connectable){

-            if($config->listener){

-                foreach($config->listener as $listenerConf){

+        if ($service instanceof \PEIP\INF\Event\Connectable) {

+            if ($config->listener) {

+                foreach ($config->listener as $listenerConf) {

                     $event = (string)$listenerConf['event'];

                     $listener = $this->provideService($listenerConf);

                     $service->connect($event, $listener);

Braces +12 added lines, -12 removed lines

@@ -51,10 +51,10 @@ 
                 $constructor = (string)$config["constructor"];

         if($constructor != '' && Test::assertMethod($cls, $constructor)){

             $service = call_user_func_array(array($cls, $constructor), $arguments);

-        }else{

+        } else{

             $service = self::build($cls, $arguments);

         }

-            }catch(\Exception $e){

+            } catch(\Exception $e){

                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());

             }

         }

@@ -89,26 +89,26 @@ 
     protected static function buildArg($config){

         if(trim((string)$config['value']) != ''){

             $arg = (string)$config['value'];

-        }elseif($config->getName() == 'value'){

+        } elseif($config->getName() == 'value'){

             $arg = (string)$config;

-        }elseif($config->getName() == 'list'){

+        } elseif($config->getName() == 'list'){

             $arg = array();

             foreach($config->children() as $entry){

                 if($entry->getName() == 'value'){

                     if($entry['key']){

                         $arg[(string)$entry['key']] = (string)$entry;

-                    }else{

+                    } else{

                         $arg[] = (string)$entry;

                     }

-                }elseif($entry->getName() == 'service'){

+                } elseif($entry->getName() == 'service'){

                     $arg[] = $this->provideService($entry);

                 }

             }

-        }elseif($config->getName() == 'service'){

+        } elseif($config->getName() == 'service'){

             $arg = self::provideService($config);

-        }elseif($config->list){

+        } elseif($config->list){

             $arg = self::buildArg($config->list);

-        }elseif($config->service){

+        } elseif($config->service){

             $arg = self::buildArg($config->service);

         }

         return $arg;

@@ -129,12 +129,12 @@ 
     public static function buildAndModify($config, $arguments, $defaultClass = false){

         if("" != (string)$config["class"]  || $defaultClass){

              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

-        }else{

+        } else{

             throw new \RuntimeException('Could not create Service. no class or reference given.');

         }

         if($config["ref_property"]){

             $service = $service->{(string)$config["ref_property"]};

-        }elseif($config["ref_method"]){

+        } elseif($config["ref_method"]){

                 $args = array();

             if($config->argument){

                         foreach($config->argument as $arg){

@@ -176,7 +176,7 @@ 
                     $setter = self::getSetter($property);

                     if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){

                         $service->{$setter}($arg);

-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

+                    } elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

                         $service->$setter = $arg;

                     }

                 }

src/Gateway/SimpleMessagingGateway.php

Doc Comments -1 removed lines

@@ -56,7 +56,6 @@
      * sets the channel to send requests from the gateway

      * 

      * @access public

-     * @param \PEIP\INF\Channel\Channel $replyChannel The default channel to receive requests from the gateway

      * @return 

      */

     public function setRequestChannel(\PEIP\INF\Channel\Channel $requestChannel){

Unused Use Statements +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  * @implements \PEIP\INF\Gateway\MessagingGateway, \PEIP\INF\Message\MessageBuilder

  */

 

-use PEIP\Message\GenericMessage;

+use PEIP\Message\GenericMessage;
 use PEIP\Message\MessageBuilder;

 

 class SimpleMessagingGateway 

Spacing +15 added lines, -15 removed lines

@@ -43,9 +43,9 @@ 
      * @param \PEIP\INF\Channel\PollableChannel $replyChannel The default channel to receive requests from the gateway

      * @param array $defaultHeaders The default headers to apply to request messages 

      */

-    public function __construct(\PEIP\INF\Channel\Channel $requestChannel, \PEIP\INF\Channel\Channel $replyChannel = NULL, array $defaultHeaders = array()){

+    public function __construct(\PEIP\INF\Channel\Channel $requestChannel, \PEIP\INF\Channel\Channel $replyChannel = NULL, array $defaultHeaders = array()) {

         $this->setRequestChannel($requestChannel);

-        if($replyChannel){

+        if ($replyChannel) {

             $this->setReplyChannel($replyChannel);

         }     

         $this->defaultHeaders = $defaultHeaders;

@@ -59,7 +59,7 @@ 
      * @param \PEIP\INF\Channel\Channel $replyChannel The default channel to receive requests from the gateway

      * @return 

      */

-    public function setRequestChannel(\PEIP\INF\Channel\Channel $requestChannel){

+    public function setRequestChannel(\PEIP\INF\Channel\Channel $requestChannel) {

         $this->requestChannel = $requestChannel;

     }

   

@@ -70,8 +70,8 @@ 
      * @param \PEIP\INF\Channel\PollableChannel $replyChannel The default channel to receive requests from the gateway

      * @return 

      */

-    public function setReplyChannel(\PEIP\INF\Channel\Channel $replyChannel){

-        if(!($replyChannel instanceof \PEIP\INF\Channel\PollableChannel)){

+    public function setReplyChannel(\PEIP\INF\Channel\Channel $replyChannel) {

+        if (!($replyChannel instanceof \PEIP\INF\Channel\PollableChannel)) {

             throw new \InvalidArgumentException('reply channel must be instance of \PEIP\INF\Channel\PollableChannel.');

         }       

         $this->replyChannel = $replyChannel;

@@ -84,7 +84,7 @@ 
      * @param mixed $content the content/payload for the message to send 

      * @return 

      */

-    public function send($content){

+    public function send($content) {

         return $this->requestChannel->send($this->buildMessage($content));

     }

    

@@ -94,12 +94,12 @@ 
      * @access public

      * @return mixed content/payload of the received message

      */

-    public function receive(){

-        if(!isset($this->replyChannel)){

+    public function receive() {

+        if (!isset($this->replyChannel)) {

             throw new \LogicException('No replyChannel set.');

         }       

         $message = $this->replyChannel->receive();

-        if($message){

+        if ($message) {

             return $message->getContent();

         }

         return NULL;

@@ -112,12 +112,12 @@ 
      * @param mixed $content the content/payload for the message to send 

      * @return mixed content/payload of the received message

      */

-    public function sendAndReceive($content){

+    public function sendAndReceive($content) {

         $this->send($content);

         try {

             $res = $this->receive();

         }

-        catch(\Exception $e){

+        catch (\Exception $e) {

             return NULL;

         }

         return $res;

@@ -130,7 +130,7 @@ 
      * @param mixed $content the content/payload for the message to send 

      * @return \PEIP\INF\Message\Message the built message

      */

-    protected function buildMessage($content){

+    protected function buildMessage($content) {

         return $this->getMessageBuilder()->setContent($content)->build();   

     }   

       

@@ -140,7 +140,7 @@ 
      * @access protected

      * @return MessageBuilder message builder instance for the registerd message class

      */

-    protected function getMessageBuilder(){

+    protected function getMessageBuilder() {

         return isset($this->messageBuilder) && ($this->messageBuilder->getMessageClass() == $this->getMessageClass())

             ? $this->messageBuilder

             : $this->messageBuilder = MessageBuilder::getInstance($this->messageClass)->setHeaders($this->defaultHeaders);

@@ -153,7 +153,7 @@ 
      * @param   string $messageClass message class to create instances from

      * @return 

      */

-    public function setMessageClass($messageClass){

+    public function setMessageClass($messageClass) {

         $this->messageClass = $messageClass;

     }

     

@@ -163,7 +163,7 @@ 
      * @access public

      * @return string message class to create instances from

      */

-    public function getMessageClass(){

+    public function getMessageClass() {

         return $this->messageClass;

     }   

 

Braces +1 added lines, -2 removed lines

@@ -116,8 +116,7 @@
         $this->send($content);

         try {

             $res = $this->receive();

-        }

-        catch(\Exception $e){

+        } catch(\Exception $e){

             return NULL;

         }

         return $res;

src/INF/Channel/Channel.php

Doc Comments +3 added lines, -3 removed lines

@@ -33,10 +33,10 @@
      * Send a message, blocking until either the message is accepted or the

      * specified timeout period elapses.

      * 

-     * @param message the {@link Message} to send

-     * @param timeout the timeout in milliseconds

+     * @param message \PEIP\INF\Message\Message {@link Message} to send

+     * @param timeout integer timeout in milliseconds

      * 

-     * @return <code>true</code> if the message is sent successfully,

+     * @return void if the message is sent successfully,

      * <code>false</false> if the specified timeout period elapses or

      * the send is interrupted

      */

src/Message/GenericMessage.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
  * @implements \PEIP\INF\Base\Container, \PEIP\INF\Message\Message, \PEIP\INF\Base\Buildable

  */

 

-use PEIP\Util\Test;

+use PEIP\Util\Test;
 use PEIP\Base\GenericBuilder;

 

 class GenericMessage 

Indentation +5 added lines, -5 removed lines

@@ -76,11 +76,11 @@
     }

 

         /**

-     * returns all headers of the message

-     * 

-     * @access public

-     * @return ArrayAccess ArrayAccess object of headers

-     */

+         * returns all headers of the message

+         * 

+         * @access public

+         * @return ArrayAccess ArrayAccess object of headers

+         */

     public function getHeaders(){

         return (array) $this->headers;

     }

Spacing +15 added lines, -15 removed lines

@@ -41,7 +41,7 @@ 
      * @param mixed $content The content/payload of the message 

      * @param array|ArrayAccess $headers headers as key/value pairs

      */

-    public function __construct($content, $headers = array()){

+    public function __construct($content, $headers = array()) {

         $this->doSetContent($content);

         $this->doSetHeaders($headers);          

     }

@@ -53,7 +53,7 @@ 
      * @access public

      * @return

      */

-    public function getContent(){

+    public function getContent() {

         return $this->content;

     }

 

@@ -63,13 +63,13 @@ 
      * @access protected

      * @param mixed $content The content/payload of the message 

      */

-    protected function doSetContent($content){

+    protected function doSetContent($content) {

         $this->content = Test::castType($content, self::CONTENT_CAST_TYPE);

     }

 

-    protected function doSetHeaders($headers){

+    protected function doSetHeaders($headers) {

         $headers = Test::ensureArrayAccess($headers);

-        if(is_array($headers)){

+        if (is_array($headers)) {

             $headers = new \ArrayObject($headers);

         }

         $this->headers = $headers;

@@ -81,8 +81,8 @@ 
      * @access public

      * @return ArrayAccess ArrayAccess object of headers

      */

-    public function getHeaders(){

-        return (array) $this->headers;

+    public function getHeaders() {

+        return (array)$this->headers;

     }

   

     /**

@@ -92,7 +92,7 @@ 
      * @param string $name the name of the header  

      * @return mixed the value of the header

      */

-    public function getHeader($name){

+    public function getHeader($name) {

         $name = (string)$name;

         return isset($this->headers[$name]) ? $this->headers[$name] : NULL;

     }

@@ -105,8 +105,8 @@ 
      * @param string $name the name of the header

      * @return boolean wether the header has been successfully  set

      */

-    public function addHeader($name, $value){

-        if(!$this->hasHeader($name)){

+    public function addHeader($name, $value) {

+        if (!$this->hasHeader($name)) {

             $this->headers[$name] = $value;

             return true;

         }

@@ -120,7 +120,7 @@ 
      * @param string $name the name of the header

      * @return boolean wether the header is set

      */

-    public function hasHeader($name){

+    public function hasHeader($name) {

         return isset($this->headers[$name]);

     }

 

@@ -130,16 +130,16 @@ 
      * @access public

      * @return string  content/payload of the message

      */

-    public function __toString(){

+    public function __toString() {

         $res = false;

         try {

             $res = (string)$this->getContent();

         }

-        catch(\Exception $e){           

+        catch (\Exception $e) {           

             try {

                 $res = get_class($this->getContent());

             }

-            catch(\Exception $e){

+            catch (\Exception $e) {

 

             }

         }

@@ -159,7 +159,7 @@ 
      * @param array $arguments argumends for the constructor

      * @return GenericMessage new class instance

      */    

-    public static function build(array $arguments = array()){

+    public static function build(array $arguments = array()) {

         return GenericBuilder::getInstance(__CLASS__)->build($arguments);

     }     

 } 
\ No newline at end of file

Braces +2 added lines, -4 removed lines

@@ -134,12 +134,10 @@
         $res = false;

         try {

             $res = (string)$this->getContent();

-        }

-        catch(\Exception $e){           

+        } catch(\Exception $e){           

             try {

                 $res = get_class($this->getContent());

-            }

-            catch(\Exception $e){

+            } catch(\Exception $e){

 

             }

         }