Completed
Push — v1.ns ( 31020d...499c60 )
by Timo
04:35 queued 01:07
created
src/ABS/Dispatcher/MapDispatcher.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,6 @@
 block discarded – undo
80 80
      *
81 81
      * @access public
82 82
      * @param string $name name of the event
83
-     * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect
84 83
      * @return
85 84
      */
86 85
     public function disconnectAll($name){
Please login to merge, or discard this patch.
src/ABS/Handler/MessageHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
      * @see PEIP\ABS\Handler\MessageHandler::doSetInputChannel
55 55
      * @access public
56 56
      * @param \PEIP\INF\Channel\Channel $inputChannel the input-channel
57
-     * @return PEIP\ABS\Handler\MessageHandler $this;
57
+     * @return MessageHandler $this;
58 58
      */
59 59
     public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel){
60 60
         $this->doSetInputChannel($inputChannel);
Please login to merge, or discard this patch.
src/ABS/Handler/ReplyProducingMessageHandler.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      * Connects the handler to the output-channel. 
54 54
      * 
55 55
      * @access protected
56
-     * @param \PEIP\INF\Channel\Channel $inputChannel the output-channel to connect the handler to
56
+     * @param \PEIP\INF\Channel\Channel $outputChannel the output-channel to connect the handler to
57 57
      * @return 
58 58
      */
59 59
     protected function doSetOutputChannel(\PEIP\INF\Channel\Channel $outputChannel){
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
      * 
163 163
      * @access public
164 164
      * @param string $messageClass name of the message-class to create reply-messages from. 
165
-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this
165
+     * @return ReplyProducingMessageHandler $this
166 166
      */
167 167
     public function setMessageClass($messageClass){
168 168
         $this->messageClass = $messageClass;
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      * 
196 196
      * @access public
197 197
      * @param array $headerNames array of message-header names to look for a reply-channel
198
-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this
198
+     * @return ReplyProducingMessageHandler $this
199 199
      */
200 200
     public function setReplyChannelHeaders(array $headerNames){
201 201
         $this->replyChannelHeaders = $headerNames;
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
  * @implements \PEIP\INF\Gateway\MessagingGateway, \PEIP\INF\Message\MessageBuilder
21 21
  */
22 22
 
23
-use PEIP\Message\GenericMessage;
23
+use PEIP\Message\GenericMessage;
24 24
 use PEIP\Message\MessageBuilder;
25 25
 
26 26
 class SimpleMessagingGateway 
Please login to merge, or discard this patch.
src/Autoload/Autoload.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,8 @@
 block discarded – undo
66 66
      * Scans a directory recursively for php-files and adds them to autoload
67 67
      * 
68 68
      * @access public
69
-     * @param string directoy to scan
69
+     * @param string directoy to scan
70
+     * @param string $dir
70 71
      * @return void
71 72
      */ 
72 73
     public function scanDirectory($dir){
Please login to merge, or discard this patch.
src/Base/GenericBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
      * 
40 40
      * @access public
41 41
      * @param string $className class-name to create objects for
42
-     * @param ReflectionClass $reflectionClass reflection-class for class. default: NULL 
42
+     * @param \ReflectionClass $reflectionClass reflection-class for class. default: NULL 
43 43
      * @param boolean $storeRef wether to store a reference for new instance. default: true 
44 44
      * @return 
45 45
      */
Please login to merge, or discard this patch.
src/Context/XMLContext.php 2 patches
Doc Comments   +9 added lines, -5 removed lines patch added patch discarded remove patch
@@ -174,7 +174,6 @@  discard block
 block discarded – undo
174 174
      * </config>     
175 175
      * 
176 176
      * @access public
177
-     * @param XMLContext $config the config to include
178 177
      */    
179 178
     public function includeContext(XMLContext $context){
180 179
         $this->services = array_merge($this->services, $context->getServices());
@@ -185,7 +184,7 @@  discard block
 block discarded – undo
185 184
      * 
186 185
      * @see XMLContext::includeContext
187 186
      * @access public
188
-     * @param XMLContext $context the config to include
187
+     * @param string $filePath
189 188
      */    
190 189
     public function includeContextFromFile($filePath){
191 190
         if(file_exists($filePath)){
@@ -693,7 +692,7 @@  discard block
 block discarded – undo
693 692
      * 
694 693
      * @access protected
695 694
      * @param object $config configuration object to create arguments from.  
696
-     * @return mixed build arguments 
695
+     * @return \PEIP\INF\Channel\Channel[] build arguments 
697 696
      */
698 697
     protected function getReplyHandlerArguments($config){
699 698
         $args = array(
@@ -738,7 +737,8 @@  discard block
 block discarded – undo
738 737
      * 
739 738
      * @access protected
740 739
      * @param string the configuration type ofthe channel (e.g.: 'reply', 'request')
741
-     * @param object $config configuration object to return channel from. 
740
+     * @param object $config configuration object to return channel from.
741
+     * @param string $type 
742 742
      * @return \PEIP\INF\Channel\Channel reply-channel
743 743
      */
744 744
     public function doGetChannel($type, $config){
@@ -833,7 +833,7 @@  discard block
 block discarded – undo
833 833
      * @see GenericBuilder
834 834
      * @static
835 835
      * @access protected
836
-     * @param object $className name of class to build instance for. 
836
+     * @param string $className name of class to build instance for. 
837 837
      * @param array $arguments arguments for the constructor 
838 838
      * @return object build and modified srvice instance
839 839
      */     
@@ -841,6 +841,10 @@  discard block
 block discarded – undo
841 841
         return GenericBuilder::getInstance($className)->build($arguments);
842 842
     }
843 843
 
844
+    /**
845
+     * @param string $type
846
+     * @param string $name
847
+     */
844 848
     protected static function hasPublicProperty($service, $type, $name){
845 849
         $reflection = GenericBuilder::getInstance(get_class($service))->getReflectionClass();
846 850
         if($reflection->{'has'.$type}($name) && $reflection->{'get'.$type}($name)->isPublic()){
Please login to merge, or discard this patch.
Unused Use Statements   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -22,17 +22,17 @@
 block discarded – undo
22 22
  */
23 23
 
24 24
 
25
-use PEIP\Handler\CallableHandler;
26
-use PEIP\Service\HeaderServiceActivator;
27
-use PEIP\Channel\ChannelRegistry;
28
-use PEIP\Service\ServiceProvider;
29
-use PEIP\Plugins\BasePlugin;
30
-use PEIP\Factory\ServiceFactory;
31
-use PEIP\Base\GenericBuilder;
32
-use PEIP\Channel\PollableChannel;
33
-use PEIP\Channel\PublishSubscribeChannel;
34
-use PEIP\Gateway\SimpleMessagingGateway;
35
-use PEIP\Listener\Wiretap;
25
+use PEIP\Handler\CallableHandler;
26
+use PEIP\Service\HeaderServiceActivator;
27
+use PEIP\Channel\ChannelRegistry;
28
+use PEIP\Service\ServiceProvider;
29
+use PEIP\Plugins\BasePlugin;
30
+use PEIP\Factory\ServiceFactory;
31
+use PEIP\Base\GenericBuilder;
32
+use PEIP\Channel\PollableChannel;
33
+use PEIP\Channel\PublishSubscribeChannel;
34
+use PEIP\Gateway\SimpleMessagingGateway;
35
+use PEIP\Listener\Wiretap;
36 36
 use PEIP\Service\ServiceActivator;
37 37
 
38 38
 class XMLContext 
Please login to merge, or discard this patch.
src/Dispatcher/ClassDispatcher.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,6 @@
 block discarded – undo
71 71
      * notifies all listeners on a event on a subject
72 72
      *
73 73
      * @access public
74
-     * @param string $name name of the event
75 74
      * @param mixed $subject the subject
76 75
      * @return
77 76
      */
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
  * @implements \PEIP\INF\Base\Container, \PEIP\INF\Message\Message, \PEIP\INF\Base\Buildable
21 21
  */
22 22
 
23
-use PEIP\Util\Test;
23
+use PEIP\Util\Test;
24 24
 use PEIP\Base\GenericBuilder;
25 25
 
26 26
 class GenericMessage 
Please login to merge, or discard this patch.
src/Dispatcher/ClassEventDispatcher.php 2 patches
Unused Use Statements   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,8 +11,7 @@
 block discarded – undo
11 11
  *
12 12
  * @author timo
13 13
  */
14
-use PEIP\Util\Reflection;
15
-use PEIP\Util\ReflectionPool;
14
+use PEIP\Util\Reflection;
16 15
 use PEIP\Event\EventBuilder;
17 16
 
18 17
 class ClassEventDispatcher extends \PEIP\Dispatcher\ObjectEventDispatcher {
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
      * @access public
24 24
      * @param string $name name of the event
25 25
      * @param \PEIP\INF\Event\Event $object an event object
26
-     * @return boolean
26
+     * @return boolean|null
27 27
      */
28 28
     public function notify($name, $object){ 
29 29
         if($object instanceof \PEIP\INF\Event\Event){
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      * @param array $headers headers of the event-object as key/value pairs
54 54
      * @param string $eventClass event-class to create instances from
55 55
      * @return
56
-     * @see EventBuilder
56
+     boolean|null @see EventBuilder
57 57
      */
58 58
     public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){
59 59
         if(!$this->hasListeners($name, ($object))){
Please login to merge, or discard this patch.
src/Dispatcher/Dispatcher.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,6 @@
 block discarded – undo
65 65
      * Disconnects all listeners.
66 66
      * 
67 67
      * @access public
68
-     * @param Callable|PEIP\INF\Handler\Handler $listener
69 68
      * @return void
70 69
      */
71 70
     public function disconnectAll(){
Please login to merge, or discard this patch.