Completed
Branch v1.ns (bde1f9)
by Timo
03:18
created
src/ABS/Dispatcher/MapDispatcher.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,6 @@
 block discarded – undo
80 80
      *
81 81
      * @access public
82 82
      * @param string $name name of the event
83
-     * @param Callable|PEIP\INF\Handler\Handler $listener listener to connect
84 83
      * @return
85 84
      */
86 85
     public function disconnectAll($name){
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
     public function connect($name, $listener){
48 48
         Test::ensureHandler($listener);
49 49
         if (!$this->hasListeners($name)){
50
-          $this->listeners[$name] = array();
50
+            $this->listeners[$name] = array();
51 51
         }
52 52
         $this->listeners[$name][] = $listener;
53 53
         return true;
@@ -67,10 +67,10 @@  discard block
 block discarded – undo
67 67
         }
68 68
         $res = false;
69 69
         foreach ($this->listeners[$name] as $i => $callable){
70
-          if ($listener === $callable){
70
+            if ($listener === $callable){
71 71
             unset($this->listeners[$name][$i]);
72 72
             $res = true;
73
-          }
73
+            }
74 74
         }
75 75
         return $res;
76 76
     }
Please login to merge, or discard this patch.
src/ABS/Handler/MessageHandler.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
      * @see PEIP\ABS\Handler\MessageHandler::doSetInputChannel
55 55
      * @access public
56 56
      * @param \PEIP\INF\Channel\Channel $inputChannel the input-channel
57
-     * @return PEIP\ABS\Handler\MessageHandler $this;
57
+     * @return MessageHandler $this;
58 58
      */
59 59
     public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel){
60 60
         $this->doSetInputChannel($inputChannel);
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      * @return 
44 44
      */
45 45
     public function handle($message){
46
-         $this->doHandle($this->getMessageFromObject($message));      
46
+            $this->doHandle($this->getMessageFromObject($message));      
47 47
     }
48 48
    
49 49
     /**
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
             && $object->getName() == 'postSend'
91 91
             && $object->hasHeader(Pipe::HEADER_MESSAGE)
92 92
             && $content instanceof \PEIP\INF\Channel\PollableChannel
93
-         ){
93
+            ){
94 94
             $object = $content->receive();
95 95
         }
96 96
         if (!($object instanceof \PEIP\INF\Message\Message)) {
Please login to merge, or discard this patch.
src/ABS/Handler/ReplyProducingMessageHandler.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      * Connects the handler to the output-channel. 
54 54
      * 
55 55
      * @access protected
56
-     * @param \PEIP\INF\Channel\Channel $inputChannel the output-channel to connect the handler to
56
+     * @param \PEIP\INF\Channel\Channel $outputChannel the output-channel to connect the handler to
57 57
      * @return 
58 58
      */
59 59
     protected function doSetOutputChannel(\PEIP\INF\Channel\Channel $outputChannel){
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
      * 
163 163
      * @access public
164 164
      * @param string $messageClass name of the message-class to create reply-messages from. 
165
-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this
165
+     * @return ReplyProducingMessageHandler $this
166 166
      */
167 167
     public function setMessageClass($messageClass){
168 168
         $this->messageClass = $messageClass;
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      * 
196 196
      * @access public
197 197
      * @param array $headerNames array of message-header names to look for a reply-channel
198
-     * @return PEIP\ABS\Handler\ReplyProducingMessageHandler $this
198
+     * @return ReplyProducingMessageHandler $this
199 199
      */
200 200
     public function setReplyChannelHeaders(array $headerNames){
201 201
         $this->replyChannelHeaders = $headerNames;
Please login to merge, or discard this patch.
src/Autoload/Autoload.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,8 @@
 block discarded – undo
66 66
      * Scans a directory recursively for php-files and adds them to autoload
67 67
      * 
68 68
      * @access public
69
-     * @param string directoy to scan
69
+     * @param string directoy to scan
70
+     * @param string $dir
70 71
      * @return void
71 72
      */ 
72 73
     public function scanDirectory($dir){
Please login to merge, or discard this patch.
src/Base/GenericBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
      * 
40 40
      * @access public
41 41
      * @param string $className class-name to create objects for
42
-     * @param ReflectionClass $reflectionClass reflection-class for class. default: NULL 
42
+     * @param \ReflectionClass $reflectionClass reflection-class for class. default: NULL 
43 43
      * @param boolean $storeRef wether to store a reference for new instance. default: true 
44 44
      * @return 
45 45
      */
Please login to merge, or discard this patch.
src/Context/XMLContext.php 2 patches
Doc Comments   +9 added lines, -5 removed lines patch added patch discarded remove patch
@@ -174,7 +174,6 @@  discard block
 block discarded – undo
174 174
      * </config>     
175 175
      * 
176 176
      * @access public
177
-     * @param XMLContext $config the config to include
178 177
      */    
179 178
     public function includeContext(XMLContext $context){
180 179
         $this->services = array_merge($this->services, $context->getServices());
@@ -185,7 +184,7 @@  discard block
 block discarded – undo
185 184
      * 
186 185
      * @see XMLContext::includeContext
187 186
      * @access public
188
-     * @param XMLContext $context the config to include
187
+     * @param string $filePath
189 188
      */    
190 189
     public function includeContextFromFile($filePath){
191 190
         if(file_exists($filePath)){
@@ -693,7 +692,7 @@  discard block
 block discarded – undo
693 692
      * 
694 693
      * @access protected
695 694
      * @param object $config configuration object to create arguments from.  
696
-     * @return mixed build arguments 
695
+     * @return \PEIP\INF\Channel\Channel[] build arguments 
697 696
      */
698 697
     protected function getReplyHandlerArguments($config){
699 698
         $args = array(
@@ -738,7 +737,8 @@  discard block
 block discarded – undo
738 737
      * 
739 738
      * @access protected
740 739
      * @param string the configuration type ofthe channel (e.g.: 'reply', 'request')
741
-     * @param object $config configuration object to return channel from. 
740
+     * @param object $config configuration object to return channel from.
741
+     * @param string $type 
742 742
      * @return \PEIP\INF\Channel\Channel reply-channel
743 743
      */
744 744
     public function doGetChannel($type, $config){
@@ -833,7 +833,7 @@  discard block
 block discarded – undo
833 833
      * @see GenericBuilder
834 834
      * @static
835 835
      * @access protected
836
-     * @param object $className name of class to build instance for. 
836
+     * @param string $className name of class to build instance for. 
837 837
      * @param array $arguments arguments for the constructor 
838 838
      * @return object build and modified srvice instance
839 839
      */     
@@ -841,6 +841,10 @@  discard block
 block discarded – undo
841 841
         return GenericBuilder::getInstance($className)->build($arguments);
842 842
     }
843 843
 
844
+    /**
845
+     * @param string $type
846
+     * @param string $name
847
+     */
844 848
     protected static function hasPublicProperty($service, $type, $name){
845 849
         $reflection = GenericBuilder::getInstance(get_class($service))->getReflectionClass();
846 850
         if($reflection->{'has'.$type}($name) && $reflection->{'get'.$type}($name)->isPublic()){
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
      * @param callable $callable a callable which creates instances for node-name 
135 135
      */
136 136
     public function registerNodeBuilder($nodeName, $callable){
137
-       return  $this->getServiceProvider()->registerNodeBuilder($nodeName, $callable);
137
+        return  $this->getServiceProvider()->registerNodeBuilder($nodeName, $callable);
138 138
     }
139 139
    
140 140
     /**
@@ -769,7 +769,7 @@  discard block
 block discarded – undo
769 769
      */
770 770
     public function buildAndModify($config, $arguments, $defaultClass = false){
771 771
         if("" != (string)$config["class"]  || $defaultClass){
772
-             $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);
772
+                $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);
773 773
         }elseif($config["ref"]){
774 774
             $service = $this->getService((string)$config['ref']);
775 775
         }else{
Please login to merge, or discard this patch.
src/Dispatcher/ClassDispatcher.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,6 @@
 block discarded – undo
71 71
      * notifies all listeners on a event on a subject
72 72
      *
73 73
      * @access public
74
-     * @param string $name name of the event
75 74
      * @param mixed $subject the subject
76 75
      * @return
77 76
      */
Please login to merge, or discard this patch.
src/Dispatcher/ClassEventDispatcher.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      * @access public
57 57
      * @param string $name name of the event
58 58
      * @param \PEIP\INF\Event\Event $object an event object
59
-     * @return boolean
59
+     * @return boolean|null
60 60
      */
61 61
     public function notify($name, $object){ 
62 62
         if($object instanceof \PEIP\INF\Event\Event){
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      * @param array $headers headers of the event-object as key/value pairs
89 89
      * @param string $eventClass event-class to create instances from
90 90
      * @return
91
-     * @see EventBuilder
91
+     boolean|null @see EventBuilder
92 92
      */
93 93
     public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){
94 94
         if(!$this->hasListeners($name, ($object))){
Please login to merge, or discard this patch.
Indentation   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
                         Reflection_Pool::getInstance(
68 68
                             $object->getContent()
69 69
                         )
70
-                     ),
71
-                     $object
72
-                 );
70
+                        ),
71
+                        $object
72
+                    );
73 73
             }else{
74 74
                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');
75 75
             }
@@ -78,18 +78,18 @@  discard block
 block discarded – undo
78 78
         }
79 79
     }       //put your code here
80 80
 
81
-     /**
82
-     * Creates an event-object with given object as content/subject and notifies
83
-     * all registers listeners of the event.
84
-     *
85
-     * @access public
86
-     * @param string $name name of the event
87
-     * @param object $object the subject of the event
88
-     * @param array $headers headers of the event-object as key/value pairs
89
-     * @param string $eventClass event-class to create instances from
90
-     * @return
91
-     * @see EventBuilder
92
-     */
81
+        /**
82
+         * Creates an event-object with given object as content/subject and notifies
83
+         * all registers listeners of the event.
84
+         *
85
+         * @access public
86
+         * @param string $name name of the event
87
+         * @param object $object the subject of the event
88
+         * @param array $headers headers of the event-object as key/value pairs
89
+         * @param string $eventClass event-class to create instances from
90
+         * @return
91
+         * @see EventBuilder
92
+         */
93 93
     public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){
94 94
         if(!$this->hasListeners($name, ($object))){
95 95
             return false;
Please login to merge, or discard this patch.
src/Dispatcher/Dispatcher.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,6 @@
 block discarded – undo
65 65
      * Disconnects all listeners.
66 66
      * 
67 67
      * @access public
68
-     * @param Callable|PEIP\INF\Handler\Handler $listener
69 68
      * @return void
70 69
      */
71 70
     public function disconnectAll(){
Please login to merge, or discard this patch.