tidal / PEIP

src/Dispatcher/ObjectEventDispatcher.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
      * @access public
      * @param string $name name of the event 
      * @param \PEIP\INF\Event\Event $object an event object
-     * @return boolean
+     * @return boolean|null
      */
     public function notify($name, $object){
         if($object instanceof \PEIP\INF\Event\Event){

Spacing +8 added lines, -8 removed lines

@@ -40,16 +40,16 @@ 
      * @param \PEIP\INF\Event\Event $object an event object
      * @return boolean
      */
-    public function notify($name, $object){
-        if($object instanceof \PEIP\INF\Event\Event){
-            if(is_object($object->getContent())){
-                if($this->hasListeners($name, $object->getContent())){
+    public function notify($name, $object) {
+        if ($object instanceof \PEIP\INF\Event\Event) {
+            if (is_object($object->getContent())) {
+                if ($this->hasListeners($name, $object->getContent())) {
                     return self::doNotify($this->getListeners($name, $object->getContent()), $object);  
                 }                   
-            }else{
+            }else {
                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');
             }   
-        }else{
+        }else {
             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');
         }  
     }   
@@ -66,8 +66,8 @@ 
      * @return
      * @see EventBuilder 
      */
-    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){
-        if(!$this->hasListeners($name, $object)){
+    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false) {
+        if (!$this->hasListeners($name, $object)) {
             return false;
         }
         $event = EventBuilder::getInstance($eventClass)->build(

Braces +2 added lines, -2 removed lines

@@ -46,10 +46,10 @@
                 if($this->hasListeners($name, $object->getContent())){
                     return self::doNotify($this->getListeners($name, $object->getContent()), $object);  
                 }                   
-            }else{
+            } else{
                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');
             }   
-        }else{
+        } else{
             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');
         }  
     }   

src/Dispatcher/ObjectMapDispatcher.php

Doc Comments +2 added lines, -2 removed lines

@@ -162,7 +162,7 @@ 
      * @access public
      * @param $name 
      * @param $subject 
-     * @return mixed
+     * @return \PEIP\INF\Handler\Handler
      */
     public function notifyUntil($name, $subject){
         if($this->hasListeners($name, $subject)){       
@@ -205,7 +205,7 @@ 
      * @access protected
      * @param $name 
      * @param $object 
-     * @return boolean
+     * @return boolean|null
      */    
     protected static function doNotify(array $listeners, $subject){
         foreach($listeners as $listener){ 

Indentation +4 added lines, -4 removed lines

@@ -209,11 +209,11 @@
      */    
     protected static function doNotify(array $listeners, $subject){
         foreach($listeners as $listener){ 
-             if($listener instanceof \PEIP\INF\Handler\Handler){
+                if($listener instanceof \PEIP\INF\Handler\Handler){
                 $listener->handle($subject);
-             }elseif(is_callable($listener)){
-                 call_user_func($listener, $subject);
-             }
+                }elseif(is_callable($listener)){
+                    call_user_func($listener, $subject);
+                }
         }   
     }  
 

Spacing +33 added lines, -33 removed lines

@@ -43,13 +43,13 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener event-handler
      * @return boolean
      */
-    public function connect($name, $object, $listener){
+    public function connect($name, $object, $listener) {
         Test::ensureHandler($listener);
         $listners = $this->doGetListeners();
-        if (!$this->listeners->contains($object)){
+        if (!$this->listeners->contains($object)) {
             $this->listeners->attach($object, new \ArrayObject);
         }
-        if (!array_key_exists($name, $listners[$object])){ 
+        if (!array_key_exists($name, $listners[$object])) { 
             $this->listeners[$object][$name] = array();
         }
         $hash = $this->getListenerHash($listener);
@@ -67,14 +67,14 @@ 
      * @param \PEIP\INF\Handler\Handler $listener event-handler
      * @return boolean
      */
-    public function disconnect($name, $object, $listener){
+    public function disconnect($name, $object, $listener) {
         $listners = $this->doGetListeners();
-        if (!$listners->contains($object) || !isset($listners[$object][$name])){
+        if (!$listners->contains($object) || !isset($listners[$object][$name])) {
             return false;
         }
         $eventListeners = $listners[$object][$name];
         $hash = $this->getListenerHash($listener);
-        if(isset($eventListeners[$hash])){
+        if (isset($eventListeners[$hash])) {
             unset($eventListeners[$hash]); 
 
             $listners[$object][$name] = $eventListeners;
@@ -83,10 +83,10 @@ 
         return false;
     }
 
-    public function disconnectAll($name, $object){
-        if(is_object($object)){
+    public function disconnectAll($name, $object) {
+        if (is_object($object)) {
             $listners = $this->doGetListeners();
-            if($listners && $this->hadListeners($name, $object)){
+            if ($listners && $this->hadListeners($name, $object)) {
                     $listners[$object][$name] = array();
             }        
         }
@@ -100,13 +100,13 @@ 
      * @param object $object object to check for listeners
      * @return boolean
      */
-    public function hasListeners($name, $object){
+    public function hasListeners($name, $object) {
         $listners = $this->doGetListeners();
-        if (!$this->hadListeners($name, $object)){
+        if (!$this->hadListeners($name, $object)) {
             $res = false;
-        }else{
+        }else {
             $listners = $this->doGetListeners();
-            $res = (boolean) count($listners[$object][$name]);
+            $res = (boolean)count($listners[$object][$name]);
         }
         return $res;
     }
@@ -119,7 +119,7 @@ 
      * @param object $object object to check for listeners
      * @return boolean
      */
-    public function hadListeners($name, $object){
+    public function hadListeners($name, $object) {
         $listners = $this->doGetListeners();
         return ($listners->contains($object) && isset($listners[$object][$name])) ? true : false;
     }
@@ -131,9 +131,9 @@ 
      * @param object $object object to get event-names for
      * @return string[] array of event-names
      */
-    public function getEventNames($object){
+    public function getEventNames($object) {
         $listeners = $this->doGetListeners();
-        if (!$listeners->contains($object)){
+        if (!$listeners->contains($object)) {
             return array();
         }
         return array_keys($listeners[$object]->getArrayCopy());
@@ -147,8 +147,8 @@ 
      * @param $object 
      * @return boolean
      */
-    public function notify($name, $object){
-        if($this->hasListeners($name, $object)){
+    public function notify($name, $object) {
+        if ($this->hasListeners($name, $object)) {
             $listners = $this->doGetListeners();
             self::doNotify($listners[$object][$name], $object);
         }
@@ -164,8 +164,8 @@ 
      * @param $subject 
      * @return mixed
      */
-    public function notifyUntil($name, $subject){
-        if($this->hasListeners($name, $subject)){       
+    public function notifyUntil($name, $subject) {
+        if ($this->hasListeners($name, $subject)) {       
             $res = self::doNotifyUntil($this->getListeners($name, $subject), $subject);   
         }
         return $res;
@@ -179,8 +179,8 @@ 
      * @param object $object object to check for listeners
      * @return array array of listeners
      */
-    public function getListeners($name, $object){
-        if (!$this->hadListeners($name, $object)){
+    public function getListeners($name, $object) {
+        if (!$this->hadListeners($name, $object)) {
             return array();
         }
         $listeners = $this->listeners[$object]->getArrayCopy();
@@ -194,7 +194,7 @@ 
      * @access protected
      * @return ObjectStorage
      */
-    protected function doGetListeners(){
+    protected function doGetListeners() {
         return isset($this->listeners) ? $this->listeners : $this->listeners = new ObjectStorage();
     }
    
@@ -207,11 +207,11 @@ 
      * @param $object 
      * @return boolean
      */    
-    protected static function doNotify(array $listeners, $subject){
-        foreach($listeners as $listener){ 
-             if($listener instanceof \PEIP\INF\Handler\Handler){
+    protected static function doNotify(array $listeners, $subject) {
+        foreach ($listeners as $listener) { 
+             if ($listener instanceof \PEIP\INF\Handler\Handler) {
                 $listener->handle($subject);
-             }elseif(is_callable($listener)){
+             }elseif (is_callable($listener)) {
                  call_user_func($listener, $subject);
              }
         }   
@@ -226,12 +226,12 @@ 
      * @param $object 
      * @return \PEIP\INF\Handler\Handler the listener which returned a boolean true value
      */     
-    protected static function doNotifyUntil(array $listeners, $subject){  
+    protected static function doNotifyUntil(array $listeners, $subject) {  
         $res = NULL; 
-        foreach ($listeners as $listener){ 
-            if($listener instanceof \PEIP\INF\Handler\Handler){
+        foreach ($listeners as $listener) { 
+            if ($listener instanceof \PEIP\INF\Handler\Handler) {
                 $res = $listener->handle($subject);
-                if ($res){ 
+                if ($res) { 
                     return $listener;
                 }
             }
@@ -239,8 +239,8 @@ 
         return $res;
     }
 
-    protected function getListenerHash($listener){
-        if(!is_object($listener)){
+    protected function getListenerHash($listener) {
+        if (!is_object($listener)) {
             $o = new \stdClass();
             $o->listener = $listener;
             $listener = $o;

Braces +2 added lines, -2 removed lines

@@ -104,7 +104,7 @@ 
         $listners = $this->doGetListeners();
         if (!$this->hadListeners($name, $object)){
             $res = false;
-        }else{
+        } else{
             $listners = $this->doGetListeners();
             $res = (boolean) count($listners[$object][$name]);
         }
@@ -211,7 +211,7 @@ 
         foreach($listeners as $listener){ 
              if($listener instanceof \PEIP\INF\Handler\Handler){
                 $listener->handle($subject);
-             }elseif(is_callable($listener)){
+             } elseif(is_callable($listener)){
                  call_user_func($listener, $subject);
              }
         }   

src/Event/Event.php

Doc Comments -1 removed lines

@@ -49,7 +49,6 @@
      * @access public
      * @param mixed $subject the subject for the event
      * @param string $name the name of the event
-     * @param array|ArrayAccess $headers the headers for the event 
      */
     public function __construct($subject, $name, $parameters = array(), $type = false){
         parent::__construct($subject, Test::ensureArrayAccess($parameters));

Spacing +9 added lines, -9 removed lines

@@ -51,7 +51,7 @@ 
      * @param string $name the name of the event
      * @param array|ArrayAccess $headers the headers for the event 
      */
-    public function __construct($subject, $name, $parameters = array(), $type = false){
+    public function __construct($subject, $name, $parameters = array(), $type = false) {
         parent::__construct($subject, Test::ensureArrayAccess($parameters));
         $this->name = $name;
         $this->type = $type ? $type : get_class($this);
@@ -63,7 +63,7 @@ 
      * @access public
      * @return string the name of the event
      */
-    public function getName(){
+    public function getName() {
         return $this->name;
     }
 
@@ -74,7 +74,7 @@ 
      * @access public
      * @return string the type of the event
      */
-    public function getType(){
+    public function getType() {
         return $this->name;
     }
   
@@ -84,7 +84,7 @@ 
      * @access public
      * @param mixed $value the return-value to set 
      */
-    public function setReturnValue($value){
+    public function setReturnValue($value) {
         $this->value = $value;
     }
   
@@ -94,7 +94,7 @@ 
      * @access public
      * @return mixed the return-value to set
      */
-    public function getReturnValue(){
+    public function getReturnValue() {
         return $this->value;
     }
   
@@ -104,8 +104,8 @@ 
      * @access public
      * @param boolean $processed 
      */
-    public function setProcessed($processed){
-        $this->processed = (boolean) $processed;
+    public function setProcessed($processed) {
+        $this->processed = (boolean)$processed;
     }
 
     /**
@@ -114,7 +114,7 @@ 
      * @access public
      * @return boolean wether the event is processed 
      */
-    public function isProcessed(){
+    public function isProcessed() {
         return $this->processed;
     }
 
@@ -124,7 +124,7 @@ 
      * @access public
      * @return mixed the subject/content
      */
-    public function getSubject(){
+    public function getSubject() {
         return $this->getContent();
     }
 }

src/Factory/ServiceFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
      * @see GenericBuilder
      * @static
      * @access protected
-     * @param object $className name of class to build instance for.
+     * @param string $className name of class to build instance for.
      * @param array $arguments arguments for the constructor
      * @return object build and modified srvice instance
      */

Indentation +23 added lines, -23 removed lines

@@ -16,13 +16,13 @@ 
 use PEIP\Context\XMLContext;
 
 class ServiceFactory {
-     /**
-     * Creates and initializes service instance from a given configuration.
-     *
-     * @access public
-     * @param $config configuration of the service
-     * @return object the initialized service instance
-     */
+        /**
+         * Creates and initializes service instance from a given configuration.
+         *
+         * @access public
+         * @param $config configuration of the service
+         * @return object the initialized service instance
+         */
     public static function createService(array $config){
         $args = array();
         //build arguments for constructor
@@ -35,15 +35,15 @@ 
     }
 
         /**
-     * Builds an arbitrary service/object instance from a config-obect.
-     *
-     * @static
-     * @access protected
-     * @param object $config configuration object to build a service instance from.
-     * @param array $arguments arguments for the service constructor
-     * @param string $defaultClass class to create instance for if none is set in config
-     * @return object build and modified srvice instance
-     */
+         * Builds an arbitrary service/object instance from a config-obect.
+         *
+         * @static
+         * @access protected
+         * @param object $config configuration object to build a service instance from.
+         * @param array $arguments arguments for the service constructor
+         * @param string $defaultClass class to create instance for if none is set in config
+         * @return object build and modified srvice instance
+         */
     public static function doBuild($config, $arguments, $defaultClass = false){
         $cls = isset($config["class"]) ? trim((string)$config["class"]) : (string)$defaultClass;
         if($cls != ''){
@@ -80,12 +80,12 @@ 
     }
 
         /**
-     * Builds single argument (to call a method with later) from a config-obect.
-     *
-     * @access protected
-     * @param object $config configuration object to create argument from.
-     * @return mixed build argument
-     */
+         * Builds single argument (to call a method with later) from a config-obect.
+         *
+         * @access protected
+         * @param object $config configuration object to create argument from.
+         * @return mixed build argument
+         */
     protected function buildArg($config){
         if(trim((string)$config['value']) != ''){
             $arg = (string)$config['value'];
@@ -128,7 +128,7 @@ 
      */
     public static function buildAndModify(array $config, $arguments, $defaultClass = ""){
         if((isset($config["class"]) && "" != (string)$config["class"])  || $defaultClass !== ""){
-             $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);
+                $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);
         }else{
             throw new \RuntimeException('Could not create Service. no class or reference given.');
         }

Spacing +44 added lines, -44 removed lines

@@ -23,11 +23,11 @@ 
      * @param $config configuration of the service
      * @return object the initialized service instance
      */
-    public static function createService(array $config){
+    public static function createService(array $config) {
         $args = array();
         //build arguments for constructor
-        if(isset($config['constructor_arg'])){
-            foreach($config['constructor_arg'] as $arg){
+        if (isset($config['constructor_arg'])) {
+            foreach ($config['constructor_arg'] as $arg) {
                 $args[] = self::buildArg($arg);
             }
         }
@@ -44,21 +44,21 @@ 
      * @param string $defaultClass class to create instance for if none is set in config
      * @return object build and modified srvice instance
      */
-    public static function doBuild($config, $arguments, $defaultClass = false){
+    public static function doBuild($config, $arguments, $defaultClass = false) {
         $cls = isset($config["class"]) ? trim((string)$config["class"]) : (string)$defaultClass;
-        if($cls != ''){
+        if ($cls != '') {
             try {
-                $constructor = isset($config["constructor"])?(string)$config["constructor"]:"";
-                if($constructor != '' && Test::assertMethod($cls, $constructor)){
+                $constructor = isset($config["constructor"]) ? (string)$config["constructor"] : "";
+                if ($constructor != '' && Test::assertMethod($cls, $constructor)) {
                     $service = call_user_func_array(array($cls, $constructor), $arguments);
-                }else{
+                }else {
                     $service = self::build($cls, $arguments);
                 }
-            }catch(\Exception $e){
+            } catch (\Exception $e) {
                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());
             }
         }
-        if(is_object($service)){
+        if (is_object($service)) {
             return $service;
         }
         throw new \RuntimeException('Could not create Service "'.$cls.'". Class does not exist.');
@@ -75,7 +75,7 @@ 
      * @param array $arguments arguments for the constructor
      * @return object build and modified srvice instance
      */
-    public static function build($className, $arguments){
+    public static function build($className, $arguments) {
         return GenericBuilder::getInstance($className)->build($arguments);
     }
 
@@ -86,29 +86,29 @@ 
      * @param object $config configuration object to create argument from.
      * @return mixed build argument
      */
-    protected function buildArg($config){
-        if(trim((string)$config['value']) != ''){
+    protected function buildArg($config) {
+        if (trim((string)$config['value']) != '') {
             $arg = (string)$config['value'];
-        }elseif($config->getName() == 'value'){
+        }elseif ($config->getName() == 'value') {
             $arg = (string)$config;
-        }elseif($config->getName() == 'list'){
+        }elseif ($config->getName() == 'list') {
             $arg = array();
-            foreach($config->children() as $entry){
-                if($entry->getName() == 'value'){
-                    if($entry['key']){
+            foreach ($config->children() as $entry) {
+                if ($entry->getName() == 'value') {
+                    if ($entry['key']) {
                         $arg[(string)$entry['key']] = (string)$entry;
-                    }else{
+                    }else {
                         $arg[] = (string)$entry;
                     }
-                }elseif($entry->getName() == 'service'){
+                }elseif ($entry->getName() == 'service') {
                     $arg[] = $this->provideService($entry);
                 }
             }
-        }elseif($config->getName() == 'service'){
+        }elseif ($config->getName() == 'service') {
             $arg = self::provideService($config);
-        }elseif($config->list){
+        }elseif ($config->list) {
             $arg = $this->buildArg($config->list);
-        }elseif($config->service){
+        }elseif ($config->service) {
             $arg = $this->buildArg($config->service);
         }
         return $arg;
@@ -126,24 +126,24 @@ 
      * @param string $defaultClass class to create instance for if none is set in config
      * @return object build and modified srvice instance
      */
-    public static function buildAndModify(array $config, $arguments, $defaultClass = ""){
-        if((isset($config["class"]) && "" != (string)$config["class"])  || $defaultClass !== ""){
+    public static function buildAndModify(array $config, $arguments, $defaultClass = "") {
+        if ((isset($config["class"]) && "" != (string)$config["class"]) || $defaultClass !== "") {
              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);
-        }else{
+        }else {
             throw new \RuntimeException('Could not create Service. no class or reference given.');
         }
-        if(isset($config["ref_property"])){
+        if (isset($config["ref_property"])) {
             $service = $service->{(string)$config["ref_property"]};
-        }elseif(isset($config["ref_method"])){
+        }elseif (isset($config["ref_method"])) {
                 $args = array();
-            if(isset($config['argument'])){
-                        foreach($config['argument'] as $arg){
+            if (isset($config['argument'])) {
+                        foreach ($config['argument'] as $arg) {
                             $args[] = $this->buildArg($arg);
                         }
                 }
             $service = call_user_func_array(array($service, (string)$config["ref_method"]), $args);
         }
-        if(!is_object($service)){
+        if (!is_object($service)) {
             throw new \RuntimeException('Could not create Service.');
         }
         $service = self::modifyService($service, $config);
@@ -165,29 +165,29 @@ 
      * @param object $config configuration to get the modification instructions from.
      * @return object the modificated service
      */
-    protected function modifyService($service, $config){        
+    protected function modifyService($service, $config) {        
         $config = is_array($config) ? new \ArrayObject($config) : $config;
         // set instance properties
-        if(isset($config->property)){
-            foreach($config->property as $property){
+        if (isset($config->property)) {
+            foreach ($config->property as $property) {
                 $arg = $this->buildArg($property);
-                if($arg){
+                if ($arg) {
                     $setter = self::getSetter($property);
-                    if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){
+                    if ($setter && self::hasPublicProperty($service, 'Method', $setter)) {
                         $service->{$setter}($arg);
-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){
+                    }elseif (in_array($property, self::hasPublicProperty($service, 'Property', $setter))) {
                         $service->$setter = $arg;
                     }
                 }
             }
         }
         // call instance methods
-        if(isset($config->action)){
-            foreach($config->action as $action){
+        if (isset($config->action)) {
+            foreach ($config->action as $action) {
                 $method = (string)$action['method'] != '' ? (string)$action['method'] : NULL;
-                if($method && self::hasPublicProperty($service, 'Method', $method)){
+                if ($method && self::hasPublicProperty($service, 'Method', $method)) {
                     $args = array();
-                    foreach($action->children() as $argument){
+                    foreach ($action->children() as $argument) {
                         $args[] = $this->buildArg($argument);
                     }
                     call_user_func_array(array($service, (string)$action['method']), $args);
@@ -195,9 +195,9 @@ 
             }
         }
         // register instance listeners
-        if($service instanceof \PEIP\INF\Event\Connectable){
-            if(isset($config->listener)){
-                foreach($config->listener as $listenerConf){
+        if ($service instanceof \PEIP\INF\Event\Connectable) {
+            if (isset($config->listener)) {
+                foreach ($config->listener as $listenerConf) {
                     $event = (string)$listenerConf['event'];
                     $listener = $this->provideService($listenerConf);
                     $service->connect($event, $listener);

Braces +12 added lines, -12 removed lines

@@ -51,10 +51,10 @@ 
                 $constructor = isset($config["constructor"])?(string)$config["constructor"]:"";
                 if($constructor != '' && Test::assertMethod($cls, $constructor)){
                     $service = call_user_func_array(array($cls, $constructor), $arguments);
-                }else{
+                } else{
                     $service = self::build($cls, $arguments);
                 }
-            }catch(\Exception $e){
+            } catch(\Exception $e){
                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());
             }
         }
@@ -89,26 +89,26 @@ 
     protected function buildArg($config){
         if(trim((string)$config['value']) != ''){
             $arg = (string)$config['value'];
-        }elseif($config->getName() == 'value'){
+        } elseif($config->getName() == 'value'){
             $arg = (string)$config;
-        }elseif($config->getName() == 'list'){
+        } elseif($config->getName() == 'list'){
             $arg = array();
             foreach($config->children() as $entry){
                 if($entry->getName() == 'value'){
                     if($entry['key']){
                         $arg[(string)$entry['key']] = (string)$entry;
-                    }else{
+                    } else{
                         $arg[] = (string)$entry;
                     }
-                }elseif($entry->getName() == 'service'){
+                } elseif($entry->getName() == 'service'){
                     $arg[] = $this->provideService($entry);
                 }
             }
-        }elseif($config->getName() == 'service'){
+        } elseif($config->getName() == 'service'){
             $arg = self::provideService($config);
-        }elseif($config->list){
+        } elseif($config->list){
             $arg = $this->buildArg($config->list);
-        }elseif($config->service){
+        } elseif($config->service){
             $arg = $this->buildArg($config->service);
         }
         return $arg;
@@ -129,12 +129,12 @@ 
     public static function buildAndModify(array $config, $arguments, $defaultClass = ""){
         if((isset($config["class"]) && "" != (string)$config["class"])  || $defaultClass !== ""){
              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);
-        }else{
+        } else{
             throw new \RuntimeException('Could not create Service. no class or reference given.');
         }
         if(isset($config["ref_property"])){
             $service = $service->{(string)$config["ref_property"]};
-        }elseif(isset($config["ref_method"])){
+        } elseif(isset($config["ref_method"])){
                 $args = array();
             if(isset($config['argument'])){
                         foreach($config['argument'] as $arg){
@@ -175,7 +175,7 @@ 
                     $setter = self::getSetter($property);
                     if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){
                         $service->{$setter}($arg);
-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){
+                    } elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){
                         $service->$setter = $arg;
                     }
                 }

src/Gateway/SimpleMessagingGateway.php

Doc Comments +1 added lines, -2 removed lines

@@ -55,7 +55,6 @@ 
      * sets the channel to send requests from the gateway
      * 
      * @access public
-     * @param \PEIP\INF\Channel\Channel $replyChannel The default channel to receive requests from the gateway
      * @return 
      */
     public function setRequestChannel(\PEIP\INF\Channel\Channel $requestChannel){
@@ -108,7 +107,7 @@ 
      * sends and receives a request/message through the gateway
      * 
      * @access public
-     * @param mixed $content the content/payload for the message to send 
+     * @param \Order $content the content/payload for the message to send 
      * @return mixed content/payload of the received message
      */
     public function sendAndReceive($content){

Spacing +15 added lines, -15 removed lines

@@ -42,9 +42,9 @@ 
      * @param \PEIP\INF\Channel\PollableChannel $replyChannel The default channel to receive requests from the gateway
      * @param array $defaultHeaders The default headers to apply to request messages 
      */
-    public function __construct(\PEIP\INF\Channel\Channel $requestChannel, \PEIP\INF\Channel\Channel $replyChannel = NULL, array $defaultHeaders = array()){
+    public function __construct(\PEIP\INF\Channel\Channel $requestChannel, \PEIP\INF\Channel\Channel $replyChannel = NULL, array $defaultHeaders = array()) {
         $this->setRequestChannel($requestChannel);
-        if($replyChannel){
+        if ($replyChannel) {
             $this->setReplyChannel($replyChannel);
         }     
         $this->defaultHeaders = $defaultHeaders;
@@ -58,7 +58,7 @@ 
      * @param \PEIP\INF\Channel\Channel $replyChannel The default channel to receive requests from the gateway
      * @return 
      */
-    public function setRequestChannel(\PEIP\INF\Channel\Channel $requestChannel){
+    public function setRequestChannel(\PEIP\INF\Channel\Channel $requestChannel) {
         $this->requestChannel = $requestChannel;
     }
   
@@ -69,8 +69,8 @@ 
      * @param \PEIP\INF\Channel\PollableChannel $replyChannel The default channel to receive requests from the gateway
      * @return 
      */
-    public function setReplyChannel(\PEIP\INF\Channel\Channel $replyChannel){
-        if(!($replyChannel instanceof \PEIP\INF\Channel\PollableChannel)){
+    public function setReplyChannel(\PEIP\INF\Channel\Channel $replyChannel) {
+        if (!($replyChannel instanceof \PEIP\INF\Channel\PollableChannel)) {
             throw new \InvalidArgumentException('reply channel must be instance of \PEIP\INF\Channel\PollableChannel.');
         }       
         $this->replyChannel = $replyChannel;
@@ -83,7 +83,7 @@ 
      * @param mixed $content the content/payload for the message to send 
      * @return 
      */
-    public function send($content){
+    public function send($content) {
         return $this->requestChannel->send($this->buildMessage($content));
     }
    
@@ -93,12 +93,12 @@ 
      * @access public
      * @return mixed content/payload of the received message
      */
-    public function receive(){
-        if(!isset($this->replyChannel)){
+    public function receive() {
+        if (!isset($this->replyChannel)) {
             throw new \LogicException('No replyChannel set.');
         }       
         $message = $this->replyChannel->receive();
-        if($message){
+        if ($message) {
             return $message->getContent();
         }
         return NULL;
@@ -111,12 +111,12 @@ 
      * @param mixed $content the content/payload for the message to send 
      * @return mixed content/payload of the received message
      */
-    public function sendAndReceive($content){
+    public function sendAndReceive($content) {
         $this->send($content);
         try {
             $res = $this->receive();
         }
-        catch(\Exception $e){
+        catch (\Exception $e) {
             return NULL;
         }
         return $res;
@@ -129,7 +129,7 @@ 
      * @param mixed $content the content/payload for the message to send 
      * @return \PEIP\INF\Message\Message the built message
      */
-    protected function buildMessage($content){
+    protected function buildMessage($content) {
         return $this->getMessageBuilder()->setContent($content)->build();   
     }   
       
@@ -139,7 +139,7 @@ 
      * @access protected
      * @return MessageBuilder message builder instance for the registerd message class
      */
-    protected function getMessageBuilder(){
+    protected function getMessageBuilder() {
         return isset($this->messageBuilder) && ($this->messageBuilder->getMessageClass() == $this->getMessageClass())
             ? $this->messageBuilder
             : $this->messageBuilder = MessageBuilder::getInstance($this->messageClass)->setHeaders($this->defaultHeaders);
@@ -152,7 +152,7 @@ 
      * @param   string $messageClass message class to create instances from
      * @return 
      */
-    public function setMessageClass($messageClass){
+    public function setMessageClass($messageClass) {
         $this->messageClass = $messageClass;
     }
     
@@ -162,7 +162,7 @@ 
      * @access public
      * @return string message class to create instances from
      */
-    public function getMessageClass(){
+    public function getMessageClass() {
         return $this->messageClass;
     }   
 

Braces +1 added lines, -2 removed lines

@@ -115,8 +115,7 @@
         $this->send($content);
         try {
             $res = $this->receive();
-        }
-        catch(\Exception $e){
+        } catch(\Exception $e){
             return NULL;
         }
         return $res;

src/INF/Channel/Channel.php

Doc Comments +3 added lines, -3 removed lines

@@ -33,10 +33,10 @@
      * Send a message, blocking until either the message is accepted or the
      * specified timeout period elapses.
      * 
-     * @param message the {@link Message} to send
-     * @param timeout the timeout in milliseconds
+     * @param message \PEIP\INF\Message\Message {@link Message} to send
+     * @param timeout integer timeout in milliseconds
      * 
-     * @return <code>true</code> if the message is sent successfully,
+     * @return null|boolean if the message is sent successfully,
      * <code>false</false> if the specified timeout period elapses or
      * the send is interrupted
      */

src/Message/TextMessage.php

Doc Comments -1 removed lines

@@ -64,7 +64,6 @@
      * @static
      * @access public
      * @implements \PEIP\INF\Base\Buildable
-     * @param string $name the name of the header
      * @return boolean wether the header is set
      */
     public static function build(array $arguments = array()){

Spacing +4 added lines, -4 removed lines

@@ -34,7 +34,7 @@ 
      * @param $title 
      * @return 
      */
-    public function __construct($content, $title){
+    public function __construct($content, $title) {
         $this->setContent((string)$content);
     }
 
@@ -44,7 +44,7 @@ 
      * @param $title 
      * @return 
      */
-    public function setTitle($title){
+    public function setTitle($title) {
         $this->title = (string)$title;
     }
 
@@ -53,7 +53,7 @@ 
      * @access public
      * @return 
      */
-    public function getTitle(){
+    public function getTitle() {
         return $this->title;
     }
 
@@ -67,7 +67,7 @@ 
      * @param string $name the name of the header
      * @return boolean wether the header is set
      */
-    public static function build(array $arguments = array()){
+    public static function build(array $arguments = array()) {
         return GenericBuilder::getInstance('\PEIP\Message\StringMessage')->build($arguments);
     }
 

src/Pipe/FixedEventPipe.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
     
     /**
      * @access public
-     * @param $eventName 
+     * @param string $eventName 
      * @return 
      */
     public function setEventName($eventName){

Spacing +6 added lines, -6 removed lines

@@ -31,10 +31,10 @@ 
      * @param $inputChannel 
      * @return 
      */
-    public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel){        
-        if(isset($this->eventName)){
+    public function setInputChannel(\PEIP\INF\Channel\Channel $inputChannel) {        
+        if (isset($this->eventName)) {
             $this->connectChannel($inputChannel);   
-        }else{
+        }else {
             $this->inputChannel = $inputChannel;    
         }               
     }       
@@ -45,10 +45,10 @@ 
      * @param $eventName 
      * @return 
      */
-    public function setEventName($eventName){
-        if(!isset($this->eventName)){
+    public function setEventName($eventName) {
+        if (!isset($this->eventName)) {
             $this->eventName = $eventName;
-            if($this->inputChannel){
+            if ($this->inputChannel) {
                 $this->inputChannel->connect($this->eventName, $this);
             }   
         }

Braces +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         $name = is_object($name) ? get_class($name) : (string)$name;
         if(Test::assertClassOrInterfaceExists($name)){
             parent::connect($name, $listener);
-        }else{
+        } else{
             throw new \InvalidArgumentException($name." is not an Class nor Interface");
         }
     }

src/Pipe/Pipe.php

Doc Comments +1 added lines, -1 removed lines

@@ -184,7 +184,7 @@
     
     /**
      * @access protected
-     * @param $commandName 
+     * @param string $commandName 
      * @param $callable 
      * @return 
      */

Spacing +17 added lines, -17 removed lines

@@ -60,7 +60,7 @@ 
      * @param $name 
      * @return 
      */
-    public function setName($name){
+    public function setName($name) {
         $this->name = $name;
     }
     
@@ -69,7 +69,7 @@ 
      * @access public
      * @return 
      */
-    public function getName(){
+    public function getName() {
         return $this->name;
     }
 
@@ -80,7 +80,7 @@ 
      * @param $timeout 
      * @return 
      */
-    public function send(\PEIP\INF\Message\Message $message, $timeout = -1){
+    public function send(\PEIP\INF\Message\Message $message, $timeout = -1) {
         return $this->handle($message);
     }
 
@@ -90,7 +90,7 @@ 
      * @param $message 
      * @return 
      */
-    protected function doSend(\PEIP\INF\Message\Message $message){
+    protected function doSend(\PEIP\INF\Message\Message $message) {
         $this->doFireEvent(self::EVENT_PRE_PUBLISH, array(self::HEADER_MESSAGE=>$message));
         $this->getMessageDispatcher()->notify($message);
         $this->doFireEvent(self::EVENT_POST_PUBLISH, array(self::HEADER_MESSAGE=>$message));
@@ -103,12 +103,12 @@ 
      * @param $content 
      * @return 
      */
-    protected function replyMessage($message){ 
+    protected function replyMessage($message) { 
         $message = $this->ensureMessage($message);
         //if(\PEIP\Util\Test::assertMessage($message)){
-            if($this->getOutputChannel()){ 
+            if ($this->getOutputChannel()) { 
                 $this->getOutputChannel()->send($message);
-            }else{ 
+            }else { 
                 $this->doSend($message);
             }
         //}
@@ -120,7 +120,7 @@ 
      * @param $message 
      * @return 
      */
-    protected function doReply(\PEIP\INF\Message\Message $message){
+    protected function doReply(\PEIP\INF\Message\Message $message) {
         $this->replyMessage($message);
     }
 
@@ -130,7 +130,7 @@ 
      * @param $handler 
      * @return 
      */
-    public function subscribe($handler){
+    public function subscribe($handler) {
         Test::ensureHandler($handler);
         $this->getMessageDispatcher()->connect($handler);
         $this->doFireEvent(self::EVENT_SUBSCRIBE, array(self::HEADER_SUBSCRIBER=>$handler));
@@ -142,7 +142,7 @@ 
      * @param $handler e
      * @return 
      */
-    public function unsubscribe($handler){
+    public function unsubscribe($handler) {
         Test::ensureHandler($handler);
         $this->getMessageDispatcher()->disconnect($handler);
         $this->doFireEvent(
@@ -160,9 +160,9 @@ 
      * @param $transferListeners 
      * @return 
      */
-    public function setMessageDispatcher(\PEIP\INF\Dispatcher\Dispatcher $dispatcher, $transferListeners = true){
-        if(isset($this->dispatcher) && $transferListeners){
-            foreach($this->dispatcher->getListeners() as $listener){
+    public function setMessageDispatcher(\PEIP\INF\Dispatcher\Dispatcher $dispatcher, $transferListeners = true) {
+        if (isset($this->dispatcher) && $transferListeners) {
+            foreach ($this->dispatcher->getListeners() as $listener) {
                 $dispatcher->connect($listener);
                 $this->dispatcher->disconnect($listener);       
             }   
@@ -176,7 +176,7 @@ 
      * @access public
      * @return 
      */
-    public function getMessageDispatcher(){
+    public function getMessageDispatcher() {
         $defaultDispatcher = self::DEFAULT_CLASS_MESSAGE_DISPATCHER;
         return isset($this->dispatcher) ? $this->dispatcher : $this->dispatcher = new $defaultDispatcher;
     }   
@@ -188,7 +188,7 @@ 
      * @param $callable 
      * @return 
      */
-    protected function registerCommand($commandName, $callable){
+    protected function registerCommand($commandName, $callable) {
         $this->commands[$commandName] = $callable;  
     }
     
@@ -198,10 +198,10 @@ 
      * @param $cmdMessage 
      * @return 
      */
-    public function command(\PEIP\INF\Message\Message $cmdMessage){
+    public function command(\PEIP\INF\Message\Message $cmdMessage) {
         $this->doFireEvent(self::EVENT_PRE_COMMAND, array(self::HEADER_MESSAGE=>$cmdMessage));
         $commandName = trim((string)$cmdMessage->getHeader('COMMAND'));
-        if($commandName != '' && array_key_exists($commandName, $this->commands)){
+        if ($commandName != '' && array_key_exists($commandName, $this->commands)) {
             call_user_func($this->commands[$commandName], $cmdMessage->getContent());   
         }
         $this->doFireEvent(self::EVENT_POST_COMMAND, array(self::HEADER_MESSAGE=>$cmdMessage));

Braces +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
         //if(\PEIP\Util\Test::assertMessage($message)){
             if($this->getOutputChannel()){ 
                 $this->getOutputChannel()->send($message);
-            }else{ 
+            } else{ 
                 $this->doSend($message);
             }
         //}