tidal / PEIP

src/Factory/ServiceFactory.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -11,8 +11,8 @@
  *

  * @author timo

  */

-use PEIP\Util\Test;

-use PEIP\Base\GenericBuilder;

+use PEIP\Util\Test;
+use PEIP\Base\GenericBuilder;
 use PEIP\Context\XMLContext;

 

 class ServiceFactory {

Spacing +44 added lines, -44 removed lines

@@ -23,11 +23,11 @@ 
      * @param $config configuration of the service

      * @return object the initialized service instance

      */

-    public static function createService(array $config){

+    public static function createService(array $config) {

         $args = array();

         //build arguments for constructor

-        if(isset($config['constructor_arg'])){

-            foreach($config['constructor_arg'] as $arg){

+        if (isset($config['constructor_arg'])) {

+            foreach ($config['constructor_arg'] as $arg) {

                 $args[] = self::buildArg($arg);

             }

         }

@@ -44,21 +44,21 @@ 
      * @param string $defaultClass class to create instance for if none is set in config

      * @return object build and modified srvice instance

      */

-    public static function doBuild($config, $arguments, $defaultClass = false){

+    public static function doBuild($config, $arguments, $defaultClass = false) {

         $cls = isset($config["class"]) ? trim((string)$config["class"]) : (string)$defaultClass;

-        if($cls != ''){

+        if ($cls != '') {

             try {

-                $constructor = isset($config["constructor"])?(string)$config["constructor"]:"";

-                if($constructor != '' && Test::assertMethod($cls, $constructor)){

+                $constructor = isset($config["constructor"]) ? (string)$config["constructor"] : "";

+                if ($constructor != '' && Test::assertMethod($cls, $constructor)) {

                     $service = call_user_func_array(array($cls, $constructor), $arguments);

-                }else{

+                }else {

                     $service = self::build($cls, $arguments);

                 }

-            }catch(\Exception $e){

+            } catch (\Exception $e) {

                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());

             }

         }

-        if(is_object($service)){

+        if (is_object($service)) {

             return $service;

         }

         throw new \RuntimeException('Could not create Service "'.$cls.'". Class does not exist.');

@@ -75,7 +75,7 @@ 
      * @param array $arguments arguments for the constructor

      * @return object build and modified srvice instance

      */

-    public static function build($className, $arguments){

+    public static function build($className, $arguments) {

         return GenericBuilder::getInstance($className)->build($arguments);

     }

 

@@ -86,29 +86,29 @@ 
      * @param object $config configuration object to create argument from.

      * @return mixed build argument

      */

-    protected static function buildArg($config){

-        if(trim((string)$config['value']) != ''){

+    protected static function buildArg($config) {

+        if (trim((string)$config['value']) != '') {

             $arg = (string)$config['value'];

-        }elseif($config->getName() == 'value'){

+        }elseif ($config->getName() == 'value') {

             $arg = (string)$config;

-        }elseif($config->getName() == 'list'){

+        }elseif ($config->getName() == 'list') {

             $arg = array();

-            foreach($config->children() as $entry){

-                if($entry->getName() == 'value'){

-                    if($entry['key']){

+            foreach ($config->children() as $entry) {

+                if ($entry->getName() == 'value') {

+                    if ($entry['key']) {

                         $arg[(string)$entry['key']] = (string)$entry;

-                    }else{

+                    }else {

                         $arg[] = (string)$entry;

                     }

-                }elseif($entry->getName() == 'service'){

+                }elseif ($entry->getName() == 'service') {

                     $arg[] = $this->provideService($entry);

                 }

             }

-        }elseif($config->getName() == 'service'){

+        }elseif ($config->getName() == 'service') {

             $arg = self::provideService($config);

-        }elseif($config->list){

+        }elseif ($config->list) {

             $arg = self::buildArg($config->list);

-        }elseif($config->service){

+        }elseif ($config->service) {

             $arg = self::buildArg($config->service);

         }

         return $arg;

@@ -126,24 +126,24 @@ 
      * @param string $defaultClass class to create instance for if none is set in config

      * @return object build and modified srvice instance

      */

-    public static function buildAndModify(array $config, $arguments, $defaultClass = ""){

-        if((isset($config["class"]) && "" != (string)$config["class"])  || $defaultClass !== ""){

+    public static function buildAndModify(array $config, $arguments, $defaultClass = "") {

+        if ((isset($config["class"]) && "" != (string)$config["class"]) || $defaultClass !== "") {

              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

-        }else{

+        }else {

             throw new \RuntimeException('Could not create Service. no class or reference given.');

         }

-        if(isset($config["ref_property"])){

+        if (isset($config["ref_property"])) {

             $service = $service->{(string)$config["ref_property"]};

-        }elseif(isset($config["ref_method"])){

+        }elseif (isset($config["ref_method"])) {

                 $args = array();

-            if(isset($config['argument'])){

-                        foreach($config['argument'] as $arg){

+            if (isset($config['argument'])) {

+                        foreach ($config['argument'] as $arg) {

                             $args[] = self::buildArg($arg);

                         }

                 }

             $service = call_user_func_array(array($service, (string)$config["ref_method"]), $args);

         }

-        if(!is_object($service)){

+        if (!is_object($service)) {

             throw new \RuntimeException('Could not create Service.');

         }

         $service = self::modifyService($service, $config);

@@ -165,29 +165,29 @@ 
      * @param object $config configuration to get the modification instructions from.

      * @return object the modificated service

      */

-    protected function modifyService($service, $config){        

+    protected function modifyService($service, $config) {        

         $config = is_array($config) ? new \ArrayObject($config) : $config;

         // set instance properties

-        if(isset($config->property)){

-            foreach($config->property as $property){

+        if (isset($config->property)) {

+            foreach ($config->property as $property) {

                 $arg = self::buildArg($property);

-                if($arg){

+                if ($arg) {

                     $setter = self::getSetter($property);

-                    if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){

+                    if ($setter && self::hasPublicProperty($service, 'Method', $setter)) {

                         $service->{$setter}($arg);

-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

+                    }elseif (in_array($property, self::hasPublicProperty($service, 'Property', $setter))) {

                         $service->$setter = $arg;

                     }

                 }

             }

         }

         // call instance methods

-        if(isset($config->action)){

-            foreach($config->action as $action){

+        if (isset($config->action)) {

+            foreach ($config->action as $action) {

                 $method = (string)$action['method'] != '' ? (string)$action['method'] : NULL;

-                if($method && self::hasPublicProperty($service, 'Method', $method)){

+                if ($method && self::hasPublicProperty($service, 'Method', $method)) {

                     $args = array();

-                    foreach($action->children() as $argument){

+                    foreach ($action->children() as $argument) {

                         $args[] = self::buildArg($argument);

                     }

                     call_user_func_array(array($service, (string)$action['method']), $args);

@@ -195,9 +195,9 @@ 
             }

         }

         // register instance listeners

-        if($service instanceof \PEIP\INF\Event\Connectable){

-            if(isset($config->listener)){

-                foreach($config->listener as $listenerConf){

+        if ($service instanceof \PEIP\INF\Event\Connectable) {

+            if (isset($config->listener)) {

+                foreach ($config->listener as $listenerConf) {

                     $event = (string)$listenerConf['event'];

                     $listener = $this->provideService($listenerConf);

                     $service->connect($event, $listener);

examples/Cafe/lib/model/Barista.php

Spacing +4 added lines, -4 removed lines

@@ -30,16 +30,16 @@
         return $this->prepareDrink($orderItem['order'], $orderItem['type'], true);
     }    
 	
-    protected function prepareDrink($orderNumber, $type, $iced){
+    protected function prepareDrink($orderNumber, $type, $iced) {
     	$drink = new Drink($orderNumber, $type, $iced);	
     	return $drink;
     }
 
-    protected function printAction($cold, $orderNr){
-    	if($cold){
+    protected function printAction($cold, $orderNr) {
+    	if ($cold) {
     		$type = 'cold';
     		$count = $this->coldDrinkCounter;
-    	}else{
+    	}else {
     		$type = 'hot';
     		$count = $this->hotDrinkCounter;    		
     	}

examples/Cafe/lib/model/Order.php

Spacing +6 added lines, -6 removed lines

@@ -7,16 +7,16 @@ 
 		$orderNumber;
 	protected static $orderCount = 0;
 
-	public function __construct(){
+	public function __construct() {
 		self::$orderCount++;
 		$this->orderNumber = self::$orderCount;
 	}	
 
-	public function getOrderNumber(){
+	public function getOrderNumber() {
 		return $this->orderNumber;
 	}
 	
-	public function addItem($type, $number, $iced = false){
+	public function addItem($type, $number, $iced = false) {
 		$this->items[] = 
 			array(
 				'type' => $type,
@@ -25,13 +25,13 @@ 
 			);
 	}
 
-	public function getItems(){
+	public function getItems() {
 		return $this->items;
 	}
 
-	public function getTotalCount(){
+	public function getTotalCount() {
 		$x = 0;
-		foreach($this->items as $item){
+		foreach ($this->items as $item) {
 			$x += (int)$item['number'];
 		}
 		return $x;

examples/Cafe/lib/model/Delivery.php

Spacing +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
 		$deliveredDrinks,
 		$orderNumber;
 	
-	public function __construct(array $deliveredDrinks){
+	public function __construct(array $deliveredDrinks) {
 		$this->deliveredDrinks = $deliveredDrinks;
 		$this->orderNumber = $deliveredDrinks[0]->getOrderNumber();
 	}

examples/Cafe/lib/model/Drink.php

Spacing +4 added lines, -4 removed lines

@@ -8,21 +8,21 @@
 		$type,
 		$iced;
 	
-	public function __construct($orderNumber, $type, $iced){
+	public function __construct($orderNumber, $type, $iced) {
 		$this->orderNumber = $orderNumber;
 		$this->type = $type;
 		$this->iced = $iced;
 	}
 
-	public function getType(){
+	public function getType() {
 		return $this->type; 
 	}
 
-	public function getIced(){
+	public function getIced() {
 		return $this->iced; 
 	}	
 
-	public function getOrderNumber(){
+	public function getOrderNumber() {
 		return $this->orderNumber;
 	}
 	

examples/Cafe/lib/model/Waiter.php

Spacing +3 added lines, -3 removed lines

@@ -5,18 +5,18 @@
 
 	protected $orders;
 	
-	public function prepareDelivery(array $drinks){
+	public function prepareDelivery(array $drinks) {
 		echo PEIP_LINE_SEPARATOR.'Waiter: prepareDelivery: #'.$drinks[0]->getOrderNumber();
 		return new Delivery($drinks);
 	}
 
 	
-	public function receiveOrder(Order $order){
+	public function receiveOrder(Order $order) {
 		echo PEIP_LINE_SEPARATOR.'Waiter: receiveOrder';
 		$this->orders[$order->getOrderNumber()] = $order;	
 	}
 	
-	public function getOrder($nr){
+	public function getOrder($nr) {
 		return $this->orders[$nr];
 	}
 	

src/Dispatcher/ClassEventDispatcher.php

Spacing +13 added lines, -13 removed lines

@@ -27,9 +27,9 @@ 
      * @param Callable|PEIP\INF\Handler\Handler $listener event-handler

      * @return boolean

      */

-    public function connect($name, $object, $listener){ 

+    public function connect($name, $object, $listener) { 

         $class = is_object($object) ? get_class($object) : (string)$object;

-        foreach(Reflection::getImplementedClassesAndInterfaces($object) as $cls){

+        foreach (Reflection::getImplementedClassesAndInterfaces($object) as $cls) {

             $reflection = Reflection_Pool::getInstance($class);

             parent::connect($name, $reflection, $listener);

         }

@@ -37,13 +37,13 @@ 
         return true;

     }

 

-    public function disconnect($name, $object, $listener){

+    public function disconnect($name, $object, $listener) {

         $class = is_object($object) ? get_class($object) : (string)$object;

         $res = true;

-        foreach(Reflection::getImplementedClassesAndInterfaces($object) as $cls){

+        foreach (Reflection::getImplementedClassesAndInterfaces($object) as $cls) {

             $reflection = Reflection_Pool::getInstance($class);

             $r = parent::disconnect($name, $reflection, $listener);

-            if(!$r){

+            if (!$r) {

                 $res = false;

             }

         }

@@ -58,9 +58,9 @@ 
      * @param \PEIP\INF\Event\Event $object an event object

      * @return boolean

      */

-    public function notify($name, $object){ 

-        if($object instanceof \PEIP\INF\Event\Event){

-            if(is_object($object->getContent())){

+    public function notify($name, $object) { 

+        if ($object instanceof \PEIP\INF\Event\Event) {

+            if (is_object($object->getContent())) {

                 return self::doNotify(

                     $this->getListeners(

                         $name,

@@ -70,10 +70,10 @@ 
                      ),

                      $object

                  );

-            }else{

+            }else {

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }

-        }else{

+        }else {

             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');

         }

     }       //put your code here

@@ -90,8 +90,8 @@ 
      * @return

      * @see EventBuilder

      */

-    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){

-        if(!$this->hasListeners($name, ($object))){

+    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false) {

+        if (!$this->hasListeners($name, ($object))) {

             return false;

         }

 

@@ -114,7 +114,7 @@ 
      * @param object $object object to check for listeners

      * @return boolean

      */

-    public function hasListeners($name, $object){

+    public function hasListeners($name, $object) {

         return parent::hasListeners(

             $name,

             Reflection_Pool::getInstance($object)

Unused Use Statements +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
  *

  * @author timo

  */

-use PEIP\Util\Reflection;

+use PEIP\Util\Reflection;
 use PEIP\Event\EventBuilder;

 

 class ClassEventDispatcher extends \PEIP\Dispatcher\ObjectEventDispatcher {

src/Base/GenericBuilder.php

Spacing +10 added lines, -10 removed lines

@@ -43,10 +43,10 @@ 
      * @param boolean $storeRef wether to store a reference for new instance. default: true 
      * @return 
      */
-    public function __construct($className, \ReflectionClass $reflectionClass = NULL, $storeRef = true){
-        if($reflectionClass ){
+    public function __construct($className, \ReflectionClass $reflectionClass = NULL, $storeRef = true) {
+        if ($reflectionClass) {
             
-            if($reflectionClass->getName() != $className){
+            if ($reflectionClass->getName() != $className) {
                 throw new \Exception(
                     'Constructing GenericBuilder with wrong ReflectionClass'
                 );
@@ -56,7 +56,7 @@ 
             $this->reflectionClass = $reflectionClass;
         }
         $this->className = $className;
-        if($storeRef){
+        if ($storeRef) {
             self::$instances[$this->className] = $this;
         }            
     }
@@ -68,8 +68,8 @@ 
      * @param string $className class-name to return builder instance for 
      * @return GenericBuilder builder instance for class
      */
-    public static function getInstance($className){
-        if(!array_key_exists((string)$className, self::$instances)) {
+    public static function getInstance($className) {
+        if (!array_key_exists((string)$className, self::$instances)) {
             new GenericBuilder($className);
         }
         return self::$instances[$className];
@@ -82,9 +82,9 @@ 
      * @param array $arguments array of constructore arguments
      * @return object the created object instance
      */
-    public function build(array $arguments = array()){      
-        if(Test::assertClassHasConstructor($this->className)){
-            if(!Test::assertRequiredConstructorParameters($this->className, $arguments)){
+    public function build(array $arguments = array()) {      
+        if (Test::assertClassHasConstructor($this->className)) {
+            if (!Test::assertRequiredConstructorParameters($this->className, $arguments)) {
                 throw new \Exception('Missing Argument '.(count($arguments) + 1).' for '.$this->className.'::__construct');
             }
             return $this->getReflectionClass()->newInstanceArgs($arguments);
@@ -98,7 +98,7 @@ 
      * @access public
      * @return ReflectionClass
      */
-    public function getReflectionClass(){
+    public function getReflectionClass() {
         return ReflectionPool::getInstance($this->className);
     }
     

src/Event/EventBuilder.php

Spacing +4 added lines, -4 removed lines

@@ -37,7 +37,7 @@ 
      * @param string $eventClass the event-class the builder shall create instances for 
      * @param array $defaultHeaders default headers for the created events 
      */
-    public function __construct($eventClass = '\PEIP\Event\Event', array $defaultHeaders = array()){
+    public function __construct($eventClass = '\PEIP\Event\Event', array $defaultHeaders = array()) {
         $this->eventClass = $eventClass;
         $this->defaultParameters = $defaultHeaders;
     }
@@ -49,7 +49,7 @@ 
      * @param string $eventClass the event-class the builder shall create instances for 
      * @return EventBuilder the instance of EventBuilder for the given event-class 
      */    
-    public static function getInstance($eventClass = '\PEIP\Event\Event'){ 
+    public static function getInstance($eventClass = '\PEIP\Event\Event') { 
 
         return isset(self::$instances[$eventClass]) 
             ? self::$instances[$eventClass] 
@@ -67,7 +67,7 @@ 
      * @param array $headers the headers for the event 
      * @return object event instance
      */
-    public function build($subject, $name, array $headers = array()){
+    public function build($subject, $name, array $headers = array()) {
 
         return new $this->eventClass(
             $subject,
@@ -86,7 +86,7 @@ 
      * @param array $parameters the headers for the event
      * @return 
      */
-    public function buildAndDispatch(ObjectEventDispatcher $dispatcher, $subject, $name, array $headers = array()){
+    public function buildAndDispatch(ObjectEventDispatcher $dispatcher, $subject, $name, array $headers = array()) {
   
         return $dispatcher->notify(
             $name,