View GitHub Repository PEIP

Schedule Inspection
Subscribe
Completed
Push — v1.ns ( 64f725...6f2676 )
by Timo
03:26
created
Status
Category
Toggle Patches
src/Factory/ServiceFactory.php 2 patches
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -11,8 +11,8 @@
 
 block discarded – undo
11 11 
  *
12 12 
  * @author timo
13 13 
  */
14 
-use PEIP\Util\Test;
15 
-use PEIP\Base\GenericBuilder;
14 
+use PEIP\Util\Test;
15 
+use PEIP\Base\GenericBuilder;
16 16 
 use PEIP\Context\XMLContext;
17 17
18 18 
 class ServiceFactory {
Please login to merge, or discard this patch.
Braces   +12 added lines, -12 removed lines patch added patch discarded remove patch 
@@ -51,10 +51,10 @@  discard block
 
 block discarded – undo
51 51 
                 $constructor = isset($config["constructor"])?(string)$config["constructor"]:"";
52 52 
                 if($constructor != '' && Test::assertMethod($cls, $constructor)){
53 53 
                     $service = call_user_func_array(array($cls, $constructor), $arguments);
54 
-                }else{
54 
+                } else{
55 55 
                     $service = self::build($cls, $arguments);
56 56 
                 }
57 
-            }catch(\Exception $e){
57 
+            } catch(\Exception $e){
58 58 
                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());
59 59 
             }
60 60 
         }

@@ -89,26 +89,26 @@  discard block
 
 block discarded – undo
89 89 
     protected static function buildArg($config){
90 90 
         if(trim((string)$config['value']) != ''){
91 91 
             $arg = (string)$config['value'];
92 
-        }elseif($config->getName() == 'value'){
92 
+        } elseif($config->getName() == 'value'){
93 93 
             $arg = (string)$config;
94 
-        }elseif($config->getName() == 'list'){
94 
+        } elseif($config->getName() == 'list'){
95 95 
             $arg = array();
96 96 
             foreach($config->children() as $entry){
97 97 
                 if($entry->getName() == 'value'){
98 98 
                     if($entry['key']){
99 99 
                         $arg[(string)$entry['key']] = (string)$entry;
100 
-                    }else{
100 
+                    } else{
101 101 
                         $arg[] = (string)$entry;
102 102 
                     }
103 
-                }elseif($entry->getName() == 'service'){
103 
+                } elseif($entry->getName() == 'service'){
104 104 
                     $arg[] = $this->provideService($entry);
105 105 
                 }
106 106 
             }
107 
-        }elseif($config->getName() == 'service'){
107 
+        } elseif($config->getName() == 'service'){
108 108 
             $arg = self::provideService($config);
109 
-        }elseif($config->list){
109 
+        } elseif($config->list){
110 110 
             $arg = self::buildArg($config->list);
111 
-        }elseif($config->service){
111 
+        } elseif($config->service){
112 112 
             $arg = self::buildArg($config->service);
113 113 
         }
114 114 
         return $arg;

@@ -129,12 +129,12 @@  discard block
 
 block discarded – undo
129 129 
     public static function buildAndModify($config, $arguments, $defaultClass = ""){
130 130 
         if((isset($config["class"]) && "" != (string)$config["class"])  || $defaultClass !== ""){
131 131 
              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);
132 
-        }else{
132 
+        } else{
133 133 
             throw new \RuntimeException('Could not create Service. no class or reference given.');
134 134 
         }
135 135 
         if(isset($config["ref_property"])){
136 136 
             $service = $service->{(string)$config["ref_property"]};
137 
-        }elseif(isset($config["ref_method"])){
137 
+        } elseif(isset($config["ref_method"])){
138 138 
                 $args = array();
139 139 
             if($config->argument){
140 140 
                         foreach($config->argument as $arg){

@@ -177,7 +177,7 @@  discard block
 
 block discarded – undo
177 177 
                     $setter = self::getSetter($property);
178 178 
                     if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){
179 179 
                         $service->{$setter}($arg);
180 
-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){
180 
+                    } elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){
181 181 
                         $service->$setter = $arg;
182 182 
                     }
183 183 
                 }
Please login to merge, or discard this patch.