tidal / PEIP

src/Base/GenericBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
      * 
      * @access public
      * @param string $className class-name to create objects for
-     * @param ReflectionClass $reflectionClass reflection-class for class. default: NULL 
+     * @param \ReflectionClass $reflectionClass reflection-class for class. default: NULL 
      * @param boolean $storeRef wether to store a reference for new instance. default: true 
      * @return 
      */

src/Event/EventBuilder.php

Doc Comments -1 removed lines

@@ -83,7 +83,6 @@
      * @param ObjectEventDispatcher $dispatcher the dispatcher to dispatch the event 
      * @param mixed $subject the subject for the event
      * @param string $name the name of the event
-     * @param array $parameters the headers for the event
      * @return 
      */
     public function buildAndDispatch(ObjectEventDispatcher $dispatcher, $subject, $name, array $headers = array()){

src/Factory/DedicatedFactory.php

Doc Comments +3 added lines

@@ -47,6 +47,9 @@
         return new DedicatedFactory(array($class, '__construct'), $parameters); 

     } 

 

+    /**
+     * @param string[] $callable
+     */
     public static function getfromCallable($callable, array $parameters = array()){

         return new DedicatedFactory($callable, $parameters); 

     } 

src/Factory/ServiceFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
      * @see GenericBuilder

      * @static

      * @access protected

-     * @param object $className name of class to build instance for.

+     * @param string $className name of class to build instance for.

      * @param array $arguments arguments for the constructor

      * @return object build and modified srvice instance

      */

Braces +12 added lines, -12 removed lines

@@ -51,10 +51,10 @@ 
                 $constructor = isset($config["constructor"])?(string)$config["constructor"]:"";

                 if($constructor != '' && Test::assertMethod($cls, $constructor)){

                     $service = call_user_func_array(array($cls, $constructor), $arguments);

-                }else{

+                } else{

                     $service = self::build($cls, $arguments);

                 }

-            }catch(\Exception $e){

+            } catch(\Exception $e){

                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());

             }

         }

@@ -89,26 +89,26 @@ 
     protected static function buildArg($config){

         if(trim((string)$config['value']) != ''){

             $arg = (string)$config['value'];

-        }elseif($config->getName() == 'value'){

+        } elseif($config->getName() == 'value'){

             $arg = (string)$config;

-        }elseif($config->getName() == 'list'){

+        } elseif($config->getName() == 'list'){

             $arg = array();

             foreach($config->children() as $entry){

                 if($entry->getName() == 'value'){

                     if($entry['key']){

                         $arg[(string)$entry['key']] = (string)$entry;

-                    }else{

+                    } else{

                         $arg[] = (string)$entry;

                     }

-                }elseif($entry->getName() == 'service'){

+                } elseif($entry->getName() == 'service'){

                     $arg[] = $this->provideService($entry);

                 }

             }

-        }elseif($config->getName() == 'service'){

+        } elseif($config->getName() == 'service'){

             $arg = self::provideService($config);

-        }elseif($config->list){

+        } elseif($config->list){

             $arg = self::buildArg($config->list);

-        }elseif($config->service){

+        } elseif($config->service){

             $arg = self::buildArg($config->service);

         }

         return $arg;

@@ -129,12 +129,12 @@ 
     public static function buildAndModify($config, $arguments, $defaultClass = ""){

         if((isset($config["class"]) && "" != (string)$config["class"])  || $defaultClass !== ""){

              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);

-        }else{

+        } else{

             throw new \RuntimeException('Could not create Service. no class or reference given.');

         }

         if(isset($config["ref_property"])){

             $service = $service->{(string)$config["ref_property"]};

-        }elseif(isset($config["ref_method"])){

+        } elseif(isset($config["ref_method"])){

                 $args = array();

             if($config->argument){

                         foreach($config->argument as $arg){

@@ -177,7 +177,7 @@ 
                     $setter = self::getSetter($property);

                     if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){

                         $service->{$setter}($arg);

-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

+                    } elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){

                         $service->$setter = $arg;

                     }

                 }

src/Service/ServiceProvider.php

Doc Comments +3 added lines

@@ -112,6 +112,9 @@
         );

     }

 

+    /**
+     * @param string $key
+     */
     public function provideService($key){

         $this->doFireEvent(self::EVENT_BEFORE_PROVIDE_SERVICE, array(

             self::HEADER_KEY=>$key)

Braces +5 added lines, -5 removed lines

@@ -118,7 +118,7 @@ 
 
         if($this->hasService($key)){
             $service =  $this->getService($key);
-        }else{
+        } else{
             $service =  $this->createService($key);
         }
 
@@ -150,11 +150,11 @@ 
                 ));
 
                 return $node;                
-            }else{
+            } else{
                 $errorMessage = 'COULD NOT BUILD NODE FOR KEY: '.$key;
             }
 
-        }else{
+        } else{
             $errorMessage = 'NO CONFIG FOR KEY: '.$key;
         }
         $this->doFireEvent(self::EVENT_CREATE_SERVICE_ERROR, array(
@@ -198,10 +198,10 @@ 
                     self::HEADER_NODE => $nodeInstance
                 ));
                 return $nodeInstance;
-            }else{
+            } else{
                 $errorMessage = 'BUILDER RETURNED NO OBJECT FOR NODE-TYPE: '.$nodeName;
             }
-        }else{
+        } else{
             $errorMessage = 'NO BUILDER FOUND FOR NODE-TYPE: '.$nodeName;
         }
 

examples/Cafe/lib/model/Barista.php

Braces +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
     	if($cold){
     		$type = 'cold';
     		$count = $this->coldDrinkCounter;
-    	}else{
+    	} else{
     		$type = 'hot';
     		$count = $this->hotDrinkCounter;    		
     	}

src/Dispatcher/ClassEventDispatcher.php

Braces +2 added lines, -2 removed lines

@@ -70,10 +70,10 @@
                      ),

                      $object

                  );

-            }else{

+            } else{

                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');

             }

-        }else{

+        } else{

             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');

         }

     }       //put your code here

Doc Comments +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
      * @access public

      * @param string $name name of the event

      * @param \PEIP\INF\Event\Event $object an event object

-     * @return boolean

+     * @return boolean|null

      */

     public function notify($name, $object){ 

         if($object instanceof \PEIP\INF\Event\Event){

@@ -53,7 +53,7 @@ 
      * @param array $headers headers of the event-object as key/value pairs

      * @param string $eventClass event-class to create instances from

      * @return

-     * @see EventBuilder

+     boolean|null @see EventBuilder

      */

     public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){

         if(!$this->hasListeners($name, ($object))){

src/Util/Test.php

Braces +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
             class_exists($className);
             $res =  ReflectionPool::getInstance($className)
                 ->implementsInterface($interfaceName);            
-        }  catch (\Exception $e){
+        } catch (\Exception $e){
             $res = false; 
         }
         return $res;;

examples/Cafe/example.php

Braces +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
                 var_dump($drinks);

     	}	

 

-}else{

+} else{

 	throw new RuntimeException('Could not get CafeGateway');

 }