Completed
Push — v1.ns ( 919dbc...ab319d )
by Timo
03:07
created
src/Dispatcher/EventClassDispatcher.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
  *
12 12
  * @author timo
13 13
  */
14
-use PEIP\Event\EventBuilder;
14
+use PEIP\Event\EventBuilder;
15 15
 use PEIP\Util\ReflectionPool;
16 16
 
17 17
 class EventClassDispatcher
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -25,9 +25,9 @@  discard block
 block discarded – undo
25 25
      * @param \PEIP\INF\Event\Event $object an event object
26 26
      * @return boolean
27 27
      */
28
-    public function notify($name, $object){ 
29
-        if($object instanceof \PEIP\INF\Event\Event){
30
-            if(is_object($object->getContent())){
28
+    public function notify($name, $object) { 
29
+        if ($object instanceof \PEIP\INF\Event\Event) {
30
+            if (is_object($object->getContent())) {
31 31
                 return self::doNotify(
32 32
                     $this->getListeners(
33 33
                         $name,
@@ -35,10 +35,10 @@  discard block
 block discarded – undo
35 35
                      ),
36 36
                      $object->getContent()
37 37
                  );
38
-            }else{
38
+            }else {
39 39
                 throw new \InvalidArgumentException('instance of \PEIP\INF\Event\Event must contain subject');
40 40
             }
41
-        }else{
41
+        }else {
42 42
             throw new \InvalidArgumentException('object must be instance of \PEIP\INF\Event\Event');
43 43
         }
44 44
     }       //put your code here
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
      * @return
56 56
      * @see EventBuilder
57 57
      */
58
-    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false){
59
-        if(!$this->hasListeners($name, ($object))){
58
+    public function buildAndNotify($name, $object, array $headers = array(), $eventClass = false, $type = false) {
59
+        if (!$this->hasListeners($name, ($object))) {
60 60
             return false;
61 61
         }
62 62
 
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
      * @param object $object object to check for listeners
80 80
      * @return boolean
81 81
      */
82
-    public function hasListeners($name, $object){
82
+    public function hasListeners($name, $object) {
83 83
         return parent::hasListeners(
84 84
             $name,
85 85
             ReflectionPool::getInstance($object)
Please login to merge, or discard this patch.
src/Factory/ServiceFactory.php 2 patches
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,8 +11,8 @@
 block discarded – undo
11 11
  *
12 12
  * @author timo
13 13
  */
14
-use PEIP\Util\Test;
15
-use PEIP\Base\GenericBuilder;
14
+use PEIP\Util\Test;
15
+use PEIP\Base\GenericBuilder;
16 16
 use PEIP\Context\XMLContext;
17 17
 
18 18
 class ServiceFactory {
Please login to merge, or discard this patch.
Spacing   +44 added lines, -44 removed lines patch added patch discarded remove patch
@@ -23,11 +23,11 @@  discard block
 block discarded – undo
23 23
      * @param $config configuration of the service
24 24
      * @return object the initialized service instance
25 25
      */
26
-    public static function createService(array $config){
26
+    public static function createService(array $config) {
27 27
         $args = array();
28 28
         //build arguments for constructor
29
-        if(isset($config['constructor_arg'])){
30
-            foreach($config['constructor_arg'] as $arg){
29
+        if (isset($config['constructor_arg'])) {
30
+            foreach ($config['constructor_arg'] as $arg) {
31 31
                 $args[] = self::buildArg($arg);
32 32
             }
33 33
         }
@@ -44,21 +44,21 @@  discard block
 block discarded – undo
44 44
      * @param string $defaultClass class to create instance for if none is set in config
45 45
      * @return object build and modified srvice instance
46 46
      */
47
-    public static function doBuild($config, $arguments, $defaultClass = false){
47
+    public static function doBuild($config, $arguments, $defaultClass = false) {
48 48
         $cls = isset($config["class"]) ? trim((string)$config["class"]) : (string)$defaultClass;
49
-        if($cls != ''){
49
+        if ($cls != '') {
50 50
             try {
51
-                $constructor = isset($config["constructor"])?(string)$config["constructor"]:"";
52
-                if($constructor != '' && Test::assertMethod($cls, $constructor)){
51
+                $constructor = isset($config["constructor"]) ? (string)$config["constructor"] : "";
52
+                if ($constructor != '' && Test::assertMethod($cls, $constructor)) {
53 53
                     $service = call_user_func_array(array($cls, $constructor), $arguments);
54
-                }else{
54
+                }else {
55 55
                     $service = self::build($cls, $arguments);
56 56
                 }
57
-            }catch(\Exception $e){
57
+            } catch (\Exception $e) {
58 58
                 throw new \RuntimeException('Could not create Service "'.$cls.'" -> '.$e->getMessage());
59 59
             }
60 60
         }
61
-        if(is_object($service)){
61
+        if (is_object($service)) {
62 62
             return $service;
63 63
         }
64 64
         throw new \RuntimeException('Could not create Service "'.$cls.'". Class does not exist.');
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      * @param array $arguments arguments for the constructor
76 76
      * @return object build and modified srvice instance
77 77
      */
78
-    public static function build($className, $arguments){
78
+    public static function build($className, $arguments) {
79 79
         return GenericBuilder::getInstance($className)->build($arguments);
80 80
     }
81 81
 
@@ -86,29 +86,29 @@  discard block
 block discarded – undo
86 86
      * @param object $config configuration object to create argument from.
87 87
      * @return mixed build argument
88 88
      */
89
-    protected function buildArg($config){
90
-        if(trim((string)$config['value']) != ''){
89
+    protected function buildArg($config) {
90
+        if (trim((string)$config['value']) != '') {
91 91
             $arg = (string)$config['value'];
92
-        }elseif($config->getName() == 'value'){
92
+        }elseif ($config->getName() == 'value') {
93 93
             $arg = (string)$config;
94
-        }elseif($config->getName() == 'list'){
94
+        }elseif ($config->getName() == 'list') {
95 95
             $arg = array();
96
-            foreach($config->children() as $entry){
97
-                if($entry->getName() == 'value'){
98
-                    if($entry['key']){
96
+            foreach ($config->children() as $entry) {
97
+                if ($entry->getName() == 'value') {
98
+                    if ($entry['key']) {
99 99
                         $arg[(string)$entry['key']] = (string)$entry;
100
-                    }else{
100
+                    }else {
101 101
                         $arg[] = (string)$entry;
102 102
                     }
103
-                }elseif($entry->getName() == 'service'){
103
+                }elseif ($entry->getName() == 'service') {
104 104
                     $arg[] = $this->provideService($entry);
105 105
                 }
106 106
             }
107
-        }elseif($config->getName() == 'service'){
107
+        }elseif ($config->getName() == 'service') {
108 108
             $arg = self::provideService($config);
109
-        }elseif($config->list){
109
+        }elseif ($config->list) {
110 110
             $arg = $this->buildArg($config->list);
111
-        }elseif($config->service){
111
+        }elseif ($config->service) {
112 112
             $arg = $this->buildArg($config->service);
113 113
         }
114 114
         return $arg;
@@ -126,24 +126,24 @@  discard block
 block discarded – undo
126 126
      * @param string $defaultClass class to create instance for if none is set in config
127 127
      * @return object build and modified srvice instance
128 128
      */
129
-    public static function buildAndModify(array $config, $arguments, $defaultClass = ""){
130
-        if((isset($config["class"]) && "" != (string)$config["class"])  || $defaultClass !== ""){
129
+    public static function buildAndModify(array $config, $arguments, $defaultClass = "") {
130
+        if ((isset($config["class"]) && "" != (string)$config["class"]) || $defaultClass !== "") {
131 131
              $service = ServiceFactory::doBuild($config, $arguments, $defaultClass);
132
-        }else{
132
+        }else {
133 133
             throw new \RuntimeException('Could not create Service. no class or reference given.');
134 134
         }
135
-        if(isset($config["ref_property"])){
135
+        if (isset($config["ref_property"])) {
136 136
             $service = $service->{(string)$config["ref_property"]};
137
-        }elseif(isset($config["ref_method"])){
137
+        }elseif (isset($config["ref_method"])) {
138 138
                 $args = array();
139
-            if(isset($config['argument'])){
140
-                        foreach($config['argument'] as $arg){
139
+            if (isset($config['argument'])) {
140
+                        foreach ($config['argument'] as $arg) {
141 141
                             $args[] = $this->buildArg($arg);
142 142
                         }
143 143
                 }
144 144
             $service = call_user_func_array(array($service, (string)$config["ref_method"]), $args);
145 145
         }
146
-        if(!is_object($service)){
146
+        if (!is_object($service)) {
147 147
             throw new \RuntimeException('Could not create Service.');
148 148
         }
149 149
         $service = self::modifyService($service, $config);
@@ -165,29 +165,29 @@  discard block
 block discarded – undo
165 165
      * @param object $config configuration to get the modification instructions from.
166 166
      * @return object the modificated service
167 167
      */
168
-    protected function modifyService($service, $config){        
168
+    protected function modifyService($service, $config) {        
169 169
         $config = is_array($config) ? new \ArrayObject($config) : $config;
170 170
         // set instance properties
171
-        if(isset($config->property)){
172
-            foreach($config->property as $property){
171
+        if (isset($config->property)) {
172
+            foreach ($config->property as $property) {
173 173
                 $arg = $this->buildArg($property);
174
-                if($arg){
174
+                if ($arg) {
175 175
                     $setter = self::getSetter($property);
176
-                    if($setter &&  self::hasPublicProperty($service, 'Method', $setter)){
176
+                    if ($setter && self::hasPublicProperty($service, 'Method', $setter)) {
177 177
                         $service->{$setter}($arg);
178
-                    }elseif(in_array($property, self::hasPublicProperty($service, 'Property', $setter))){
178
+                    }elseif (in_array($property, self::hasPublicProperty($service, 'Property', $setter))) {
179 179
                         $service->$setter = $arg;
180 180
                     }
181 181
                 }
182 182
             }
183 183
         }
184 184
         // call instance methods
185
-        if(isset($config->action)){
186
-            foreach($config->action as $action){
185
+        if (isset($config->action)) {
186
+            foreach ($config->action as $action) {
187 187
                 $method = (string)$action['method'] != '' ? (string)$action['method'] : NULL;
188
-                if($method && self::hasPublicProperty($service, 'Method', $method)){
188
+                if ($method && self::hasPublicProperty($service, 'Method', $method)) {
189 189
                     $args = array();
190
-                    foreach($action->children() as $argument){
190
+                    foreach ($action->children() as $argument) {
191 191
                         $args[] = $this->buildArg($argument);
192 192
                     }
193 193
                     call_user_func_array(array($service, (string)$action['method']), $args);
@@ -195,9 +195,9 @@  discard block
 block discarded – undo
195 195
             }
196 196
         }
197 197
         // register instance listeners
198
-        if($service instanceof \PEIP\INF\Event\Connectable){
199
-            if(isset($config->listener)){
200
-                foreach($config->listener as $listenerConf){
198
+        if ($service instanceof \PEIP\INF\Event\Connectable) {
199
+            if (isset($config->listener)) {
200
+                foreach ($config->listener as $listenerConf) {
201 201
                     $event = (string)$listenerConf['event'];
202 202
                     $listener = $this->provideService($listenerConf);
203 203
                     $service->connect($event, $listener);
Please login to merge, or discard this patch.
examples/Cafe/lib/model/Barista.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -30,16 +30,16 @@
 block discarded – undo
30 30
         return $this->prepareDrink($orderItem['order'], $orderItem['type'], true);
31 31
     }    
32 32
 	
33
-    protected function prepareDrink($orderNumber, $type, $iced){
33
+    protected function prepareDrink($orderNumber, $type, $iced) {
34 34
     	$drink = new Drink($orderNumber, $type, $iced);	
35 35
     	return $drink;
36 36
     }
37 37
 
38
-    protected function printAction($cold, $orderNr){
39
-    	if($cold){
38
+    protected function printAction($cold, $orderNr) {
39
+    	if ($cold) {
40 40
     		$type = 'cold';
41 41
     		$count = $this->coldDrinkCounter;
42
-    	}else{
42
+    	}else {
43 43
     		$type = 'hot';
44 44
     		$count = $this->hotDrinkCounter;    		
45 45
     	}
Please login to merge, or discard this patch.
examples/Cafe/lib/model/Order.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -7,16 +7,16 @@  discard block
 block discarded – undo
7 7
 		$orderNumber;
8 8
 	protected static $orderCount = 0;
9 9
 
10
-	public function __construct(){
10
+	public function __construct() {
11 11
 		self::$orderCount++;
12 12
 		$this->orderNumber = self::$orderCount;
13 13
 	}	
14 14
 
15
-	public function getOrderNumber(){
15
+	public function getOrderNumber() {
16 16
 		return $this->orderNumber;
17 17
 	}
18 18
 	
19
-	public function addItem($type, $number, $iced = false){
19
+	public function addItem($type, $number, $iced = false) {
20 20
 		$this->items[] = 
21 21
 			array(
22 22
 				'type' => $type,
@@ -25,13 +25,13 @@  discard block
 block discarded – undo
25 25
 			);
26 26
 	}
27 27
 
28
-	public function getItems(){
28
+	public function getItems() {
29 29
 		return $this->items;
30 30
 	}
31 31
 
32
-	public function getTotalCount(){
32
+	public function getTotalCount() {
33 33
 		$x = 0;
34
-		foreach($this->items as $item){
34
+		foreach ($this->items as $item) {
35 35
 			$x += (int)$item['number'];
36 36
 		}
37 37
 		return $x;
Please login to merge, or discard this patch.
examples/Cafe/lib/model/Delivery.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 		$deliveredDrinks,
7 7
 		$orderNumber;
8 8
 	
9
-	public function __construct(array $deliveredDrinks){
9
+	public function __construct(array $deliveredDrinks) {
10 10
 		$this->deliveredDrinks = $deliveredDrinks;
11 11
 		$this->orderNumber = $deliveredDrinks[0]->getOrderNumber();
12 12
 	}
Please login to merge, or discard this patch.
examples/Cafe/lib/model/Drink.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -8,21 +8,21 @@
 block discarded – undo
8 8
 		$type,
9 9
 		$iced;
10 10
 	
11
-	public function __construct($orderNumber, $type, $iced){
11
+	public function __construct($orderNumber, $type, $iced) {
12 12
 		$this->orderNumber = $orderNumber;
13 13
 		$this->type = $type;
14 14
 		$this->iced = $iced;
15 15
 	}
16 16
 
17
-	public function getType(){
17
+	public function getType() {
18 18
 		return $this->type; 
19 19
 	}
20 20
 
21
-	public function getIced(){
21
+	public function getIced() {
22 22
 		return $this->iced; 
23 23
 	}	
24 24
 
25
-	public function getOrderNumber(){
25
+	public function getOrderNumber() {
26 26
 		return $this->orderNumber;
27 27
 	}
28 28
 	
Please login to merge, or discard this patch.
examples/Cafe/lib/model/Waiter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -5,18 +5,18 @@
 block discarded – undo
5 5
 
6 6
 	protected $orders;
7 7
 	
8
-	public function prepareDelivery(array $drinks){
8
+	public function prepareDelivery(array $drinks) {
9 9
 		echo PEIP_LINE_SEPARATOR.'Waiter: prepareDelivery: #'.$drinks[0]->getOrderNumber();
10 10
 		return new Delivery($drinks);
11 11
 	}
12 12
 
13 13
 	
14
-	public function receiveOrder(Order $order){
14
+	public function receiveOrder(Order $order) {
15 15
 		echo PEIP_LINE_SEPARATOR.'Waiter: receiveOrder';
16 16
 		$this->orders[$order->getOrderNumber()] = $order;	
17 17
 	}
18 18
 	
19
-	public function getOrder($nr){
19
+	public function getOrder($nr) {
20 20
 		return $this->orders[$nr];
21 21
 	}
22 22
 	
Please login to merge, or discard this patch.
src/Service/ServiceContainer.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 class ServiceContainer
28 28
     extends \PEIP\ABS\Base\Connectable
29 29
     implements 
30
-        \PEIP\INF\Service\ServiceContainer{
30
+        \PEIP\INF\Service\ServiceContainer {
31 31
 
32 32
     protected $services = array();
33 33
     
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      * @param $service 
46 46
      * @return 
47 47
      */
48
-    public function setService($key, $service){
48
+    public function setService($key, $service) {
49 49
         $this->services[$key] = $service;
50 50
     }
51 51
     
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
      * @param $key 
56 56
      * @return 
57 57
      */
58
-    public function getService($key){
58
+    public function getService($key) {
59 59
         return $this->services[$key];
60 60
     }
61 61
     
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      * @param $key 
66 66
      * @return 
67 67
      */
68
-    public function hasService($key){
68
+    public function hasService($key) {
69 69
         return array_key_exists($key, $this->services); 
70 70
     }   
71 71
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      * @param $key 
76 76
      * @return 
77 77
      */
78
-    public function deleteService($key){
78
+    public function deleteService($key) {
79 79
         unset($this->services[$key]);
80 80
     }
81 81
     
Please login to merge, or discard this patch.
src/Service/ServiceContainerBuilder.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 use \PEIP\Data\InternalStoreAbstract;
26 26
 use PEIP\Factory\DedicatedFactory;
27 27
 
28
-class ServiceContainerBuilder extends \PEIP\Data\InternalStoreAbstract{
28
+class ServiceContainerBuilder extends \PEIP\Data\InternalStoreAbstract {
29 29
     
30 30
     
31 31
     
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
      * @param $factory 
36 36
      * @return 
37 37
      */
38
-    public function setFactory($key, DedicatedFactory $factory){
38
+    public function setFactory($key, DedicatedFactory $factory) {
39 39
             $this->setInternalValue($key, $factory);
40 40
     }
41 41
 
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      * @param $key 
46 46
      * @return 
47 47
      */
48
-    public function getFactory($key){
48
+    public function getFactory($key) {
49 49
             $this->getInternalValue($key);
50 50
     }
51 51
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
      * @param $key 
56 56
      * @return 
57 57
      */
58
-    public function hasFactory($key){
58
+    public function hasFactory($key) {
59 59
             $this->hasInternalValue($key);
60 60
     }
61 61
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      * @param $key 
66 66
      * @return 
67 67
      */
68
-    public function deleteFactory($key){
68
+    public function deleteFactory($key) {
69 69
             $this->deleteInternalValue($key);
70 70
     }
71 71
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      * @param $key 
76 76
      * @return 
77 77
      */
78
-    public function getService($key){
78
+    public function getService($key) {
79 79
         return isset($this->services[$key]) ? $this->services[$key] : $this->services[$key] = $this->getFactory($key)->build();
80 80
     }
81 81
     
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
      * @param $key 
87 87
      * @return 
88 88
      */
89
-    public function buildService($key){
89
+    public function buildService($key) {
90 90
         return $this->getFactory($key)->build();
91 91
     }   
92 92
     
Please login to merge, or discard this patch.