PEIP\ABS\Service\ServiceActivator

Complexity

Total Complexity

7

Size/Duplication

Total Lines	46
Duplicated Lines	23.91 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	5
Bugs	5	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	doReply()	0	10	3
A	callService()	11	13	4

<?php

namespace PEIP\ABS\Service;

/*
 * This file is part of the PEIP package.
 * (c) 2009-2011 Timo Michna <timomichna/yahoo.de>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

/*
 * PEIP\ABS\Service\ServiceActivator
 * Abstract base class for all service activators
 *
 * @author Timo Michna <timomichna/yahoo.de>
 * @package PEIP
 * @subpackage service
 * @extends \PEIP\Pipe\Pipe
 * @implements \PEIP\INF\Event\Connectable, \PEIP\INF\Channel\SubscribableChannel, \PEIP\INF\Channel\Channel, \PEIP\INF\Handler\Handler, \PEIP\INF\Message\MessageBuilder
 */


abstract class ServiceActivator extends \PEIP\Pipe\Pipe
{
    protected $serviceCallable;

    /**
     * Handles the reply logic.
     * Delegates calling of service to method 'callService'.
     * Replies on message�s reply-channel or registered output-channel if set.
     *
     * @param \PEIP\INF\Message\Message $message message to handle/reply for
     *
     * @return
     */
    public function doReply(\PEIP\INF\Message\Message $message)
    {
        $res = $this->callService($message);
        $out = (bool) $message->hasHeader('REPLY_CHANNEL')
            ? $message->getHeader('REPLY_CHANNEL')
            : $this->outputChannel;
        if ($out) {
            $this->replyMessage($res, $res);

The call to ServiceActivator::replyMessage() has too many arguments starting with $res.

        }
    }

    /**
     * Calls a method on a service (registered as a callable) with
     * content/payload of given message as argument.
     *
     * @param \PEIP\INF\Message\Message $message message to call the service with it�s content/payload
     *
     * @return mixed result of calling the registered service callable with message content/payload
     */
    protected function callService(\PEIP\INF\Message\Message $message)

This method seems to be duplicated in your project.

    {
        $res = null;
        if (is_callable($this->serviceCallable)) {
            $res = call_user_func($this->serviceCallable, $message->getContent());
        } else {
            if (is_object($this->serviceCallable) && method_exists($this->serviceCallable, 'handle')) {
                $res = $this->serviceCallable->handle($message->getContent());
            }
        }

        return $res;
    }
}