Ticaje\BookingApi\Application\Service\Provider\Package\PriceAggregate

Complexity

Total Complexity

3

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getBasePrice()	0	7	2
A	getPrice()	0	3	1

<?php
declare(strict_types=1);
/**
 * Application Service Class
 * @package Ticaje_BookingApi
 * @author  Hector Luis Barrientos <ticaje@filetea.me>
 */

namespace Ticaje\BookingApi\Application\Service\Provider\Package;

use Ticaje\BookingApi\Application\Service\Provider\BasePriceProvider;
use Ticaje\BookingApi\Application\Signatures\Provider\PriceProviderSignature;
use Ticaje\Contract\Patterns\Interfaces\Dto\DtoInterface;
use Ticaje\Hexagonal\Application\Signatures\UseCase\UseCaseCommandInterface;

/**
 * Class Price
 * @package Ticaje\BookingApi\Application\Service\Provider
 */
class PriceAggregate extends BasePriceProvider implements PriceProviderSignature
{
    /**
     * @inheritDoc
     */
    protected function getBasePrice(UseCaseCommandInterface $command): float
    {
        /** @var DtoInterface $product */
        $product = $command->getProduct();

The method getProduct() does not exist on Ticaje\Hexagonal\Application\Signatures\UseCase\UseCaseCommandInterface. It seems like you code against a sub-type of Ticaje\Hexagonal\Application\Signatures\UseCase\UseCaseCommandInterface such as Ticaje\BookingApi\Application\UseCase\Command\DisabledDaysCommand or Ticaje\BookingApi\Application\UseCase\Command\GetPickupLocationCommand or Ticaje\BookingApi\Application\UseCase\Command\GetPriceCommand or Ticaje\BookingApi\Application\UseCase\Command\GetPackageCommand or Ticaje\BookingApi\Application\UseCase\Command\GetAvailabilityCommand.

        $result = $product ? $product->getPrice() : 0;

$product is of type Ticaje\Contract\Patterns\Interfaces\Dto\DtoInterface, thus it always evaluated to true.

        return (float)$result;
    }

    /**
     * @inheritDoc
     */
    public function getPrice(UseCaseCommandInterface $command): float
    {
        return (float)$this->instance->getPrice();

The method getPrice() does not exist on Ticaje\Contract\Persistence\Entity\EntityInterface.

    }
}